-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Baggage Propagation #3126
base: main
Are you sure you want to change the base?
WIP: Baggage Propagation #3126
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5237 Passed, 73 Skipped, 1m 47.69s Total Time |
BenchmarksBenchmark execution time: 2025-02-07 22:24:50 Comparing candidate commit 35ccc89 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 53 metrics, 0 unstable metrics. scenario:BenchmarkHttpServeTrace-24
scenario:BenchmarkStartRequestSpan-24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the right track, but the new code in StartRequestSpan is causing us to do tracer.Extract twice when we could just do it once. At the same place where we process span links after trace extract (line 127 on your branch, currently), we can also populate a baggagemap with the baggage items found from the returned spanParentCtx. Then, we can push those items onto the request context that we are going to propagate after line 141.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Approving this, given @mtoffl01 is going to be applied too.
What does this PR do?
Motivation
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!