-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: replace internal/telemetry by internal/newtelemetry #3136
base: eliott.bouhana/newtelemetry
Are you sure you want to change the base?
all: replace internal/telemetry by internal/newtelemetry #3136
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5298 Passed, 72 Skipped, 1m 55.88s Total Time |
bae4771
to
00e7b91
Compare
BenchmarksBenchmark execution time: 2025-02-07 17:02:33 Comparing candidate commit addfaa8 in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 56 metrics, 1 unstable metrics. scenario:BenchmarkOTelApiWithCustomTags/otel_api-24
scenario:BenchmarkSetTagString-24
scenario:BenchmarkStartRequestSpan-24
|
00e7b91
to
3069417
Compare
51286ca
to
8bc28bc
Compare
91f3955
to
b9952a7
Compare
d5012b4
to
c5dc1db
Compare
96edeb3
to
3dd727b
Compare
… would not reduce the value of the flushing interval Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
c5dc1db
to
addfaa8
Compare
What does this PR do?
This PR replace the old telemetry client with the new one. It does, in order:
git rm -r internal/telemetry
git mv internal/newtelemetry internal/telemetry
telemetry.ApplyOps
internal/telemetry/telemetrytest
package because it was not usinggithub.com/stretchr/testify/mock
correctly (like, not at all)telemetrytest
APIMotivation
Better telemetry and support for telemetry metrics in the customer request hot path.
RFC: https://docs.google.com/document/d/1C3xoTZHQZNQ-Jr1w5mMThIkpHNW_4qKRf-J5CNi7G-k/edit?pli=1&tab=t.0#heading=h.88xvn2cvs9dt
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!