Fix synchronization of ASM_DD Product listeners #10226

jandro996 · 2025-12-16T16:04:43Z

What Does This Do

Change the order of apply/remove listeners to remove/apply only for ASM_DD product

Motivation

https://datadog.zendesk.com/agent/tickets/2388805

Additional Notes

ASM_DD Product listeners needs to remove configs before add/update due to WAF requirements

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket:APPSEC-60250

pr-commenter · 2025-12-16T16:51:08Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/rc-waf-rules-dup-bug
git_commit_date	1766140713	1766141816
git_commit_sha	`fbdb1cf`	`a9b2c43`
release_version	1.58.0-SNAPSHOT~fbdb1cffac	1.57.0-SNAPSHOT~a9b2c43040

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1766143747	1766143747
ci_job_id	1309090373	1309090373
ci_pipeline_id	87753156	87753156
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-gloyouek 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-gloyouek 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088645
Total [baseline] (8.743 s) : 0, 8742591
Agent [candidate] (1.082 s) : 0, 1081993
Total [candidate] (8.715 s) : 0, 8715092
section iast
Agent [baseline] (1.238 s) : 0, 1237780
Total [baseline] (9.354 s) : 0, 9353501
Agent [candidate] (1.219 s) : 0, 1219344
Total [candidate] (9.33 s) : 0, 9329602

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.238 s	149.135 ms (13.7%)
Total	tracing	8.743 s	-
Total	iast	9.354 s	610.91 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	iast	1.219 s	137.351 ms (12.7%)
Total	tracing	8.715 s	-
Total	iast	9.33 s	614.51 ms (7.1%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (654.282 ms) : 0, 654282
BytebuddyAgent [candidate] (650.361 ms) : 0, 650361
GlobalTracer [baseline] (284.078 ms) : 0, 284078
GlobalTracer [candidate] (282.549 ms) : 0, 282549
AppSec [baseline] (32.58 ms) : 0, 32580
AppSec [candidate] (32.39 ms) : 0, 32390
Debugger [baseline] (67.665 ms) : 0, 67665
Debugger [candidate] (67.0 ms) : 0, 67000
Remote Config [baseline] (608.207 µs) : 0, 608
Remote Config [candidate] (632.411 µs) : 0, 632
Telemetry [baseline] (8.967 ms) : 0, 8967
Telemetry [candidate] (8.881 ms) : 0, 8881
Flare Poller [baseline] (3.725 ms) : 0, 3725
Flare Poller [candidate] (3.66 ms) : 0, 3660
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (802.715 ms) : 0, 802715
BytebuddyAgent [candidate] (788.691 ms) : 0, 788691
GlobalTracer [baseline] (258.507 ms) : 0, 258507
GlobalTracer [candidate] (255.292 ms) : 0, 255292
IAST [baseline] (27.542 ms) : 0, 27542
IAST [candidate] (27.089 ms) : 0, 27089
AppSec [baseline] (34.669 ms) : 0, 34669
AppSec [candidate] (34.294 ms) : 0, 34294
Debugger [baseline] (65.058 ms) : 0, 65058
Debugger [candidate] (64.735 ms) : 0, 64735
Remote Config [baseline] (592.922 µs) : 0, 593
Remote Config [candidate] (609.018 µs) : 0, 609
Telemetry [baseline] (8.454 ms) : 0, 8454
Telemetry [candidate] (8.539 ms) : 0, 8539
Flare Poller [baseline] (3.552 ms) : 0, 3552
Flare Poller [candidate] (3.616 ms) : 0, 3616

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082755
Total [baseline] (10.795 s) : 0, 10794771
Agent [candidate] (1.081 s) : 0, 1081136
Total [candidate] (10.844 s) : 0, 10843673
section appsec
Agent [baseline] (1.265 s) : 0, 1265011
Total [baseline] (11.063 s) : 0, 11063287
Agent [candidate] (1.279 s) : 0, 1279217
Total [candidate] (10.956 s) : 0, 10955965
section iast
Agent [baseline] (1.221 s) : 0, 1220702
Total [baseline] (11.183 s) : 0, 11183126
Agent [candidate] (1.223 s) : 0, 1222756
Total [candidate] (11.257 s) : 0, 11257040
section profiling
Agent [baseline] (1.207 s) : 0, 1207297
Total [baseline] (10.994 s) : 0, 10994497
Agent [candidate] (1.21 s) : 0, 1210160
Total [candidate] (10.872 s) : 0, 10872072

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.083 s	-
Agent	appsec	1.265 s	182.255 ms (16.8%)
Agent	iast	1.221 s	137.946 ms (12.7%)
Agent	profiling	1.207 s	124.542 ms (11.5%)
Total	tracing	10.795 s	-
Total	appsec	11.063 s	268.516 ms (2.5%)
Total	iast	11.183 s	388.355 ms (3.6%)
Total	profiling	10.994 s	199.726 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	appsec	1.279 s	198.08 ms (18.3%)
Agent	iast	1.223 s	141.62 ms (13.1%)
Agent	profiling	1.21 s	129.024 ms (11.9%)
Total	tracing	10.844 s	-
Total	appsec	10.956 s	112.292 ms (1.0%)
Total	iast	11.257 s	413.366 ms (3.8%)
Total	profiling	10.872 s	28.399 ms (0.3%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (649.61 ms) : 0, 649610
BytebuddyAgent [candidate] (649.153 ms) : 0, 649153
GlobalTracer [baseline] (282.767 ms) : 0, 282767
GlobalTracer [candidate] (282.54 ms) : 0, 282540
AppSec [baseline] (32.401 ms) : 0, 32401
AppSec [candidate] (32.108 ms) : 0, 32108
Debugger [baseline] (67.961 ms) : 0, 67961
Debugger [candidate] (67.725 ms) : 0, 67725
Remote Config [baseline] (638.493 µs) : 0, 638
Remote Config [candidate] (589.476 µs) : 0, 589
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (8.885 ms) : 0, 8885
Flare Poller [baseline] (3.782 ms) : 0, 3782
Flare Poller [candidate] (3.688 ms) : 0, 3688
section appsec
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (690.561 ms) : 0, 690561
BytebuddyAgent [candidate] (700.191 ms) : 0, 700191
GlobalTracer [baseline] (258.123 ms) : 0, 258123
GlobalTracer [candidate] (261.426 ms) : 0, 261426
AppSec [baseline] (171.547 ms) : 0, 171547
AppSec [candidate] (173.733 ms) : 0, 173733
Debugger [baseline] (70.262 ms) : 0, 70262
Debugger [candidate] (68.41 ms) : 0, 68410
Remote Config [baseline] (720.026 µs) : 0, 720
Remote Config [candidate] (743.682 µs) : 0, 744
Telemetry [baseline] (8.929 ms) : 0, 8929
Telemetry [candidate] (9.051 ms) : 0, 9051
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.849 ms) : 0, 3849
IAST [baseline] (24.429 ms) : 0, 24429
IAST [candidate] (24.925 ms) : 0, 24925
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (789.421 ms) : 0, 789421
BytebuddyAgent [candidate] (789.49 ms) : 0, 789490
GlobalTracer [baseline] (254.948 ms) : 0, 254948
GlobalTracer [candidate] (255.697 ms) : 0, 255697
AppSec [baseline] (31.084 ms) : 0, 31084
AppSec [candidate] (35.488 ms) : 0, 35488
Debugger [baseline] (68.96 ms) : 0, 68960
Debugger [candidate] (65.811 ms) : 0, 65811
Remote Config [baseline] (584.8 µs) : 0, 585
Remote Config [candidate] (602.229 µs) : 0, 602
Telemetry [baseline] (8.511 ms) : 0, 8511
Telemetry [candidate] (8.556 ms) : 0, 8556
Flare Poller [baseline] (3.562 ms) : 0, 3562
Flare Poller [candidate] (3.555 ms) : 0, 3555
IAST [baseline] (27.194 ms) : 0, 27194
IAST [candidate] (27.087 ms) : 0, 27087
section profiling
ProfilingAgent [baseline] (97.676 ms) : 0, 97676
ProfilingAgent [candidate] (96.28 ms) : 0, 96280
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (703.855 ms) : 0, 703855
BytebuddyAgent [candidate] (706.534 ms) : 0, 706534
GlobalTracer [baseline] (221.181 ms) : 0, 221181
GlobalTracer [candidate] (222.119 ms) : 0, 222119
AppSec [baseline] (31.957 ms) : 0, 31957
AppSec [candidate] (32.4 ms) : 0, 32400
Debugger [baseline] (68.262 ms) : 0, 68262
Debugger [candidate] (68.539 ms) : 0, 68539
Remote Config [baseline] (638.393 µs) : 0, 638
Remote Config [candidate] (659.5 µs) : 0, 660
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (3.71 ms) : 0, 3710
Flare Poller [candidate] (3.704 ms) : 0, 3704
Profiling [baseline] (98.287 ms) : 0, 98287
Profiling [candidate] (96.853 ms) : 0, 96853

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/rc-waf-rules-dup-bug
git_commit_date	1766140713	1766141816
git_commit_sha	`fbdb1cf`	`a9b2c43`
release_version	1.58.0-SNAPSHOT~fbdb1cffac	1.57.0-SNAPSHOT~a9b2c43040

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1766143983	1766143983
ci_job_id	1309090375	1309090375
ci_pipeline_id	87753156	87753156
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-d7eudjph 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-d7eudjph 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+52.964µs; +176.772µs] or [+3.365%; +11.230%]	unstable [+122.547µs; +1075.960µs] or [+2.754%; +24.184%]	unstable [-515.364op/s; +61.239op/s] or [-21.876%; +2.599%]	1.689ms	5.048ms	2128.781op/s	1.574ms	4.449ms	2355.844op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.183 ms) : 1172, 1195
.   : milestone, 1183,
iast (3.217 ms) : 3174, 3260
.   : milestone, 3217,
iast_FULL (5.759 ms) : 5700, 5819
.   : milestone, 5759,
iast_GLOBAL (3.493 ms) : 3437, 3550
.   : milestone, 3493,
profiling (1.913 ms) : 1898, 1928
.   : milestone, 1913,
tracing (1.779 ms) : 1763, 1794
.   : milestone, 1779,
section candidate
no_agent (1.165 ms) : 1154, 1176
.   : milestone, 1165,
iast (3.18 ms) : 3141, 3219
.   : milestone, 3180,
iast_FULL (5.697 ms) : 5641, 5753
.   : milestone, 5697,
iast_GLOBAL (3.588 ms) : 3532, 3644
.   : milestone, 3588,
profiling (2.125 ms) : 2106, 2144
.   : milestone, 2125,
tracing (1.808 ms) : 1793, 1823
.   : milestone, 1808,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.183 ms [1.172 ms, 1.195 ms]	-
iast	3.217 ms [3.174 ms, 3.26 ms]	2.034 ms (171.8%)
iast_FULL	5.759 ms [5.7 ms, 5.819 ms]	4.576 ms (386.7%)
iast_GLOBAL	3.493 ms [3.437 ms, 3.55 ms]	2.31 ms (195.2%)
profiling	1.913 ms [1.898 ms, 1.928 ms]	729.445 µs (61.6%)
tracing	1.779 ms [1.763 ms, 1.794 ms]	595.456 µs (50.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.165 ms [1.154 ms, 1.176 ms]	-
iast	3.18 ms [3.141 ms, 3.219 ms]	2.015 ms (173.0%)
iast_FULL	5.697 ms [5.641 ms, 5.753 ms]	4.532 ms (389.1%)
iast_GLOBAL	3.588 ms [3.532 ms, 3.644 ms]	2.423 ms (208.0%)
profiling	2.125 ms [2.106 ms, 2.144 ms]	959.732 µs (82.4%)
tracing	1.808 ms [1.793 ms, 1.823 ms]	643.123 µs (55.2%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.459 ms) : 19260, 19659
.   : milestone, 19459,
appsec (18.563 ms) : 18372, 18755
.   : milestone, 18563,
code_origins (17.576 ms) : 17399, 17753
.   : milestone, 17576,
iast (17.654 ms) : 17479, 17830
.   : milestone, 17654,
profiling (18.657 ms) : 18472, 18841
.   : milestone, 18657,
tracing (17.978 ms) : 17798, 18158
.   : milestone, 17978,
section candidate
no_agent (18.659 ms) : 18469, 18850
.   : milestone, 18659,
appsec (18.705 ms) : 18511, 18899
.   : milestone, 18705,
code_origins (17.651 ms) : 17477, 17824
.   : milestone, 17651,
iast (17.399 ms) : 17227, 17571
.   : milestone, 17399,
profiling (18.945 ms) : 18755, 19136
.   : milestone, 18945,
tracing (17.736 ms) : 17557, 17914
.   : milestone, 17736,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.459 ms [19.26 ms, 19.659 ms]	-
appsec	18.563 ms [18.372 ms, 18.755 ms]	-895.856 µs (-4.6%)
code_origins	17.576 ms [17.399 ms, 17.753 ms]	-1.883 ms (-9.7%)
iast	17.654 ms [17.479 ms, 17.83 ms]	-1.805 ms (-9.3%)
profiling	18.657 ms [18.472 ms, 18.841 ms]	-802.325 µs (-4.1%)
tracing	17.978 ms [17.798 ms, 18.158 ms]	-1.481 ms (-7.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.659 ms [18.469 ms, 18.85 ms]	-
appsec	18.705 ms [18.511 ms, 18.899 ms]	45.83 µs (0.2%)
code_origins	17.651 ms [17.477 ms, 17.824 ms]	-1.008 ms (-5.4%)
iast	17.399 ms [17.227 ms, 17.571 ms]	-1.261 ms (-6.8%)
profiling	18.945 ms [18.755 ms, 19.136 ms]	286.066 µs (1.5%)
tracing	17.736 ms [17.557 ms, 17.914 ms]	-923.682 µs (-5.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/rc-waf-rules-dup-bug
git_commit_date	1766140713	1766141816
git_commit_sha	`fbdb1cf`	`a9b2c43`
release_version	1.58.0-SNAPSHOT~fbdb1cffac	1.57.0-SNAPSHOT~a9b2c43040

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1766143941	1766143941
ci_job_id	1309090377	1309090377
ci_pipeline_id	87753156	87753156
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-h5llaf3o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-h5llaf3o 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.529 s) : 15529000, 15529000
.   : milestone, 15529000,
appsec (14.447 s) : 14447000, 14447000
.   : milestone, 14447000,
iast (18.474 s) : 18474000, 18474000
.   : milestone, 18474000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
.   : milestone, 18048000,
profiling (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
tracing (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
section candidate
no_agent (15.567 s) : 15567000, 15567000
.   : milestone, 15567000,
appsec (14.662 s) : 14662000, 14662000
.   : milestone, 14662000,
iast (18.133 s) : 18133000, 18133000
.   : milestone, 18133000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
.   : milestone, 18026000,
profiling (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
tracing (14.728 s) : 14728000, 14728000
.   : milestone, 14728000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.529 s [15.529 s, 15.529 s]	-
appsec	14.447 s [14.447 s, 14.447 s]	-1.082 s (-7.0%)
iast	18.474 s [18.474 s, 18.474 s]	2.945 s (19.0%)
iast_GLOBAL	18.048 s [18.048 s, 18.048 s]	2.519 s (16.2%)
profiling	14.901 s [14.901 s, 14.901 s]	-628.0 ms (-4.0%)
tracing	15.052 s [15.052 s, 15.052 s]	-477.0 ms (-3.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.567 s [15.567 s, 15.567 s]	-
appsec	14.662 s [14.662 s, 14.662 s]	-905.0 ms (-5.8%)
iast	18.133 s [18.133 s, 18.133 s]	2.566 s (16.5%)
iast_GLOBAL	18.026 s [18.026 s, 18.026 s]	2.459 s (15.8%)
profiling	14.941 s [14.941 s, 14.941 s]	-626.0 ms (-4.0%)
tracing	14.728 s [14.728 s, 14.728 s]	-839.0 ms (-5.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~a9b2c43040, baseline=1.58.0-SNAPSHOT~fbdb1cffac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.717 ms) : 3497, 3936
.   : milestone, 3717,
iast (2.206 ms) : 2142, 2271
.   : milestone, 2206,
iast_GLOBAL (2.255 ms) : 2190, 2319
.   : milestone, 2255,
profiling (2.071 ms) : 2018, 2124
.   : milestone, 2071,
tracing (2.044 ms) : 1992, 2095
.   : milestone, 2044,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.661 ms) : 3446, 3875
.   : milestone, 3661,
iast (2.208 ms) : 2144, 2273
.   : milestone, 2208,
iast_GLOBAL (2.25 ms) : 2186, 2315
.   : milestone, 2250,
profiling (2.051 ms) : 1999, 2103
.   : milestone, 2051,
tracing (2.056 ms) : 2005, 2107
.   : milestone, 2056,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.717 ms [3.497 ms, 3.936 ms]	2.237 ms (151.3%)
iast	2.206 ms [2.142 ms, 2.271 ms]	726.903 µs (49.1%)
iast_GLOBAL	2.255 ms [2.19 ms, 2.319 ms]	775.271 µs (52.4%)
profiling	2.071 ms [2.018 ms, 2.124 ms]	591.91 µs (40.0%)
tracing	2.044 ms [1.992 ms, 2.095 ms]	564.511 µs (38.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.661 ms [3.446 ms, 3.875 ms]	2.185 ms (148.0%)
iast	2.208 ms [2.144 ms, 2.273 ms]	732.674 µs (49.6%)
iast_GLOBAL	2.25 ms [2.186 ms, 2.315 ms]	774.664 µs (52.5%)
profiling	2.051 ms [1.999 ms, 2.103 ms]	575.304 µs (39.0%)
tracing	2.056 ms [2.005 ms, 2.107 ms]	580.188 µs (39.3%)

dougqh · 2025-12-17T16:59:18Z

I think we should discuss the implications of this with the guild.
The general thinking was that we won't each trace to see a consistent atomic configuration state; otherwise, we end up creating a lot racy states that may be hard to reason about.

jandro996 · 2025-12-18T09:14:08Z

I think we should discuss the implications of this with the guild. The general thinking was that we won't each trace to see a consistent atomic configuration state; otherwise, we end up creating a lot racy states that may be hard to reason about.

Yeah, this PR is a bit of an ugly fix, but it clearly addresses the problem we’re seeing. My main goal was to reliably reproduce the error, confirm that it’s caused by the ordering, and verify that changing the order actually fixes it.

I fully agree this is something we should discuss and refine so we can find the best long term solution. I didn’t want to change the order for all Products yet, since I’m not sure what side effects that might have.

dougqh · 2025-12-18T14:36:59Z

remote-config/remote-config-core/src/main/java/datadog/remoteconfig/state/ProductState.java

      }
    }

+    // Step 2: For products other than ASM_DD, apply changes immediately


I'm wondering if this better handled in some ASM specific code.
I ask because I'd like to keep product specific concerns out the general remote config code.

That said, since this does sound like it is addressing a rather urgent issue, I'm fine with proceeding with the fix as is. I think I'd just like a few more comments explain why ASM is being handled differently.

Thanks Doug. I’ll improve the comments and add a TODO so we can solve this properly after we discuss it in the guild. It would be great to get this change into the January 5 release. I’ll try to merge it today since I’ll be out for a couple of weeks.

wip

dcf39bd

jandro996 added type: bug Bug report and fix tag: do not merge Do not merge changes comp: asm waf Application Security Management (WAF) labels Dec 16, 2025

jandro996 temporarily deployed to ci-build December 16, 2025 16:04 — with GitHub Actions Inactive

Merge branch 'master' into alejandro.gonzalez/rc-waf-rules-dup-bug

35992ec

jandro996 temporarily deployed to ci-build December 17, 2025 09:06 — with GitHub Actions Inactive

jandro996 changed the title ~~Test waf dup warning~~ ASM_DD Product listeners are not sync properly Dec 17, 2025

jandro996 requested a review from smola December 17, 2025 09:30

add tests

943f34e

jandro996 temporarily deployed to ci-build December 18, 2025 08:09 — with GitHub Actions Inactive

dougqh reviewed Dec 18, 2025

View reviewed changes

dougqh approved these changes Dec 18, 2025

View reviewed changes

Add more context in comments

59e693b

jandro996 temporarily deployed to ci-build December 19, 2025 09:22 — with GitHub Actions Inactive

jandro996 removed the tag: do not merge Do not merge changes label Dec 19, 2025

Merge branch 'master' into alejandro.gonzalez/rc-waf-rules-dup-bug

04600fe

jandro996 marked this pull request as ready for review December 19, 2025 09:23

jandro996 requested a review from a team as a code owner December 19, 2025 09:23

jandro996 requested review from PerfectSlayer and removed request for a team December 19, 2025 09:23

jandro996 temporarily deployed to ci-build December 19, 2025 09:23 — with GitHub Actions Inactive

smola approved these changes Dec 19, 2025

View reviewed changes

fix spotless

e6f47f2

jandro996 enabled auto-merge (squash) December 19, 2025 09:43

jandro996 temporarily deployed to ci-build December 19, 2025 09:54 — with GitHub Actions Inactive

fix codenarc

91be4cd

jandro996 temporarily deployed to ci-build December 19, 2025 10:55 — with GitHub Actions Inactive

Merge branch 'master' into alejandro.gonzalez/rc-waf-rules-dup-bug

a9b2c43

jandro996 temporarily deployed to ci-build December 19, 2025 10:57 — with GitHub Actions Inactive

jandro996 merged commit 6d9873a into master Dec 19, 2025
559 checks passed

jandro996 deleted the alejandro.gonzalez/rc-waf-rules-dup-bug branch December 19, 2025 11:44

github-actions bot added this to the 1.58.0 milestone Dec 19, 2025

mcculls changed the title ~~ASM_DD Product listeners are not sync properly~~ Fix synchronization of ASM_DD Product listeners Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix synchronization of ASM_DD Product listeners #10226

Fix synchronization of ASM_DD Product listeners #10226

Uh oh!

jandro996 commented Dec 16, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

dougqh commented Dec 17, 2025

Uh oh!

jandro996 commented Dec 18, 2025

Uh oh!

dougqh Dec 18, 2025

Uh oh!

jandro996 Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix synchronization of ASM_DD Product listeners #10226

Fix synchronization of ASM_DD Product listeners #10226

Uh oh!

Conversation

jandro996 commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

dougqh commented Dec 17, 2025

Uh oh!

jandro996 commented Dec 18, 2025

Uh oh!

dougqh Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

jandro996 Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jandro996 commented Dec 16, 2025 •

edited

Loading

pr-commenter bot commented Dec 16, 2025 •

edited

Loading