-
Notifications
You must be signed in to change notification settings - Fork 324
Add instrumentation tests for JUnit #10257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PerfectSlayer
wants to merge
4
commits into
master
Choose a base branch
from
bbujon/virtual-threads
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+999
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100064
Total [baseline] (10.807 s) : 0, 10807438
Agent [candidate] (1.085 s) : 0, 1085169
Total [candidate] (10.689 s) : 0, 10689346
section appsec
Agent [baseline] (1.268 s) : 0, 1268208
Total [baseline] (11.021 s) : 0, 11020994
Agent [candidate] (1.269 s) : 0, 1268552
Total [candidate] (10.882 s) : 0, 10882173
section iast
Agent [baseline] (1.242 s) : 0, 1242071
Total [baseline] (11.258 s) : 0, 11257816
Agent [candidate] (1.227 s) : 0, 1226597
Total [candidate] (11.244 s) : 0, 11243566
section profiling
Agent [baseline] (1.203 s) : 0, 1203331
Total [baseline] (10.887 s) : 0, 10887435
Agent [candidate] (1.204 s) : 0, 1204334
Total [candidate] (10.86 s) : 0, 10859713
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (661.041 ms) : 0, 661041
BytebuddyAgent [candidate] (651.722 ms) : 0, 651722
GlobalTracer [baseline] (285.892 ms) : 0, 285892
GlobalTracer [candidate] (283.103 ms) : 0, 283103
AppSec [baseline] (33.261 ms) : 0, 33261
AppSec [candidate] (32.549 ms) : 0, 32549
Debugger [baseline] (69.076 ms) : 0, 69076
Debugger [candidate] (67.631 ms) : 0, 67631
Remote Config [baseline] (663.611 µs) : 0, 664
Remote Config [candidate] (667.178 µs) : 0, 667
Telemetry [baseline] (9.117 ms) : 0, 9117
Telemetry [candidate] (8.973 ms) : 0, 8973
Flare Poller [baseline] (3.87 ms) : 0, 3870
Flare Poller [candidate] (3.788 ms) : 0, 3788
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (691.982 ms) : 0, 691982
BytebuddyAgent [candidate] (692.557 ms) : 0, 692557
GlobalTracer [baseline] (259.361 ms) : 0, 259361
GlobalTracer [candidate] (259.713 ms) : 0, 259713
AppSec [baseline] (172.899 ms) : 0, 172899
AppSec [candidate] (173.294 ms) : 0, 173294
Debugger [baseline] (68.803 ms) : 0, 68803
Debugger [candidate] (67.975 ms) : 0, 67975
Remote Config [baseline] (779.591 µs) : 0, 780
Remote Config [candidate] (754.062 µs) : 0, 754
Telemetry [baseline] (9.407 ms) : 0, 9407
Telemetry [candidate] (9.251 ms) : 0, 9251
Flare Poller [baseline] (3.78 ms) : 0, 3780
Flare Poller [candidate] (3.746 ms) : 0, 3746
IAST [baseline] (24.522 ms) : 0, 24522
IAST [candidate] (24.589 ms) : 0, 24589
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (805.055 ms) : 0, 805055
BytebuddyAgent [candidate] (792.382 ms) : 0, 792382
GlobalTracer [baseline] (259.298 ms) : 0, 259298
GlobalTracer [candidate] (256.957 ms) : 0, 256957
AppSec [baseline] (34.635 ms) : 0, 34635
AppSec [candidate] (34.548 ms) : 0, 34548
Debugger [baseline] (65.922 ms) : 0, 65922
Debugger [candidate] (66.452 ms) : 0, 66452
Remote Config [baseline] (597.629 µs) : 0, 598
Remote Config [candidate] (552.94 µs) : 0, 553
Telemetry [baseline] (8.568 ms) : 0, 8568
Telemetry [candidate] (8.494 ms) : 0, 8494
Flare Poller [baseline] (3.589 ms) : 0, 3589
Flare Poller [candidate] (3.58 ms) : 0, 3580
IAST [baseline] (27.333 ms) : 0, 27333
IAST [candidate] (26.955 ms) : 0, 26955
section profiling
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (700.704 ms) : 0, 700704
BytebuddyAgent [candidate] (701.729 ms) : 0, 701729
GlobalTracer [baseline] (220.699 ms) : 0, 220699
GlobalTracer [candidate] (220.636 ms) : 0, 220636
AppSec [baseline] (32.137 ms) : 0, 32137
AppSec [candidate] (32.153 ms) : 0, 32153
Debugger [baseline] (68.019 ms) : 0, 68019
Debugger [candidate] (68.128 ms) : 0, 68128
Remote Config [baseline] (613.175 µs) : 0, 613
Remote Config [candidate] (631.056 µs) : 0, 631
Telemetry [baseline] (9.022 ms) : 0, 9022
Telemetry [candidate] (8.962 ms) : 0, 8962
Flare Poller [baseline] (3.711 ms) : 0, 3711
Flare Poller [candidate] (3.755 ms) : 0, 3755
ProfilingAgent [baseline] (97.277 ms) : 0, 97277
ProfilingAgent [candidate] (97.29 ms) : 0, 97290
Profiling [baseline] (97.848 ms) : 0, 97848
Profiling [candidate] (97.87 ms) : 0, 97870
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084203
Total [baseline] (8.73 s) : 0, 8730385
Agent [candidate] (1.093 s) : 0, 1092648
Total [candidate] (8.719 s) : 0, 8718669
section iast
Agent [baseline] (1.224 s) : 0, 1224029
Total [baseline] (9.324 s) : 0, 9324123
Agent [candidate] (1.223 s) : 0, 1222968
Total [candidate] (9.286 s) : 0, 9286165
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (651.277 ms) : 0, 651277
BytebuddyAgent [candidate] (657.118 ms) : 0, 657118
GlobalTracer [baseline] (282.72 ms) : 0, 282720
GlobalTracer [candidate] (284.745 ms) : 0, 284745
AppSec [baseline] (32.604 ms) : 0, 32604
AppSec [candidate] (32.97 ms) : 0, 32970
Debugger [baseline] (67.516 ms) : 0, 67516
Debugger [candidate] (67.267 ms) : 0, 67267
Remote Config [baseline] (685.139 µs) : 0, 685
Remote Config [candidate] (655.57 µs) : 0, 656
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.965 ms) : 0, 8965
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.83 ms) : 0, 3830
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (791.952 ms) : 0, 791952
BytebuddyAgent [candidate] (791.484 ms) : 0, 791484
GlobalTracer [baseline] (256.175 ms) : 0, 256175
GlobalTracer [candidate] (256.346 ms) : 0, 256346
AppSec [baseline] (34.253 ms) : 0, 34253
AppSec [candidate] (34.458 ms) : 0, 34458
Debugger [baseline] (65.245 ms) : 0, 65245
Debugger [candidate] (64.55 ms) : 0, 64550
Remote Config [baseline] (609.32 µs) : 0, 609
Remote Config [candidate] (572.615 µs) : 0, 573
Telemetry [baseline] (8.493 ms) : 0, 8493
Telemetry [candidate] (8.443 ms) : 0, 8443
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (26.949 ms) : 0, 26949
IAST [candidate] (26.984 ms) : 0, 26984
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1181, 1204
. : milestone, 1192,
iast (3.224 ms) : 3178, 3269
. : milestone, 3224,
iast_FULL (5.805 ms) : 5747, 5864
. : milestone, 5805,
iast_GLOBAL (3.613 ms) : 3560, 3665
. : milestone, 3613,
profiling (2.178 ms) : 2156, 2199
. : milestone, 2178,
tracing (1.767 ms) : 1752, 1782
. : milestone, 1767,
section candidate
no_agent (1.189 ms) : 1177, 1201
. : milestone, 1189,
iast (3.216 ms) : 3172, 3259
. : milestone, 3216,
iast_FULL (5.855 ms) : 5797, 5914
. : milestone, 5855,
iast_GLOBAL (3.724 ms) : 3667, 3781
. : milestone, 3724,
profiling (2.035 ms) : 2017, 2053
. : milestone, 2035,
tracing (1.736 ms) : 1722, 1751
. : milestone, 1736,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (19.128 ms) : 18933, 19323
. : milestone, 19128,
appsec (18.572 ms) : 18385, 18758
. : milestone, 18572,
code_origins (17.434 ms) : 17262, 17606
. : milestone, 17434,
iast (17.744 ms) : 17566, 17921
. : milestone, 17744,
profiling (19.128 ms) : 18937, 19319
. : milestone, 19128,
tracing (17.541 ms) : 17371, 17712
. : milestone, 17541,
section candidate
no_agent (19.865 ms) : 19667, 20062
. : milestone, 19865,
appsec (18.483 ms) : 18297, 18669
. : milestone, 18483,
code_origins (17.796 ms) : 17622, 17970
. : milestone, 17796,
iast (17.66 ms) : 17482, 17838
. : milestone, 17660,
profiling (19.444 ms) : 19240, 19647
. : milestone, 19444,
tracing (17.667 ms) : 17494, 17840
. : milestone, 17667,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.727 ms) : 3507, 3947
. : milestone, 3727,
iast (2.203 ms) : 2138, 2268
. : milestone, 2203,
iast_GLOBAL (2.25 ms) : 2185, 2316
. : milestone, 2250,
profiling (2.055 ms) : 2003, 2108
. : milestone, 2055,
tracing (2.045 ms) : 1994, 2097
. : milestone, 2045,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (3.715 ms) : 3495, 3936
. : milestone, 3715,
iast (2.206 ms) : 2141, 2271
. : milestone, 2206,
iast_GLOBAL (2.249 ms) : 2183, 2315
. : milestone, 2249,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.047 ms) : 1996, 2099
. : milestone, 2047,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ed582d580b, baseline=1.59.0-SNAPSHOT~231ea1aad0
dateFormat X
axisFormat %s
section baseline
no_agent (15.571 s) : 15571000, 15571000
. : milestone, 15571000,
appsec (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
iast (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
iast_GLOBAL (17.837 s) : 17837000, 17837000
. : milestone, 17837000,
profiling (15.339 s) : 15339000, 15339000
. : milestone, 15339000,
tracing (14.831 s) : 14831000, 14831000
. : milestone, 14831000,
section candidate
no_agent (15.575 s) : 15575000, 15575000
. : milestone, 15575000,
appsec (14.665 s) : 14665000, 14665000
. : milestone, 14665000,
iast (18.234 s) : 18234000, 18234000
. : milestone, 18234000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
tracing (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
|
dccd70a to
ed582d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
DRAFT. Sharing early work about JUnit assert rules related to tracing and instrumented tests.
Those API are experimental only and
AbstractInstrumentationTestmight be reworked as an extension in a near feature.Motivation
Sharing to prevent code publication and conflict.
Additional Notes
Work based on 2024Q4 R&D week results
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]