-
Notifications
You must be signed in to change notification settings - Fork 323
Print github ref in a separate job in pin-system-tests workflow #10296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084748
Total [baseline] (8.74 s) : 0, 8739973
Agent [candidate] (1.087 s) : 0, 1086785
Total [candidate] (8.727 s) : 0, 8727144
section iast
Agent [baseline] (1.236 s) : 0, 1236291
Total [baseline] (9.411 s) : 0, 9410558
Agent [candidate] (1.22 s) : 0, 1219882
Total [candidate] (9.301 s) : 0, 9301118
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (651.414 ms) : 0, 651414
BytebuddyAgent [candidate] (654.405 ms) : 0, 654405
GlobalTracer [baseline] (283.142 ms) : 0, 283142
GlobalTracer [candidate] (282.755 ms) : 0, 282755
AppSec [baseline] (32.531 ms) : 0, 32531
AppSec [candidate] (32.563 ms) : 0, 32563
Debugger [baseline] (67.549 ms) : 0, 67549
Debugger [candidate] (66.981 ms) : 0, 66981
Remote Config [baseline] (626.613 µs) : 0, 627
Remote Config [candidate] (629.014 µs) : 0, 629
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.816 ms) : 0, 8816
Flare Poller [baseline] (3.766 ms) : 0, 3766
Flare Poller [candidate] (3.721 ms) : 0, 3721
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (799.417 ms) : 0, 799417
BytebuddyAgent [candidate] (788.34 ms) : 0, 788340
GlobalTracer [baseline] (259.018 ms) : 0, 259018
GlobalTracer [candidate] (255.483 ms) : 0, 255483
AppSec [baseline] (34.728 ms) : 0, 34728
AppSec [candidate] (34.688 ms) : 0, 34688
Debugger [baseline] (65.913 ms) : 0, 65913
Debugger [candidate] (65.355 ms) : 0, 65355
Remote Config [baseline] (588.74 µs) : 0, 589
Remote Config [candidate] (606.001 µs) : 0, 606
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.44 ms) : 0, 8440
Flare Poller [baseline] (3.653 ms) : 0, 3653
Flare Poller [candidate] (3.563 ms) : 0, 3563
IAST [baseline] (27.399 ms) : 0, 27399
IAST [candidate] (26.796 ms) : 0, 26796
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090904
Total [baseline] (10.835 s) : 0, 10835190
Agent [candidate] (1.091 s) : 0, 1091430
Total [candidate] (10.887 s) : 0, 10887053
section appsec
Agent [baseline] (1.282 s) : 0, 1281604
Total [baseline] (10.969 s) : 0, 10968524
Agent [candidate] (1.267 s) : 0, 1267499
Total [candidate] (10.977 s) : 0, 10976544
section iast
Agent [baseline] (1.226 s) : 0, 1225923
Total [baseline] (11.168 s) : 0, 11167743
Agent [candidate] (1.225 s) : 0, 1224580
Total [candidate] (11.13 s) : 0, 11129607
section profiling
Agent [baseline] (1.201 s) : 0, 1201496
Total [baseline] (10.854 s) : 0, 10854348
Agent [candidate] (1.206 s) : 0, 1206195
Total [candidate] (11.046 s) : 0, 11046208
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (654.706 ms) : 0, 654706
BytebuddyAgent [candidate] (654.991 ms) : 0, 654991
GlobalTracer [baseline] (284.519 ms) : 0, 284519
GlobalTracer [candidate] (284.615 ms) : 0, 284615
AppSec [baseline] (32.811 ms) : 0, 32811
AppSec [candidate] (32.813 ms) : 0, 32813
Debugger [baseline] (68.56 ms) : 0, 68560
Debugger [candidate] (68.559 ms) : 0, 68559
Remote Config [baseline] (630.68 µs) : 0, 631
Remote Config [candidate] (639.83 µs) : 0, 640
Telemetry [baseline] (9.026 ms) : 0, 9026
Telemetry [candidate] (9.18 ms) : 0, 9180
Flare Poller [baseline] (3.672 ms) : 0, 3672
Flare Poller [candidate] (3.736 ms) : 0, 3736
section appsec
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (701.838 ms) : 0, 701838
BytebuddyAgent [candidate] (691.593 ms) : 0, 691593
GlobalTracer [baseline] (261.66 ms) : 0, 261660
GlobalTracer [candidate] (258.575 ms) : 0, 258575
AppSec [baseline] (175.431 ms) : 0, 175431
AppSec [candidate] (173.807 ms) : 0, 173807
Debugger [baseline] (66.67 ms) : 0, 66670
Debugger [candidate] (68.412 ms) : 0, 68412
Remote Config [baseline] (774.286 µs) : 0, 774
Remote Config [candidate] (783.0 µs) : 0, 783
Telemetry [baseline] (9.508 ms) : 0, 9508
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (3.738 ms) : 0, 3738
Flare Poller [candidate] (3.72 ms) : 0, 3720
IAST [baseline] (24.942 ms) : 0, 24942
IAST [candidate] (24.63 ms) : 0, 24630
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (792.14 ms) : 0, 792140
BytebuddyAgent [candidate] (792.035 ms) : 0, 792035
GlobalTracer [baseline] (256.893 ms) : 0, 256893
GlobalTracer [candidate] (256.228 ms) : 0, 256228
AppSec [baseline] (33.688 ms) : 0, 33688
AppSec [candidate] (32.599 ms) : 0, 32599
Debugger [baseline] (66.758 ms) : 0, 66758
Debugger [candidate] (67.516 ms) : 0, 67516
Remote Config [baseline] (557.723 µs) : 0, 558
Remote Config [candidate] (556.502 µs) : 0, 557
Telemetry [baseline] (8.491 ms) : 0, 8491
Telemetry [candidate] (8.368 ms) : 0, 8368
Flare Poller [baseline] (3.561 ms) : 0, 3561
Flare Poller [candidate] (3.524 ms) : 0, 3524
IAST [baseline] (27.167 ms) : 0, 27167
IAST [candidate] (27.101 ms) : 0, 27101
section profiling
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (701.263 ms) : 0, 701263
BytebuddyAgent [candidate] (703.697 ms) : 0, 703697
GlobalTracer [baseline] (220.087 ms) : 0, 220087
GlobalTracer [candidate] (220.821 ms) : 0, 220821
AppSec [baseline] (31.941 ms) : 0, 31941
AppSec [candidate] (32.047 ms) : 0, 32047
Debugger [baseline] (67.447 ms) : 0, 67447
Debugger [candidate] (67.808 ms) : 0, 67808
Remote Config [baseline] (615.147 µs) : 0, 615
Remote Config [candidate] (650.425 µs) : 0, 650
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.678 ms) : 0, 8678
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.631 ms) : 0, 3631
ProfilingAgent [baseline] (96.629 ms) : 0, 96629
ProfilingAgent [candidate] (97.794 ms) : 0, 97794
Profiling [baseline] (97.204 ms) : 0, 97204
Profiling [candidate] (98.375 ms) : 0, 98375
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (18.078 ms) : 17893, 18263
. : milestone, 18078,
appsec (18.617 ms) : 18427, 18808
. : milestone, 18617,
code_origins (17.708 ms) : 17530, 17886
. : milestone, 17708,
iast (17.937 ms) : 17756, 18119
. : milestone, 17937,
profiling (18.872 ms) : 18682, 19062
. : milestone, 18872,
tracing (17.69 ms) : 17512, 17867
. : milestone, 17690,
section candidate
no_agent (17.2 ms) : 17028, 17371
. : milestone, 17200,
appsec (19.785 ms) : 19577, 19992
. : milestone, 19785,
code_origins (17.754 ms) : 17580, 17928
. : milestone, 17754,
iast (18.589 ms) : 18401, 18778
. : milestone, 18589,
profiling (18.579 ms) : 18394, 18763
. : milestone, 18579,
tracing (17.824 ms) : 17649, 17999
. : milestone, 17824,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.18 ms) : 3144, 3216
. : milestone, 3180,
iast_FULL (5.708 ms) : 5651, 5765
. : milestone, 5708,
iast_GLOBAL (3.693 ms) : 3633, 3754
. : milestone, 3693,
profiling (2.07 ms) : 2051, 2090
. : milestone, 2070,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
section candidate
no_agent (1.197 ms) : 1186, 1208
. : milestone, 1197,
iast (3.116 ms) : 3075, 3157
. : milestone, 3116,
iast_FULL (5.975 ms) : 5914, 6037
. : milestone, 5975,
iast_GLOBAL (3.626 ms) : 3571, 3680
. : milestone, 3626,
profiling (2.056 ms) : 2036, 2076
. : milestone, 2056,
tracing (1.765 ms) : 1750, 1780
. : milestone, 1765,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.757 ms) : 3535, 3979
. : milestone, 3757,
iast (2.224 ms) : 2160, 2288
. : milestone, 2224,
iast_GLOBAL (2.269 ms) : 2204, 2334
. : milestone, 2269,
profiling (2.098 ms) : 2044, 2152
. : milestone, 2098,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.721 ms) : 3500, 3942
. : milestone, 3721,
iast (2.231 ms) : 2166, 2295
. : milestone, 2231,
iast_GLOBAL (2.272 ms) : 2207, 2337
. : milestone, 2272,
profiling (2.089 ms) : 2035, 2143
. : milestone, 2089,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~c43bfc81d1, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (15.681 s) : 15681000, 15681000
. : milestone, 15681000,
appsec (14.626 s) : 14626000, 14626000
. : milestone, 14626000,
iast (18.733 s) : 18733000, 18733000
. : milestone, 18733000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (14.539 s) : 14539000, 14539000
. : milestone, 14539000,
section candidate
no_agent (15.668 s) : 15668000, 15668000
. : milestone, 15668000,
appsec (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
iast (18.417 s) : 18417000, 18417000
. : milestone, 18417000,
iast_GLOBAL (17.775 s) : 17775000, 17775000
. : milestone, 17775000,
profiling (15.574 s) : 15574000, 15574000
. : milestone, 15574000,
tracing (14.6 s) : 14600000, 14600000
. : milestone, 14600000,
|
|
Closing this after testing it here: https://github.com/DataDog/dd-trace-java/actions/runs/20756844253/job/59601128355 🙂 |
What Does This Do
Add a separate job before
dd-octo-ststhat prints the github ref. This should allow us to see the full github ref and properly refine the workflow'sif:statement filter.Motivation
Unfortunately I failed to take into account
dd-octo-stsrestrictions in #10293 (failure). It was not sufficient to only loosen the trigger branch restrictions in the workflow.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]