-
Notifications
You must be signed in to change notification settings - Fork 323
Mute JNA initialisation when creating ForeignMemoryWriters #10302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
approved these changes
Jan 7, 2026
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1082584
Total [baseline] (10.823 s) : 0, 10822523
Agent [candidate] (1.1 s) : 0, 1100013
Total [candidate] (10.838 s) : 0, 10837973
section appsec
Agent [baseline] (1.282 s) : 0, 1281520
Total [baseline] (10.802 s) : 0, 10801934
Agent [candidate] (1.265 s) : 0, 1265141
Total [candidate] (11.069 s) : 0, 11068567
section iast
Agent [baseline] (1.227 s) : 0, 1227297
Total [baseline] (11.251 s) : 0, 11251003
Agent [candidate] (1.222 s) : 0, 1222418
Total [candidate] (11.045 s) : 0, 11044927
section profiling
Agent [baseline] (1.209 s) : 0, 1208571
Total [baseline] (10.977 s) : 0, 10977402
Agent [candidate] (1.199 s) : 0, 1198668
Total [candidate] (10.892 s) : 0, 10892110
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (649.773 ms) : 0, 649773
BytebuddyAgent [candidate] (660.856 ms) : 0, 660856
GlobalTracer [baseline] (281.691 ms) : 0, 281691
GlobalTracer [candidate] (286.116 ms) : 0, 286116
AppSec [baseline] (32.659 ms) : 0, 32659
AppSec [candidate] (33.187 ms) : 0, 33187
Debugger [baseline] (68.419 ms) : 0, 68419
Debugger [candidate] (69.31 ms) : 0, 69310
Remote Config [baseline] (641.473 µs) : 0, 641
Remote Config [candidate] (639.105 µs) : 0, 639
Telemetry [baseline] (9.028 ms) : 0, 9028
Telemetry [candidate] (9.183 ms) : 0, 9183
Flare Poller [baseline] (3.763 ms) : 0, 3763
Flare Poller [candidate] (3.789 ms) : 0, 3789
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (700.636 ms) : 0, 700636
BytebuddyAgent [candidate] (689.111 ms) : 0, 689111
GlobalTracer [baseline] (261.67 ms) : 0, 261670
GlobalTracer [candidate] (257.621 ms) : 0, 257621
IAST [baseline] (25.186 ms) : 0, 25186
IAST [candidate] (24.439 ms) : 0, 24439
AppSec [baseline] (174.985 ms) : 0, 174985
AppSec [candidate] (173.114 ms) : 0, 173114
Debugger [baseline] (67.979 ms) : 0, 67979
Debugger [candidate] (69.921 ms) : 0, 69921
Remote Config [baseline] (763.007 µs) : 0, 763
Remote Config [candidate] (753.426 µs) : 0, 753
Telemetry [baseline] (9.524 ms) : 0, 9524
Telemetry [candidate] (9.71 ms) : 0, 9710
Flare Poller [baseline] (3.857 ms) : 0, 3857
Flare Poller [candidate] (3.966 ms) : 0, 3966
section iast
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (794.586 ms) : 0, 794586
BytebuddyAgent [candidate] (790.354 ms) : 0, 790354
GlobalTracer [baseline] (256.56 ms) : 0, 256560
GlobalTracer [candidate] (255.985 ms) : 0, 255985
IAST [baseline] (27.168 ms) : 0, 27168
IAST [candidate] (27.001 ms) : 0, 27001
AppSec [baseline] (35.243 ms) : 0, 35243
AppSec [candidate] (32.623 ms) : 0, 32623
Debugger [baseline] (64.636 ms) : 0, 64636
Debugger [candidate] (67.362 ms) : 0, 67362
Remote Config [baseline] (577.879 µs) : 0, 578
Remote Config [candidate] (567.195 µs) : 0, 567
Telemetry [baseline] (8.423 ms) : 0, 8423
Telemetry [candidate] (8.466 ms) : 0, 8466
Flare Poller [baseline] (3.486 ms) : 0, 3486
Flare Poller [candidate] (3.562 ms) : 0, 3562
section profiling
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (704.91 ms) : 0, 704910
BytebuddyAgent [candidate] (699.222 ms) : 0, 699222
GlobalTracer [baseline] (221.384 ms) : 0, 221384
GlobalTracer [candidate] (219.441 ms) : 0, 219441
AppSec [baseline] (32.447 ms) : 0, 32447
AppSec [candidate] (31.942 ms) : 0, 31942
Debugger [baseline] (68.431 ms) : 0, 68431
Debugger [candidate] (67.883 ms) : 0, 67883
Remote Config [baseline] (664.372 µs) : 0, 664
Remote Config [candidate] (638.802 µs) : 0, 639
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.662 ms) : 0, 8662
Flare Poller [baseline] (3.636 ms) : 0, 3636
Flare Poller [candidate] (3.638 ms) : 0, 3638
ProfilingAgent [baseline] (97.325 ms) : 0, 97325
ProfilingAgent [candidate] (96.578 ms) : 0, 96578
Profiling [baseline] (97.913 ms) : 0, 97913
Profiling [candidate] (97.155 ms) : 0, 97155
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083574
Total [baseline] (8.677 s) : 0, 8677182
Agent [candidate] (1.083 s) : 0, 1083025
Total [candidate] (8.726 s) : 0, 8725836
section iast
Agent [baseline] (1.218 s) : 0, 1218322
Total [baseline] (9.333 s) : 0, 9332629
Agent [candidate] (1.222 s) : 0, 1222188
Total [candidate] (9.287 s) : 0, 9286795
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (649.62 ms) : 0, 649620
BytebuddyAgent [candidate] (650.855 ms) : 0, 650855
GlobalTracer [baseline] (283.333 ms) : 0, 283333
GlobalTracer [candidate] (282.289 ms) : 0, 282289
AppSec [baseline] (32.836 ms) : 0, 32836
AppSec [candidate] (32.562 ms) : 0, 32562
Debugger [baseline] (67.891 ms) : 0, 67891
Debugger [candidate] (67.226 ms) : 0, 67226
Remote Config [baseline] (615.213 µs) : 0, 615
Remote Config [candidate] (600.427 µs) : 0, 600
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.771 ms) : 0, 3771
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (788.466 ms) : 0, 788466
BytebuddyAgent [candidate] (791.341 ms) : 0, 791341
GlobalTracer [baseline] (254.618 ms) : 0, 254618
GlobalTracer [candidate] (255.665 ms) : 0, 255665
IAST [baseline] (26.942 ms) : 0, 26942
IAST [candidate] (27.0 ms) : 0, 27000
AppSec [baseline] (33.362 ms) : 0, 33362
AppSec [candidate] (34.227 ms) : 0, 34227
Debugger [baseline] (65.724 ms) : 0, 65724
Debugger [candidate] (64.774 ms) : 0, 64774
Remote Config [baseline] (624.84 µs) : 0, 625
Remote Config [candidate] (623.294 µs) : 0, 623
Telemetry [baseline] (8.458 ms) : 0, 8458
Telemetry [candidate] (8.471 ms) : 0, 8471
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.59 ms) : 0, 3590
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (18.189 ms) : 18000, 18378
. : milestone, 18189,
appsec (18.556 ms) : 18369, 18744
. : milestone, 18556,
code_origins (18.153 ms) : 17969, 18337
. : milestone, 18153,
iast (17.452 ms) : 17279, 17624
. : milestone, 17452,
profiling (18.701 ms) : 18516, 18885
. : milestone, 18701,
tracing (17.64 ms) : 17462, 17818
. : milestone, 17640,
section candidate
no_agent (17.134 ms) : 16964, 17304
. : milestone, 17134,
appsec (18.666 ms) : 18476, 18856
. : milestone, 18666,
code_origins (17.865 ms) : 17688, 18042
. : milestone, 17865,
iast (17.599 ms) : 17423, 17775
. : milestone, 17599,
profiling (18.536 ms) : 18351, 18720
. : milestone, 18536,
tracing (17.756 ms) : 17579, 17934
. : milestone, 17756,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1195
. : milestone, 1183,
iast (3.203 ms) : 3161, 3246
. : milestone, 3203,
iast_FULL (5.828 ms) : 5770, 5886
. : milestone, 5828,
iast_GLOBAL (3.596 ms) : 3543, 3649
. : milestone, 3596,
profiling (2.14 ms) : 2120, 2160
. : milestone, 2140,
tracing (1.845 ms) : 1830, 1860
. : milestone, 1845,
section candidate
no_agent (1.18 ms) : 1169, 1192
. : milestone, 1180,
iast (3.258 ms) : 3214, 3301
. : milestone, 3258,
iast_FULL (5.738 ms) : 5681, 5796
. : milestone, 5738,
iast_GLOBAL (3.414 ms) : 3366, 3462
. : milestone, 3414,
profiling (2.058 ms) : 2039, 2078
. : milestone, 2058,
tracing (1.794 ms) : 1777, 1810
. : milestone, 1794,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.694 ms) : 3479, 3909
. : milestone, 3694,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.276 ms) : 2210, 2341
. : milestone, 2276,
profiling (2.075 ms) : 2022, 2128
. : milestone, 2075,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.472 ms) : 2421, 2524
. : milestone, 2472,
iast (2.212 ms) : 2147, 2276
. : milestone, 2212,
iast_GLOBAL (2.263 ms) : 2199, 2328
. : milestone, 2263,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.059 ms) : 2008, 2110
. : milestone, 2059,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~fb3fbd7611, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
appsec (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
iast (17.903 s) : 17903000, 17903000
. : milestone, 17903000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
tracing (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
section candidate
no_agent (15.648 s) : 15648000, 15648000
. : milestone, 15648000,
appsec (14.392 s) : 14392000, 14392000
. : milestone, 14392000,
iast (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
iast_GLOBAL (17.703 s) : 17703000, 17703000
. : milestone, 17703000,
profiling (15.557 s) : 15557000, 15557000
. : milestone, 15557000,
tracing (14.525 s) : 14525000, 14525000
. : milestone, 14525000,
|
Contributor
Author
|
Closing in favour of #10304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
JNA initialisation usually trigger unix command executions that creates process execution spans. This causes the smoke test to count more spans hence it made it failing.
This PR move the blackhole that was hiding the spans from the write to the initialisation of writer instances (since now the JNA is initialised here)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]