-
Notifications
You must be signed in to change notification settings - Fork 323
fix NullPointerException in ClassesToRetransformFinder #10316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add check against null from classes returned by Instrumentation::getAllLoadedClasses
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (324.135 µs) : 283, 366
. : milestone, 324,
basic (279.655 µs) : 273, 287
. : milestone, 280,
loop (8.949 ms) : 8945, 8954
. : milestone, 8949,
section candidate
noprobe (312.177 µs) : 288, 336
. : milestone, 312,
basic (278.43 µs) : 272, 285
. : milestone, 278,
loop (8.955 ms) : 8951, 8960
. : milestone, 8955,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091156
Total [baseline] (8.761 s) : 0, 8761281
Agent [candidate] (1.085 s) : 0, 1084984
Total [candidate] (8.769 s) : 0, 8768971
section iast
Agent [baseline] (1.231 s) : 0, 1230848
Total [baseline] (9.337 s) : 0, 9336825
Agent [candidate] (1.223 s) : 0, 1223488
Total [candidate] (9.292 s) : 0, 9291927
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (655.673 ms) : 0, 655673
BytebuddyAgent [candidate] (651.9 ms) : 0, 651900
GlobalTracer [baseline] (284.134 ms) : 0, 284134
GlobalTracer [candidate] (283.211 ms) : 0, 283211
AppSec [baseline] (32.812 ms) : 0, 32812
AppSec [candidate] (32.768 ms) : 0, 32768
Debugger [baseline] (68.156 ms) : 0, 68156
Debugger [candidate] (67.06 ms) : 0, 67060
Remote Config [baseline] (621.387 µs) : 0, 621
Remote Config [candidate] (641.024 µs) : 0, 641
Telemetry [baseline] (9.0 ms) : 0, 9000
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.729 ms) : 0, 3729
Flare Poller [candidate] (3.747 ms) : 0, 3747
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (796.667 ms) : 0, 796667
BytebuddyAgent [candidate] (791.72 ms) : 0, 791720
GlobalTracer [baseline] (257.36 ms) : 0, 257360
GlobalTracer [candidate] (256.018 ms) : 0, 256018
AppSec [baseline] (33.764 ms) : 0, 33764
AppSec [candidate] (34.418 ms) : 0, 34418
Debugger [baseline] (66.222 ms) : 0, 66222
Debugger [candidate] (65.093 ms) : 0, 65093
Remote Config [baseline] (593.048 µs) : 0, 593
Remote Config [candidate] (574.278 µs) : 0, 574
Telemetry [baseline] (8.596 ms) : 0, 8596
Telemetry [candidate] (8.503 ms) : 0, 8503
Flare Poller [baseline] (3.638 ms) : 0, 3638
Flare Poller [candidate] (3.548 ms) : 0, 3548
IAST [baseline] (27.231 ms) : 0, 27231
IAST [candidate] (26.904 ms) : 0, 26904
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1102403
Total [baseline] (10.963 s) : 0, 10963175
Agent [candidate] (1.085 s) : 0, 1085459
Total [candidate] (10.749 s) : 0, 10749179
section appsec
Agent [baseline] (1.265 s) : 0, 1265340
Total [baseline] (11.042 s) : 0, 11041733
Agent [candidate] (1.268 s) : 0, 1267535
Total [candidate] (10.976 s) : 0, 10976427
section iast
Agent [baseline] (1.233 s) : 0, 1232727
Total [baseline] (11.22 s) : 0, 11219891
Agent [candidate] (1.233 s) : 0, 1233084
Total [candidate] (11.216 s) : 0, 11215862
section profiling
Agent [baseline] (1.207 s) : 0, 1207078
Total [baseline] (11.039 s) : 0, 11038722
Agent [candidate] (1.206 s) : 0, 1205675
Total [candidate] (10.884 s) : 0, 10883925
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (662.11 ms) : 0, 662110
BytebuddyAgent [candidate] (651.632 ms) : 0, 651632
GlobalTracer [baseline] (286.37 ms) : 0, 286370
GlobalTracer [candidate] (282.599 ms) : 0, 282599
AppSec [baseline] (33.277 ms) : 0, 33277
AppSec [candidate] (32.39 ms) : 0, 32390
Debugger [baseline] (69.747 ms) : 0, 69747
Debugger [candidate] (68.539 ms) : 0, 68539
Remote Config [baseline] (633.842 µs) : 0, 634
Remote Config [candidate] (639.587 µs) : 0, 640
Telemetry [baseline] (9.26 ms) : 0, 9260
Telemetry [candidate] (9.105 ms) : 0, 9105
Flare Poller [baseline] (3.89 ms) : 0, 3890
Flare Poller [candidate] (3.801 ms) : 0, 3801
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (691.412 ms) : 0, 691412
BytebuddyAgent [candidate] (692.278 ms) : 0, 692278
GlobalTracer [baseline] (258.389 ms) : 0, 258389
GlobalTracer [candidate] (259.001 ms) : 0, 259001
AppSec [baseline] (174.43 ms) : 0, 174430
AppSec [candidate] (173.464 ms) : 0, 173464
Debugger [baseline] (66.308 ms) : 0, 66308
Debugger [candidate] (67.763 ms) : 0, 67763
Remote Config [baseline] (733.899 µs) : 0, 734
Remote Config [candidate] (755.188 µs) : 0, 755
Telemetry [baseline] (9.347 ms) : 0, 9347
Telemetry [candidate] (9.332 ms) : 0, 9332
Flare Poller [baseline] (3.73 ms) : 0, 3730
Flare Poller [candidate] (3.766 ms) : 0, 3766
IAST [baseline] (24.453 ms) : 0, 24453
IAST [candidate] (24.588 ms) : 0, 24588
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (796.864 ms) : 0, 796864
BytebuddyAgent [candidate] (798.143 ms) : 0, 798143
GlobalTracer [baseline] (257.97 ms) : 0, 257970
GlobalTracer [candidate] (257.724 ms) : 0, 257724
AppSec [baseline] (32.982 ms) : 0, 32982
AppSec [candidate] (33.667 ms) : 0, 33667
Debugger [baseline] (68.038 ms) : 0, 68038
Debugger [candidate] (66.742 ms) : 0, 66742
Remote Config [baseline] (578.005 µs) : 0, 578
Remote Config [candidate] (594.294 µs) : 0, 594
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.531 ms) : 0, 8531
Flare Poller [baseline] (3.571 ms) : 0, 3571
Flare Poller [candidate] (3.556 ms) : 0, 3556
IAST [baseline] (27.351 ms) : 0, 27351
IAST [candidate] (27.293 ms) : 0, 27293
section profiling
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (703.84 ms) : 0, 703840
BytebuddyAgent [candidate] (703.275 ms) : 0, 703275
GlobalTracer [baseline] (220.705 ms) : 0, 220705
GlobalTracer [candidate] (220.767 ms) : 0, 220767
AppSec [baseline] (32.165 ms) : 0, 32165
AppSec [candidate] (32.201 ms) : 0, 32201
Debugger [baseline] (68.206 ms) : 0, 68206
Debugger [candidate] (68.219 ms) : 0, 68219
Remote Config [baseline] (646.028 µs) : 0, 646
Remote Config [candidate] (636.536 µs) : 0, 637
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.783 ms) : 0, 8783
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.65 ms) : 0, 3650
ProfilingAgent [baseline] (97.912 ms) : 0, 97912
ProfilingAgent [candidate] (97.03 ms) : 0, 97030
Profiling [baseline] (98.512 ms) : 0, 98512
Profiling [candidate] (97.608 ms) : 0, 97608
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 4 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1201
. : milestone, 1189,
iast (3.197 ms) : 3153, 3241
. : milestone, 3197,
iast_FULL (6.001 ms) : 5940, 6062
. : milestone, 6001,
iast_GLOBAL (3.578 ms) : 3526, 3630
. : milestone, 3578,
profiling (2.091 ms) : 2072, 2110
. : milestone, 2091,
tracing (1.841 ms) : 1825, 1857
. : milestone, 1841,
section candidate
no_agent (1.29 ms) : 1275, 1304
. : milestone, 1290,
iast (3.13 ms) : 3089, 3170
. : milestone, 3130,
iast_FULL (5.512 ms) : 5458, 5566
. : milestone, 5512,
iast_GLOBAL (3.587 ms) : 3531, 3643
. : milestone, 3587,
profiling (1.933 ms) : 1917, 1950
. : milestone, 1933,
tracing (1.817 ms) : 1802, 1833
. : milestone, 1817,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (17.199 ms) : 17029, 17369
. : milestone, 17199,
appsec (18.813 ms) : 18621, 19005
. : milestone, 18813,
code_origins (17.712 ms) : 17537, 17888
. : milestone, 17712,
iast (19.889 ms) : 19686, 20093
. : milestone, 19889,
profiling (18.925 ms) : 18733, 19117
. : milestone, 18925,
tracing (17.626 ms) : 17454, 17798
. : milestone, 17626,
section candidate
no_agent (19.263 ms) : 19066, 19461
. : milestone, 19263,
appsec (18.534 ms) : 18344, 18725
. : milestone, 18534,
code_origins (18.857 ms) : 18669, 19045
. : milestone, 18857,
iast (17.472 ms) : 17297, 17647
. : milestone, 17472,
profiling (18.559 ms) : 18376, 18742
. : milestone, 18559,
tracing (17.597 ms) : 17422, 17772
. : milestone, 17597,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
appsec (15.191 s) : 15191000, 15191000
. : milestone, 15191000,
iast (18.468 s) : 18468000, 18468000
. : milestone, 18468000,
iast_GLOBAL (18.083 s) : 18083000, 18083000
. : milestone, 18083000,
profiling (14.696 s) : 14696000, 14696000
. : milestone, 14696000,
tracing (14.59 s) : 14590000, 14590000
. : milestone, 14590000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
iast (18.501 s) : 18501000, 18501000
. : milestone, 18501000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
. : milestone, 17851000,
profiling (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
tracing (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~2a279dfc59, baseline=1.59.0-SNAPSHOT~08e165783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.754 ms) : 3536, 3973
. : milestone, 3754,
iast (2.229 ms) : 2164, 2294
. : milestone, 2229,
iast_GLOBAL (2.262 ms) : 2197, 2327
. : milestone, 2262,
profiling (2.112 ms) : 2057, 2166
. : milestone, 2112,
tracing (2.052 ms) : 2002, 2103
. : milestone, 2052,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.758 ms) : 3539, 3978
. : milestone, 3758,
iast (2.22 ms) : 2155, 2285
. : milestone, 2220,
iast_GLOBAL (2.274 ms) : 2208, 2340
. : milestone, 2274,
profiling (2.104 ms) : 2049, 2158
. : milestone, 2104,
tracing (2.054 ms) : 2003, 2105
. : milestone, 2054,
|
What Does This Do
add check against null from classes returned by
Instrumentation::getAllLoadedClassesMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4904