Datastax Cassandra 4 instrumentation #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| throwable = throwable.getCause(); | ||
| } | ||
| DECORATE.onError(span, throwable); | ||
| span.finish(); |
Contributor
There was a problem hiding this comment.
Should this span be the active span at this time? If so, this lambda wouldn't need to capture here.
Contributor
There was a problem hiding this comment.
It seems unfortunate that we go to such lengths and quite some cost to propagate context into completable futures, when all we really need to do is capture the span in a closure, but we're doing both here, the CompletableFuture instrumentation should be making sure this would be the active span at the time.
...rc/main/java8/datadog/trace/instrumentation/datastax/cassandra/CassandraClientDecorator.java
Outdated
Show resolved
Hide resolved
richardstartin
approved these changes
Dec 2, 2020
tylerbenson
approved these changes
Dec 2, 2020
| public class CassandraClientInstrumentation extends Instrumenter.Default { | ||
|
|
||
| public CassandraClientInstrumentation() { | ||
| super("cassandra"); |
Contributor
There was a problem hiding this comment.
Do we want to add a secondary name to distinguish 3 from 4?
...in/java/datadog/trace/instrumentation/datastax/cassandra/CassandraClientInstrumentation.java
Outdated
Show resolved
Hide resolved
...in/java/datadog/trace/instrumentation/datastax/cassandra/CassandraClientInstrumentation.java
Outdated
Show resolved
Hide resolved
...rc/main/java8/datadog/trace/instrumentation/datastax/cassandra/CassandraClientDecorator.java
Outdated
Show resolved
Hide resolved
randomanderson
force-pushed
the
landerson/datastax-4
branch
3 times, most recently
from
adb9c26 to
c93f1c0
Compare
randomanderson
force-pushed
the
landerson/datastax-4
branch
from
c93f1c0 to
165b840
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation for cassandra 4. The large API changes between versions means not much can be salvaged from the cassandra 3 instrumentation other than the test.