Skip to content

Removed scala converter lambdas and ensure they are added as helpers #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manuel-alvarez-alvarez merged 3 commits into from
Jun 11, 2024
Merged

Removed scala converter lambdas and ensure they are added as helpers #7146

manuel-alvarez-alvarez merged 3 commits into from
Jun 11, 2024

Conversation

@manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Jun 10, 2024 •
edited by atlassian bot
Loading

What Does This Do

Removes lambdas and anonymous classes from datadog.trace.instrumentation.scala.ScalaJavaConverters and ensures that the new ones are added as helpers.

Motivation

We started to get telemetry logs regarding an issue with scala call sites due to missing classes:

afterInterpolation threw
java.lang.NoClassDefFoundError: datadog/trace/instrumentation/scala/ScalaJavaConverters$1
  at datadog.trace.instrumentation.scala.ScalaJavaConverters.lambda$toIterable$0(ScalaJavaConverters.java:12)
  at com.datadog.iast.propagation.StringModuleImpl.onStringFormat(StringModuleImpl.java:526)
  at datadog.trace.instrumentation.scala.StringContextCallSite.afterInterpolation(StringContextCallSite.java:28)
  at [redacted: 65 frames]
  at datadog.trace.instrumentation.spray.SprayHelper$$anonfun$wrapRoute$1.apply(SprayHelper.scala:33)
  at datadog.trace.instrumentation.spray.SprayHelper$$anonfun$wrapRoute$1.apply(SprayHelper.scala:30)
  at [redacted: 19 frames]

Additional Notes

Jira ticket: APPSEC-53573

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: bug Bug report and fix comp: asm iast Application Security Management (IAST) labels Jun 10, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review June 10, 2024 12:46
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner June 10, 2024 12:46
@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-fix-scala-helper
git_commit_date 1718111499 1718112690
git_commit_sha 42276d7 196ec7a
release_version 1.36.0-SNAPSHOT~42276d7c29 1.36.0-SNAPSHOT~196ec7a688
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718115546 1718115546
ci_job_id 539219135 539219135
ci_pipeline_id 36396136 36396136
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060651
Total [baseline] (8.597 s) : 0, 8597176
Agent [candidate] (1.06 s) : 0, 1060072
Total [candidate] (8.538 s) : 0, 8537800
section iast
Agent [baseline] (1.175 s) : 0, 1175190
Total [baseline] (8.985 s) : 0, 8984976
Agent [candidate] (1.18 s) : 0, 1180437
Total [candidate] (9.038 s) : 0, 9038463
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1187171
Total [baseline] (8.973 s) : 0, 8972602
Agent [candidate] (1.171 s) : 0, 1170754
Total [candidate] (8.96 s) : 0, 8959872
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162986
Total [baseline] (9.052 s) : 0, 9052277
Agent [candidate] (1.164 s) : 0, 1163668
Total [candidate] (8.988 s) : 0, 8988366
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.175 s 114.539 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.187 s 126.52 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.163 s 102.335 ms (9.6%)
Total tracing 8.597 s -
Total iast 8.985 s 387.8 ms (4.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.973 s 375.426 ms (4.4%)
Total iast_TELEMETRY_OFF 9.052 s 455.101 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.18 s 120.364 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 110.681 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.164 s 103.596 ms (9.8%)
Total tracing 8.538 s -
Total iast 9.038 s 500.663 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 422.072 ms (4.9%)
Total iast_TELEMETRY_OFF 8.988 s 450.565 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.2 ms) : 0, 664200
BytebuddyAgent [candidate] (663.623 ms) : 0, 663623
GlobalTracer [baseline] (303.305 ms) : 0, 303305
GlobalTracer [candidate] (303.28 ms) : 0, 303280
AppSec [baseline] (50.123 ms) : 0, 50123
AppSec [candidate] (50.216 ms) : 0, 50216
Logs Intake [baseline] (392.891 µs) : 0, 393
Logs Intake [candidate] (403.702 µs) : 0, 404
Remote Config [baseline] (691.269 µs) : 0, 691
Remote Config [candidate] (674.485 µs) : 0, 674
Telemetry [baseline] (7.494 ms) : 0, 7494
Telemetry [candidate] (7.514 ms) : 0, 7514
section iast
BytebuddyAgent [baseline] (784.68 ms) : 0, 784680
BytebuddyAgent [candidate] (787.117 ms) : 0, 787117
GlobalTracer [baseline] (295.456 ms) : 0, 295456
GlobalTracer [candidate] (296.24 ms) : 0, 296240
AppSec [baseline] (46.961 ms) : 0, 46961
AppSec [candidate] (47.136 ms) : 0, 47136
IAST [baseline] (26.978 ms) : 0, 26978
IAST [candidate] (26.51 ms) : 0, 26510
Logs Intake [baseline] (297.712 µs) : 0, 298
Logs Intake [candidate] (305.493 µs) : 0, 305
Remote Config [baseline] (560.89 µs) : 0, 561
Remote Config [candidate] (572.552 µs) : 0, 573
Telemetry [baseline] (6.866 ms) : 0, 6866
Telemetry [candidate] (9.118 ms) : 0, 9118
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.311 ms) : 0, 792311
BytebuddyAgent [candidate] (780.314 ms) : 0, 780314
GlobalTracer [baseline] (298.528 ms) : 0, 298528
GlobalTracer [candidate] (293.802 ms) : 0, 293802
AppSec [baseline] (47.271 ms) : 0, 47271
AppSec [candidate] (46.68 ms) : 0, 46680
IAST [baseline] (25.433 ms) : 0, 25433
IAST [candidate] (27.259 ms) : 0, 27259
Logs Intake [baseline] (300.708 µs) : 0, 301
Logs Intake [candidate] (300.769 µs) : 0, 301
Remote Config [baseline] (572.246 µs) : 0, 572
Remote Config [candidate] (586.508 µs) : 0, 587
Telemetry [baseline] (9.17 ms) : 0, 9170
Telemetry [candidate] (8.413 ms) : 0, 8413
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.475 ms) : 0, 775475
BytebuddyAgent [candidate] (775.613 ms) : 0, 775613
GlobalTracer [baseline] (293.28 ms) : 0, 293280
GlobalTracer [candidate] (293.119 ms) : 0, 293119
AppSec [baseline] (46.444 ms) : 0, 46444
AppSec [candidate] (46.489 ms) : 0, 46489
IAST [baseline] (26.036 ms) : 0, 26036
IAST [candidate] (25.223 ms) : 0, 25223
Logs Intake [baseline] (300.511 µs) : 0, 301
Logs Intake [candidate] (299.931 µs) : 0, 300
Remote Config [baseline] (566.914 µs) : 0, 567
Remote Config [candidate] (565.377 µs) : 0, 565
Telemetry [baseline] (7.541 ms) : 0, 7541
Telemetry [candidate] (8.996 ms) : 0, 8996
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063002
Total [baseline] (10.453 s) : 0, 10452852
Agent [candidate] (1.071 s) : 0, 1070977
Total [candidate] (10.368 s) : 0, 10367864
section appsec
Agent [baseline] (1.184 s) : 0, 1183606
Total [baseline] (10.499 s) : 0, 10499417
Agent [candidate] (1.185 s) : 0, 1185451
Total [candidate] (10.465 s) : 0, 10465101
section iast
Agent [baseline] (1.171 s) : 0, 1170725
Total [baseline] (10.642 s) : 0, 10641868
Agent [candidate] (1.169 s) : 0, 1169371
Total [candidate] (10.739 s) : 0, 10739119
section profiling
Agent [baseline] (1.26 s) : 0, 1260381
Total [baseline] (10.719 s) : 0, 10719350
Agent [candidate] (1.269 s) : 0, 1269458
Total [candidate] (10.659 s) : 0, 10659055
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.184 s 120.604 ms (11.3%)
Agent iast 1.171 s 107.723 ms (10.1%)
Agent profiling 1.26 s 197.379 ms (18.6%)
Total tracing 10.453 s -
Total appsec 10.499 s 46.564 ms (0.4%)
Total iast 10.642 s 189.015 ms (1.8%)
Total profiling 10.719 s 266.497 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.185 s 114.474 ms (10.7%)
Agent iast 1.169 s 98.394 ms (9.2%)
Agent profiling 1.269 s 198.481 ms (18.5%)
Total tracing 10.368 s -
Total appsec 10.465 s 97.236 ms (0.9%)
Total iast 10.739 s 371.255 ms (3.6%)
Total profiling 10.659 s 291.19 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.664 ms) : 0, 665664
BytebuddyAgent [candidate] (670.673 ms) : 0, 670673
GlobalTracer [baseline] (304.163 ms) : 0, 304163
GlobalTracer [candidate] (306.477 ms) : 0, 306477
AppSec [baseline] (50.171 ms) : 0, 50171
AppSec [candidate] (50.418 ms) : 0, 50418
Logs Intake [baseline] (405.622 µs) : 0, 406
Logs Intake [candidate] (448.104 µs) : 0, 448
Remote Config [baseline] (687.962 µs) : 0, 688
Remote Config [candidate] (664.481 µs) : 0, 664
Telemetry [baseline] (7.532 ms) : 0, 7532
Telemetry [candidate] (7.581 ms) : 0, 7581
section appsec
BytebuddyAgent [baseline] (676.805 ms) : 0, 676805
BytebuddyAgent [candidate] (678.516 ms) : 0, 678516
GlobalTracer [baseline] (297.971 ms) : 0, 297971
GlobalTracer [candidate] (298.961 ms) : 0, 298961
AppSec [baseline] (153.38 ms) : 0, 153380
AppSec [candidate] (153.632 ms) : 0, 153632
Logs Intake [baseline] (320.28 µs) : 0, 320
Logs Intake [candidate] (327.586 µs) : 0, 328
Remote Config [baseline] (653.388 µs) : 0, 653
Remote Config [candidate] (642.28 µs) : 0, 642
Telemetry [baseline] (8.862 ms) : 0, 8862
Telemetry [candidate] (8.534 ms) : 0, 8534
IAST [baseline] (22.283 ms) : 0, 22283
IAST [candidate] (20.543 ms) : 0, 20543
section iast
BytebuddyAgent [baseline] (780.292 ms) : 0, 780292
BytebuddyAgent [candidate] (779.643 ms) : 0, 779643
GlobalTracer [baseline] (293.764 ms) : 0, 293764
GlobalTracer [candidate] (293.983 ms) : 0, 293983
AppSec [baseline] (46.798 ms) : 0, 46798
AppSec [candidate] (46.733 ms) : 0, 46733
Logs Intake [baseline] (303.364 µs) : 0, 303
Logs Intake [candidate] (316.183 µs) : 0, 316
Remote Config [baseline] (586.03 µs) : 0, 586
Remote Config [candidate] (571.236 µs) : 0, 571
Telemetry [baseline] (9.926 ms) : 0, 9926
Telemetry [candidate] (7.698 ms) : 0, 7698
IAST [baseline] (25.796 ms) : 0, 25796
IAST [candidate] (27.152 ms) : 0, 27152
section profiling
BytebuddyAgent [baseline] (662.623 ms) : 0, 662623
BytebuddyAgent [candidate] (667.328 ms) : 0, 667328
GlobalTracer [baseline] (385.821 ms) : 0, 385821
GlobalTracer [candidate] (388.861 ms) : 0, 388861
AppSec [baseline] (50.53 ms) : 0, 50530
AppSec [candidate] (51.312 ms) : 0, 51312
Logs Intake [baseline] (331.279 µs) : 0, 331
Logs Intake [candidate] (337.503 µs) : 0, 338
Remote Config [baseline] (744.864 µs) : 0, 745
Remote Config [candidate] (747.158 µs) : 0, 747
Telemetry [baseline] (7.355 ms) : 0, 7355
Telemetry [candidate] (7.397 ms) : 0, 7397
ProfilingAgent [baseline] (96.274 ms) : 0, 96274
ProfilingAgent [candidate] (96.399 ms) : 0, 96399
Profiling [baseline] (96.299 ms) : 0, 96299
Profiling [candidate] (96.423 ms) : 0, 96423
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-11T13:49:51 2024-06-11T13:56:41
git_branch master malvarez/iast-fix-scala-helper
git_commit_date 1718111499 1718112690
git_commit_sha 42276d7 196ec7a
release_version 1.36.0-SNAPSHOT~42276d7c29 1.36.0-SNAPSHOT~196ec7a688
start_time 2024-06-11T13:49:38 2024-06-11T13:56:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718114545 1718114545
ci_job_id 539219136 539219136
ci_pipeline_id 36396136 36396136
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
appsec_no_iast (1.702 ms) : 1677, 1726
.   : milestone, 1702,
iast (1.482 ms) : 1459, 1505
.   : milestone, 1482,
profiling (1.535 ms) : 1509, 1560
.   : milestone, 1535,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
section candidate
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.718 ms) : 1695, 1741
.   : milestone, 1718,
appsec_no_iast (1.722 ms) : 1698, 1745
.   : milestone, 1722,
iast (1.457 ms) : 1434, 1480
.   : milestone, 1457,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.455 ms) : 1431, 1480
.   : milestone, 1455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.724 ms [1.7 ms, 1.748 ms] 379.428 µs (28.2%)
appsec_no_iast 1.702 ms [1.677 ms, 1.726 ms] 356.968 µs (26.5%)
iast 1.482 ms [1.459 ms, 1.505 ms] 136.969 µs (10.2%)
profiling 1.535 ms [1.509 ms, 1.56 ms] 189.916 µs (14.1%)
tracing 1.459 ms [1.434 ms, 1.483 ms] 113.796 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.321 ms, 1.359 ms] -
appsec 1.718 ms [1.695 ms, 1.741 ms] 378.195 µs (28.2%)
appsec_no_iast 1.722 ms [1.698 ms, 1.745 ms] 381.91 µs (28.5%)
iast 1.457 ms [1.434 ms, 1.48 ms] 116.772 µs (8.7%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 145.775 µs (10.9%)
tracing 1.455 ms [1.431 ms, 1.48 ms] 115.639 µs (8.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.056 µs) : 347, 391
.   : milestone, 369,
iast (491.776 µs) : 471, 513
.   : milestone, 492,
iast_FULL (550.518 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (501.144 µs) : 480, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (482.938 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (453.04 µs) : 431, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (476.001 µs) : 454, 498
.   : milestone, 476,
tracing (436.922 µs) : 417, 457
.   : milestone, 437,
section candidate
no_agent (369.758 µs) : 350, 389
.   : milestone, 370,
iast (479.569 µs) : 458, 501
.   : milestone, 480,
iast_FULL (557.391 µs) : 536, 579
.   : milestone, 557,
iast_GLOBAL (503.395 µs) : 483, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (480.632 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (456.116 µs) : 434, 478
.   : milestone, 456,
iast_TELEMETRY_OFF (475.065 µs) : 454, 497
.   : milestone, 475,
tracing (446.419 µs) : 426, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.056 µs [347.409 µs, 390.704 µs] -
iast 491.776 µs [470.643 µs, 512.909 µs] 122.719 µs (33.3%)
iast_FULL 550.518 µs [529.519 µs, 571.518 µs] 181.462 µs (49.2%)
iast_GLOBAL 501.144 µs [480.315 µs, 521.972 µs] 132.087 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 482.938 µs [461.43 µs, 504.446 µs] 113.882 µs (30.9%)
iast_INACTIVE 453.04 µs [431.261 µs, 474.819 µs] 83.984 µs (22.8%)
iast_TELEMETRY_OFF 476.001 µs [454.249 µs, 497.753 µs] 106.945 µs (29.0%)
tracing 436.922 µs [416.831 µs, 457.013 µs] 67.865 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.758 µs [350.374 µs, 389.141 µs] -
iast 479.569 µs [458.359 µs, 500.78 µs] 109.812 µs (29.7%)
iast_FULL 557.391 µs [535.757 µs, 579.026 µs] 187.634 µs (50.7%)
iast_GLOBAL 503.395 µs [482.555 µs, 524.235 µs] 133.638 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 480.632 µs [459.679 µs, 501.586 µs] 110.875 µs (30.0%)
iast_INACTIVE 456.116 µs [434.398 µs, 477.834 µs] 86.358 µs (23.4%)
iast_TELEMETRY_OFF 475.065 µs [453.575 µs, 496.555 µs] 105.307 µs (28.5%)
tracing 446.419 µs [425.573 µs, 467.266 µs] 76.662 µs (20.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/iast-fix-scala-helper
git_commit_date 1718111499 1718112690
git_commit_sha 42276d7 196ec7a
release_version 1.36.0-SNAPSHOT~42276d7c29 1.36.0-SNAPSHOT~196ec7a688
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718115055 1718115055
ci_job_id 539219137 539219137
ci_pipeline_id 36396136 36396136
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.826 s) : 14826000, 14826000
.   : milestone, 14826000,
appsec (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
iast (18.753 s) : 18753000, 18753000
.   : milestone, 18753000,
iast_GLOBAL (17.768 s) : 17768000, 17768000
.   : milestone, 17768000,
profiling (15.444 s) : 15444000, 15444000
.   : milestone, 15444000,
tracing (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
section candidate
no_agent (14.846 s) : 14846000, 14846000
.   : milestone, 14846000,
appsec (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
iast (19.036 s) : 19036000, 19036000
.   : milestone, 19036000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
.   : milestone, 18075000,
profiling (15.705 s) : 15705000, 15705000
.   : milestone, 15705000,
tracing (15.126 s) : 15126000, 15126000
.   : milestone, 15126000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.826 s [14.826 s, 14.826 s] -
appsec 15.005 s [15.005 s, 15.005 s] 179.0 ms (1.2%)
iast 18.753 s [18.753 s, 18.753 s] 3.927 s (26.5%)
iast_GLOBAL 17.768 s [17.768 s, 17.768 s] 2.942 s (19.8%)
profiling 15.444 s [15.444 s, 15.444 s] 618.0 ms (4.2%)
tracing 14.996 s [14.996 s, 14.996 s] 170.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.846 s [14.846 s, 14.846 s] -
appsec 15.094 s [15.094 s, 15.094 s] 248.0 ms (1.7%)
iast 19.036 s [19.036 s, 19.036 s] 4.19 s (28.2%)
iast_GLOBAL 18.075 s [18.075 s, 18.075 s] 3.229 s (21.7%)
profiling 15.705 s [15.705 s, 15.705 s] 859.0 ms (5.8%)
tracing 15.126 s [15.126 s, 15.126 s] 280.0 ms (1.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~196ec7a688, baseline=1.36.0-SNAPSHOT~42276d7c29
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.198 ms) : 2163, 2232
.   : milestone, 2198,
iast (1.963 ms) : 1921, 2004
.   : milestone, 1963,
iast_GLOBAL (2.007 ms) : 1965, 2048
.   : milestone, 2007,
profiling (1.843 ms) : 1810, 1875
.   : milestone, 1843,
tracing (1.825 ms) : 1793, 1857
.   : milestone, 1825,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.196 ms) : 2162, 2230
.   : milestone, 2196,
iast (1.955 ms) : 1914, 1995
.   : milestone, 1955,
iast_GLOBAL (1.996 ms) : 1955, 2036
.   : milestone, 1996,
profiling (1.841 ms) : 1807, 1875
.   : milestone, 1841,
tracing (1.829 ms) : 1797, 1861
.   : milestone, 1829,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.198 ms [2.163 ms, 2.232 ms] 737.049 µs (50.5%)
iast 1.963 ms [1.921 ms, 2.004 ms] 502.038 µs (34.4%)
iast_GLOBAL 2.007 ms [1.965 ms, 2.048 ms] 546.065 µs (37.4%)
profiling 1.843 ms [1.81 ms, 1.875 ms] 382.065 µs (26.2%)
tracing 1.825 ms [1.793 ms, 1.857 ms] 364.234 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.196 ms [2.162 ms, 2.23 ms] 730.211 µs (49.8%)
iast 1.955 ms [1.914 ms, 1.995 ms] 488.96 µs (33.4%)
iast_GLOBAL 1.996 ms [1.955 ms, 2.036 ms] 529.65 µs (36.1%)
profiling 1.841 ms [1.807 ms, 1.875 ms] 375.529 µs (25.6%)
tracing 1.829 ms [1.797 ms, 1.861 ms] 363.287 µs (24.8%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper branch from a58c57b to c2905e5 Compare June 11, 2024 11:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners June 11, 2024 11:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper branch from c2905e5 to fff99c7 Compare June 11, 2024 12:00
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper branch from fff99c7 to 34ab557 Compare June 11, 2024 13:02
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/iast-fix-scala-helper branch from 34ab557 to 196ec7a Compare June 11, 2024 13:31
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 5294fac into master Jun 11, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-fix-scala-helper branch June 11, 2024 14:28
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 11, 2024
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
45988c8 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
@manuel-alvarez-alvarez manuel-alvarez-alvarez mentioned this pull request Jun 12, 2024
Merged
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
277606b 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
mcculls pushed a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez @mcculls
Removed scala converter lambdas and ensure they are added as helpers (#…
d55387a 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
9f1f33f 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
e12639a 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
3a15b4f 
…7146)

Removed scala converter lambdas and ensure they are added as helpers

(cherry picked from commit 5294fac)
manuel-alvarez-alvarez added a commit that referenced this pull request Jun 12, 2024
@manuel-alvarez-alvarez
Removed scala converter lambdas and ensure they are added as helpers (#…
917b7d9 
…7168)

Removed scala converter lambdas and ensure they are added as helpers (#7146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@amarziali amarziali amarziali approved these changes

@ValentinZakharov ValentinZakharov ValentinZakharov approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: asm iast Application Security Management (IAST) type: bug Bug report and fix

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

6 participants

@manuel-alvarez-alvarez @smola @PerfectSlayer @amarziali @ValentinZakharov