Skip to content

Avoid publishing RC to Sonatype and upload the right assets to GitHub release #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PerfectSlayer merged 2 commits into from
Jun 11, 2024
Merged

Avoid publishing RC to Sonatype and upload the right assets to GitHub release #7148

PerfectSlayer merged 2 commits into from
Jun 11, 2024

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Jun 10, 2024 •
edited
Loading

What Does This Do

This PR tries to fix two issues of the GitLab CI:

  • Avoid publishing release candidates to Sonatype,
  • Upload the same artifacts we send to Sonatype as GitHub release assets

Motivation

Our release process is broken. We ship three different binaires for the same version.
If this works, Maven central and GitHub release should be the same. Only lib-injection will be wrong.

Additional Notes

I could not test the pipeline, so it will be test as part of the next release.

Added @randomanderson for review as he might have a better understanding of the whole pipeline and the GitLab workflow syntax.

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 10, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 10, 2024 13:10
@PerfectSlayer PerfectSlayer requested review from am312 and mcculls June 10, 2024 13:10
@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci-gitlab
git_commit_date 1718106998 1718106476
git_commit_sha 3648b65 03c60a9
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~03c60a922a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718109382 1718109382
ci_job_id 539016618 539016618
ci_pipeline_id 36383018 36383018
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 14 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:appsec:Remote Config better
[-68.162µs; -13.959µs] or [-10.336%; -2.117%]		 618.391µs 659.451µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065939
Total [baseline] (10.332 s) : 0, 10331716
Agent [candidate] (1.073 s) : 0, 1073430
Total [candidate] (10.446 s) : 0, 10446393
section appsec
Agent [baseline] (1.178 s) : 0, 1177983
Total [baseline] (10.438 s) : 0, 10438184
Agent [candidate] (1.176 s) : 0, 1176350
Total [candidate] (10.46 s) : 0, 10459603
section iast
Agent [baseline] (1.168 s) : 0, 1167857
Total [baseline] (10.807 s) : 0, 10806871
Agent [candidate] (1.167 s) : 0, 1166502
Total [candidate] (10.654 s) : 0, 10654341
section profiling
Agent [baseline] (1.263 s) : 0, 1263141
Total [baseline] (10.7 s) : 0, 10699741
Agent [candidate] (1.265 s) : 0, 1265103
Total [candidate] (10.618 s) : 0, 10617894
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.178 s 112.044 ms (10.5%)
Agent iast 1.168 s 101.918 ms (9.6%)
Agent profiling 1.263 s 197.202 ms (18.5%)
Total tracing 10.332 s -
Total appsec 10.438 s 106.467 ms (1.0%)
Total iast 10.807 s 475.155 ms (4.6%)
Total profiling 10.7 s 368.024 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent appsec 1.176 s 102.921 ms (9.6%)
Agent iast 1.167 s 93.072 ms (8.7%)
Agent profiling 1.265 s 191.674 ms (17.9%)
Total tracing 10.446 s -
Total appsec 10.46 s 13.21 ms (0.1%)
Total iast 10.654 s 207.948 ms (2.0%)
Total profiling 10.618 s 171.501 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.805 ms) : 0, 667805
BytebuddyAgent [candidate] (673.357 ms) : 0, 673357
GlobalTracer [baseline] (304.855 ms) : 0, 304855
GlobalTracer [candidate] (305.892 ms) : 0, 305892
AppSec [baseline] (50.102 ms) : 0, 50102
AppSec [candidate] (50.558 ms) : 0, 50558
Logs Intake [baseline] (400.942 µs) : 0, 401
Logs Intake [candidate] (382.305 µs) : 0, 382
Remote Config [baseline] (679.85 µs) : 0, 680
Remote Config [candidate] (686.811 µs) : 0, 687
Telemetry [baseline] (7.597 ms) : 0, 7597
Telemetry [candidate] (7.664 ms) : 0, 7664
section appsec
BytebuddyAgent [baseline] (673.994 ms) : 0, 673994
BytebuddyAgent [candidate] (673.318 ms) : 0, 673318
GlobalTracer [baseline] (296.368 ms) : 0, 296368
GlobalTracer [candidate] (296.772 ms) : 0, 296772
AppSec [baseline] (152.472 ms) : 0, 152472
AppSec [candidate] (152.619 ms) : 0, 152619
Logs Intake [baseline] (321.882 µs) : 0, 322
Logs Intake [candidate] (334.29 µs) : 0, 334
Remote Config [baseline] (659.451 µs) : 0, 659
Remote Config [candidate] (618.391 µs) : 0, 618
Telemetry [baseline] (8.44 ms) : 0, 8440
Telemetry [candidate] (8.16 ms) : 0, 8160
IAST [baseline] (22.753 ms) : 0, 22753
IAST [candidate] (20.412 ms) : 0, 20412
section iast
BytebuddyAgent [baseline] (778.55 ms) : 0, 778550
BytebuddyAgent [candidate] (778.082 ms) : 0, 778082
GlobalTracer [baseline] (293.447 ms) : 0, 293447
GlobalTracer [candidate] (292.789 ms) : 0, 292789
AppSec [baseline] (47.034 ms) : 0, 47034
AppSec [candidate] (46.889 ms) : 0, 46889
Logs Intake [baseline] (300.21 µs) : 0, 300
Logs Intake [candidate] (297.582 µs) : 0, 298
Remote Config [baseline] (574.721 µs) : 0, 575
Remote Config [candidate] (577.528 µs) : 0, 578
Telemetry [baseline] (8.425 ms) : 0, 8425
Telemetry [candidate] (7.595 ms) : 0, 7595
IAST [baseline] (26.275 ms) : 0, 26275
IAST [candidate] (27.005 ms) : 0, 27005
section profiling
ProfilingAgent [baseline] (97.141 ms) : 0, 97141
ProfilingAgent [candidate] (95.826 ms) : 0, 95826
BytebuddyAgent [baseline] (661.425 ms) : 0, 661425
BytebuddyAgent [candidate] (666.593 ms) : 0, 666593
GlobalTracer [baseline] (388.218 ms) : 0, 388218
GlobalTracer [candidate] (386.442 ms) : 0, 386442
AppSec [baseline] (51.261 ms) : 0, 51261
AppSec [candidate] (50.796 ms) : 0, 50796
Logs Intake [baseline] (330.04 µs) : 0, 330
Logs Intake [candidate] (326.03 µs) : 0, 326
Remote Config [baseline] (743.806 µs) : 0, 744
Remote Config [candidate] (732.099 µs) : 0, 732
Telemetry [baseline] (7.384 ms) : 0, 7384
Telemetry [candidate] (7.329 ms) : 0, 7329
Profiling [baseline] (97.165 ms) : 0, 97165
Profiling [candidate] (95.85 ms) : 0, 95850
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059229
Total [baseline] (8.558 s) : 0, 8558188
Agent [candidate] (1.06 s) : 0, 1060477
Total [candidate] (8.532 s) : 0, 8532450
section iast
Agent [baseline] (1.165 s) : 0, 1164591
Total [baseline] (9.009 s) : 0, 9009097
Agent [candidate] (1.168 s) : 0, 1167779
Total [candidate] (8.99 s) : 0, 8990298
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.164 s) : 0, 1164237
Total [baseline] (8.953 s) : 0, 8953122
Agent [candidate] (1.166 s) : 0, 1166331
Total [candidate] (8.945 s) : 0, 8945424
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165533
Total [baseline] (9.005 s) : 0, 9004919
Agent [candidate] (1.162 s) : 0, 1162397
Total [candidate] (8.956 s) : 0, 8956298
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.165 s 105.362 ms (9.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.164 s 105.007 ms (9.9%)
Agent iast_TELEMETRY_OFF 1.166 s 106.304 ms (10.0%)
Total tracing 8.558 s -
Total iast 9.009 s 450.91 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.953 s 394.934 ms (4.6%)
Total iast_TELEMETRY_OFF 9.005 s 446.732 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.168 s 107.301 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.166 s 105.854 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.162 s 101.919 ms (9.6%)
Total tracing 8.532 s -
Total iast 8.99 s 457.848 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.945 s 412.974 ms (4.8%)
Total iast_TELEMETRY_OFF 8.956 s 423.847 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.742 ms) : 0, 663742
BytebuddyAgent [candidate] (663.58 ms) : 0, 663580
GlobalTracer [baseline] (302.632 ms) : 0, 302632
GlobalTracer [candidate] (303.65 ms) : 0, 303650
AppSec [baseline] (49.94 ms) : 0, 49940
AppSec [candidate] (50.124 ms) : 0, 50124
Logs Intake [baseline] (403.751 µs) : 0, 404
Logs Intake [candidate] (366.153 µs) : 0, 366
Remote Config [baseline] (664.925 µs) : 0, 665
Remote Config [candidate] (703.138 µs) : 0, 703
Telemetry [baseline] (7.542 ms) : 0, 7542
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast
BytebuddyAgent [baseline] (777.11 ms) : 0, 777110
BytebuddyAgent [candidate] (778.431 ms) : 0, 778431
GlobalTracer [baseline] (292.418 ms) : 0, 292418
GlobalTracer [candidate] (293.631 ms) : 0, 293631
AppSec [baseline] (46.916 ms) : 0, 46916
AppSec [candidate] (46.851 ms) : 0, 46851
Logs Intake [baseline] (301.203 µs) : 0, 301
Logs Intake [candidate] (294.317 µs) : 0, 294
Remote Config [baseline] (582.456 µs) : 0, 582
Remote Config [candidate] (573.093 µs) : 0, 573
Telemetry [baseline] (7.758 ms) : 0, 7758
Telemetry [candidate] (6.908 ms) : 0, 6908
IAST [baseline] (26.264 ms) : 0, 26264
IAST [candidate] (27.791 ms) : 0, 27791
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.455 ms) : 0, 776455
BytebuddyAgent [candidate] (778.089 ms) : 0, 778089
GlobalTracer [baseline] (292.859 ms) : 0, 292859
GlobalTracer [candidate] (293.781 ms) : 0, 293781
AppSec [baseline] (46.205 ms) : 0, 46205
AppSec [candidate] (46.413 ms) : 0, 46413
Logs Intake [baseline] (300.737 µs) : 0, 301
Logs Intake [candidate] (298.159 µs) : 0, 298
Remote Config [baseline] (565.837 µs) : 0, 566
Remote Config [candidate] (572.853 µs) : 0, 573
Telemetry [baseline] (7.572 ms) : 0, 7572
Telemetry [candidate] (7.675 ms) : 0, 7675
IAST [baseline] (26.972 ms) : 0, 26972
IAST [candidate] (26.134 ms) : 0, 26134
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.645 ms) : 0, 776645
BytebuddyAgent [candidate] (774.935 ms) : 0, 774935
GlobalTracer [baseline] (293.777 ms) : 0, 293777
GlobalTracer [candidate] (292.967 ms) : 0, 292967
AppSec [baseline] (48.479 ms) : 0, 48479
AppSec [candidate] (47.836 ms) : 0, 47836
Logs Intake [baseline] (301.183 µs) : 0, 301
Logs Intake [candidate] (296.748 µs) : 0, 297
Remote Config [baseline] (562.497 µs) : 0, 562
Remote Config [candidate] (551.17 µs) : 0, 551
Telemetry [baseline] (8.238 ms) : 0, 8238
Telemetry [candidate] (6.734 ms) : 0, 6734
IAST [baseline] (24.204 ms) : 0, 24204
IAST [candidate] (25.785 ms) : 0, 25785
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-11T12:07:13 2024-06-11T12:14:03
git_branch master bbujon/ci-gitlab
git_commit_date 1718106998 1718106476
git_commit_sha 3648b65 03c60a9
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~03c60a922a
start_time 2024-06-11T12:06:59 2024-06-11T12:13:50
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718108388 1718108388
ci_job_id 539016619 539016619
ci_pipeline_id 36383018 36383018
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.487 µs) : 350, 389
.   : milestone, 369,
iast (488.172 µs) : 467, 509
.   : milestone, 488,
iast_FULL (556.119 µs) : 535, 577
.   : milestone, 556,
iast_GLOBAL (516.395 µs) : 493, 539
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (477.872 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (454.459 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (469.387 µs) : 448, 490
.   : milestone, 469,
tracing (441.063 µs) : 421, 461
.   : milestone, 441,
section candidate
no_agent (376.147 µs) : 355, 397
.   : milestone, 376,
iast (482.7 µs) : 462, 504
.   : milestone, 483,
iast_FULL (556.72 µs) : 536, 578
.   : milestone, 557,
iast_GLOBAL (505.532 µs) : 485, 526
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (481.709 µs) : 461, 503
.   : milestone, 482,
iast_INACTIVE (451.012 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (474.504 µs) : 453, 496
.   : milestone, 475,
tracing (441.686 µs) : 421, 462
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.487 µs [349.777 µs, 389.198 µs] -
iast 488.172 µs [466.976 µs, 509.368 µs] 118.685 µs (32.1%)
iast_FULL 556.119 µs [535.353 µs, 576.886 µs] 186.632 µs (50.5%)
iast_GLOBAL 516.395 µs [493.402 µs, 539.388 µs] 146.907 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 477.872 µs [457.069 µs, 498.674 µs] 108.384 µs (29.3%)
iast_INACTIVE 454.459 µs [433.04 µs, 475.878 µs] 84.971 µs (23.0%)
iast_TELEMETRY_OFF 469.387 µs [448.418 µs, 490.357 µs] 99.9 µs (27.0%)
tracing 441.063 µs [420.666 µs, 461.46 µs] 71.575 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.147 µs [355.438 µs, 396.856 µs] -
iast 482.7 µs [461.594 µs, 503.805 µs] 106.552 µs (28.3%)
iast_FULL 556.72 µs [535.608 µs, 577.833 µs] 180.573 µs (48.0%)
iast_GLOBAL 505.532 µs [484.599 µs, 526.465 µs] 129.385 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 481.709 µs [460.878 µs, 502.539 µs] 105.561 µs (28.1%)
iast_INACTIVE 451.012 µs [430.261 µs, 471.764 µs] 74.865 µs (19.9%)
iast_TELEMETRY_OFF 474.504 µs [453.414 µs, 495.593 µs] 98.356 µs (26.1%)
tracing 441.686 µs [420.908 µs, 462.465 µs] 65.539 µs (17.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.731 ms) : 1707, 1755
.   : milestone, 1731,
appsec_no_iast (1.729 ms) : 1705, 1752
.   : milestone, 1729,
iast (1.494 ms) : 1470, 1517
.   : milestone, 1494,
profiling (1.521 ms) : 1498, 1544
.   : milestone, 1521,
tracing (1.472 ms) : 1448, 1497
.   : milestone, 1472,
section candidate
no_agent (1.358 ms) : 1338, 1379
.   : milestone, 1358,
appsec (1.714 ms) : 1690, 1738
.   : milestone, 1714,
appsec_no_iast (1.72 ms) : 1695, 1744
.   : milestone, 1720,
iast (1.478 ms) : 1455, 1501
.   : milestone, 1478,
profiling (1.474 ms) : 1450, 1499
.   : milestone, 1474,
tracing (1.461 ms) : 1436, 1486
.   : milestone, 1461,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.731 ms [1.707 ms, 1.755 ms] 386.096 µs (28.7%)
appsec_no_iast 1.729 ms [1.705 ms, 1.752 ms] 383.774 µs (28.5%)
iast 1.494 ms [1.47 ms, 1.517 ms] 148.919 µs (11.1%)
profiling 1.521 ms [1.498 ms, 1.544 ms] 176.126 µs (13.1%)
tracing 1.472 ms [1.448 ms, 1.497 ms] 127.306 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.358 ms [1.338 ms, 1.379 ms] -
appsec 1.714 ms [1.69 ms, 1.738 ms] 355.334 µs (26.2%)
appsec_no_iast 1.72 ms [1.695 ms, 1.744 ms] 361.223 µs (26.6%)
iast 1.478 ms [1.455 ms, 1.501 ms] 119.534 µs (8.8%)
profiling 1.474 ms [1.45 ms, 1.499 ms] 115.877 µs (8.5%)
tracing 1.461 ms [1.436 ms, 1.486 ms] 102.853 µs (7.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/ci-gitlab
git_commit_date 1718106998 1718106476
git_commit_sha 3648b65 03c60a9
release_version 1.36.0-SNAPSHOT~3648b658ef 1.36.0-SNAPSHOT~03c60a922a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718108896 1718108896
ci_job_id 539016620 539016620
ci_pipeline_id 36383018 36383018
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1474
.   : milestone, 1463,
appsec (2.216 ms) : 2182, 2250
.   : milestone, 2216,
iast (1.957 ms) : 1917, 1998
.   : milestone, 1957,
iast_GLOBAL (2.008 ms) : 1967, 2049
.   : milestone, 2008,
profiling (1.863 ms) : 1828, 1898
.   : milestone, 1863,
tracing (1.831 ms) : 1799, 1862
.   : milestone, 1831,
section candidate
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.212 ms) : 2178, 2246
.   : milestone, 2212,
iast (1.969 ms) : 1928, 2010
.   : milestone, 1969,
iast_GLOBAL (2.009 ms) : 1968, 2051
.   : milestone, 2009,
profiling (1.86 ms) : 1826, 1893
.   : milestone, 1860,
tracing (1.835 ms) : 1803, 1867
.   : milestone, 1835,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.474 ms] -
appsec 2.216 ms [2.182 ms, 2.25 ms] 753.091 µs (51.5%)
iast 1.957 ms [1.917 ms, 1.998 ms] 494.206 µs (33.8%)
iast_GLOBAL 2.008 ms [1.967 ms, 2.049 ms] 545.037 µs (37.3%)
profiling 1.863 ms [1.828 ms, 1.898 ms] 400.297 µs (27.4%)
tracing 1.831 ms [1.799 ms, 1.862 ms] 367.539 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.212 ms [2.178 ms, 2.246 ms] 747.184 µs (51.0%)
iast 1.969 ms [1.928 ms, 2.01 ms] 504.39 µs (34.4%)
iast_GLOBAL 2.009 ms [1.968 ms, 2.051 ms] 544.574 µs (37.2%)
profiling 1.86 ms [1.826 ms, 1.893 ms] 395.006 µs (27.0%)
tracing 1.835 ms [1.803 ms, 1.867 ms] 370.404 µs (25.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~03c60a922a, baseline=1.36.0-SNAPSHOT~3648b658ef
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
appsec (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,
iast (18.731 s) : 18731000, 18731000
.   : milestone, 18731000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
.   : milestone, 17999000,
profiling (15.5 s) : 15500000, 15500000
.   : milestone, 15500000,
tracing (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
section candidate
no_agent (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
appsec (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
iast (18.525 s) : 18525000, 18525000
.   : milestone, 18525000,
iast_GLOBAL (17.887 s) : 17887000, 17887000
.   : milestone, 17887000,
profiling (15.065 s) : 15065000, 15065000
.   : milestone, 15065000,
tracing (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.036 s [15.036 s, 15.036 s] -
appsec 14.907 s [14.907 s, 14.907 s] -129.0 ms (-0.9%)
iast 18.731 s [18.731 s, 18.731 s] 3.695 s (24.6%)
iast_GLOBAL 17.999 s [17.999 s, 17.999 s] 2.963 s (19.7%)
profiling 15.5 s [15.5 s, 15.5 s] 464.0 ms (3.1%)
tracing 15.136 s [15.136 s, 15.136 s] 100.0 ms (0.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.077 s [15.077 s, 15.077 s] -
appsec 15.149 s [15.149 s, 15.149 s] 72.0 ms (0.5%)
iast 18.525 s [18.525 s, 18.525 s] 3.448 s (22.9%)
iast_GLOBAL 17.887 s [17.887 s, 17.887 s] 2.81 s (18.6%)
profiling 15.065 s [15.065 s, 15.065 s] -12.0 ms (-0.1%)
tracing 15.06 s [15.06 s, 15.06 s] -17.0 ms (-0.1%)

@PerfectSlayer
Copy link
Contributor Author

PerfectSlayer commented Jun 11, 2024

Thanks for the review Laplie 👍

@PerfectSlayer PerfectSlayer merged commit 617453e into master Jun 11, 2024
@PerfectSlayer PerfectSlayer deleted the bbujon/ci-gitlab branch June 11, 2024 12:57
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 11, 2024
@PerfectSlayer PerfectSlayer restored the bbujon/ci-gitlab branch June 12, 2024 10:18
@PerfectSlayer PerfectSlayer deleted the bbujon/ci-gitlab branch June 12, 2024 10:19
@PerfectSlayer PerfectSlayer mentioned this pull request Jun 12, 2024
Merged
@randomanderson randomanderson mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randomanderson randomanderson randomanderson approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls was automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312 am312 was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@PerfectSlayer @randomanderson