Rework the listeners for AMS_FEATURES #7158

manuel-alvarez-alvarez · 2024-06-11T08:58:27Z

What Does This Do

Move remote configuration config code away from ApiSecurityRequestSampler and ensure we are dealing with the removal of configuration files correctly.

Motivation

Additional Notes

pr-commenter · 2024-06-11T09:43:02Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/rc-remove-keys-from-listener
git_commit_date	1718370692	1718370339
git_commit_sha	`33a2dcd`	`a23b0a8`
release_version	1.36.0-SNAPSHOT~33a2dcd37c	1.36.0-SNAPSHOT~a23b0a8e7e

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718373225	1718373225
ci_job_id	543689302	543689302
ci_pipeline_id	36775293	36775293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063901
Total [baseline] (8.553 s) : 0, 8553405
Agent [candidate] (1.064 s) : 0, 1064120
Total [candidate] (8.554 s) : 0, 8553576
section iast
Agent [baseline] (1.172 s) : 0, 1172145
Total [baseline] (9.003 s) : 0, 9002633
Agent [candidate] (1.171 s) : 0, 1171176
Total [candidate] (9.039 s) : 0, 9039124
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179952
Total [baseline] (9.022 s) : 0, 9022071
Agent [candidate] (1.172 s) : 0, 1171799
Total [candidate] (8.994 s) : 0, 8994316
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165794
Total [baseline] (8.99 s) : 0, 8990162
Agent [candidate] (1.176 s) : 0, 1176296
Total [candidate] (9.014 s) : 0, 9014438

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	iast	1.172 s	108.245 ms (10.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	116.052 ms (10.9%)
Agent	iast_TELEMETRY_OFF	1.166 s	101.893 ms (9.6%)
Total	tracing	8.553 s	-
Total	iast	9.003 s	449.228 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.022 s	468.666 ms (5.5%)
Total	iast_TELEMETRY_OFF	8.99 s	436.757 ms (5.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	iast	1.171 s	107.055 ms (10.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	107.679 ms (10.1%)
Agent	iast_TELEMETRY_OFF	1.176 s	112.175 ms (10.5%)
Total	tracing	8.554 s	-
Total	iast	9.039 s	485.547 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	8.994 s	440.74 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.014 s	460.861 ms (5.4%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.313 ms) : 0, 666313
BytebuddyAgent [candidate] (666.659 ms) : 0, 666659
GlobalTracer [baseline] (304.11 ms) : 0, 304110
GlobalTracer [candidate] (304.336 ms) : 0, 304336
AppSec [baseline] (50.438 ms) : 0, 50438
AppSec [candidate] (50.098 ms) : 0, 50098
Logs Intake [baseline] (335.816 µs) : 0, 336
Logs Intake [candidate] (332.615 µs) : 0, 333
Remote Config [baseline] (676.187 µs) : 0, 676
Remote Config [candidate] (674.116 µs) : 0, 674
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.533 ms) : 0, 7533
section iast
BytebuddyAgent [baseline] (781.252 ms) : 0, 781252
BytebuddyAgent [candidate] (780.835 ms) : 0, 780835
GlobalTracer [baseline] (293.336 ms) : 0, 293336
GlobalTracer [candidate] (293.741 ms) : 0, 293741
AppSec [baseline] (47.376 ms) : 0, 47376
AppSec [candidate] (47.085 ms) : 0, 47085
Logs Intake [baseline] (307.924 µs) : 0, 308
Logs Intake [candidate] (1.071 ms) : 0, 1071
Remote Config [baseline] (621.388 µs) : 0, 621
Remote Config [candidate] (1.41 ms) : 0, 1410
Telemetry [baseline] (6.908 ms) : 0, 6908
Telemetry [candidate] (6.987 ms) : 0, 6987
IAST [baseline] (29.006 ms) : 0, 29006
IAST [candidate] (26.734 ms) : 0, 26734
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (787.171 ms) : 0, 787171
BytebuddyAgent [candidate] (781.56 ms) : 0, 781560
GlobalTracer [baseline] (295.866 ms) : 0, 295866
GlobalTracer [candidate] (294.523 ms) : 0, 294523
AppSec [baseline] (47.904 ms) : 0, 47904
AppSec [candidate] (47.597 ms) : 0, 47597
Logs Intake [baseline] (306.772 µs) : 0, 307
Logs Intake [candidate] (304.524 µs) : 0, 305
Remote Config [baseline] (1.359 ms) : 0, 1359
Remote Config [candidate] (585.43 µs) : 0, 585
Telemetry [baseline] (7.121 ms) : 0, 7121
Telemetry [candidate] (7.76 ms) : 0, 7760
IAST [baseline] (26.755 ms) : 0, 26755
IAST [candidate] (26.074 ms) : 0, 26074
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.128 ms) : 0, 778128
BytebuddyAgent [candidate] (784.35 ms) : 0, 784350
GlobalTracer [baseline] (292.77 ms) : 0, 292770
GlobalTracer [candidate] (295.864 ms) : 0, 295864
AppSec [baseline] (47.303 ms) : 0, 47303
AppSec [candidate] (47.721 ms) : 0, 47721
Logs Intake [baseline] (303.038 µs) : 0, 303
Logs Intake [candidate] (307.601 µs) : 0, 308
Remote Config [baseline] (613.149 µs) : 0, 613
Remote Config [candidate] (597.523 µs) : 0, 598
Telemetry [baseline] (7.778 ms) : 0, 7778
Telemetry [candidate] (6.97 ms) : 0, 6970
IAST [baseline] (25.498 ms) : 0, 25498
IAST [candidate] (27.057 ms) : 0, 27057

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063769
Total [baseline] (10.418 s) : 0, 10418240
Agent [candidate] (1.067 s) : 0, 1066608
Total [candidate] (10.387 s) : 0, 10386578
section appsec
Agent [baseline] (1.182 s) : 0, 1181868
Total [baseline] (10.497 s) : 0, 10497059
Agent [candidate] (1.185 s) : 0, 1184574
Total [candidate] (10.562 s) : 0, 10561915
section iast
Agent [baseline] (1.184 s) : 0, 1183824
Total [baseline] (10.733 s) : 0, 10733207
Agent [candidate] (1.174 s) : 0, 1174116
Total [candidate] (10.714 s) : 0, 10713560
section profiling
Agent [baseline] (1.275 s) : 0, 1274809
Total [baseline] (10.674 s) : 0, 10673586
Agent [candidate] (1.262 s) : 0, 1262068
Total [candidate] (10.628 s) : 0, 10627885

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.182 s	118.099 ms (11.1%)
Agent	iast	1.184 s	120.055 ms (11.3%)
Agent	profiling	1.275 s	211.04 ms (19.8%)
Total	tracing	10.418 s	-
Total	appsec	10.497 s	78.819 ms (0.8%)
Total	iast	10.733 s	314.967 ms (3.0%)
Total	profiling	10.674 s	255.346 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.067 s	-
Agent	appsec	1.185 s	117.965 ms (11.1%)
Agent	iast	1.174 s	107.508 ms (10.1%)
Agent	profiling	1.262 s	195.459 ms (18.3%)
Total	tracing	10.387 s	-
Total	appsec	10.562 s	175.337 ms (1.7%)
Total	iast	10.714 s	326.982 ms (3.1%)
Total	profiling	10.628 s	241.308 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.28 ms) : 0, 666280
BytebuddyAgent [candidate] (668.06 ms) : 0, 668060
GlobalTracer [baseline] (304.111 ms) : 0, 304111
GlobalTracer [candidate] (304.889 ms) : 0, 304889
AppSec [baseline] (50.424 ms) : 0, 50424
AppSec [candidate] (50.507 ms) : 0, 50507
Logs Intake [baseline] (334.775 µs) : 0, 335
Logs Intake [candidate] (333.295 µs) : 0, 333
Remote Config [baseline] (673.165 µs) : 0, 673
Remote Config [candidate] (672.571 µs) : 0, 673
Telemetry [baseline] (7.604 ms) : 0, 7604
Telemetry [candidate] (7.681 ms) : 0, 7681
section appsec
BytebuddyAgent [baseline] (676.133 ms) : 0, 676133
BytebuddyAgent [candidate] (676.91 ms) : 0, 676910
GlobalTracer [baseline] (297.38 ms) : 0, 297380
GlobalTracer [candidate] (297.73 ms) : 0, 297730
AppSec [baseline] (154.187 ms) : 0, 154187
AppSec [candidate] (154.221 ms) : 0, 154221
Logs Intake [baseline] (325.191 µs) : 0, 325
Logs Intake [candidate] (337.176 µs) : 0, 337
Remote Config [baseline] (620.258 µs) : 0, 620
Remote Config [candidate] (625.3 µs) : 0, 625
Telemetry [baseline] (9.222 ms) : 0, 9222
Telemetry [candidate] (9.503 ms) : 0, 9503
IAST [baseline] (19.361 ms) : 0, 19361
IAST [candidate] (21.641 ms) : 0, 21641
section iast
BytebuddyAgent [baseline] (788.432 ms) : 0, 788432
BytebuddyAgent [candidate] (782.496 ms) : 0, 782496
GlobalTracer [baseline] (296.503 ms) : 0, 296503
GlobalTracer [candidate] (294.952 ms) : 0, 294952
AppSec [baseline] (48.023 ms) : 0, 48023
AppSec [candidate] (47.385 ms) : 0, 47385
Logs Intake [baseline] (3.231 ms) : 0, 3231
Logs Intake [candidate] (316.862 µs) : 0, 317
Remote Config [baseline] (825.832 µs) : 0, 826
Remote Config [candidate] (2.132 ms) : 0, 2132
Telemetry [baseline] (7.858 ms) : 0, 7858
Telemetry [candidate] (6.973 ms) : 0, 6973
IAST [baseline] (25.534 ms) : 0, 25534
IAST [candidate] (26.544 ms) : 0, 26544
section profiling
BytebuddyAgent [baseline] (669.98 ms) : 0, 669980
BytebuddyAgent [candidate] (662.583 ms) : 0, 662583
GlobalTracer [baseline] (389.614 ms) : 0, 389614
GlobalTracer [candidate] (386.221 ms) : 0, 386221
AppSec [baseline] (51.913 ms) : 0, 51913
AppSec [candidate] (51.313 ms) : 0, 51313
Logs Intake [baseline] (345.198 µs) : 0, 345
Logs Intake [candidate] (335.463 µs) : 0, 335
Remote Config [baseline] (705.494 µs) : 0, 705
Remote Config [candidate] (716.96 µs) : 0, 717
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.365 ms) : 0, 7365
ProfilingAgent [baseline] (97.241 ms) : 0, 97241
ProfilingAgent [candidate] (96.592 ms) : 0, 96592
Profiling [baseline] (97.267 ms) : 0, 97267
Profiling [candidate] (96.617 ms) : 0, 96617

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-14T13:24:28	2024-06-14T13:31:18
git_branch	master	malvarez/rc-remove-keys-from-listener
git_commit_date	1718370692	1718370339
git_commit_sha	`33a2dcd`	`a23b0a8`
release_version	1.36.0-SNAPSHOT~33a2dcd37c	1.36.0-SNAPSHOT~a23b0a8e7e
start_time	2024-06-14T13:24:15	2024-06-14T13:31:05

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718372222	1718372222
ci_job_id	543689303	543689303
ci_pipeline_id	36775293	36775293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1336, 1374
.   : milestone, 1355,
appsec (1.721 ms) : 1697, 1746
.   : milestone, 1721,
appsec_no_iast (1.712 ms) : 1686, 1737
.   : milestone, 1712,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.518 ms) : 1493, 1544
.   : milestone, 1518,
tracing (1.448 ms) : 1424, 1473
.   : milestone, 1448,
section candidate
no_agent (1.34 ms) : 1321, 1359
.   : milestone, 1340,
appsec (1.728 ms) : 1705, 1751
.   : milestone, 1728,
appsec_no_iast (1.703 ms) : 1677, 1728
.   : milestone, 1703,
iast (1.476 ms) : 1453, 1498
.   : milestone, 1476,
profiling (1.475 ms) : 1450, 1499
.   : milestone, 1475,
tracing (1.452 ms) : 1427, 1476
.   : milestone, 1452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.374 ms]	-
appsec	1.721 ms [1.697 ms, 1.746 ms]	366.523 µs (27.1%)
appsec_no_iast	1.712 ms [1.686 ms, 1.737 ms]	356.733 µs (26.3%)
iast	1.475 ms [1.453 ms, 1.498 ms]	120.399 µs (8.9%)
profiling	1.518 ms [1.493 ms, 1.544 ms]	163.453 µs (12.1%)
tracing	1.448 ms [1.424 ms, 1.473 ms]	93.505 µs (6.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.34 ms [1.321 ms, 1.359 ms]	-
appsec	1.728 ms [1.705 ms, 1.751 ms]	387.495 µs (28.9%)
appsec_no_iast	1.703 ms [1.677 ms, 1.728 ms]	362.521 µs (27.1%)
iast	1.476 ms [1.453 ms, 1.498 ms]	135.539 µs (10.1%)
profiling	1.475 ms [1.45 ms, 1.499 ms]	134.493 µs (10.0%)
tracing	1.452 ms [1.427 ms, 1.476 ms]	111.657 µs (8.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.42 µs) : 348, 387
.   : milestone, 367,
iast (478.605 µs) : 458, 499
.   : milestone, 479,
iast_FULL (552.189 µs) : 531, 574
.   : milestone, 552,
iast_GLOBAL (500.537 µs) : 479, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (486.273 µs) : 465, 508
.   : milestone, 486,
iast_INACTIVE (453.139 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (473.892 µs) : 452, 496
.   : milestone, 474,
tracing (441.246 µs) : 421, 462
.   : milestone, 441,
section candidate
no_agent (371.968 µs) : 352, 391
.   : milestone, 372,
iast (474.983 µs) : 454, 496
.   : milestone, 475,
iast_FULL (552.113 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (507.048 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.488 µs) : 462, 503
.   : milestone, 482,
iast_INACTIVE (454.324 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (472.777 µs) : 451, 495
.   : milestone, 473,
tracing (447.791 µs) : 427, 469
.   : milestone, 448,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.42 µs [347.605 µs, 387.234 µs]	-
iast	478.605 µs [457.801 µs, 499.408 µs]	111.185 µs (30.3%)
iast_FULL	552.189 µs [530.865 µs, 573.512 µs]	184.769 µs (50.3%)
iast_GLOBAL	500.537 µs [479.382 µs, 521.692 µs]	133.117 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED	486.273 µs [464.889 µs, 507.656 µs]	118.853 µs (32.3%)
iast_INACTIVE	453.139 µs [432.115 µs, 474.164 µs]	85.72 µs (23.3%)
iast_TELEMETRY_OFF	473.892 µs [451.965 µs, 495.818 µs]	106.472 µs (29.0%)
tracing	441.246 µs [420.806 µs, 461.686 µs]	73.826 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.968 µs [352.475 µs, 391.461 µs]	-
iast	474.983 µs [453.794 µs, 496.172 µs]	103.015 µs (27.7%)
iast_FULL	552.113 µs [530.769 µs, 573.457 µs]	180.145 µs (48.4%)
iast_GLOBAL	507.048 µs [485.924 µs, 528.172 µs]	135.08 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED	482.488 µs [461.667 µs, 503.31 µs]	110.52 µs (29.7%)
iast_INACTIVE	454.324 µs [432.82 µs, 475.828 µs]	82.356 µs (22.1%)
iast_TELEMETRY_OFF	472.777 µs [450.931 µs, 494.623 µs]	100.809 µs (27.1%)
tracing	447.791 µs [426.933 µs, 468.65 µs]	75.824 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/rc-remove-keys-from-listener
git_commit_date	1718370692	1718370339
git_commit_sha	`33a2dcd`	`a23b0a8`
release_version	1.36.0-SNAPSHOT~33a2dcd37c	1.36.0-SNAPSHOT~a23b0a8e7e

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1718372742	1718372742
ci_job_id	543689304	543689304
ci_pipeline_id	36775293	36775293
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.215 ms) : 2181, 2249
.   : milestone, 2215,
iast (1.979 ms) : 1938, 2021
.   : milestone, 1979,
iast_GLOBAL (2.029 ms) : 1987, 2071
.   : milestone, 2029,
profiling (1.885 ms) : 1850, 1920
.   : milestone, 1885,
tracing (1.851 ms) : 1819, 1883
.   : milestone, 1851,
section candidate
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.227 ms) : 2193, 2261
.   : milestone, 2227,
iast (1.972 ms) : 1931, 2014
.   : milestone, 1972,
iast_GLOBAL (2.015 ms) : 1973, 2056
.   : milestone, 2015,
profiling (1.871 ms) : 1836, 1905
.   : milestone, 1871,
tracing (1.847 ms) : 1815, 1879
.   : milestone, 1847,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.215 ms [2.181 ms, 2.249 ms]	738.375 µs (50.0%)
iast	1.979 ms [1.938 ms, 2.021 ms]	503.136 µs (34.1%)
iast_GLOBAL	2.029 ms [1.987 ms, 2.071 ms]	552.434 µs (37.4%)
profiling	1.885 ms [1.85 ms, 1.92 ms]	408.862 µs (27.7%)
tracing	1.851 ms [1.819 ms, 1.883 ms]	374.844 µs (25.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	2.227 ms [2.193 ms, 2.261 ms]	751.418 µs (50.9%)
iast	1.972 ms [1.931 ms, 2.014 ms]	496.728 µs (33.7%)
iast_GLOBAL	2.015 ms [1.973 ms, 2.056 ms]	539.181 µs (36.5%)
profiling	1.871 ms [1.836 ms, 1.905 ms]	395.352 µs (26.8%)
tracing	1.847 ms [1.815 ms, 1.879 ms]	371.562 µs (25.2%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~a23b0a8e7e, baseline=1.36.0-SNAPSHOT~33a2dcd37c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.549 s) : 15549000, 15549000
.   : milestone, 15549000,
appsec (14.913 s) : 14913000, 14913000
.   : milestone, 14913000,
iast (18.928 s) : 18928000, 18928000
.   : milestone, 18928000,
iast_GLOBAL (17.776 s) : 17776000, 17776000
.   : milestone, 17776000,
profiling (15.43 s) : 15430000, 15430000
.   : milestone, 15430000,
tracing (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
section candidate
no_agent (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
appsec (15.091 s) : 15091000, 15091000
.   : milestone, 15091000,
iast (19.009 s) : 19009000, 19009000
.   : milestone, 19009000,
iast_GLOBAL (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
profiling (15.756 s) : 15756000, 15756000
.   : milestone, 15756000,
tracing (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.549 s [15.549 s, 15.549 s]	-
appsec	14.913 s [14.913 s, 14.913 s]	-636.0 ms (-4.1%)
iast	18.928 s [18.928 s, 18.928 s]	3.379 s (21.7%)
iast_GLOBAL	17.776 s [17.776 s, 17.776 s]	2.227 s (14.3%)
profiling	15.43 s [15.43 s, 15.43 s]	-119.0 ms (-0.8%)
tracing	14.849 s [14.849 s, 14.849 s]	-700.0 ms (-4.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.039 s [15.039 s, 15.039 s]	-
appsec	15.091 s [15.091 s, 15.091 s]	52.0 ms (0.3%)
iast	19.009 s [19.009 s, 19.009 s]	3.97 s (26.4%)
iast_GLOBAL	17.947 s [17.947 s, 17.947 s]	2.908 s (19.3%)
profiling	15.756 s [15.756 s, 15.756 s]	717.0 ms (4.8%)
tracing	15.159 s [15.159 s, 15.159 s]	120.0 ms (0.8%)

manuel-alvarez-alvarez changed the title ~~Do not rely on config keys for ASM features~~ Do not rely on config files for ASM features Jun 11, 2024

smola added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm waf Application Security Management (WAF) labels Jun 11, 2024

manuel-alvarez-alvarez force-pushed the malvarez/rc-remove-keys-from-listener branch from fc777a1 to 7808bc0 Compare June 11, 2024 16:15

manuel-alvarez-alvarez marked this pull request as ready for review June 11, 2024 16:32

manuel-alvarez-alvarez requested review from a team as code owners June 11, 2024 16:32

manuel-alvarez-alvarez requested review from ValentinZakharov, mcculls, nayeem-kamal and smola June 11, 2024 16:32

jandro996 approved these changes Jun 12, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/rc-remove-keys-from-listener branch from f117d08 to 5b2fe0d Compare June 13, 2024 10:44

manuel-alvarez-alvarez changed the title ~~Do not rely on config files for ASM features~~ Rework the listeners for AMS_FEATURES Jun 13, 2024

manuel-alvarez-alvarez force-pushed the malvarez/rc-remove-keys-from-listener branch 4 times, most recently from 49f9e5e to db762ac Compare June 14, 2024 10:04

ValentinZakharov approved these changes Jun 14, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/rc-remove-keys-from-listener branch 3 times, most recently from 195718c to a23b0a8 Compare June 14, 2024 13:05

manuel-alvarez-alvarez added 2 commits June 17, 2024 09:30

Rework the listeners for ASM_FEATURES

dc94ede

Remove code coverage checks for AppSecFeatures pojos

7be63f5

manuel-alvarez-alvarez force-pushed the malvarez/rc-remove-keys-from-listener branch from a23b0a8 to 7be63f5 Compare June 17, 2024 07:30

manuel-alvarez-alvarez merged commit 8f7a318 into master Jun 17, 2024

manuel-alvarez-alvarez deleted the malvarez/rc-remove-keys-from-listener branch June 17, 2024 08:03

github-actions bot added this to the 1.35.1 milestone Jun 17, 2024

mcculls modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rework the listeners for AMS_FEATURES #7158

Rework the listeners for AMS_FEATURES #7158

Uh oh!

manuel-alvarez-alvarez commented Jun 11, 2024 •

edited

Loading

Uh oh!

pr-commenter bot commented Jun 11, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Rework the listeners for AMS_FEATURES #7158

Rework the listeners for AMS_FEATURES #7158

Uh oh!

Conversation

manuel-alvarez-alvarez commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

pr-commenter bot commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

manuel-alvarez-alvarez commented Jun 11, 2024 •

edited

Loading

pr-commenter bot commented Jun 11, 2024 •

edited

Loading