Skip to content

Avoid publishing RC to Sonatype and upload the right assets to GitHub release #7179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PerfectSlayer merged 2 commits into from
Jun 12, 2024
Merged

Avoid publishing RC to Sonatype and upload the right assets to GitHub release #7179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418d5a4
fix(ci): Do not publish RC to sonatype
PerfectSlayer Jun 10, 2024
9b8d30b
fix(ci): Upload the Sonatype artifacts as GitHub assets
PerfectSlayer Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ deploy_to_sonatype:
rules:
- if: '$CI_COMMIT_BRANCH == "master"'
when: on_success
- if: '$CI_COMMIT_TAG =~ /^v.*/'
# Do not deploy release candidate versions
- if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+$/'
when: on_success
- when: manual
allow_failure: true
Expand All @@ -205,6 +206,12 @@ deploy_artifacts_to_github:
when: on_success
- when: manual
allow_failure: true
# Requires the deploy_to_sonatype job to have run first as build cache is broken
# This will deploy the artifacts built from the publishToSonatype task to the GitHub release
needs:
- job: deploy_to_sonatype
# The deploy_to_sonatype job is not run for release candidate versions
optional: true
script:
- aws ssm get-parameter --region us-east-1 --name ci.dd-trace-java.gh_release_token --with-decryption --query "Parameter.Value" --out text > github-token.txt
- gh auth login --with-token < github-token.txt
Expand All @@ -221,7 +228,7 @@ generate-lib-init-tag-values:
rules:
- if: '$POPULATE_CACHE'
when: never
# We don't tag prerelease versions
# Do not tag release candidate versions
- if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+$/'
when: on_success
- when: manual
Expand Down