Skip to content

Do not include system-properties in test session command tag #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikita-tkachenko-datadog merged 1 commit into from
Jun 14, 2024
Merged

Do not include system-properties in test session command tag #7187

nikita-tkachenko-datadog merged 1 commit into from
Jun 14, 2024

Conversation

@nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 13, 2024 •
edited by atlassian bot
Loading

What Does This Do

Updates logic that puts together test session commands for Maven and Gradle builds: system properties are no longer a part of the command.

Motivation

System properties have no effect on the subset of executed tests (this is usually controlled with specifying tasks and/or profiles).
The downside of including them in session commands is that test session fingerprint may become unstable (if a property value changes from run to run, e.g. contains a path that has branch name in it).
They might also contain sensitive info that we don't want to send to Datadog.

Jira ticket: SDTEST-454

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Jun 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/do-not-include-system-props-in-test-session-command
git_commit_date 1718202127 1718292175
git_commit_sha 8085070 64b2c95
release_version 1.36.0-SNAPSHOT~80850709c7 1.36.0-SNAPSHOT~64b2c954f9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718295237 1718295237
ci_job_id 542573579 542573579
ci_pipeline_id 36677587 36677587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062501
Total [baseline] (8.594 s) : 0, 8594311
Agent [candidate] (1.062 s) : 0, 1062379
Total [candidate] (8.543 s) : 0, 8542996
section iast
Agent [baseline] (1.175 s) : 0, 1174740
Total [baseline] (8.998 s) : 0, 8998138
Agent [candidate] (1.168 s) : 0, 1168318
Total [candidate] (8.994 s) : 0, 8994098
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176815
Total [baseline] (8.972 s) : 0, 8971679
Agent [candidate] (1.168 s) : 0, 1168363
Total [candidate] (8.96 s) : 0, 8960430
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1172903
Total [baseline] (9.026 s) : 0, 9025529
Agent [candidate] (1.166 s) : 0, 1166238
Total [candidate] (8.975 s) : 0, 8974849
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.175 s 112.24 ms (10.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 114.314 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.173 s 110.402 ms (10.4%)
Total tracing 8.594 s -
Total iast 8.998 s 403.827 ms (4.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.972 s 377.368 ms (4.4%)
Total iast_TELEMETRY_OFF 9.026 s 431.218 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.168 s 105.939 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 105.984 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.166 s 103.86 ms (9.8%)
Total tracing 8.543 s -
Total iast 8.994 s 451.102 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 417.433 ms (4.9%)
Total iast_TELEMETRY_OFF 8.975 s 431.853 ms (5.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.298 ms) : 0, 665298
BytebuddyAgent [candidate] (665.197 ms) : 0, 665197
GlobalTracer [baseline] (304.055 ms) : 0, 304055
GlobalTracer [candidate] (303.933 ms) : 0, 303933
AppSec [baseline] (50.146 ms) : 0, 50146
AppSec [candidate] (50.126 ms) : 0, 50126
Logs Intake [baseline] (413.7 µs) : 0, 414
Logs Intake [candidate] (417.154 µs) : 0, 417
Remote Config [baseline] (670.433 µs) : 0, 670
Remote Config [candidate] (677.399 µs) : 0, 677
Telemetry [baseline] (7.502 ms) : 0, 7502
Telemetry [candidate] (7.553 ms) : 0, 7553
section iast
BytebuddyAgent [baseline] (784.287 ms) : 0, 784287
BytebuddyAgent [candidate] (779.113 ms) : 0, 779113
GlobalTracer [baseline] (294.985 ms) : 0, 294985
GlobalTracer [candidate] (293.443 ms) : 0, 293443
AppSec [baseline] (46.974 ms) : 0, 46974
AppSec [candidate] (46.921 ms) : 0, 46921
Logs Intake [baseline] (303.139 µs) : 0, 303
Logs Intake [candidate] (303.208 µs) : 0, 303
Remote Config [baseline] (580.466 µs) : 0, 580
Remote Config [candidate] (568.277 µs) : 0, 568
Telemetry [baseline] (6.966 ms) : 0, 6966
Telemetry [candidate] (8.457 ms) : 0, 8457
IAST [baseline] (27.272 ms) : 0, 27272
IAST [candidate] (26.196 ms) : 0, 26196
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.578 ms) : 0, 784578
BytebuddyAgent [candidate] (778.61 ms) : 0, 778610
GlobalTracer [baseline] (295.712 ms) : 0, 295712
GlobalTracer [candidate] (294.526 ms) : 0, 294526
AppSec [baseline] (46.894 ms) : 0, 46894
AppSec [candidate] (46.341 ms) : 0, 46341
Logs Intake [baseline] (300.241 µs) : 0, 300
Logs Intake [candidate] (308.042 µs) : 0, 308
Remote Config [baseline] (574.183 µs) : 0, 574
Remote Config [candidate] (570.877 µs) : 0, 571
Telemetry [baseline] (8.373 ms) : 0, 8373
Telemetry [candidate] (7.674 ms) : 0, 7674
IAST [baseline] (26.979 ms) : 0, 26979
IAST [candidate] (26.998 ms) : 0, 26998
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.215 ms) : 0, 781215
BytebuddyAgent [candidate] (777.176 ms) : 0, 777176
GlobalTracer [baseline] (295.308 ms) : 0, 295308
GlobalTracer [candidate] (293.892 ms) : 0, 293892
AppSec [baseline] (48.27 ms) : 0, 48270
AppSec [candidate] (47.264 ms) : 0, 47264
Logs Intake [baseline] (301.942 µs) : 0, 302
Logs Intake [candidate] (295.318 µs) : 0, 295
Remote Config [baseline] (574.814 µs) : 0, 575
Remote Config [candidate] (555.872 µs) : 0, 556
Telemetry [baseline] (8.33 ms) : 0, 8330
Telemetry [candidate] (7.584 ms) : 0, 7584
IAST [baseline] (25.469 ms) : 0, 25469
IAST [candidate] (26.093 ms) : 0, 26093
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061854
Total [baseline] (10.405 s) : 0, 10405380
Agent [candidate] (1.063 s) : 0, 1063455
Total [candidate] (10.37 s) : 0, 10369878
section appsec
Agent [baseline] (1.183 s) : 0, 1182852
Total [baseline] (10.517 s) : 0, 10517371
Agent [candidate] (1.189 s) : 0, 1189023
Total [candidate] (10.529 s) : 0, 10528701
section iast
Agent [baseline] (1.176 s) : 0, 1176297
Total [baseline] (10.722 s) : 0, 10721683
Agent [candidate] (1.169 s) : 0, 1168594
Total [candidate] (10.824 s) : 0, 10824350
section profiling
Agent [baseline] (1.269 s) : 0, 1269147
Total [baseline] (10.705 s) : 0, 10705332
Agent [candidate] (1.26 s) : 0, 1260409
Total [candidate] (10.596 s) : 0, 10595845
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.183 s 120.998 ms (11.4%)
Agent iast 1.176 s 114.443 ms (10.8%)
Agent profiling 1.269 s 207.294 ms (19.5%)
Total tracing 10.405 s -
Total appsec 10.517 s 111.991 ms (1.1%)
Total iast 10.722 s 316.303 ms (3.0%)
Total profiling 10.705 s 299.951 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.189 s 125.568 ms (11.8%)
Agent iast 1.169 s 105.14 ms (9.9%)
Agent profiling 1.26 s 196.955 ms (18.5%)
Total tracing 10.37 s -
Total appsec 10.529 s 158.823 ms (1.5%)
Total iast 10.824 s 454.473 ms (4.4%)
Total profiling 10.596 s 225.967 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.778 ms) : 0, 664778
BytebuddyAgent [candidate] (665.517 ms) : 0, 665517
GlobalTracer [baseline] (303.689 ms) : 0, 303689
GlobalTracer [candidate] (304.791 ms) : 0, 304791
AppSec [baseline] (50.377 ms) : 0, 50377
AppSec [candidate] (50.103 ms) : 0, 50103
Logs Intake [baseline] (411.251 µs) : 0, 411
Logs Intake [candidate] (393.555 µs) : 0, 394
Remote Config [baseline] (674.382 µs) : 0, 674
Remote Config [candidate] (671.807 µs) : 0, 672
Telemetry [baseline] (7.572 ms) : 0, 7572
Telemetry [candidate] (7.557 ms) : 0, 7557
section appsec
BytebuddyAgent [baseline] (677.153 ms) : 0, 677153
BytebuddyAgent [candidate] (681.454 ms) : 0, 681454
GlobalTracer [baseline] (298.355 ms) : 0, 298355
GlobalTracer [candidate] (299.454 ms) : 0, 299454
AppSec [baseline] (152.808 ms) : 0, 152808
AppSec [candidate] (153.778 ms) : 0, 153778
Logs Intake [baseline] (326.635 µs) : 0, 327
Logs Intake [candidate] (331.724 µs) : 0, 332
Remote Config [baseline] (645.195 µs) : 0, 645
Remote Config [candidate] (641.572 µs) : 0, 642
Telemetry [baseline] (8.508 ms) : 0, 8508
Telemetry [candidate] (8.264 ms) : 0, 8264
IAST [baseline] (21.184 ms) : 0, 21184
IAST [candidate] (20.888 ms) : 0, 20888
section iast
BytebuddyAgent [baseline] (784.711 ms) : 0, 784711
BytebuddyAgent [candidate] (778.468 ms) : 0, 778468
GlobalTracer [baseline] (295.987 ms) : 0, 295987
GlobalTracer [candidate] (293.906 ms) : 0, 293906
AppSec [baseline] (47.045 ms) : 0, 47045
AppSec [candidate] (47.185 ms) : 0, 47185
Logs Intake [baseline] (305.955 µs) : 0, 306
Logs Intake [candidate] (302.686 µs) : 0, 303
Remote Config [baseline] (582.754 µs) : 0, 583
Remote Config [candidate] (578.783 µs) : 0, 579
Telemetry [baseline] (8.543 ms) : 0, 8543
Telemetry [candidate] (9.326 ms) : 0, 9326
IAST [baseline] (25.777 ms) : 0, 25777
IAST [candidate] (25.564 ms) : 0, 25564
section profiling
BytebuddyAgent [baseline] (667.807 ms) : 0, 667807
BytebuddyAgent [candidate] (662.478 ms) : 0, 662478
GlobalTracer [baseline] (388.767 ms) : 0, 388767
GlobalTracer [candidate] (386.218 ms) : 0, 386218
AppSec [baseline] (50.944 ms) : 0, 50944
AppSec [candidate] (51.06 ms) : 0, 51060
Logs Intake [baseline] (343.001 µs) : 0, 343
Logs Intake [candidate] (328.692 µs) : 0, 329
Remote Config [baseline] (740.343 µs) : 0, 740
Remote Config [candidate] (744.891 µs) : 0, 745
Telemetry [baseline] (7.327 ms) : 0, 7327
Telemetry [candidate] (7.285 ms) : 0, 7285
ProfilingAgent [baseline] (96.285 ms) : 0, 96285
ProfilingAgent [candidate] (95.653 ms) : 0, 95653
Profiling [baseline] (96.309 ms) : 0, 96309
Profiling [candidate] (95.678 ms) : 0, 95678
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-13T15:42:54 2024-06-13T15:49:44
git_branch master nikita-tkachenko/do-not-include-system-props-in-test-session-command
git_commit_date 1718202127 1718292175
git_commit_sha 8085070 64b2c95
release_version 1.36.0-SNAPSHOT~80850709c7 1.36.0-SNAPSHOT~64b2c954f9
start_time 2024-06-13T15:42:40 2024-06-13T15:49:31
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718294130 1718294130
ci_job_id 542573580 542573580
ci_pipeline_id 36677587 36677587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.353 ms) : 1332, 1373
.   : milestone, 1353,
appsec (1.708 ms) : 1683, 1733
.   : milestone, 1708,
appsec_no_iast (1.71 ms) : 1684, 1735
.   : milestone, 1710,
iast (1.496 ms) : 1473, 1519
.   : milestone, 1496,
profiling (1.524 ms) : 1498, 1550
.   : milestone, 1524,
tracing (1.463 ms) : 1439, 1487
.   : milestone, 1463,
section candidate
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.714 ms) : 1690, 1739
.   : milestone, 1714,
appsec_no_iast (1.72 ms) : 1695, 1744
.   : milestone, 1720,
iast (1.479 ms) : 1456, 1502
.   : milestone, 1479,
profiling (1.485 ms) : 1461, 1510
.   : milestone, 1485,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.332 ms, 1.373 ms] -
appsec 1.708 ms [1.683 ms, 1.733 ms] 355.388 µs (26.3%)
appsec_no_iast 1.71 ms [1.684 ms, 1.735 ms] 356.955 µs (26.4%)
iast 1.496 ms [1.473 ms, 1.519 ms] 143.353 µs (10.6%)
profiling 1.524 ms [1.498 ms, 1.55 ms] 171.524 µs (12.7%)
tracing 1.463 ms [1.439 ms, 1.487 ms] 110.452 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.714 ms [1.69 ms, 1.739 ms] 360.166 µs (26.6%)
appsec_no_iast 1.72 ms [1.695 ms, 1.744 ms] 365.454 µs (27.0%)
iast 1.479 ms [1.456 ms, 1.502 ms] 124.598 µs (9.2%)
profiling 1.485 ms [1.461 ms, 1.51 ms] 130.978 µs (9.7%)
tracing 1.474 ms [1.45 ms, 1.498 ms] 119.805 µs (8.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.114 µs) : 353, 395
.   : milestone, 374,
iast (493.608 µs) : 472, 515
.   : milestone, 494,
iast_FULL (556.348 µs) : 535, 578
.   : milestone, 556,
iast_GLOBAL (512.971 µs) : 491, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (479.836 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (457.774 µs) : 436, 479
.   : milestone, 458,
iast_TELEMETRY_OFF (473.04 µs) : 452, 494
.   : milestone, 473,
tracing (448.323 µs) : 428, 469
.   : milestone, 448,
section candidate
no_agent (371.854 µs) : 352, 392
.   : milestone, 372,
iast (488.318 µs) : 467, 510
.   : milestone, 488,
iast_FULL (555.267 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (518.274 µs) : 496, 541
.   : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (486.247 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (462.46 µs) : 441, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (477.019 µs) : 456, 498
.   : milestone, 477,
tracing (439.787 µs) : 420, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.114 µs [353.365 µs, 394.862 µs] -
iast 493.608 µs [471.841 µs, 515.376 µs] 119.495 µs (31.9%)
iast_FULL 556.348 µs [535.157 µs, 577.538 µs] 182.234 µs (48.7%)
iast_GLOBAL 512.971 µs [490.839 µs, 535.102 µs] 138.857 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 479.836 µs [459.011 µs, 500.662 µs] 105.723 µs (28.3%)
iast_INACTIVE 457.774 µs [436.485 µs, 479.063 µs] 83.66 µs (22.4%)
iast_TELEMETRY_OFF 473.04 µs [451.84 µs, 494.24 µs] 98.926 µs (26.4%)
tracing 448.323 µs [427.676 µs, 468.97 µs] 74.209 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.854 µs [352.115 µs, 391.592 µs] -
iast 488.318 µs [466.888 µs, 509.749 µs] 116.465 µs (31.3%)
iast_FULL 555.267 µs [534.081 µs, 576.454 µs] 183.414 µs (49.3%)
iast_GLOBAL 518.274 µs [495.785 µs, 540.763 µs] 146.42 µs (39.4%)
iast_HARDCODED_SECRET_DISABLED 486.247 µs [465.055 µs, 507.44 µs] 114.394 µs (30.8%)
iast_INACTIVE 462.46 µs [440.652 µs, 484.267 µs] 90.606 µs (24.4%)
iast_TELEMETRY_OFF 477.019 µs [455.779 µs, 498.259 µs] 105.165 µs (28.3%)
tracing 439.787 µs [419.881 µs, 459.693 µs] 67.933 µs (18.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/do-not-include-system-props-in-test-session-command
git_commit_date 1718202127 1718292175
git_commit_sha 8085070 64b2c95
release_version 1.36.0-SNAPSHOT~80850709c7 1.36.0-SNAPSHOT~64b2c954f9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718294647 1718294647
ci_job_id 542573581 542573581
ci_pipeline_id 36677587 36677587
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
appsec (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
iast (18.908 s) : 18908000, 18908000
.   : milestone, 18908000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
.   : milestone, 18015000,
profiling (15.351 s) : 15351000, 15351000
.   : milestone, 15351000,
tracing (15.13 s) : 15130000, 15130000
.   : milestone, 15130000,
section candidate
no_agent (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
appsec (15.283 s) : 15283000, 15283000
.   : milestone, 15283000,
iast (19.088 s) : 19088000, 19088000
.   : milestone, 19088000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
.   : milestone, 17866000,
profiling (15.844 s) : 15844000, 15844000
.   : milestone, 15844000,
tracing (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.948 s [14.948 s, 14.948 s] -
appsec 15.244 s [15.244 s, 15.244 s] 296.0 ms (2.0%)
iast 18.908 s [18.908 s, 18.908 s] 3.96 s (26.5%)
iast_GLOBAL 18.015 s [18.015 s, 18.015 s] 3.067 s (20.5%)
profiling 15.351 s [15.351 s, 15.351 s] 403.0 ms (2.7%)
tracing 15.13 s [15.13 s, 15.13 s] 182.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.012 s [15.012 s, 15.012 s] -
appsec 15.283 s [15.283 s, 15.283 s] 271.0 ms (1.8%)
iast 19.088 s [19.088 s, 19.088 s] 4.076 s (27.2%)
iast_GLOBAL 17.866 s [17.866 s, 17.866 s] 2.854 s (19.0%)
profiling 15.844 s [15.844 s, 15.844 s] 832.0 ms (5.5%)
tracing 14.994 s [14.994 s, 14.994 s] -18.0 ms (-0.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~64b2c954f9, baseline=1.36.0-SNAPSHOT~80850709c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.222 ms) : 2188, 2257
.   : milestone, 2222,
iast (1.98 ms) : 1938, 2021
.   : milestone, 1980,
iast_GLOBAL (2.022 ms) : 1981, 2063
.   : milestone, 2022,
profiling (1.866 ms) : 1831, 1901
.   : milestone, 1866,
tracing (1.845 ms) : 1813, 1878
.   : milestone, 1845,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.211 ms) : 2176, 2245
.   : milestone, 2211,
iast (1.978 ms) : 1937, 2020
.   : milestone, 1978,
iast_GLOBAL (2.023 ms) : 1981, 2064
.   : milestone, 2023,
profiling (1.855 ms) : 1823, 1888
.   : milestone, 1855,
tracing (1.839 ms) : 1807, 1871
.   : milestone, 1839,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.222 ms [2.188 ms, 2.257 ms] 753.218 µs (51.3%)
iast 1.98 ms [1.938 ms, 2.021 ms] 510.428 µs (34.7%)
iast_GLOBAL 2.022 ms [1.981 ms, 2.063 ms] 552.405 µs (37.6%)
profiling 1.866 ms [1.831 ms, 1.901 ms] 397.077 µs (27.0%)
tracing 1.845 ms [1.813 ms, 1.878 ms] 376.017 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.211 ms [2.176 ms, 2.245 ms] 741.645 µs (50.5%)
iast 1.978 ms [1.937 ms, 2.02 ms] 509.452 µs (34.7%)
iast_GLOBAL 2.023 ms [1.981 ms, 2.064 ms] 553.716 µs (37.7%)
profiling 1.855 ms [1.823 ms, 1.888 ms] 386.588 µs (26.3%)
tracing 1.839 ms [1.807 ms, 1.871 ms] 369.898 µs (25.2%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 13, 2024 21:24
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 13, 2024 21:24
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit ecd93fb into master Jun 14, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/do-not-include-system-props-in-test-session-command branch June 14, 2024 19:21
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 14, 2024
@mcculls mcculls modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

comp: ci visibility Continuous Integration Visibility

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nikita-tkachenko-datadog @tonyredondo @mcculls