Skip to content

Fix NPE when kafka consumer info is not available #7195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 1 commit into from
Jun 14, 2024
Merged

Fix NPE when kafka consumer info is not available #7195

amarziali merged 1 commit into from
Jun 14, 2024

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Jun 14, 2024

What Does This Do

Backport of #7190

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added type: bug Bug report and fix inst: kafka Kafka instrumentation labels Jun 14, 2024
@amarziali amarziali added this to the 1.35.1 milestone Jun 14, 2024
@amarziali amarziali requested a review from a team as a code owner June 14, 2024 11:40
@amarziali amarziali enabled auto-merge (squash) June 14, 2024 11:44
@pr-commenter
Copy link

pr-commenter bot commented Jun 14, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718365351 1718365125
git_commit_sha 24d82a5 bdf4dec
release_version 1.36.0-SNAPSHOT~24d82a55c1 1.36.0-SNAPSHOT~bdf4dec00b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718367870 1718367870
ci_job_id 543562451 543562451
ci_pipeline_id 36766308 36766308
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066318
Total [baseline] (8.608 s) : 0, 8608289
Agent [candidate] (1.066 s) : 0, 1066224
Total [candidate] (8.593 s) : 0, 8592503
section iast
Agent [baseline] (1.169 s) : 0, 1169013
Total [baseline] (8.992 s) : 0, 8991618
Agent [candidate] (1.177 s) : 0, 1177368
Total [candidate] (9.032 s) : 0, 9032045
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.175 s) : 0, 1174968
Total [baseline] (9.038 s) : 0, 9037712
Agent [candidate] (1.167 s) : 0, 1167490
Total [candidate] (8.985 s) : 0, 8985269
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1201502
Total [baseline] (9.075 s) : 0, 9075450
Agent [candidate] (1.163 s) : 0, 1162814
Total [candidate] (9.001 s) : 0, 9000748
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.169 s 102.695 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 108.649 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.202 s 135.184 ms (12.7%)
Total tracing 8.608 s -
Total iast 8.992 s 383.329 ms (4.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.038 s 429.423 ms (5.0%)
Total iast_TELEMETRY_OFF 9.075 s 467.161 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent iast 1.177 s 111.144 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.167 s 101.265 ms (9.5%)
Agent iast_TELEMETRY_OFF 1.163 s 96.59 ms (9.1%)
Total tracing 8.593 s -
Total iast 9.032 s 439.543 ms (5.1%)
Total iast_HARDCODED_SECRET_DISABLED 8.985 s 392.766 ms (4.6%)
Total iast_TELEMETRY_OFF 9.001 s 408.246 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.79 ms) : 0, 667790
BytebuddyAgent [candidate] (666.579 ms) : 0, 666579
GlobalTracer [baseline] (305.103 ms) : 0, 305103
GlobalTracer [candidate] (305.94 ms) : 0, 305940
AppSec [baseline] (50.174 ms) : 0, 50174
AppSec [candidate] (50.493 ms) : 0, 50493
Logs Intake [baseline] (334.568 µs) : 0, 335
Logs Intake [candidate] (423.299 µs) : 0, 423
Remote Config [baseline] (668.155 µs) : 0, 668
Remote Config [candidate] (670.729 µs) : 0, 671
Telemetry [baseline] (7.558 ms) : 0, 7558
Telemetry [candidate] (7.655 ms) : 0, 7655
section iast
BytebuddyAgent [baseline] (779.591 ms) : 0, 779591
BytebuddyAgent [candidate] (786.361 ms) : 0, 786361
GlobalTracer [baseline] (293.229 ms) : 0, 293229
GlobalTracer [candidate] (295.608 ms) : 0, 295608
AppSec [baseline] (47.092 ms) : 0, 47092
AppSec [candidate] (47.516 ms) : 0, 47516
Logs Intake [baseline] (302.371 µs) : 0, 302
Logs Intake [candidate] (306.922 µs) : 0, 307
Remote Config [baseline] (604.729 µs) : 0, 605
Remote Config [candidate] (594.595 µs) : 0, 595
Telemetry [baseline] (7.867 ms) : 0, 7867
Telemetry [candidate] (7.042 ms) : 0, 7042
IAST [baseline] (27.058 ms) : 0, 27058
IAST [candidate] (26.5 ms) : 0, 26500
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.778 ms) : 0, 782778
BytebuddyAgent [candidate] (778.323 ms) : 0, 778323
GlobalTracer [baseline] (295.298 ms) : 0, 295298
GlobalTracer [candidate] (293.285 ms) : 0, 293285
AppSec [baseline] (47.204 ms) : 0, 47204
AppSec [candidate] (46.67 ms) : 0, 46670
Logs Intake [baseline] (314.298 µs) : 0, 314
Logs Intake [candidate] (304.74 µs) : 0, 305
Remote Config [baseline] (601.741 µs) : 0, 602
Remote Config [candidate] (573.897 µs) : 0, 574
Telemetry [baseline] (7.857 ms) : 0, 7857
Telemetry [candidate] (7.667 ms) : 0, 7667
IAST [baseline] (27.468 ms) : 0, 27468
IAST [candidate] (27.306 ms) : 0, 27306
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.833 ms) : 0, 801833
BytebuddyAgent [candidate] (775.682 ms) : 0, 775682
GlobalTracer [baseline] (302.162 ms) : 0, 302162
GlobalTracer [candidate] (293.855 ms) : 0, 293855
AppSec [baseline] (48.717 ms) : 0, 48717
AppSec [candidate] (49.117 ms) : 0, 49117
Logs Intake [baseline] (303.142 µs) : 0, 303
Logs Intake [candidate] (298.341 µs) : 0, 298
Remote Config [baseline] (587.466 µs) : 0, 587
Remote Config [candidate] (560.793 µs) : 0, 561
Telemetry [baseline] (7.816 ms) : 0, 7816
Telemetry [candidate] (7.493 ms) : 0, 7493
IAST [baseline] (26.368 ms) : 0, 26368
IAST [candidate] (22.503 ms) : 0, 22503
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062775
Total [baseline] (10.527 s) : 0, 10526760
Agent [candidate] (1.064 s) : 0, 1063817
Total [candidate] (10.35 s) : 0, 10349649
section appsec
Agent [baseline] (1.185 s) : 0, 1185410
Total [baseline] (10.518 s) : 0, 10517768
Agent [candidate] (1.188 s) : 0, 1187862
Total [candidate] (10.551 s) : 0, 10551229
section iast
Agent [baseline] (1.179 s) : 0, 1179211
Total [baseline] (10.715 s) : 0, 10714539
Agent [candidate] (1.18 s) : 0, 1180152
Total [candidate] (10.782 s) : 0, 10782029
section profiling
Agent [baseline] (1.262 s) : 0, 1262319
Total [baseline] (10.653 s) : 0, 10653306
Agent [candidate] (1.261 s) : 0, 1261378
Total [candidate] (10.667 s) : 0, 10666686
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.185 s 122.635 ms (11.5%)
Agent iast 1.179 s 116.435 ms (11.0%)
Agent profiling 1.262 s 199.544 ms (18.8%)
Total tracing 10.527 s -
Total appsec 10.518 s -8.992 ms (-0.1%)
Total iast 10.715 s 187.779 ms (1.8%)
Total profiling 10.653 s 126.546 ms (1.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.188 s 124.045 ms (11.7%)
Agent iast 1.18 s 116.335 ms (10.9%)
Agent profiling 1.261 s 197.561 ms (18.6%)
Total tracing 10.35 s -
Total appsec 10.551 s 201.579 ms (1.9%)
Total iast 10.782 s 432.38 ms (4.2%)
Total profiling 10.667 s 317.037 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.087 ms) : 0, 665087
BytebuddyAgent [candidate] (665.963 ms) : 0, 665963
GlobalTracer [baseline] (304.419 ms) : 0, 304419
GlobalTracer [candidate] (304.546 ms) : 0, 304546
AppSec [baseline] (50.285 ms) : 0, 50285
AppSec [candidate] (50.295 ms) : 0, 50295
Logs Intake [baseline] (332.267 µs) : 0, 332
Logs Intake [candidate] (375.403 µs) : 0, 375
Remote Config [baseline] (670.984 µs) : 0, 671
Remote Config [candidate] (687.702 µs) : 0, 688
Telemetry [baseline] (7.579 ms) : 0, 7579
Telemetry [candidate] (7.562 ms) : 0, 7562
section appsec
BytebuddyAgent [baseline] (678.469 ms) : 0, 678469
BytebuddyAgent [candidate] (680.101 ms) : 0, 680101
GlobalTracer [baseline] (298.376 ms) : 0, 298376
GlobalTracer [candidate] (299.091 ms) : 0, 299091
AppSec [baseline] (153.929 ms) : 0, 153929
AppSec [candidate] (153.711 ms) : 0, 153711
Logs Intake [baseline] (335.806 µs) : 0, 336
Logs Intake [candidate] (337.15 µs) : 0, 337
Remote Config [baseline] (636.303 µs) : 0, 636
Remote Config [candidate] (651.908 µs) : 0, 652
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.137 ms) : 0, 8137
IAST [baseline] (20.658 ms) : 0, 20658
IAST [candidate] (22.523 ms) : 0, 22523
section iast
BytebuddyAgent [baseline] (786.425 ms) : 0, 786425
BytebuddyAgent [candidate] (786.703 ms) : 0, 786703
GlobalTracer [baseline] (296.111 ms) : 0, 296111
GlobalTracer [candidate] (295.742 ms) : 0, 295742
AppSec [baseline] (47.419 ms) : 0, 47419
AppSec [candidate] (47.485 ms) : 0, 47485
Logs Intake [baseline] (309.802 µs) : 0, 310
Logs Intake [candidate] (310.079 µs) : 0, 310
Remote Config [baseline] (598.018 µs) : 0, 598
Remote Config [candidate] (589.397 µs) : 0, 589
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.449 ms) : 0, 8449
IAST [baseline] (26.452 ms) : 0, 26452
IAST [candidate] (27.514 ms) : 0, 27514
section profiling
BytebuddyAgent [baseline] (662.662 ms) : 0, 662662
BytebuddyAgent [candidate] (662.343 ms) : 0, 662343
GlobalTracer [baseline] (386.561 ms) : 0, 386561
GlobalTracer [candidate] (386.137 ms) : 0, 386137
AppSec [baseline] (51.271 ms) : 0, 51271
AppSec [candidate] (50.807 ms) : 0, 50807
Logs Intake [baseline] (336.324 µs) : 0, 336
Logs Intake [candidate] (332.551 µs) : 0, 333
Remote Config [baseline] (706.022 µs) : 0, 706
Remote Config [candidate] (733.476 µs) : 0, 733
Telemetry [baseline] (7.388 ms) : 0, 7388
Telemetry [candidate] (7.333 ms) : 0, 7333
ProfilingAgent [baseline] (96.518 ms) : 0, 96518
ProfilingAgent [candidate] (96.796 ms) : 0, 96796
Profiling [baseline] (96.542 ms) : 0, 96542
Profiling [candidate] (96.822 ms) : 0, 96822
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-14T11:55:08 2024-06-14T12:01:57
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718365351 1718365125
git_commit_sha 24d82a5 bdf4dec
release_version 1.36.0-SNAPSHOT~24d82a55c1 1.36.0-SNAPSHOT~bdf4dec00b
start_time 2024-06-14T11:54:55 2024-06-14T12:01:44
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718366861 1718366861
ci_job_id 543562453 543562453
ci_pipeline_id 36766308 36766308
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.716 ms) : 1692, 1740
.   : milestone, 1716,
appsec_no_iast (1.71 ms) : 1685, 1734
.   : milestone, 1710,
iast (1.462 ms) : 1439, 1485
.   : milestone, 1462,
profiling (1.513 ms) : 1487, 1539
.   : milestone, 1513,
tracing (1.459 ms) : 1435, 1482
.   : milestone, 1459,
section candidate
no_agent (1.337 ms) : 1318, 1357
.   : milestone, 1337,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
appsec_no_iast (1.726 ms) : 1701, 1750
.   : milestone, 1726,
iast (1.474 ms) : 1451, 1497
.   : milestone, 1474,
profiling (1.525 ms) : 1498, 1551
.   : milestone, 1525,
tracing (1.443 ms) : 1418, 1468
.   : milestone, 1443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.366 ms] -
appsec 1.716 ms [1.692 ms, 1.74 ms] 370.113 µs (27.5%)
appsec_no_iast 1.71 ms [1.685 ms, 1.734 ms] 363.742 µs (27.0%)
iast 1.462 ms [1.439 ms, 1.485 ms] 116.089 µs (8.6%)
profiling 1.513 ms [1.487 ms, 1.539 ms] 167.056 µs (12.4%)
tracing 1.459 ms [1.435 ms, 1.482 ms] 112.785 µs (8.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.318 ms, 1.357 ms] -
appsec 1.724 ms [1.7 ms, 1.748 ms] 386.265 µs (28.9%)
appsec_no_iast 1.726 ms [1.701 ms, 1.75 ms] 388.264 µs (29.0%)
iast 1.474 ms [1.451 ms, 1.497 ms] 136.433 µs (10.2%)
profiling 1.525 ms [1.498 ms, 1.551 ms] 187.192 µs (14.0%)
tracing 1.443 ms [1.418 ms, 1.468 ms] 105.755 µs (7.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.238 µs) : 349, 388
.   : milestone, 368,
iast (480.587 µs) : 459, 502
.   : milestone, 481,
iast_FULL (549.184 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (505.563 µs) : 484, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (480.199 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (461.254 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (466.872 µs) : 446, 488
.   : milestone, 467,
tracing (438.521 µs) : 418, 459
.   : milestone, 439,
section candidate
no_agent (370.571 µs) : 351, 390
.   : milestone, 371,
iast (478.187 µs) : 457, 499
.   : milestone, 478,
iast_FULL (553.636 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (497.781 µs) : 477, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (480.983 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (450.433 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (463.982 µs) : 443, 485
.   : milestone, 464,
tracing (445.049 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.238 µs [348.672 µs, 387.804 µs] -
iast 480.587 µs [459.454 µs, 501.72 µs] 112.349 µs (30.5%)
iast_FULL 549.184 µs [527.978 µs, 570.39 µs] 180.946 µs (49.1%)
iast_GLOBAL 505.563 µs [484.251 µs, 526.875 µs] 137.325 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 480.199 µs [459.096 µs, 501.303 µs] 111.962 µs (30.4%)
iast_INACTIVE 461.254 µs [439.317 µs, 483.192 µs] 93.017 µs (25.3%)
iast_TELEMETRY_OFF 466.872 µs [446.102 µs, 487.643 µs] 98.635 µs (26.8%)
tracing 438.521 µs [417.755 µs, 459.288 µs] 70.284 µs (19.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.571 µs [350.99 µs, 390.152 µs] -
iast 478.187 µs [457.09 µs, 499.284 µs] 107.616 µs (29.0%)
iast_FULL 553.636 µs [532.369 µs, 574.904 µs] 183.066 µs (49.4%)
iast_GLOBAL 497.781 µs [476.748 µs, 518.813 µs] 127.21 µs (34.3%)
iast_HARDCODED_SECRET_DISABLED 480.983 µs [460.094 µs, 501.871 µs] 110.412 µs (29.8%)
iast_INACTIVE 450.433 µs [429.028 µs, 471.837 µs] 79.862 µs (21.6%)
iast_TELEMETRY_OFF 463.982 µs [443.149 µs, 484.816 µs] 93.412 µs (25.2%)
tracing 445.049 µs [423.746 µs, 466.352 µs] 74.478 µs (20.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/kafka-npe
git_commit_date 1718365351 1718365125
git_commit_sha 24d82a5 bdf4dec
release_version 1.36.0-SNAPSHOT~24d82a55c1 1.36.0-SNAPSHOT~bdf4dec00b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718367374 1718367374
ci_job_id 543562455 543562455
ci_pipeline_id 36766308 36766308
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.472 s) : 15472000, 15472000
.   : milestone, 15472000,
appsec (15.202 s) : 15202000, 15202000
.   : milestone, 15202000,
iast (18.786 s) : 18786000, 18786000
.   : milestone, 18786000,
iast_GLOBAL (17.93 s) : 17930000, 17930000
.   : milestone, 17930000,
profiling (15.664 s) : 15664000, 15664000
.   : milestone, 15664000,
tracing (14.856 s) : 14856000, 14856000
.   : milestone, 14856000,
section candidate
no_agent (15.386 s) : 15386000, 15386000
.   : milestone, 15386000,
appsec (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
iast (18.741 s) : 18741000, 18741000
.   : milestone, 18741000,
iast_GLOBAL (17.841 s) : 17841000, 17841000
.   : milestone, 17841000,
profiling (15.965 s) : 15965000, 15965000
.   : milestone, 15965000,
tracing (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.472 s [15.472 s, 15.472 s] -
appsec 15.202 s [15.202 s, 15.202 s] -270.0 ms (-1.7%)
iast 18.786 s [18.786 s, 18.786 s] 3.314 s (21.4%)
iast_GLOBAL 17.93 s [17.93 s, 17.93 s] 2.458 s (15.9%)
profiling 15.664 s [15.664 s, 15.664 s] 192.0 ms (1.2%)
tracing 14.856 s [14.856 s, 14.856 s] -616.0 ms (-4.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.386 s [15.386 s, 15.386 s] -
appsec 15.077 s [15.077 s, 15.077 s] -309.0 ms (-2.0%)
iast 18.741 s [18.741 s, 18.741 s] 3.355 s (21.8%)
iast_GLOBAL 17.841 s [17.841 s, 17.841 s] 2.455 s (16.0%)
profiling 15.965 s [15.965 s, 15.965 s] 579.0 ms (3.8%)
tracing 14.963 s [14.963 s, 14.963 s] -423.0 ms (-2.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~bdf4dec00b, baseline=1.36.0-SNAPSHOT~24d82a55c1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
.   : milestone, 1462,
appsec (2.206 ms) : 2171, 2240
.   : milestone, 2206,
iast (1.962 ms) : 1921, 2003
.   : milestone, 1962,
iast_GLOBAL (2.006 ms) : 1964, 2047
.   : milestone, 2006,
profiling (2.319 ms) : 2143, 2496
.   : milestone, 2319,
tracing (1.828 ms) : 1796, 1860
.   : milestone, 1828,
section candidate
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.186 ms) : 2152, 2219
.   : milestone, 2186,
iast (1.953 ms) : 1912, 1994
.   : milestone, 1953,
iast_GLOBAL (2.003 ms) : 1962, 2044
.   : milestone, 2003,
profiling (1.86 ms) : 1824, 1895
.   : milestone, 1860,
tracing (1.823 ms) : 1791, 1855
.   : milestone, 1823,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.473 ms] -
appsec 2.206 ms [2.171 ms, 2.24 ms] 743.555 µs (50.9%)
iast 1.962 ms [1.921 ms, 2.003 ms] 499.886 µs (34.2%)
iast_GLOBAL 2.006 ms [1.964 ms, 2.047 ms] 543.694 µs (37.2%)
profiling 2.319 ms [2.143 ms, 2.496 ms] 857.205 µs (58.6%)
tracing 1.828 ms [1.796 ms, 1.86 ms] 366.019 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.186 ms [2.152 ms, 2.219 ms] 730.284 µs (50.2%)
iast 1.953 ms [1.912 ms, 1.994 ms] 497.855 µs (34.2%)
iast_GLOBAL 2.003 ms [1.962 ms, 2.044 ms] 547.483 µs (37.6%)
profiling 1.86 ms [1.824 ms, 1.895 ms] 404.399 µs (27.8%)
tracing 1.823 ms [1.791 ms, 1.855 ms] 367.333 µs (25.2%)

@amarziali amarziali merged commit 35451a2 into release/v1.35.x Jun 14, 2024
@amarziali amarziali deleted the andrea.marziali/kafka-npe branch June 14, 2024 13:56
@mcculls mcculls modified the milestones: 1.35.1, 1.35.2 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

inst: kafka Kafka instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.35.2

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @PerfectSlayer @mcculls