Ensure user tracking request headers are not rate limited #7222

manuel-alvarez-alvarez · 2024-06-19T14:10:24Z

What Does This Do

It makes sure that request headers are always set in the span when there are user tracking events.

Motivation

User tracking events are disjoint from waf events so rating limitations should not apply.

Additional Notes

Jira ticket: [PROJ-IDENT]

manuel-alvarez-alvarez · 2024-06-19T14:23:17Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/GatewayBridge.java

-    "appsec.events.users.login.success.track", "appsec.events.users.login.failure.track"
+    "appsec.events.users.login.success.track",
+    "appsec.events.users.login.failure.track",
+    "appsec.events.users.signup.track"


I missed this event in the initial PR

pr-commenter · 2024-06-19T15:01:32Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/waf-ensure-user-tracking-headers-not-rate-limited
git_commit_date	1719309238	1719331291
git_commit_sha	`d19ceac`	`c917eac`
release_version	1.36.0-SNAPSHOT~d19ceac03e	1.36.0-SNAPSHOT~c917eacde1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719334355	1719334355
ci_job_id	552872697	552872697
ci_pipeline_id	37521240	37521240
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069115
Total [baseline] (8.605 s) : 0, 8605248
Agent [candidate] (1.064 s) : 0, 1064316
Total [candidate] (8.558 s) : 0, 8558417
section iast
Agent [baseline] (1.169 s) : 0, 1169289
Total [baseline] (8.985 s) : 0, 8985450
Agent [candidate] (1.18 s) : 0, 1179959
Total [candidate] (9.013 s) : 0, 9013142
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1176746
Total [baseline] (8.971 s) : 0, 8971161
Agent [candidate] (1.172 s) : 0, 1172128
Total [candidate] (8.97 s) : 0, 8969741
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1174568
Total [baseline] (9.0 s) : 0, 9000245
Agent [candidate] (1.168 s) : 0, 1167515
Total [candidate] (8.983 s) : 0, 8983412

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	iast	1.169 s	100.174 ms (9.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.177 s	107.631 ms (10.1%)
Agent	iast_TELEMETRY_OFF	1.175 s	105.453 ms (9.9%)
Total	tracing	8.605 s	-
Total	iast	8.985 s	380.202 ms (4.4%)
Total	iast_HARDCODED_SECRET_DISABLED	8.971 s	365.913 ms (4.3%)
Total	iast_TELEMETRY_OFF	9.0 s	394.997 ms (4.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	iast	1.18 s	115.643 ms (10.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	107.812 ms (10.1%)
Agent	iast_TELEMETRY_OFF	1.168 s	103.199 ms (9.7%)
Total	tracing	8.558 s	-
Total	iast	9.013 s	454.725 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.97 s	411.325 ms (4.8%)
Total	iast_TELEMETRY_OFF	8.983 s	424.996 ms (5.0%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.504 ms) : 0, 670504
BytebuddyAgent [candidate] (667.144 ms) : 0, 667144
GlobalTracer [baseline] (305.358 ms) : 0, 305358
GlobalTracer [candidate] (304.143 ms) : 0, 304143
AppSec [baseline] (50.513 ms) : 0, 50513
AppSec [candidate] (50.351 ms) : 0, 50351
Remote Config [baseline] (691.307 µs) : 0, 691
Remote Config [candidate] (689.365 µs) : 0, 689
Telemetry [baseline] (7.591 ms) : 0, 7591
Telemetry [candidate] (7.564 ms) : 0, 7564
section iast
BytebuddyAgent [baseline] (779.732 ms) : 0, 779732
BytebuddyAgent [candidate] (787.164 ms) : 0, 787164
GlobalTracer [baseline] (293.417 ms) : 0, 293417
GlobalTracer [candidate] (295.885 ms) : 0, 295885
AppSec [baseline] (47.144 ms) : 0, 47144
AppSec [candidate] (47.529 ms) : 0, 47529
IAST [baseline] (28.249 ms) : 0, 28249
IAST [candidate] (28.352 ms) : 0, 28352
Remote Config [baseline] (613.594 µs) : 0, 614
Remote Config [candidate] (636.676 µs) : 0, 637
Telemetry [baseline] (6.885 ms) : 0, 6885
Telemetry [candidate] (7.015 ms) : 0, 7015
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (785.29 ms) : 0, 785290
BytebuddyAgent [candidate] (780.667 ms) : 0, 780667
GlobalTracer [baseline] (295.411 ms) : 0, 295411
GlobalTracer [candidate] (293.948 ms) : 0, 293948
AppSec [baseline] (47.752 ms) : 0, 47752
AppSec [candidate] (47.433 ms) : 0, 47433
IAST [baseline] (27.265 ms) : 0, 27265
IAST [candidate] (29.209 ms) : 0, 29209
Remote Config [baseline] (647.719 µs) : 0, 648
Remote Config [candidate] (618.304 µs) : 0, 618
Telemetry [baseline] (7.001 ms) : 0, 7001
Telemetry [candidate] (6.925 ms) : 0, 6925
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.507 ms) : 0, 782507
BytebuddyAgent [candidate] (779.184 ms) : 0, 779184
GlobalTracer [baseline] (295.199 ms) : 0, 295199
GlobalTracer [candidate] (293.543 ms) : 0, 293543
AppSec [baseline] (47.429 ms) : 0, 47429
AppSec [candidate] (47.093 ms) : 0, 47093
IAST [baseline] (27.823 ms) : 0, 27823
IAST [candidate] (26.111 ms) : 0, 26111
Remote Config [baseline] (613.639 µs) : 0, 614
Remote Config [candidate] (596.192 µs) : 0, 596
Telemetry [baseline] (7.612 ms) : 0, 7612
Telemetry [candidate] (7.556 ms) : 0, 7556

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063440
Total [baseline] (10.299 s) : 0, 10298786
Agent [candidate] (1.07 s) : 0, 1070083
Total [candidate] (10.36 s) : 0, 10359992
section appsec
Agent [baseline] (1.182 s) : 0, 1182405
Total [baseline] (10.544 s) : 0, 10543910
Agent [candidate] (1.184 s) : 0, 1184050
Total [candidate] (10.438 s) : 0, 10437818
section iast
Agent [baseline] (1.17 s) : 0, 1170239
Total [baseline] (10.725 s) : 0, 10724677
Agent [candidate] (1.171 s) : 0, 1170735
Total [candidate] (10.721 s) : 0, 10720532
section profiling
Agent [baseline] (1.271 s) : 0, 1271393
Total [baseline] (10.657 s) : 0, 10657273
Agent [candidate] (1.265 s) : 0, 1264674
Total [candidate] (10.618 s) : 0, 10617614

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	appsec	1.182 s	118.965 ms (11.2%)
Agent	iast	1.17 s	106.799 ms (10.0%)
Agent	profiling	1.271 s	207.952 ms (19.6%)
Total	tracing	10.299 s	-
Total	appsec	10.544 s	245.124 ms (2.4%)
Total	iast	10.725 s	425.891 ms (4.1%)
Total	profiling	10.657 s	358.487 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.07 s	-
Agent	appsec	1.184 s	113.967 ms (10.7%)
Agent	iast	1.171 s	100.652 ms (9.4%)
Agent	profiling	1.265 s	194.592 ms (18.2%)
Total	tracing	10.36 s	-
Total	appsec	10.438 s	77.826 ms (0.8%)
Total	iast	10.721 s	360.539 ms (3.5%)
Total	profiling	10.618 s	257.621 ms (2.5%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.485 ms) : 0, 666485
BytebuddyAgent [candidate] (671.125 ms) : 0, 671125
GlobalTracer [baseline] (304.249 ms) : 0, 304249
GlobalTracer [candidate] (305.825 ms) : 0, 305825
AppSec [baseline] (50.132 ms) : 0, 50132
AppSec [candidate] (50.26 ms) : 0, 50260
Remote Config [baseline] (684.941 µs) : 0, 685
Remote Config [candidate] (688.475 µs) : 0, 688
Telemetry [baseline] (7.518 ms) : 0, 7518
Telemetry [candidate] (7.533 ms) : 0, 7533
section appsec
BytebuddyAgent [baseline] (676.126 ms) : 0, 676126
BytebuddyAgent [candidate] (678.238 ms) : 0, 678238
GlobalTracer [baseline] (297.608 ms) : 0, 297608
GlobalTracer [candidate] (298.228 ms) : 0, 298228
AppSec [baseline] (153.991 ms) : 0, 153991
AppSec [candidate] (153.732 ms) : 0, 153732
IAST [baseline] (22.345 ms) : 0, 22345
IAST [candidate] (20.976 ms) : 0, 20976
Remote Config [baseline] (638.214 µs) : 0, 638
Remote Config [candidate] (639.646 µs) : 0, 640
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.149 ms) : 0, 8149
section iast
BytebuddyAgent [baseline] (780.134 ms) : 0, 780134
BytebuddyAgent [candidate] (779.971 ms) : 0, 779971
GlobalTracer [baseline] (292.991 ms) : 0, 292991
GlobalTracer [candidate] (293.777 ms) : 0, 293777
AppSec [baseline] (47.072 ms) : 0, 47072
AppSec [candidate] (47.055 ms) : 0, 47055
IAST [baseline] (29.231 ms) : 0, 29231
IAST [candidate] (28.233 ms) : 0, 28233
Remote Config [baseline] (659.909 µs) : 0, 660
Remote Config [candidate] (680.864 µs) : 0, 681
Telemetry [baseline] (6.866 ms) : 0, 6866
Telemetry [candidate] (7.71 ms) : 0, 7710
section profiling
BytebuddyAgent [baseline] (668.53 ms) : 0, 668530
BytebuddyAgent [candidate] (664.179 ms) : 0, 664179
GlobalTracer [baseline] (388.885 ms) : 0, 388885
GlobalTracer [candidate] (387.305 ms) : 0, 387305
AppSec [baseline] (51.709 ms) : 0, 51709
AppSec [candidate] (51.531 ms) : 0, 51531
Remote Config [baseline] (747.245 µs) : 0, 747
Remote Config [candidate] (743.423 µs) : 0, 743
Telemetry [baseline] (7.397 ms) : 0, 7397
Telemetry [candidate] (7.384 ms) : 0, 7384
ProfilingAgent [baseline] (96.657 ms) : 0, 96657
ProfilingAgent [candidate] (96.482 ms) : 0, 96482
Profiling [baseline] (96.682 ms) : 0, 96682
Profiling [candidate] (96.506 ms) : 0, 96506

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-25T16:21:30	2024-06-25T16:28:20
git_branch	master	malvarez/waf-ensure-user-tracking-headers-not-rate-limited
git_commit_date	1719309238	1719331291
git_commit_sha	`d19ceac`	`c917eac`
release_version	1.36.0-SNAPSHOT~d19ceac03e	1.36.0-SNAPSHOT~c917eacde1
start_time	2024-06-25T16:21:17	2024-06-25T16:28:06

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719333246	1719333246
ci_job_id	552872698	552872698
ci_pipeline_id	37521240	37521240
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.33 ms) : 1311, 1349
.   : milestone, 1330,
appsec (1.727 ms) : 1702, 1752
.   : milestone, 1727,
appsec_no_iast (1.719 ms) : 1693, 1745
.   : milestone, 1719,
iast (1.482 ms) : 1460, 1504
.   : milestone, 1482,
profiling (1.484 ms) : 1459, 1509
.   : milestone, 1484,
tracing (1.476 ms) : 1452, 1500
.   : milestone, 1476,
section candidate
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.722 ms) : 1698, 1746
.   : milestone, 1722,
appsec_no_iast (1.72 ms) : 1695, 1746
.   : milestone, 1720,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.533 ms) : 1507, 1559
.   : milestone, 1533,
tracing (1.478 ms) : 1454, 1502
.   : milestone, 1478,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.33 ms [1.311 ms, 1.349 ms]	-
appsec	1.727 ms [1.702 ms, 1.752 ms]	397.005 µs (29.8%)
appsec_no_iast	1.719 ms [1.693 ms, 1.745 ms]	388.756 µs (29.2%)
iast	1.482 ms [1.46 ms, 1.504 ms]	151.637 µs (11.4%)
profiling	1.484 ms [1.459 ms, 1.509 ms]	153.692 µs (11.6%)
tracing	1.476 ms [1.452 ms, 1.5 ms]	145.742 µs (11.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.348 ms [1.328 ms, 1.367 ms]	-
appsec	1.722 ms [1.698 ms, 1.746 ms]	374.164 µs (27.8%)
appsec_no_iast	1.72 ms [1.695 ms, 1.746 ms]	372.686 µs (27.7%)
iast	1.491 ms [1.468 ms, 1.514 ms]	143.199 µs (10.6%)
profiling	1.533 ms [1.507 ms, 1.559 ms]	185.758 µs (13.8%)
tracing	1.478 ms [1.454 ms, 1.502 ms]	130.229 µs (9.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.838 µs) : 348, 388
.   : milestone, 368,
iast (482.187 µs) : 461, 503
.   : milestone, 482,
iast_FULL (553.613 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (506.23 µs) : 484, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (487.891 µs) : 467, 509
.   : milestone, 488,
iast_INACTIVE (462.966 µs) : 442, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (474.133 µs) : 453, 495
.   : milestone, 474,
tracing (442.998 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (376.443 µs) : 356, 397
.   : milestone, 376,
iast (489.101 µs) : 468, 511
.   : milestone, 489,
iast_FULL (548.084 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (513.85 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (492.861 µs) : 472, 514
.   : milestone, 493,
iast_INACTIVE (452.901 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (475.439 µs) : 454, 497
.   : milestone, 475,
tracing (443.663 µs) : 423, 464
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	367.838 µs [347.556 µs, 388.12 µs]	-
iast	482.187 µs [461.049 µs, 503.325 µs]	114.349 µs (31.1%)
iast_FULL	553.613 µs [532.554 µs, 574.671 µs]	185.775 µs (50.5%)
iast_GLOBAL	506.23 µs [484.25 µs, 528.21 µs]	138.392 µs (37.6%)
iast_HARDCODED_SECRET_DISABLED	487.891 µs [466.663 µs, 509.119 µs]	120.054 µs (32.6%)
iast_INACTIVE	462.966 µs [442.089 µs, 483.842 µs]	95.128 µs (25.9%)
iast_TELEMETRY_OFF	474.133 µs [453.31 µs, 494.956 µs]	106.295 µs (28.9%)
tracing	442.998 µs [422.49 µs, 463.505 µs]	75.16 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.443 µs [356.328 µs, 396.557 µs]	-
iast	489.101 µs [467.698 µs, 510.505 µs]	112.658 µs (29.9%)
iast_FULL	548.084 µs [526.947 µs, 569.222 µs]	171.642 µs (45.6%)
iast_GLOBAL	513.85 µs [491.654 µs, 536.047 µs]	137.408 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED	492.861 µs [471.571 µs, 514.151 µs]	116.418 µs (30.9%)
iast_INACTIVE	452.901 µs [432.084 µs, 473.718 µs]	76.458 µs (20.3%)
iast_TELEMETRY_OFF	475.439 µs [453.927 µs, 496.951 µs]	98.996 µs (26.3%)
tracing	443.663 µs [423.156 µs, 464.17 µs]	67.22 µs (17.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/waf-ensure-user-tracking-headers-not-rate-limited
git_commit_date	1719309238	1719331291
git_commit_sha	`d19ceac`	`c917eac`
release_version	1.36.0-SNAPSHOT~d19ceac03e	1.36.0-SNAPSHOT~c917eacde1

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1719333845	1719333845
ci_job_id	552872699	552872699
ci_pipeline_id	37521240	37521240
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.546 s) : 15546000, 15546000
.   : milestone, 15546000,
appsec (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
iast (18.868 s) : 18868000, 18868000
.   : milestone, 18868000,
iast_GLOBAL (17.71 s) : 17710000, 17710000
.   : milestone, 17710000,
profiling (15.2 s) : 15200000, 15200000
.   : milestone, 15200000,
tracing (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
appsec (15.013 s) : 15013000, 15013000
.   : milestone, 15013000,
iast (18.926 s) : 18926000, 18926000
.   : milestone, 18926000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
.   : milestone, 18054000,
profiling (15.765 s) : 15765000, 15765000
.   : milestone, 15765000,
tracing (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.546 s [15.546 s, 15.546 s]	-
appsec	15.279 s [15.279 s, 15.279 s]	-267.0 ms (-1.7%)
iast	18.868 s [18.868 s, 18.868 s]	3.322 s (21.4%)
iast_GLOBAL	17.71 s [17.71 s, 17.71 s]	2.164 s (13.9%)
profiling	15.2 s [15.2 s, 15.2 s]	-346.0 ms (-2.2%)
tracing	15.039 s [15.039 s, 15.039 s]	-507.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.457 s [15.457 s, 15.457 s]	-
appsec	15.013 s [15.013 s, 15.013 s]	-444.0 ms (-2.9%)
iast	18.926 s [18.926 s, 18.926 s]	3.469 s (22.4%)
iast_GLOBAL	18.054 s [18.054 s, 18.054 s]	2.597 s (16.8%)
profiling	15.765 s [15.765 s, 15.765 s]	308.0 ms (2.0%)
tracing	14.951 s [14.951 s, 14.951 s]	-506.0 ms (-3.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c917eacde1, baseline=1.36.0-SNAPSHOT~d19ceac03e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.451 ms) : 1440, 1463
.   : milestone, 1451,
appsec (2.193 ms) : 2160, 2227
.   : milestone, 2193,
iast (1.953 ms) : 1912, 1994
.   : milestone, 1953,
iast_GLOBAL (1.994 ms) : 1953, 2035
.   : milestone, 1994,
profiling (1.851 ms) : 1817, 1884
.   : milestone, 1851,
tracing (1.819 ms) : 1787, 1851
.   : milestone, 1819,
section candidate
no_agent (1.452 ms) : 1441, 1464
.   : milestone, 1452,
appsec (2.187 ms) : 2154, 2221
.   : milestone, 2187,
iast (1.953 ms) : 1912, 1993
.   : milestone, 1953,
iast_GLOBAL (2.0 ms) : 1959, 2042
.   : milestone, 2000,
profiling (1.836 ms) : 1803, 1869
.   : milestone, 1836,
tracing (1.816 ms) : 1784, 1848
.   : milestone, 1816,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.451 ms [1.44 ms, 1.463 ms]	-
appsec	2.193 ms [2.16 ms, 2.227 ms]	741.701 µs (51.1%)
iast	1.953 ms [1.912 ms, 1.994 ms]	501.787 µs (34.6%)
iast_GLOBAL	1.994 ms [1.953 ms, 2.035 ms]	542.526 µs (37.4%)
profiling	1.851 ms [1.817 ms, 1.884 ms]	399.514 µs (27.5%)
tracing	1.819 ms [1.787 ms, 1.851 ms]	367.401 µs (25.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.452 ms [1.441 ms, 1.464 ms]	-
appsec	2.187 ms [2.154 ms, 2.221 ms]	735.036 µs (50.6%)
iast	1.953 ms [1.912 ms, 1.993 ms]	500.344 µs (34.5%)
iast_GLOBAL	2.0 ms [1.959 ms, 2.042 ms]	548.003 µs (37.7%)
profiling	1.836 ms [1.803 ms, 1.869 ms]	383.69 µs (26.4%)
tracing	1.816 ms [1.784 ms, 1.848 ms]	363.941 µs (25.1%)

jandro996

If we confirm that user tracking events are out of rate limiting, LGTM

manuel-alvarez-alvarez · 2024-06-27T09:32:57Z

Not required after #7221

manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label Jun 19, 2024

manuel-alvarez-alvarez marked this pull request as ready for review June 19, 2024 14:10

manuel-alvarez-alvarez requested a review from a team as a code owner June 19, 2024 14:10

manuel-alvarez-alvarez requested review from ValentinZakharov and jandro996 June 19, 2024 14:10

manuel-alvarez-alvarez commented Jun 19, 2024

View reviewed changes

smola approved these changes Jun 19, 2024

View reviewed changes

jandro996 approved these changes Jun 20, 2024

View reviewed changes

smola mentioned this pull request Jun 24, 2024

Apply appsec rate limiter on event instead of when request end #7221

Merged

manuel-alvarez-alvarez added 2 commits June 25, 2024 18:01

Ensure user tracking request headers are not rate limited

61504bc

Include signup event in request header collection

c917eac

manuel-alvarez-alvarez force-pushed the malvarez/waf-ensure-user-tracking-headers-not-rate-limited branch from 5faba30 to c917eac Compare June 25, 2024 16:02

manuel-alvarez-alvarez closed this Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ensure user tracking request headers are not rate limited #7222

Ensure user tracking request headers are not rate limited #7222

Uh oh!

manuel-alvarez-alvarez commented Jun 19, 2024 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez Jun 19, 2024

Uh oh!

pr-commenter bot commented Jun 19, 2024 •

edited

Loading

Uh oh!

jandro996 left a comment

Uh oh!

manuel-alvarez-alvarez commented Jun 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Ensure user tracking request headers are not rate limited #7222

Ensure user tracking request headers are not rate limited #7222

Uh oh!

Conversation

manuel-alvarez-alvarez commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

manuel-alvarez-alvarez Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

manuel-alvarez-alvarez commented Jun 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manuel-alvarez-alvarez commented Jun 19, 2024 •

edited

Loading

pr-commenter bot commented Jun 19, 2024 •

edited

Loading