Skip to content

Add _dd.tracer_host to local root spans #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 3 commits into from
Aug 13, 2024
Merged

Add _dd.tracer_host to local root spans #7388

amarziali merged 3 commits into from
Aug 13, 2024

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Aug 6, 2024

What Does This Do

This PR lazily adds the hostname to the tag _dd.tracer_host to every local root span.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the comp: core Tracer core label Aug 6, 2024
@amarziali amarziali marked this pull request as ready for review August 6, 2024 12:55
@amarziali amarziali requested a review from a team as a code owner August 6, 2024 12:55
@amarziali amarziali requested review from mcculls and ygree August 6, 2024 12:55
@pr-commenter
Copy link

pr-commenter bot commented Aug 6, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/remote-hostname-always
git_commit_date 1722960232 1723019783
git_commit_sha 42eee08 83ba9b1
release_version 1.39.0-SNAPSHOT~42eee0817d 1.39.0-SNAPSHOT~83ba9b1d4b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723022861 1723022861
ci_job_id 597015453 597015453
ci_pipeline_id 41081782 41081782
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.546 s) : 0, 1545957
Total [baseline] (14.348 s) : 0, 14348272
Agent [candidate] (1.548 s) : 0, 1547838
Total [candidate] (14.285 s) : 0, 14285057
section appsec
Agent [baseline] (1.732 s) : 0, 1731710
Total [baseline] (14.424 s) : 0, 14423978
Agent [candidate] (1.744 s) : 0, 1744350
Total [candidate] (14.392 s) : 0, 14391890
section iast
Agent [baseline] (1.719 s) : 0, 1719076
Total [baseline] (14.833 s) : 0, 14832860
Agent [candidate] (1.728 s) : 0, 1728429
Total [candidate] (14.964 s) : 0, 14963699
section profiling
Agent [baseline] (1.856 s) : 0, 1855609
Total [baseline] (14.648 s) : 0, 14648078
Agent [candidate] (1.859 s) : 0, 1859278
Total [candidate] (14.602 s) : 0, 14602179
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.546 s -
Agent appsec 1.732 s 185.754 ms (12.0%)
Agent iast 1.719 s 173.119 ms (11.2%)
Agent profiling 1.856 s 309.652 ms (20.0%)
Total tracing 14.348 s -
Total appsec 14.424 s 75.707 ms (0.5%)
Total iast 14.833 s 484.589 ms (3.4%)
Total profiling 14.648 s 299.806 ms (2.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.548 s -
Agent appsec 1.744 s 196.512 ms (12.7%)
Agent iast 1.728 s 180.592 ms (11.7%)
Agent profiling 1.859 s 311.44 ms (20.1%)
Total tracing 14.285 s -
Total appsec 14.392 s 106.833 ms (0.7%)
Total iast 14.964 s 678.641 ms (4.8%)
Total profiling 14.602 s 317.121 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (991.295 ms) : 0, 991295
BytebuddyAgent [candidate] (992.347 ms) : 0, 992347
GlobalTracer [baseline] (453.46 ms) : 0, 453460
GlobalTracer [candidate] (454.025 ms) : 0, 454025
AppSec [baseline] (70.716 ms) : 0, 70716
AppSec [candidate] (70.917 ms) : 0, 70917
Remote Config [baseline] (857.88 µs) : 0, 858
Remote Config [candidate] (852.73 µs) : 0, 853
Telemetry [baseline] (9.603 ms) : 0, 9603
Telemetry [candidate] (9.596 ms) : 0, 9596
section appsec
BytebuddyAgent [baseline] (1.01 s) : 0, 1009874
BytebuddyAgent [candidate] (1.017 s) : 0, 1016692
GlobalTracer [baseline] (445.865 ms) : 0, 445865
GlobalTracer [candidate] (449.798 ms) : 0, 449798
AppSec [baseline] (232.976 ms) : 0, 232976
AppSec [candidate] (234.364 ms) : 0, 234364
Remote Config [baseline] (770.75 µs) : 0, 771
Remote Config [candidate] (784.851 µs) : 0, 785
Telemetry [baseline] (9.709 ms) : 0, 9709
Telemetry [candidate] (9.913 ms) : 0, 9913
IAST [baseline] (24.853 ms) : 0, 24853
IAST [candidate] (25.018 ms) : 0, 25018
section iast
BytebuddyAgent [baseline] (1.153 s) : 0, 1153223
BytebuddyAgent [candidate] (1.161 s) : 0, 1160503
GlobalTracer [baseline] (434.399 ms) : 0, 434399
GlobalTracer [candidate] (436.753 ms) : 0, 436753
AppSec [baseline] (70.65 ms) : 0, 70650
AppSec [candidate] (69.528 ms) : 0, 69528
Remote Config [baseline] (749.576 µs) : 0, 750
Remote Config [candidate] (2.464 ms) : 0, 2464
Telemetry [baseline] (9.952 ms) : 0, 9952
Telemetry [candidate] (10.156 ms) : 0, 10156
IAST [baseline] (30.029 ms) : 0, 30029
IAST [candidate] (28.763 ms) : 0, 28763
section profiling
ProfilingAgent [baseline] (148.511 ms) : 0, 148511
ProfilingAgent [candidate] (152.142 ms) : 0, 152142
BytebuddyAgent [baseline] (985.203 ms) : 0, 985203
BytebuddyAgent [candidate] (985.554 ms) : 0, 985554
GlobalTracer [baseline] (583.796 ms) : 0, 583796
GlobalTracer [candidate] (583.381 ms) : 0, 583381
AppSec [baseline] (72.089 ms) : 0, 72089
AppSec [candidate] (72.122 ms) : 0, 72122
Remote Config [baseline] (906.461 µs) : 0, 906
Remote Config [candidate] (894.852 µs) : 0, 895
Telemetry [baseline] (9.26 ms) : 0, 9260
Telemetry [candidate] (9.274 ms) : 0, 9274
Profiling [baseline] (148.579 ms) : 0, 148579
Profiling [candidate] (152.216 ms) : 0, 152216
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.548 s) : 0, 1548010
Total [baseline] (11.794 s) : 0, 11794312
Agent [candidate] (1.56 s) : 0, 1559783
Total [candidate] (11.829 s) : 0, 11829061
section iast
Agent [baseline] (1.733 s) : 0, 1732909
Total [baseline] (12.541 s) : 0, 12541276
Agent [candidate] (1.721 s) : 0, 1721435
Total [candidate] (12.524 s) : 0, 12523934
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.725 s) : 0, 1724885
Total [baseline] (12.488 s) : 0, 12487926
Agent [candidate] (1.727 s) : 0, 1726505
Total [candidate] (12.461 s) : 0, 12460715
section iast_TELEMETRY_OFF
Agent [baseline] (1.72 s) : 0, 1720250
Total [baseline] (12.477 s) : 0, 12477022
Agent [candidate] (1.716 s) : 0, 1715576
Total [candidate] (12.483 s) : 0, 12482673
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.548 s -
Agent iast 1.733 s 184.899 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.725 s 176.876 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.72 s 172.24 ms (11.1%)
Total tracing 11.794 s -
Total iast 12.541 s 746.964 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 12.488 s 693.614 ms (5.9%)
Total iast_TELEMETRY_OFF 12.477 s 682.71 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.56 s -
Agent iast 1.721 s 161.652 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.727 s 166.722 ms (10.7%)
Agent iast_TELEMETRY_OFF 1.716 s 155.793 ms (10.0%)
Total tracing 11.829 s -
Total iast 12.524 s 694.873 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 12.461 s 631.655 ms (5.3%)
Total iast_TELEMETRY_OFF 12.483 s 653.612 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (992.17 ms) : 0, 992170
BytebuddyAgent [candidate] (1.001 s) : 0, 1001048
GlobalTracer [baseline] (454.443 ms) : 0, 454443
GlobalTracer [candidate] (456.633 ms) : 0, 456633
AppSec [baseline] (70.94 ms) : 0, 70940
AppSec [candidate] (71.267 ms) : 0, 71267
Remote Config [baseline] (850.115 µs) : 0, 850
Remote Config [candidate] (858.034 µs) : 0, 858
Telemetry [baseline] (9.588 ms) : 0, 9588
Telemetry [candidate] (9.704 ms) : 0, 9704
section iast
BytebuddyAgent [baseline] (1.164 s) : 0, 1164050
BytebuddyAgent [candidate] (1.154 s) : 0, 1154244
GlobalTracer [baseline] (437.376 ms) : 0, 437376
GlobalTracer [candidate] (434.503 ms) : 0, 434503
AppSec [baseline] (70.096 ms) : 0, 70096
AppSec [candidate] (72.616 ms) : 0, 72616
IAST [baseline] (31.216 ms) : 0, 31216
IAST [candidate] (30.116 ms) : 0, 30116
Remote Config [baseline] (752.819 µs) : 0, 753
Remote Config [candidate] (735.583 µs) : 0, 736
Telemetry [baseline] (9.143 ms) : 0, 9143
Telemetry [candidate] (9.058 ms) : 0, 9058
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.157 s) : 0, 1157205
BytebuddyAgent [candidate] (1.159 s) : 0, 1159288
GlobalTracer [baseline] (437.264 ms) : 0, 437264
GlobalTracer [candidate] (436.727 ms) : 0, 436727
AppSec [baseline] (72.558 ms) : 0, 72558
AppSec [candidate] (71.727 ms) : 0, 71727
IAST [baseline] (27.656 ms) : 0, 27656
IAST [candidate] (28.478 ms) : 0, 28478
Remote Config [baseline] (726.559 µs) : 0, 727
Remote Config [candidate] (751.709 µs) : 0, 752
Telemetry [baseline] (9.19 ms) : 0, 9190
Telemetry [candidate] (9.186 ms) : 0, 9186
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.154 s) : 0, 1154363
BytebuddyAgent [candidate] (1.149 s) : 0, 1149334
GlobalTracer [baseline] (436.488 ms) : 0, 436488
GlobalTracer [candidate] (435.185 ms) : 0, 435185
AppSec [baseline] (67.461 ms) : 0, 67461
AppSec [candidate] (68.212 ms) : 0, 68212
IAST [baseline] (31.778 ms) : 0, 31778
IAST [candidate] (32.914 ms) : 0, 32914
Remote Config [baseline] (794.723 µs) : 0, 795
Remote Config [candidate] (781.049 µs) : 0, 781
Telemetry [baseline] (9.109 ms) : 0, 9109
Telemetry [candidate] (8.957 ms) : 0, 8957
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-07T08:45:50 2024-08-07T08:52:39
git_branch master andrea.marziali/remote-hostname-always
git_commit_date 1722960232 1723019783
git_commit_sha 42eee08 83ba9b1
release_version 1.39.0-SNAPSHOT~42eee0817d 1.39.0-SNAPSHOT~83ba9b1d4b
start_time 2024-08-07T08:45:37 2024-08-07T08:52:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723021101 1723021101
ci_job_id 597015454 597015454
ci_pipeline_id 41081782 41081782
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.912 µs) : 350, 388
.   : milestone, 369,
iast (482.017 µs) : 461, 503
.   : milestone, 482,
iast_FULL (548.17 µs) : 527, 569
.   : milestone, 548,
iast_GLOBAL (506.639 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (481.931 µs) : 460, 504
.   : milestone, 482,
iast_INACTIVE (455.017 µs) : 432, 478
.   : milestone, 455,
iast_TELEMETRY_OFF (470.091 µs) : 449, 491
.   : milestone, 470,
tracing (435.746 µs) : 415, 456
.   : milestone, 436,
section candidate
no_agent (366.998 µs) : 348, 386
.   : milestone, 367,
iast (477.03 µs) : 456, 498
.   : milestone, 477,
iast_FULL (543.57 µs) : 523, 564
.   : milestone, 544,
iast_GLOBAL (498.616 µs) : 478, 519
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (475.799 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (445.834 µs) : 424, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (462.481 µs) : 442, 483
.   : milestone, 462,
tracing (437.91 µs) : 417, 458
.   : milestone, 438,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.912 µs [349.601 µs, 388.224 µs] -
iast 482.017 µs [460.741 µs, 503.293 µs] 113.104 µs (30.7%)
iast_FULL 548.17 µs [526.896 µs, 569.443 µs] 179.257 µs (48.6%)
iast_GLOBAL 506.639 µs [484.945 µs, 528.333 µs] 137.727 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 481.931 µs [460.176 µs, 503.686 µs] 113.019 µs (30.6%)
iast_INACTIVE 455.017 µs [431.908 µs, 478.126 µs] 86.105 µs (23.3%)
iast_TELEMETRY_OFF 470.091 µs [448.953 µs, 491.229 µs] 101.179 µs (27.4%)
tracing 435.746 µs [415.149 µs, 456.343 µs] 66.834 µs (18.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.998 µs [347.757 µs, 386.24 µs] -
iast 477.03 µs [456.364 µs, 497.697 µs] 110.032 µs (30.0%)
iast_FULL 543.57 µs [522.706 µs, 564.434 µs] 176.572 µs (48.1%)
iast_GLOBAL 498.616 µs [477.745 µs, 519.487 µs] 131.618 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 475.799 µs [454.504 µs, 497.095 µs] 108.801 µs (29.6%)
iast_INACTIVE 445.834 µs [424.176 µs, 467.493 µs] 78.836 µs (21.5%)
iast_TELEMETRY_OFF 462.481 µs [441.917 µs, 483.044 µs] 95.482 µs (26.0%)
tracing 437.91 µs [417.428 µs, 458.391 µs] 70.911 µs (19.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1324, 1365
.   : milestone, 1344,
appsec (1.725 ms) : 1701, 1748
.   : milestone, 1725,
appsec_no_iast (1.72 ms) : 1696, 1744
.   : milestone, 1720,
iast (1.469 ms) : 1446, 1491
.   : milestone, 1469,
profiling (1.474 ms) : 1449, 1498
.   : milestone, 1474,
tracing (1.469 ms) : 1445, 1493
.   : milestone, 1469,
section candidate
no_agent (1.339 ms) : 1319, 1360
.   : milestone, 1339,
appsec (1.695 ms) : 1670, 1719
.   : milestone, 1695,
appsec_no_iast (1.695 ms) : 1669, 1721
.   : milestone, 1695,
iast (1.488 ms) : 1465, 1510
.   : milestone, 1488,
profiling (1.489 ms) : 1464, 1513
.   : milestone, 1489,
tracing (1.448 ms) : 1424, 1472
.   : milestone, 1448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.324 ms, 1.365 ms] -
appsec 1.725 ms [1.701 ms, 1.748 ms] 380.16 µs (28.3%)
appsec_no_iast 1.72 ms [1.696 ms, 1.744 ms] 375.87 µs (28.0%)
iast 1.469 ms [1.446 ms, 1.491 ms] 124.293 µs (9.2%)
profiling 1.474 ms [1.449 ms, 1.498 ms] 129.172 µs (9.6%)
tracing 1.469 ms [1.445 ms, 1.493 ms] 124.426 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.319 ms, 1.36 ms] -
appsec 1.695 ms [1.67 ms, 1.719 ms] 355.427 µs (26.5%)
appsec_no_iast 1.695 ms [1.669 ms, 1.721 ms] 355.615 µs (26.6%)
iast 1.488 ms [1.465 ms, 1.51 ms] 148.419 µs (11.1%)
profiling 1.489 ms [1.464 ms, 1.513 ms] 149.35 µs (11.2%)
tracing 1.448 ms [1.424 ms, 1.472 ms] 108.638 µs (8.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/remote-hostname-always
git_commit_date 1722960232 1723019783
git_commit_sha 42eee08 83ba9b1
release_version 1.39.0-SNAPSHOT~42eee0817d 1.39.0-SNAPSHOT~83ba9b1d4b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723021610 1723021610
ci_job_id 597015455 597015455
ci_pipeline_id 41081782 41081782
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.428 s) : 15428000, 15428000
.   : milestone, 15428000,
appsec (15.196 s) : 15196000, 15196000
.   : milestone, 15196000,
iast (18.839 s) : 18839000, 18839000
.   : milestone, 18839000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
.   : milestone, 17998000,
profiling (15.768 s) : 15768000, 15768000
.   : milestone, 15768000,
tracing (15.204 s) : 15204000, 15204000
.   : milestone, 15204000,
section candidate
no_agent (14.847 s) : 14847000, 14847000
.   : milestone, 14847000,
appsec (15.156 s) : 15156000, 15156000
.   : milestone, 15156000,
iast (18.803 s) : 18803000, 18803000
.   : milestone, 18803000,
iast_GLOBAL (17.89 s) : 17890000, 17890000
.   : milestone, 17890000,
profiling (15.788 s) : 15788000, 15788000
.   : milestone, 15788000,
tracing (15.224 s) : 15224000, 15224000
.   : milestone, 15224000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.428 s [15.428 s, 15.428 s] -
appsec 15.196 s [15.196 s, 15.196 s] -232.0 ms (-1.5%)
iast 18.839 s [18.839 s, 18.839 s] 3.411 s (22.1%)
iast_GLOBAL 17.998 s [17.998 s, 17.998 s] 2.57 s (16.7%)
profiling 15.768 s [15.768 s, 15.768 s] 340.0 ms (2.2%)
tracing 15.204 s [15.204 s, 15.204 s] -224.0 ms (-1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.847 s [14.847 s, 14.847 s] -
appsec 15.156 s [15.156 s, 15.156 s] 309.0 ms (2.1%)
iast 18.803 s [18.803 s, 18.803 s] 3.956 s (26.6%)
iast_GLOBAL 17.89 s [17.89 s, 17.89 s] 3.043 s (20.5%)
profiling 15.788 s [15.788 s, 15.788 s] 941.0 ms (6.3%)
tracing 15.224 s [15.224 s, 15.224 s] 377.0 ms (2.5%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~83ba9b1d4b, baseline=1.39.0-SNAPSHOT~42eee0817d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.213 ms) : 2178, 2249
.   : milestone, 2213,
iast (1.961 ms) : 1919, 2003
.   : milestone, 1961,
iast_GLOBAL (1.989 ms) : 1947, 2031
.   : milestone, 1989,
profiling (1.852 ms) : 1818, 1887
.   : milestone, 1852,
tracing (1.833 ms) : 1800, 1865
.   : milestone, 1833,
section candidate
no_agent (1.456 ms) : 1445, 1468
.   : milestone, 1456,
appsec (2.216 ms) : 2181, 2252
.   : milestone, 2216,
iast (1.954 ms) : 1913, 1996
.   : milestone, 1954,
iast_GLOBAL (2.012 ms) : 1969, 2055
.   : milestone, 2012,
profiling (1.844 ms) : 1810, 1877
.   : milestone, 1844,
tracing (1.82 ms) : 1787, 1853
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.213 ms [2.178 ms, 2.249 ms] 756.947 µs (52.0%)
iast 1.961 ms [1.919 ms, 2.003 ms] 504.473 µs (34.6%)
iast_GLOBAL 1.989 ms [1.947 ms, 2.031 ms] 532.88 µs (36.6%)
profiling 1.852 ms [1.818 ms, 1.887 ms] 395.882 µs (27.2%)
tracing 1.833 ms [1.8 ms, 1.865 ms] 376.267 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.445 ms, 1.468 ms] -
appsec 2.216 ms [2.181 ms, 2.252 ms] 760.236 µs (52.2%)
iast 1.954 ms [1.913 ms, 1.996 ms] 498.313 µs (34.2%)
iast_GLOBAL 2.012 ms [1.969 ms, 2.055 ms] 555.837 µs (38.2%)
profiling 1.844 ms [1.81 ms, 1.877 ms] 387.75 µs (26.6%)
tracing 1.82 ms [1.787 ms, 1.853 ms] 363.905 µs (25.0%)

@mcculls mcculls requested a review from dougqh August 7, 2024 16:24
dougqh
dougqh reviewed Aug 7, 2024
View reviewed changes
dd-trace-core/src/main/java/datadog/trace/core/tagprocessor/RemoteHostnameAdder.java
@Override
public Map<String, Object> processTags(
Map<String, Object> unsafeTags, DDSpanContext spanContext) {
if (spanContext.getSpanId() == spanContext.getRootSpanId()) {
Copy link
Contributor

@dougqh dougqh Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice solution.
It does mean that this tag isn't usable in a tag sampling rule, but I think that's a reasonable _dd meta tags.

@amarziali amarziali merged commit d81dc14 into master Aug 13, 2024
@amarziali amarziali deleted the andrea.marziali/remote-hostname-always branch August 13, 2024 14:39
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 13, 2024
@amarziali amarziali restored the andrea.marziali/remote-hostname-always branch August 13, 2024 14:58
@mcculls mcculls mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@dougqh dougqh dougqh approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amarziali @mcculls @dougqh