Skip to content

Fix considering directory as jar file #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpbempel merged 1 commit into from
Aug 19, 2024
Merged

Fix considering directory as jar file #7459

jpbempel merged 1 commit into from
Aug 19, 2024
+7 −1

Conversation

@jpbempel
Copy link
Member

@jpbempel jpbempel commented Aug 16, 2024 •
edited by atlassian bot
Loading

What Does This Do

In some cases, extracted jar path from the CodeSource of a class can point to a directory instead of a jar file.
Now we are skipping this case to avoid having an exception trying to open it as a jar file

Motivation

Additional Notes

Contributor Checklist

Jira ticket: DEBUG-2576

@jpbempel
Fix considering directory as jar file
8ce76ab 
In some cases, extracted jar path from the CodeSource of a class
can point to a directory instead of a jar file.
Now we are skipping this case to avoid having an exception trying to
open it as a jar file
@jpbempel jpbempel requested a review from a team as a code owner August 16, 2024 15:28
@jpbempel jpbempel requested review from cimi and removed request for a team August 16, 2024 15:28
@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug Bug report and fix labels Aug 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 16, 2024

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1723822609 1723822988
end_time 2024-08-16T15:38:03 2024-08-16T15:44:22
git_branch master jpbempel/check-jarpath
git_commit_sha 529f893 8ce76ab
start_time 2024-08-16T15:36:50 2024-08-16T15:43:09
See matching parameters
Baseline Candidate
ci_job_id 607420369 607420369
ci_pipeline_id 41997771 41997771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1723822019 1723822019

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-24.770µs; +30.986µs] or [-9.613%; +12.025%]		 unstable
[-36.377µs; +46.463µs] or [-12.353%; +15.778%]		 unstable
[-47.130µs; +60.547µs] or [-15.300%; +19.655%]		 unstable
[-82.222µs; +127.760µs] or [-12.653%; +19.661%]		 same
scenario:basic same same same unstable
[-33.729µs; +46.344µs] or [-5.710%; +7.845%]		 unstable
[-178.658op/s; +178.658op/s] or [-6.968%; +6.968%]
scenario:loop unsure
[-14.418µs; -0.654µs] or [-0.139%; -0.006%]		 same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (294.482 µs) : 262, 327
.   : milestone, 294,
basic (298.244 µs) : 290, 307
.   : milestone, 298,
loop (10.504 ms) : 10486, 10522
.   : milestone, 10504,
section candidate
noprobe (299.525 µs) : 254, 345
.   : milestone, 300,
basic (301.356 µs) : 291, 311
.   : milestone, 301,
loop (10.495 ms) : 10468, 10521
.   : milestone, 10495,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 294.482 µs [262.32 µs, 326.643 µs]
basic 298.244 µs [289.69 µs, 306.797 µs]
loop 10.504 ms [10.486 ms, 10.522 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 299.525 µs [253.811 µs, 345.239 µs]
basic 301.356 µs [291.372 µs, 311.34 µs]
loop 10.495 ms [10.468 ms, 10.521 ms]

@pr-commenter
Copy link

pr-commenter bot commented Aug 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/check-jarpath
git_commit_date 1723811562 1723822019
git_commit_sha 529f893 8ce76ab
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~8ce76ab338
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723824426 1723824426
ci_job_id 607420355 607420355
ci_pipeline_id 41997771 41997771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047244
Total [baseline] (10.356 s) : 0, 10356166
Agent [candidate] (1.056 s) : 0, 1056466
Total [candidate] (10.247 s) : 0, 10247323
section appsec
Agent [baseline] (1.178 s) : 0, 1177616
Total [baseline] (10.523 s) : 0, 10523114
Agent [candidate] (1.172 s) : 0, 1172146
Total [candidate] (10.451 s) : 0, 10451376
section iast
Agent [baseline] (1.175 s) : 0, 1174714
Total [baseline] (10.817 s) : 0, 10816582
Agent [candidate] (1.193 s) : 0, 1192578
Total [candidate] (10.828 s) : 0, 10828016
section profiling
Agent [baseline] (1.249 s) : 0, 1249119
Total [baseline] (10.6 s) : 0, 10600476
Agent [candidate] (1.26 s) : 0, 1259924
Total [candidate] (10.62 s) : 0, 10619929
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.178 s 130.372 ms (12.4%)
Agent iast 1.175 s 127.47 ms (12.2%)
Agent profiling 1.249 s 201.875 ms (19.3%)
Total tracing 10.356 s -
Total appsec 10.523 s 166.948 ms (1.6%)
Total iast 10.817 s 460.416 ms (4.4%)
Total profiling 10.6 s 244.31 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.172 s 115.68 ms (10.9%)
Agent iast 1.193 s 136.112 ms (12.9%)
Agent profiling 1.26 s 203.457 ms (19.3%)
Total tracing 10.247 s -
Total appsec 10.451 s 204.053 ms (2.0%)
Total iast 10.828 s 580.692 ms (5.7%)
Total profiling 10.62 s 372.606 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.887 ms) : 0, 667887
BytebuddyAgent [candidate] (674.467 ms) : 0, 674467
GlobalTracer [baseline] (306.697 ms) : 0, 306697
GlobalTracer [candidate] (308.94 ms) : 0, 308940
AppSec [baseline] (51.103 ms) : 0, 51103
AppSec [candidate] (51.217 ms) : 0, 51217
Remote Config [baseline] (695.254 µs) : 0, 695
Remote Config [candidate] (692.046 µs) : 0, 692
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (7.588 ms) : 0, 7588
section appsec
BytebuddyAgent [baseline] (683.39 ms) : 0, 683390
BytebuddyAgent [candidate] (680.404 ms) : 0, 680404
GlobalTracer [baseline] (302.416 ms) : 0, 302416
GlobalTracer [candidate] (300.343 ms) : 0, 300343
AppSec [baseline] (158.306 ms) : 0, 158306
AppSec [candidate] (157.311 ms) : 0, 157311
Remote Config [baseline] (610.24 µs) : 0, 610
Remote Config [candidate] (599.262 µs) : 0, 599
Telemetry [baseline] (8.779 ms) : 0, 8779
Telemetry [candidate] (9.287 ms) : 0, 9287
IAST [baseline] (21.15 ms) : 0, 21150
IAST [candidate] (21.394 ms) : 0, 21394
section iast
BytebuddyAgent [baseline] (781.516 ms) : 0, 781516
BytebuddyAgent [candidate] (794.986 ms) : 0, 794986
GlobalTracer [baseline] (296.178 ms) : 0, 296178
GlobalTracer [candidate] (300.185 ms) : 0, 300185
AppSec [baseline] (52.562 ms) : 0, 52562
AppSec [candidate] (52.928 ms) : 0, 52928
Remote Config [baseline] (574.434 µs) : 0, 574
Remote Config [candidate] (617.192 µs) : 0, 617
Telemetry [baseline] (7.899 ms) : 0, 7899
Telemetry [candidate] (8.131 ms) : 0, 8131
IAST [baseline] (22.532 ms) : 0, 22532
IAST [candidate] (22.045 ms) : 0, 22045
section profiling
BytebuddyAgent [baseline] (664.428 ms) : 0, 664428
BytebuddyAgent [candidate] (673.271 ms) : 0, 673271
GlobalTracer [baseline] (392.762 ms) : 0, 392762
GlobalTracer [candidate] (392.976 ms) : 0, 392976
AppSec [baseline] (52.419 ms) : 0, 52419
AppSec [candidate] (52.751 ms) : 0, 52751
Remote Config [baseline] (679.299 µs) : 0, 679
Remote Config [candidate] (712.264 µs) : 0, 712
Telemetry [baseline] (7.397 ms) : 0, 7397
Telemetry [candidate] (7.49 ms) : 0, 7490
ProfilingAgent [baseline] (94.267 ms) : 0, 94267
ProfilingAgent [candidate] (95.087 ms) : 0, 95087
Profiling [baseline] (94.291 ms) : 0, 94291
Profiling [candidate] (95.112 ms) : 0, 95112
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053931
Total [baseline] (8.49 s) : 0, 8489594
Agent [candidate] (1.046 s) : 0, 1045722
Total [candidate] (8.49 s) : 0, 8490260
section iast
Agent [baseline] (1.176 s) : 0, 1176139
Total [baseline] (8.975 s) : 0, 8975050
Agent [candidate] (1.183 s) : 0, 1183454
Total [candidate] (9.059 s) : 0, 9058644
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178521
Total [baseline] (8.956 s) : 0, 8955864
Agent [candidate] (1.176 s) : 0, 1176422
Total [candidate] (8.96 s) : 0, 8960325
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174257
Total [baseline] (8.967 s) : 0, 8966892
Agent [candidate] (1.183 s) : 0, 1182892
Total [candidate] (9.005 s) : 0, 9004641
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.176 s 122.207 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 124.589 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.174 s 120.326 ms (11.4%)
Total tracing 8.49 s -
Total iast 8.975 s 485.457 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.956 s 466.27 ms (5.5%)
Total iast_TELEMETRY_OFF 8.967 s 477.298 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.183 s 137.733 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 130.7 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.183 s 137.17 ms (13.1%)
Total tracing 8.49 s -
Total iast 9.059 s 568.384 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 470.065 ms (5.5%)
Total iast_TELEMETRY_OFF 9.005 s 514.381 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.714 ms) : 0, 672714
BytebuddyAgent [candidate] (666.763 ms) : 0, 666763
GlobalTracer [baseline] (308.188 ms) : 0, 308188
GlobalTracer [candidate] (306.116 ms) : 0, 306116
AppSec [baseline] (51.236 ms) : 0, 51236
AppSec [candidate] (51.309 ms) : 0, 51309
Remote Config [baseline] (689.454 µs) : 0, 689
Remote Config [candidate] (681.606 µs) : 0, 682
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.414 ms) : 0, 7414
section iast
BytebuddyAgent [baseline] (783.427 ms) : 0, 783427
BytebuddyAgent [candidate] (787.625 ms) : 0, 787625
GlobalTracer [baseline] (296.4 ms) : 0, 296400
GlobalTracer [candidate] (297.509 ms) : 0, 297509
AppSec [baseline] (50.945 ms) : 0, 50945
AppSec [candidate] (54.283 ms) : 0, 54283
Remote Config [baseline] (571.708 µs) : 0, 572
Remote Config [candidate] (590.799 µs) : 0, 591
Telemetry [baseline] (8.672 ms) : 0, 8672
Telemetry [candidate] (8.009 ms) : 0, 8009
IAST [baseline] (22.663 ms) : 0, 22663
IAST [candidate] (21.887 ms) : 0, 21887
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.473 ms) : 0, 783473
BytebuddyAgent [candidate] (782.263 ms) : 0, 782263
GlobalTracer [baseline] (297.458 ms) : 0, 297458
GlobalTracer [candidate] (296.721 ms) : 0, 296721
AppSec [baseline] (50.455 ms) : 0, 50455
AppSec [candidate] (50.289 ms) : 0, 50289
Remote Config [baseline] (572.01 µs) : 0, 572
Remote Config [candidate] (588.421 µs) : 0, 588
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (8.7 ms) : 0, 8700
IAST [baseline] (25.149 ms) : 0, 25149
IAST [candidate] (24.322 ms) : 0, 24322
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (780.663 ms) : 0, 780663
BytebuddyAgent [candidate] (787.252 ms) : 0, 787252
GlobalTracer [baseline] (297.104 ms) : 0, 297104
GlobalTracer [candidate] (299.528 ms) : 0, 299528
AppSec [baseline] (53.032 ms) : 0, 53032
AppSec [candidate] (53.327 ms) : 0, 53327
Remote Config [baseline] (627.255 µs) : 0, 627
Remote Config [candidate] (616.199 µs) : 0, 616
Telemetry [baseline] (7.844 ms) : 0, 7844
Telemetry [candidate] (7.117 ms) : 0, 7117
IAST [baseline] (21.453 ms) : 0, 21453
IAST [candidate] (21.399 ms) : 0, 21399
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-16T15:37:52 2024-08-16T15:44:40
git_branch master jpbempel/check-jarpath
git_commit_date 1723811562 1723822019
git_commit_sha 529f893 8ce76ab
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~8ce76ab338
start_time 2024-08-16T15:37:39 2024-08-16T15:44:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723823423 1723823423
ci_job_id 607420358 607420358
ci_pipeline_id 41997771 41997771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.014 µs) : 345, 385
.   : milestone, 365,
iast (476.48 µs) : 455, 498
.   : milestone, 476,
iast_FULL (548.185 µs) : 526, 571
.   : milestone, 548,
iast_GLOBAL (501.333 µs) : 479, 523
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (478.753 µs) : 457, 500
.   : milestone, 479,
iast_INACTIVE (454.972 µs) : 432, 478
.   : milestone, 455,
iast_TELEMETRY_OFF (474.437 µs) : 453, 496
.   : milestone, 474,
tracing (439.423 µs) : 419, 460
.   : milestone, 439,
section candidate
no_agent (369.495 µs) : 350, 389
.   : milestone, 369,
iast (482.914 µs) : 462, 504
.   : milestone, 483,
iast_FULL (545.255 µs) : 523, 568
.   : milestone, 545,
iast_GLOBAL (506.934 µs) : 485, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (476.793 µs) : 456, 498
.   : milestone, 477,
iast_INACTIVE (452.272 µs) : 430, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (466.435 µs) : 445, 487
.   : milestone, 466,
tracing (438.913 µs) : 419, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.014 µs [345.398 µs, 384.63 µs] -
iast 476.48 µs [454.784 µs, 498.176 µs] 111.466 µs (30.5%)
iast_FULL 548.185 µs [525.818 µs, 570.552 µs] 183.171 µs (50.2%)
iast_GLOBAL 501.333 µs [479.305 µs, 523.362 µs] 136.319 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 478.753 µs [457.198 µs, 500.308 µs] 113.739 µs (31.2%)
iast_INACTIVE 454.972 µs [432.232 µs, 477.713 µs] 89.958 µs (24.6%)
iast_TELEMETRY_OFF 474.437 µs [452.954 µs, 495.92 µs] 109.423 µs (30.0%)
tracing 439.423 µs [419.114 µs, 459.731 µs] 74.408 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.495 µs [349.8 µs, 389.19 µs] -
iast 482.914 µs [461.626 µs, 504.202 µs] 113.419 µs (30.7%)
iast_FULL 545.255 µs [522.914 µs, 567.596 µs] 175.76 µs (47.6%)
iast_GLOBAL 506.934 µs [484.71 µs, 529.158 µs] 137.439 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 476.793 µs [455.74 µs, 497.846 µs] 107.298 µs (29.0%)
iast_INACTIVE 452.272 µs [430.088 µs, 474.455 µs] 82.777 µs (22.4%)
iast_TELEMETRY_OFF 466.435 µs [445.472 µs, 487.398 µs] 96.94 µs (26.2%)
tracing 438.913 µs [418.786 µs, 459.04 µs] 69.418 µs (18.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
appsec_no_iast (1.707 ms) : 1683, 1732
.   : milestone, 1707,
iast (1.475 ms) : 1453, 1498
.   : milestone, 1475,
profiling (1.477 ms) : 1452, 1501
.   : milestone, 1477,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
section candidate
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.694 ms) : 1669, 1718
.   : milestone, 1694,
appsec_no_iast (1.726 ms) : 1702, 1751
.   : milestone, 1726,
iast (1.463 ms) : 1441, 1486
.   : milestone, 1463,
profiling (1.475 ms) : 1450, 1500
.   : milestone, 1475,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.333 ms, 1.372 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 365.055 µs (27.0%)
appsec_no_iast 1.707 ms [1.683 ms, 1.732 ms] 354.757 µs (26.2%)
iast 1.475 ms [1.453 ms, 1.498 ms] 122.984 µs (9.1%)
profiling 1.477 ms [1.452 ms, 1.501 ms] 124.143 µs (9.2%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 111.842 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.357 ms] -
appsec 1.694 ms [1.669 ms, 1.718 ms] 355.367 µs (26.6%)
appsec_no_iast 1.726 ms [1.702 ms, 1.751 ms] 388.135 µs (29.0%)
iast 1.463 ms [1.441 ms, 1.486 ms] 125.289 µs (9.4%)
profiling 1.475 ms [1.45 ms, 1.5 ms] 136.67 µs (10.2%)
tracing 1.459 ms [1.434 ms, 1.483 ms] 120.825 µs (9.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/check-jarpath
git_commit_date 1723811562 1723822019
git_commit_sha 529f893 8ce76ab
release_version 1.39.0-SNAPSHOT~529f893c6a 1.39.0-SNAPSHOT~8ce76ab338
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723823938 1723823938
ci_job_id 607420360 607420360
ci_pipeline_id 41997771 41997771
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.223 ms) : 2188, 2259
.   : milestone, 2223,
iast (1.969 ms) : 1926, 2011
.   : milestone, 1969,
iast_GLOBAL (2.006 ms) : 1963, 2050
.   : milestone, 2006,
profiling (1.861 ms) : 1827, 1894
.   : milestone, 1861,
tracing (1.831 ms) : 1798, 1863
.   : milestone, 1831,
section candidate
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.217 ms) : 2182, 2252
.   : milestone, 2217,
iast (1.961 ms) : 1918, 2003
.   : milestone, 1961,
iast_GLOBAL (2.01 ms) : 1966, 2053
.   : milestone, 2010,
profiling (1.856 ms) : 1821, 1891
.   : milestone, 1856,
tracing (1.821 ms) : 1789, 1853
.   : milestone, 1821,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.223 ms [2.188 ms, 2.259 ms] 765.42 µs (52.5%)
iast 1.969 ms [1.926 ms, 2.011 ms] 510.777 µs (35.0%)
iast_GLOBAL 2.006 ms [1.963 ms, 2.05 ms] 548.526 µs (37.6%)
profiling 1.861 ms [1.827 ms, 1.894 ms] 402.758 µs (27.6%)
tracing 1.831 ms [1.798 ms, 1.863 ms] 373.01 µs (25.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.217 ms [2.182 ms, 2.252 ms] 758.128 µs (52.0%)
iast 1.961 ms [1.918 ms, 2.003 ms] 501.664 µs (34.4%)
iast_GLOBAL 2.01 ms [1.966 ms, 2.053 ms] 550.512 µs (37.7%)
profiling 1.856 ms [1.821 ms, 1.891 ms] 396.533 µs (27.2%)
tracing 1.821 ms [1.789 ms, 1.853 ms] 361.993 µs (24.8%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~8ce76ab338, baseline=1.39.0-SNAPSHOT~529f893c6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.051 s) : 15051000, 15051000
.   : milestone, 15051000,
appsec (15.122 s) : 15122000, 15122000
.   : milestone, 15122000,
iast (18.618 s) : 18618000, 18618000
.   : milestone, 18618000,
iast_GLOBAL (18.204 s) : 18204000, 18204000
.   : milestone, 18204000,
profiling (15.295 s) : 15295000, 15295000
.   : milestone, 15295000,
tracing (15.329 s) : 15329000, 15329000
.   : milestone, 15329000,
section candidate
no_agent (15.321 s) : 15321000, 15321000
.   : milestone, 15321000,
appsec (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
iast (18.935 s) : 18935000, 18935000
.   : milestone, 18935000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
.   : milestone, 17873000,
profiling (15.788 s) : 15788000, 15788000
.   : milestone, 15788000,
tracing (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.051 s [15.051 s, 15.051 s] -
appsec 15.122 s [15.122 s, 15.122 s] 71.0 ms (0.5%)
iast 18.618 s [18.618 s, 18.618 s] 3.567 s (23.7%)
iast_GLOBAL 18.204 s [18.204 s, 18.204 s] 3.153 s (20.9%)
profiling 15.295 s [15.295 s, 15.295 s] 244.0 ms (1.6%)
tracing 15.329 s [15.329 s, 15.329 s] 278.0 ms (1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.321 s [15.321 s, 15.321 s] -
appsec 15.183 s [15.183 s, 15.183 s] -138.0 ms (-0.9%)
iast 18.935 s [18.935 s, 18.935 s] 3.614 s (23.6%)
iast_GLOBAL 17.873 s [17.873 s, 17.873 s] 2.552 s (16.7%)
profiling 15.788 s [15.788 s, 15.788 s] 467.0 ms (3.0%)
tracing 15.03 s [15.03 s, 15.03 s] -291.0 ms (-1.9%)

cimi
cimi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@cimi cimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@jpbempel jpbempel merged commit 26bee84 into master Aug 19, 2024
@jpbempel jpbempel deleted the jpbempel/check-jarpath branch August 19, 2024 07:06
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cimi cimi cimi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jpbempel @cimi