Free AppSecRequestContext resources when the request ends #7535

manuel-alvarez-alvarez · 2024-08-30T13:48:23Z

What Does This Do

Free all retained data structures by the AppSecRequestContext when the request ends.

Motivation

When the span holding the reference to the AppSecRequestContext is in pending state, there is a lot of data retained by AppSec (headers, cookies, addresses...) that are no longer required as they have already being flushed to the span. The only catch is for the cases were additional post processing is required (e.g. API security).

Additional Notes

Screenshots with the retained sizes of AppSecRequestContext:
Before

After

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
~~[ ] Update the public documentation in case of new configuration flag or behavior~~

smola · 2024-08-30T13:57:44Z

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java


  /* Should be accessible from the modules */

+  public void close(boolean requiresPostProcessing) {


Just for the record, since I was initially confused by this. This post processing currently does not happen in any case, but eventually will: #6923

pr-commenter · 2024-08-30T14:25:37Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/appsec-free-memmory
git_commit_date	1725033924	1725040009
git_commit_sha	`e024c38`	`d1aac21`
release_version	1.39.0-SNAPSHOT~e024c381c7	1.39.0-SNAPSHOT~d1aac21e0a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725042311	1725042311
ci_job_id	623406122	623406122
ci_pipeline_id	43283290	43283290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057900
Total [baseline] (10.415 s) : 0, 10415255
Agent [candidate] (1.052 s) : 0, 1052203
Total [candidate] (10.404 s) : 0, 10404385
section appsec
Agent [baseline] (1.183 s) : 0, 1182546
Total [baseline] (10.554 s) : 0, 10553581
Agent [candidate] (1.181 s) : 0, 1181433
Total [candidate] (10.549 s) : 0, 10549442
section iast
Agent [baseline] (1.193 s) : 0, 1192666
Total [baseline] (10.877 s) : 0, 10877049
Agent [candidate] (1.192 s) : 0, 1192178
Total [candidate] (10.817 s) : 0, 10816704
section profiling
Agent [baseline] (1.252 s) : 0, 1251884
Total [baseline] (10.637 s) : 0, 10637099
Agent [candidate] (1.267 s) : 0, 1267213
Total [candidate] (10.647 s) : 0, 10647430

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.183 s	124.646 ms (11.8%)
Agent	iast	1.193 s	134.766 ms (12.7%)
Agent	profiling	1.252 s	193.984 ms (18.3%)
Total	tracing	10.415 s	-
Total	appsec	10.554 s	138.326 ms (1.3%)
Total	iast	10.877 s	461.795 ms (4.4%)
Total	profiling	10.637 s	221.844 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	appsec	1.181 s	129.23 ms (12.3%)
Agent	iast	1.192 s	139.975 ms (13.3%)
Agent	profiling	1.267 s	215.01 ms (20.4%)
Total	tracing	10.404 s	-
Total	appsec	10.549 s	145.058 ms (1.4%)
Total	iast	10.817 s	412.319 ms (4.0%)
Total	profiling	10.647 s	243.045 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.07 ms) : 0, 674070
BytebuddyAgent [candidate] (670.518 ms) : 0, 670518
GlobalTracer [baseline] (309.093 ms) : 0, 309093
GlobalTracer [candidate] (307.562 ms) : 0, 307562
AppSec [baseline] (52.868 ms) : 0, 52868
AppSec [candidate] (52.393 ms) : 0, 52393
Remote Config [baseline] (680.493 µs) : 0, 680
Remote Config [candidate] (668.379 µs) : 0, 668
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.473 ms) : 0, 7473
section appsec
BytebuddyAgent [baseline] (687.993 ms) : 0, 687993
BytebuddyAgent [candidate] (688.586 ms) : 0, 688586
GlobalTracer [baseline] (300.47 ms) : 0, 300470
GlobalTracer [candidate] (300.137 ms) : 0, 300137
AppSec [baseline] (161.309 ms) : 0, 161309
AppSec [candidate] (159.679 ms) : 0, 159679
Remote Config [baseline] (610.599 µs) : 0, 611
Remote Config [candidate] (609.589 µs) : 0, 610
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (7.563 ms) : 0, 7563
IAST [baseline] (20.998 ms) : 0, 20998
IAST [candidate] (22.543 ms) : 0, 22543
section iast
BytebuddyAgent [baseline] (792.706 ms) : 0, 792706
BytebuddyAgent [candidate] (793.304 ms) : 0, 793304
GlobalTracer [baseline] (300.633 ms) : 0, 300633
GlobalTracer [candidate] (299.802 ms) : 0, 299802
AppSec [baseline] (53.116 ms) : 0, 53116
AppSec [candidate] (52.956 ms) : 0, 52956
Remote Config [baseline] (597.817 µs) : 0, 598
Remote Config [candidate] (588.979 µs) : 0, 589
Telemetry [baseline] (7.419 ms) : 0, 7419
Telemetry [candidate] (7.35 ms) : 0, 7350
IAST [baseline] (24.382 ms) : 0, 24382
IAST [candidate] (24.391 ms) : 0, 24391
section profiling
BytebuddyAgent [baseline] (665.775 ms) : 0, 665775
BytebuddyAgent [candidate] (674.026 ms) : 0, 674026
GlobalTracer [baseline] (390.517 ms) : 0, 390517
GlobalTracer [candidate] (394.163 ms) : 0, 394163
AppSec [baseline] (53.023 ms) : 0, 53023
AppSec [candidate] (53.611 ms) : 0, 53611
Remote Config [baseline] (677.823 µs) : 0, 678
Remote Config [candidate] (694.928 µs) : 0, 695
Telemetry [baseline] (7.367 ms) : 0, 7367
Telemetry [candidate] (7.482 ms) : 0, 7482
ProfilingAgent [baseline] (96.649 ms) : 0, 96649
ProfilingAgent [candidate] (98.837 ms) : 0, 98837
Profiling [baseline] (96.672 ms) : 0, 96672
Profiling [candidate] (98.86 ms) : 0, 98860

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052381
Total [baseline] (8.517 s) : 0, 8516699
Agent [candidate] (1.054 s) : 0, 1053561
Total [candidate] (8.496 s) : 0, 8496036
section iast
Agent [baseline] (1.175 s) : 0, 1174639
Total [baseline] (8.982 s) : 0, 8982027
Agent [candidate] (1.183 s) : 0, 1182530
Total [candidate] (8.968 s) : 0, 8968333
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178641
Total [baseline] (8.998 s) : 0, 8998236
Agent [candidate] (1.176 s) : 0, 1176470
Total [candidate] (8.949 s) : 0, 8948685
section iast_TELEMETRY_OFF
Agent [baseline] (1.179 s) : 0, 1179464
Total [baseline] (9.012 s) : 0, 9011798
Agent [candidate] (1.179 s) : 0, 1179272
Total [candidate] (8.987 s) : 0, 8987400

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	iast	1.175 s	122.259 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	126.26 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.179 s	127.083 ms (12.1%)
Total	tracing	8.517 s	-
Total	iast	8.982 s	465.328 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.998 s	481.538 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.012 s	495.099 ms (5.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.183 s	128.969 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	122.909 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.179 s	125.711 ms (11.9%)
Total	tracing	8.496 s	-
Total	iast	8.968 s	472.298 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	8.949 s	452.649 ms (5.3%)
Total	iast_TELEMETRY_OFF	8.987 s	491.364 ms (5.8%)

gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.578 ms) : 0, 670578
BytebuddyAgent [candidate] (671.706 ms) : 0, 671706
GlobalTracer [baseline] (307.84 ms) : 0, 307840
GlobalTracer [candidate] (307.706 ms) : 0, 307706
AppSec [baseline] (52.255 ms) : 0, 52255
AppSec [candidate] (52.357 ms) : 0, 52357
Remote Config [baseline] (684.893 µs) : 0, 685
Remote Config [candidate] (667.834 µs) : 0, 668
Telemetry [baseline] (7.418 ms) : 0, 7418
Telemetry [candidate] (7.504 ms) : 0, 7504
section iast
BytebuddyAgent [baseline] (780.456 ms) : 0, 780456
BytebuddyAgent [candidate] (785.608 ms) : 0, 785608
GlobalTracer [baseline] (296.214 ms) : 0, 296214
GlobalTracer [candidate] (298.389 ms) : 0, 298389
AppSec [baseline] (52.733 ms) : 0, 52733
AppSec [candidate] (54.187 ms) : 0, 54187
IAST [baseline] (22.885 ms) : 0, 22885
IAST [candidate] (22.728 ms) : 0, 22728
Remote Config [baseline] (596.344 µs) : 0, 596
Remote Config [candidate] (590.189 µs) : 0, 590
Telemetry [baseline] (8.128 ms) : 0, 8128
Telemetry [candidate] (7.28 ms) : 0, 7280
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (781.877 ms) : 0, 781877
BytebuddyAgent [candidate] (781.411 ms) : 0, 781411
GlobalTracer [baseline] (298.286 ms) : 0, 298286
GlobalTracer [candidate] (296.749 ms) : 0, 296749
AppSec [baseline] (51.267 ms) : 0, 51267
AppSec [candidate] (52.424 ms) : 0, 52424
IAST [baseline] (23.981 ms) : 0, 23981
IAST [candidate] (23.513 ms) : 0, 23513
Remote Config [baseline] (614.242 µs) : 0, 614
Remote Config [candidate] (586.733 µs) : 0, 587
Telemetry [baseline] (8.971 ms) : 0, 8971
Telemetry [candidate] (8.111 ms) : 0, 8111
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (783.114 ms) : 0, 783114
BytebuddyAgent [candidate] (782.702 ms) : 0, 782702
GlobalTracer [baseline] (298.368 ms) : 0, 298368
GlobalTracer [candidate] (298.267 ms) : 0, 298267
AppSec [baseline] (54.052 ms) : 0, 54052
AppSec [candidate] (53.4 ms) : 0, 53400
IAST [baseline] (22.291 ms) : 0, 22291
IAST [candidate] (21.845 ms) : 0, 21845
Remote Config [baseline] (583.713 µs) : 0, 584
Remote Config [candidate] (599.214 µs) : 0, 599
Telemetry [baseline] (7.286 ms) : 0, 7286
Telemetry [candidate] (8.709 ms) : 0, 8709

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-30T17:55:50	2024-08-30T18:02:35
git_branch	master	malvarez/appsec-free-memmory
git_commit_date	1725033924	1725040009
git_commit_sha	`e024c38`	`d1aac21`
release_version	1.39.0-SNAPSHOT~e024c381c7	1.39.0-SNAPSHOT~d1aac21e0a
start_time	2024-08-30T17:55:36	2024-08-30T18:02:22

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1725041297	1725041297
ci_job_id	623406123	623406123
ci_pipeline_id	43283290	43283290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.459 µs) : 346, 385
.   : milestone, 365,
iast (478.972 µs) : 458, 500
.   : milestone, 479,
iast_FULL (546.86 µs) : 525, 569
.   : milestone, 547,
iast_GLOBAL (499.127 µs) : 478, 521
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (471.864 µs) : 450, 494
.   : milestone, 472,
iast_INACTIVE (441.649 µs) : 421, 462
.   : milestone, 442,
iast_TELEMETRY_OFF (464.579 µs) : 442, 487
.   : milestone, 465,
tracing (434.813 µs) : 414, 455
.   : milestone, 435,
section candidate
no_agent (376.155 µs) : 354, 398
.   : milestone, 376,
iast (475.714 µs) : 454, 497
.   : milestone, 476,
iast_FULL (548.514 µs) : 527, 570
.   : milestone, 549,
iast_GLOBAL (489.758 µs) : 469, 511
.   : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (477.796 µs) : 456, 499
.   : milestone, 478,
iast_INACTIVE (441.277 µs) : 420, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (468.907 µs) : 447, 491
.   : milestone, 469,
tracing (438.91 µs) : 418, 460
.   : milestone, 439,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.459 µs [346.274 µs, 384.643 µs]	-
iast	478.972 µs [458.084 µs, 499.86 µs]	113.513 µs (31.1%)
iast_FULL	546.86 µs [525.22 µs, 568.501 µs]	181.402 µs (49.6%)
iast_GLOBAL	499.127 µs [477.685 µs, 520.569 µs]	133.668 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED	471.864 µs [449.976 µs, 493.753 µs]	106.406 µs (29.1%)
iast_INACTIVE	441.649 µs [420.811 µs, 462.488 µs]	76.191 µs (20.8%)
iast_TELEMETRY_OFF	464.579 µs [442.067 µs, 487.091 µs]	99.12 µs (27.1%)
tracing	434.813 µs [414.301 µs, 455.326 µs]	69.355 µs (19.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.155 µs [354.107 µs, 398.202 µs]	-
iast	475.714 µs [454.285 µs, 497.142 µs]	99.559 µs (26.5%)
iast_FULL	548.514 µs [527.148 µs, 569.88 µs]	172.359 µs (45.8%)
iast_GLOBAL	489.758 µs [468.768 µs, 510.749 µs]	113.604 µs (30.2%)
iast_HARDCODED_SECRET_DISABLED	477.796 µs [456.402 µs, 499.19 µs]	101.641 µs (27.0%)
iast_INACTIVE	441.277 µs [420.285 µs, 462.269 µs]	65.122 µs (17.3%)
iast_TELEMETRY_OFF	468.907 µs [446.54 µs, 491.274 µs]	92.752 µs (24.7%)
tracing	438.91 µs [417.742 µs, 460.078 µs]	62.755 µs (16.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.336 ms) : 1317, 1355
.   : milestone, 1336,
appsec (1.705 ms) : 1682, 1729
.   : milestone, 1705,
appsec_no_iast (1.714 ms) : 1690, 1737
.   : milestone, 1714,
iast (1.454 ms) : 1432, 1476
.   : milestone, 1454,
profiling (1.462 ms) : 1439, 1485
.   : milestone, 1462,
tracing (1.465 ms) : 1440, 1489
.   : milestone, 1465,
section candidate
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.706 ms) : 1682, 1731
.   : milestone, 1706,
appsec_no_iast (1.7 ms) : 1675, 1726
.   : milestone, 1700,
iast (1.468 ms) : 1446, 1490
.   : milestone, 1468,
profiling (1.47 ms) : 1447, 1492
.   : milestone, 1470,
tracing (1.462 ms) : 1438, 1486
.   : milestone, 1462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.336 ms [1.317 ms, 1.355 ms]	-
appsec	1.705 ms [1.682 ms, 1.729 ms]	368.997 µs (27.6%)
appsec_no_iast	1.714 ms [1.69 ms, 1.737 ms]	377.213 µs (28.2%)
iast	1.454 ms [1.432 ms, 1.476 ms]	117.637 µs (8.8%)
profiling	1.462 ms [1.439 ms, 1.485 ms]	125.843 µs (9.4%)
tracing	1.465 ms [1.44 ms, 1.489 ms]	128.222 µs (9.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.324 ms, 1.362 ms]	-
appsec	1.706 ms [1.682 ms, 1.731 ms]	363.302 µs (27.0%)
appsec_no_iast	1.7 ms [1.675 ms, 1.726 ms]	357.33 µs (26.6%)
iast	1.468 ms [1.446 ms, 1.49 ms]	125.16 µs (9.3%)
profiling	1.47 ms [1.447 ms, 1.492 ms]	126.564 µs (9.4%)
tracing	1.462 ms [1.438 ms, 1.486 ms]	119.095 µs (8.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/appsec-free-memmory
git_commit_date	1725033924	1725040009
git_commit_sha	`e024c38`	`d1aac21`
release_version	1.39.0-SNAPSHOT~e024c381c7	1.39.0-SNAPSHOT~d1aac21e0a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1725041962	1725041962
ci_job_id	623406124	623406124
ci_pipeline_id	43283290	43283290
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.043 s) : 15043000, 15043000
.   : milestone, 15043000,
appsec (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
iast (18.837 s) : 18837000, 18837000
.   : milestone, 18837000,
iast_GLOBAL (17.893 s) : 17893000, 17893000
.   : milestone, 17893000,
profiling (15.035 s) : 15035000, 15035000
.   : milestone, 15035000,
tracing (14.848 s) : 14848000, 14848000
.   : milestone, 14848000,
section candidate
no_agent (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
appsec (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
iast (18.702 s) : 18702000, 18702000
.   : milestone, 18702000,
iast_GLOBAL (17.657 s) : 17657000, 17657000
.   : milestone, 17657000,
profiling (15.406 s) : 15406000, 15406000
.   : milestone, 15406000,
tracing (14.974 s) : 14974000, 14974000
.   : milestone, 14974000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.043 s [15.043 s, 15.043 s]	-
appsec	15.033 s [15.033 s, 15.033 s]	-10.0 ms (-0.1%)
iast	18.837 s [18.837 s, 18.837 s]	3.794 s (25.2%)
iast_GLOBAL	17.893 s [17.893 s, 17.893 s]	2.85 s (18.9%)
profiling	15.035 s [15.035 s, 15.035 s]	-8.0 ms (-0.1%)
tracing	14.848 s [14.848 s, 14.848 s]	-195.0 ms (-1.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.261 s [15.261 s, 15.261 s]	-
appsec	15.105 s [15.105 s, 15.105 s]	-156.0 ms (-1.0%)
iast	18.702 s [18.702 s, 18.702 s]	3.441 s (22.5%)
iast_GLOBAL	17.657 s [17.657 s, 17.657 s]	2.396 s (15.7%)
profiling	15.406 s [15.406 s, 15.406 s]	145.0 ms (1.0%)
tracing	14.974 s [14.974 s, 14.974 s]	-287.0 ms (-1.9%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~d1aac21e0a, baseline=1.39.0-SNAPSHOT~e024c381c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1462, 1487
.   : milestone, 1475,
appsec (2.249 ms) : 2213, 2284
.   : milestone, 2249,
iast (1.992 ms) : 1948, 2035
.   : milestone, 1992,
iast_GLOBAL (2.015 ms) : 1971, 2058
.   : milestone, 2015,
profiling (1.884 ms) : 1849, 1919
.   : milestone, 1884,
tracing (1.858 ms) : 1824, 1892
.   : milestone, 1858,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.241 ms) : 2206, 2276
.   : milestone, 2241,
iast (1.971 ms) : 1928, 2013
.   : milestone, 1971,
iast_GLOBAL (2.021 ms) : 1978, 2065
.   : milestone, 2021,
profiling (1.879 ms) : 1844, 1913
.   : milestone, 1879,
tracing (1.858 ms) : 1824, 1891
.   : milestone, 1858,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.462 ms, 1.487 ms]	-
appsec	2.249 ms [2.213 ms, 2.284 ms]	773.846 µs (52.5%)
iast	1.992 ms [1.948 ms, 2.035 ms]	516.973 µs (35.1%)
iast_GLOBAL	2.015 ms [1.971 ms, 2.058 ms]	539.834 µs (36.6%)
profiling	1.884 ms [1.849 ms, 1.919 ms]	409.371 µs (27.8%)
tracing	1.858 ms [1.824 ms, 1.892 ms]	383.031 µs (26.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.241 ms [2.206 ms, 2.276 ms]	771.334 µs (52.5%)
iast	1.971 ms [1.928 ms, 2.013 ms]	500.862 µs (34.1%)
iast_GLOBAL	2.021 ms [1.978 ms, 2.065 ms]	551.704 µs (37.5%)
profiling	1.879 ms [1.844 ms, 1.913 ms]	409.155 µs (27.8%)
tracing	1.858 ms [1.824 ms, 1.891 ms]	388.139 µs (26.4%)

manuel-alvarez-alvarez added the comp: asm waf Application Security Management (WAF) label Aug 30, 2024

manuel-alvarez-alvarez requested review from a team as code owners August 30, 2024 13:48

manuel-alvarez-alvarez requested review from jandro996 and smola August 30, 2024 13:48

smola approved these changes Aug 30, 2024

View reviewed changes

Free AppSecRequestContext resources when the request ends

d1aac21

manuel-alvarez-alvarez force-pushed the malvarez/appsec-free-memmory branch from 64c8f77 to d1aac21 Compare August 30, 2024 17:47

manuel-alvarez-alvarez merged commit c279fa5 into master Aug 30, 2024

manuel-alvarez-alvarez deleted the malvarez/appsec-free-memmory branch August 30, 2024 19:27

PerfectSlayer added this to the 1.39.0 milestone Sep 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Free AppSecRequestContext resources when the request ends #7535

Free AppSecRequestContext resources when the request ends #7535

Uh oh!

manuel-alvarez-alvarez commented Aug 30, 2024 •

edited by smola

Loading

Uh oh!

smola Aug 30, 2024

Uh oh!

pr-commenter bot commented Aug 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		/* Should be accessible from the modules */

		public void close(boolean requiresPostProcessing) {

Free AppSecRequestContext resources when the request ends #7535

Free AppSecRequestContext resources when the request ends #7535

Uh oh!

Conversation

manuel-alvarez-alvarez commented Aug 30, 2024 • edited by smola Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

smola Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manuel-alvarez-alvarez commented Aug 30, 2024 •

edited by smola

Loading

pr-commenter bot commented Aug 30, 2024 •

edited

Loading