Skip to content

Revert "Updated ASM rules to 1.13.1 (#7536)" #7544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smola merged 1 commit into from
Sep 2, 2024
Merged

Revert "Updated ASM rules to 1.13.1 (#7536)" #7544

smola merged 1 commit into from
Sep 2, 2024

Conversation

@smola
Copy link
Member

@smola smola commented Sep 2, 2024 •
edited
Loading

What Does This Do

This reverts commit 44c20d2 (#7536).

Motivation

Rollout of the Exploit Prevention rules enabled by default is delayed.

Additional Notes

Contributor Checklist

@smola smola added tag: no release notes Changes to exclude from release notes comp: asm waf Application Security Management (WAF) labels Sep 2, 2024
@smola smola marked this pull request as ready for review September 2, 2024 06:31
@smola smola requested a review from a team as a code owner September 2, 2024 06:31
@smola smola enabled auto-merge (squash) September 2, 2024 06:50
@pr-commenter
Copy link

pr-commenter bot commented Sep 2, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/revert-7536
git_commit_date 1725257604 1725257723
git_commit_sha a977699 438a7cb
release_version 1.39.0-SNAPSHOT~a97769918c 1.39.0-SNAPSHOT~438a7cb32c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725260150 1725260150
ci_job_id 624077377 624077377
ci_pipeline_id 43336676 43336676
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059314
Total [baseline] (10.346 s) : 0, 10345766
Agent [candidate] (1.049 s) : 0, 1049102
Total [candidate] (10.36 s) : 0, 10360081
section appsec
Agent [baseline] (1.187 s) : 0, 1186571
Total [baseline] (10.624 s) : 0, 10623851
Agent [candidate] (1.186 s) : 0, 1185609
Total [candidate] (10.6 s) : 0, 10599622
section iast
Agent [baseline] (1.186 s) : 0, 1185932
Total [baseline] (10.981 s) : 0, 10980843
Agent [candidate] (1.172 s) : 0, 1171871
Total [candidate] (10.815 s) : 0, 10814519
section profiling
Agent [baseline] (1.25 s) : 0, 1249739
Total [baseline] (10.592 s) : 0, 10592219
Agent [candidate] (1.248 s) : 0, 1247844
Total [candidate] (10.611 s) : 0, 10611092
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.187 s 127.258 ms (12.0%)
Agent iast 1.186 s 126.619 ms (12.0%)
Agent profiling 1.25 s 190.425 ms (18.0%)
Total tracing 10.346 s -
Total appsec 10.624 s 278.085 ms (2.7%)
Total iast 10.981 s 635.077 ms (6.1%)
Total profiling 10.592 s 246.453 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.186 s 136.507 ms (13.0%)
Agent iast 1.172 s 122.769 ms (11.7%)
Agent profiling 1.248 s 198.742 ms (18.9%)
Total tracing 10.36 s -
Total appsec 10.6 s 239.54 ms (2.3%)
Total iast 10.815 s 454.438 ms (4.4%)
Total profiling 10.611 s 251.011 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.117 ms) : 0, 675117
BytebuddyAgent [candidate] (668.763 ms) : 0, 668763
GlobalTracer [baseline] (309.332 ms) : 0, 309332
GlobalTracer [candidate] (307.186 ms) : 0, 307186
AppSec [baseline] (52.889 ms) : 0, 52889
AppSec [candidate] (51.457 ms) : 0, 51457
Remote Config [baseline] (688.061 µs) : 0, 688
Remote Config [candidate] (669.769 µs) : 0, 670
Telemetry [baseline] (7.601 ms) : 0, 7601
Telemetry [candidate] (7.448 ms) : 0, 7448
section appsec
BytebuddyAgent [baseline] (691.262 ms) : 0, 691262
BytebuddyAgent [candidate] (691.434 ms) : 0, 691434
GlobalTracer [baseline] (301.194 ms) : 0, 301194
GlobalTracer [candidate] (301.056 ms) : 0, 301056
AppSec [baseline] (159.398 ms) : 0, 159398
AppSec [candidate] (158.995 ms) : 0, 158995
Remote Config [baseline] (615.76 µs) : 0, 616
Remote Config [candidate] (620.219 µs) : 0, 620
Telemetry [baseline] (9.58 ms) : 0, 9580
Telemetry [candidate] (8.592 ms) : 0, 8592
IAST [baseline] (21.82 ms) : 0, 21820
IAST [candidate] (22.57 ms) : 0, 22570
section iast
BytebuddyAgent [baseline] (785.556 ms) : 0, 785556
BytebuddyAgent [candidate] (779.124 ms) : 0, 779124
GlobalTracer [baseline] (300.879 ms) : 0, 300879
GlobalTracer [candidate] (295.914 ms) : 0, 295914
AppSec [baseline] (53.031 ms) : 0, 53031
AppSec [candidate] (52.82 ms) : 0, 52820
Remote Config [baseline] (604.858 µs) : 0, 605
Remote Config [candidate] (584.652 µs) : 0, 585
Telemetry [baseline] (8.343 ms) : 0, 8343
Telemetry [candidate] (8.857 ms) : 0, 8857
IAST [baseline] (23.84 ms) : 0, 23840
IAST [candidate] (20.988 ms) : 0, 20988
section profiling
BytebuddyAgent [baseline] (664.817 ms) : 0, 664817
BytebuddyAgent [candidate] (664.566 ms) : 0, 664566
GlobalTracer [baseline] (389.205 ms) : 0, 389205
GlobalTracer [candidate] (388.842 ms) : 0, 388842
AppSec [baseline] (52.938 ms) : 0, 52938
AppSec [candidate] (52.153 ms) : 0, 52153
Remote Config [baseline] (680.174 µs) : 0, 680
Remote Config [candidate] (688.47 µs) : 0, 688
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (7.386 ms) : 0, 7386
ProfilingAgent [baseline] (96.696 ms) : 0, 96696
ProfilingAgent [candidate] (96.353 ms) : 0, 96353
Profiling [baseline] (96.72 ms) : 0, 96720
Profiling [candidate] (96.377 ms) : 0, 96377
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065456
Total [baseline] (8.52 s) : 0, 8520466
Agent [candidate] (1.049 s) : 0, 1048892
Total [candidate] (8.493 s) : 0, 8493113
section iast
Agent [baseline] (1.173 s) : 0, 1172891
Total [baseline] (9.017 s) : 0, 9017152
Agent [candidate] (1.171 s) : 0, 1170965
Total [candidate] (8.968 s) : 0, 8968377
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174394
Total [baseline] (8.96 s) : 0, 8960325
Agent [candidate] (1.182 s) : 0, 1181647
Total [candidate] (8.943 s) : 0, 8942777
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1178168
Total [baseline] (8.966 s) : 0, 8966295
Agent [candidate] (1.176 s) : 0, 1176005
Total [candidate] (8.977 s) : 0, 8977426
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.173 s 107.435 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 108.938 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.178 s 112.713 ms (10.6%)
Total tracing 8.52 s -
Total iast 9.017 s 496.685 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 439.859 ms (5.2%)
Total iast_TELEMETRY_OFF 8.966 s 445.829 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.171 s 122.073 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 132.755 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.176 s 127.112 ms (12.1%)
Total tracing 8.493 s -
Total iast 8.968 s 475.264 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.943 s 449.664 ms (5.3%)
Total iast_TELEMETRY_OFF 8.977 s 484.312 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.711 ms) : 0, 679711
BytebuddyAgent [candidate] (668.832 ms) : 0, 668832
GlobalTracer [baseline] (310.852 ms) : 0, 310852
GlobalTracer [candidate] (306.787 ms) : 0, 306787
AppSec [baseline] (52.86 ms) : 0, 52860
AppSec [candidate] (51.581 ms) : 0, 51581
Remote Config [baseline] (680.692 µs) : 0, 681
Remote Config [candidate] (672.585 µs) : 0, 673
Telemetry [baseline] (7.56 ms) : 0, 7560
Telemetry [candidate] (7.454 ms) : 0, 7454
section iast
BytebuddyAgent [baseline] (779.106 ms) : 0, 779106
BytebuddyAgent [candidate] (778.193 ms) : 0, 778193
GlobalTracer [baseline] (295.733 ms) : 0, 295733
GlobalTracer [candidate] (295.203 ms) : 0, 295203
AppSec [baseline] (53.937 ms) : 0, 53937
AppSec [candidate] (52.937 ms) : 0, 52937
IAST [baseline] (21.125 ms) : 0, 21125
IAST [candidate] (23.261 ms) : 0, 23261
Remote Config [baseline] (592.394 µs) : 0, 592
Remote Config [candidate] (576.245 µs) : 0, 576
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (7.237 ms) : 0, 7237
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.242 ms) : 0, 780242
BytebuddyAgent [candidate] (785.348 ms) : 0, 785348
GlobalTracer [baseline] (295.974 ms) : 0, 295974
GlobalTracer [candidate] (298.348 ms) : 0, 298348
AppSec [baseline] (52.254 ms) : 0, 52254
AppSec [candidate] (55.228 ms) : 0, 55228
IAST [baseline] (21.996 ms) : 0, 21996
IAST [candidate] (21.025 ms) : 0, 21025
Remote Config [baseline] (602.539 µs) : 0, 603
Remote Config [candidate] (578.569 µs) : 0, 579
Telemetry [baseline] (9.676 ms) : 0, 9676
Telemetry [candidate] (7.374 ms) : 0, 7374
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.051 ms) : 0, 782051
BytebuddyAgent [candidate] (781.405 ms) : 0, 781405
GlobalTracer [baseline] (298.047 ms) : 0, 298047
GlobalTracer [candidate] (296.415 ms) : 0, 296415
AppSec [baseline] (54.911 ms) : 0, 54911
AppSec [candidate] (53.078 ms) : 0, 53078
IAST [baseline] (21.648 ms) : 0, 21648
IAST [candidate] (22.677 ms) : 0, 22677
Remote Config [baseline] (580.324 µs) : 0, 580
Remote Config [candidate] (584.888 µs) : 0, 585
Telemetry [baseline] (7.215 ms) : 0, 7215
Telemetry [candidate] (8.147 ms) : 0, 8147
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-02T06:26:26 2024-09-02T06:33:12
git_branch master smola/revert-7536
git_commit_date 1725257604 1725257723
git_commit_sha a977699 438a7cb
release_version 1.39.0-SNAPSHOT~a97769918c 1.39.0-SNAPSHOT~438a7cb32c
start_time 2024-09-02T06:26:13 2024-09-02T06:32:59
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1725259135 1725259135
ci_job_id 624077378 624077378
ci_pipeline_id 43336676 43336676
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.554 µs) : 352, 391
.   : milestone, 372,
iast (479.833 µs) : 458, 501
.   : milestone, 480,
iast_FULL (542.676 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (497.282 µs) : 477, 518
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (472.363 µs) : 451, 494
.   : milestone, 472,
iast_INACTIVE (436.466 µs) : 416, 457
.   : milestone, 436,
iast_TELEMETRY_OFF (469.303 µs) : 446, 492
.   : milestone, 469,
tracing (437.689 µs) : 417, 458
.   : milestone, 438,
section candidate
no_agent (363.029 µs) : 343, 383
.   : milestone, 363,
iast (473.161 µs) : 451, 495
.   : milestone, 473,
iast_FULL (550.862 µs) : 529, 572
.   : milestone, 551,
iast_GLOBAL (507.174 µs) : 485, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (482.075 µs) : 460, 504
.   : milestone, 482,
iast_INACTIVE (441.441 µs) : 421, 462
.   : milestone, 441,
iast_TELEMETRY_OFF (468.354 µs) : 446, 490
.   : milestone, 468,
tracing (435.271 µs) : 415, 455
.   : milestone, 435,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.554 µs [352.045 µs, 391.063 µs] -
iast 479.833 µs [458.305 µs, 501.362 µs] 108.279 µs (29.1%)
iast_FULL 542.676 µs [521.595 µs, 563.758 µs] 171.122 µs (46.1%)
iast_GLOBAL 497.282 µs [476.51 µs, 518.054 µs] 125.728 µs (33.8%)
iast_HARDCODED_SECRET_DISABLED 472.363 µs [451.216 µs, 493.51 µs] 100.809 µs (27.1%)
iast_INACTIVE 436.466 µs [415.683 µs, 457.25 µs] 64.912 µs (17.5%)
iast_TELEMETRY_OFF 469.303 µs [446.499 µs, 492.107 µs] 97.749 µs (26.3%)
tracing 437.689 µs [417.165 µs, 458.214 µs] 66.135 µs (17.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.029 µs [342.881 µs, 383.178 µs] -
iast 473.161 µs [450.908 µs, 495.414 µs] 110.131 µs (30.3%)
iast_FULL 550.862 µs [529.478 µs, 572.246 µs] 187.833 µs (51.7%)
iast_GLOBAL 507.174 µs [485.376 µs, 528.972 µs] 144.145 µs (39.7%)
iast_HARDCODED_SECRET_DISABLED 482.075 µs [460.045 µs, 504.106 µs] 119.046 µs (32.8%)
iast_INACTIVE 441.441 µs [421.202 µs, 461.68 µs] 78.412 µs (21.6%)
iast_TELEMETRY_OFF 468.354 µs [446.314 µs, 490.394 µs] 105.325 µs (29.0%)
tracing 435.271 µs [415.264 µs, 455.278 µs] 72.242 µs (19.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1351
.   : milestone, 1332,
appsec (1.726 ms) : 1702, 1749
.   : milestone, 1726,
appsec_no_iast (1.715 ms) : 1691, 1740
.   : milestone, 1715,
iast (1.48 ms) : 1458, 1502
.   : milestone, 1480,
profiling (1.469 ms) : 1446, 1492
.   : milestone, 1469,
tracing (1.446 ms) : 1423, 1470
.   : milestone, 1446,
section candidate
no_agent (1.332 ms) : 1313, 1352
.   : milestone, 1332,
appsec (1.723 ms) : 1700, 1746
.   : milestone, 1723,
appsec_no_iast (1.705 ms) : 1680, 1729
.   : milestone, 1705,
iast (1.47 ms) : 1448, 1493
.   : milestone, 1470,
profiling (1.47 ms) : 1447, 1493
.   : milestone, 1470,
tracing (1.443 ms) : 1418, 1469
.   : milestone, 1443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.312 ms, 1.351 ms] -
appsec 1.726 ms [1.702 ms, 1.749 ms] 394.006 µs (29.6%)
appsec_no_iast 1.715 ms [1.691 ms, 1.74 ms] 383.816 µs (28.8%)
iast 1.48 ms [1.458 ms, 1.502 ms] 148.709 µs (11.2%)
profiling 1.469 ms [1.446 ms, 1.492 ms] 137.278 µs (10.3%)
tracing 1.446 ms [1.423 ms, 1.47 ms] 114.595 µs (8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.352 ms] -
appsec 1.723 ms [1.7 ms, 1.746 ms] 390.679 µs (29.3%)
appsec_no_iast 1.705 ms [1.68 ms, 1.729 ms] 372.234 µs (27.9%)
iast 1.47 ms [1.448 ms, 1.493 ms] 137.939 µs (10.4%)
profiling 1.47 ms [1.447 ms, 1.493 ms] 137.357 µs (10.3%)
tracing 1.443 ms [1.418 ms, 1.469 ms] 111.091 µs (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/revert-7536
git_commit_date 1725257604 1725257723
git_commit_sha a977699 438a7cb
release_version 1.39.0-SNAPSHOT~a97769918c 1.39.0-SNAPSHOT~438a7cb32c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1725259646 1725259646
ci_job_id 624077379 624077379
ci_pipeline_id 43336676 43336676
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.574 s) : 15574000, 15574000
.   : milestone, 15574000,
appsec (15.243 s) : 15243000, 15243000
.   : milestone, 15243000,
iast (18.964 s) : 18964000, 18964000
.   : milestone, 18964000,
iast_GLOBAL (17.967 s) : 17967000, 17967000
.   : milestone, 17967000,
profiling (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
tracing (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
section candidate
no_agent (15.29 s) : 15290000, 15290000
.   : milestone, 15290000,
appsec (15.168 s) : 15168000, 15168000
.   : milestone, 15168000,
iast (18.979 s) : 18979000, 18979000
.   : milestone, 18979000,
iast_GLOBAL (17.665 s) : 17665000, 17665000
.   : milestone, 17665000,
profiling (15.215 s) : 15215000, 15215000
.   : milestone, 15215000,
tracing (14.785 s) : 14785000, 14785000
.   : milestone, 14785000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.574 s [15.574 s, 15.574 s] -
appsec 15.243 s [15.243 s, 15.243 s] -331.0 ms (-2.1%)
iast 18.964 s [18.964 s, 18.964 s] 3.39 s (21.8%)
iast_GLOBAL 17.967 s [17.967 s, 17.967 s] 2.393 s (15.4%)
profiling 15.146 s [15.146 s, 15.146 s] -428.0 ms (-2.7%)
tracing 15.03 s [15.03 s, 15.03 s] -544.0 ms (-3.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.29 s [15.29 s, 15.29 s] -
appsec 15.168 s [15.168 s, 15.168 s] -122.0 ms (-0.8%)
iast 18.979 s [18.979 s, 18.979 s] 3.689 s (24.1%)
iast_GLOBAL 17.665 s [17.665 s, 17.665 s] 2.375 s (15.5%)
profiling 15.215 s [15.215 s, 15.215 s] -75.0 ms (-0.5%)
tracing 14.785 s [14.785 s, 14.785 s] -505.0 ms (-3.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~438a7cb32c, baseline=1.39.0-SNAPSHOT~a97769918c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
.   : milestone, 1462,
appsec (2.251 ms) : 2216, 2287
.   : milestone, 2251,
iast (1.991 ms) : 1947, 2034
.   : milestone, 1991,
iast_GLOBAL (2.033 ms) : 1989, 2077
.   : milestone, 2033,
profiling (1.876 ms) : 1842, 1911
.   : milestone, 1876,
tracing (1.843 ms) : 1810, 1876
.   : milestone, 1843,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.238 ms) : 2202, 2273
.   : milestone, 2238,
iast (1.978 ms) : 1936, 2021
.   : milestone, 1978,
iast_GLOBAL (2.034 ms) : 1990, 2078
.   : milestone, 2034,
profiling (2.354 ms) : 2170, 2539
.   : milestone, 2354,
tracing (1.84 ms) : 1808, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.451 ms, 1.473 ms] -
appsec 2.251 ms [2.216 ms, 2.287 ms] 789.097 µs (54.0%)
iast 1.991 ms [1.947 ms, 2.034 ms] 528.649 µs (36.2%)
iast_GLOBAL 2.033 ms [1.989 ms, 2.077 ms] 571.101 µs (39.1%)
profiling 1.876 ms [1.842 ms, 1.911 ms] 414.399 µs (28.3%)
tracing 1.843 ms [1.81 ms, 1.876 ms] 380.878 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.238 ms [2.202 ms, 2.273 ms] 766.05 µs (52.1%)
iast 1.978 ms [1.936 ms, 2.021 ms] 506.611 µs (34.4%)
iast_GLOBAL 2.034 ms [1.99 ms, 2.078 ms] 562.253 µs (38.2%)
profiling 2.354 ms [2.17 ms, 2.539 ms] 882.854 µs (60.0%)
tracing 1.84 ms [1.808 ms, 1.872 ms] 368.558 µs (25.0%)

@smola smola merged commit 271c706 into master Sep 2, 2024
@smola smola deleted the smola/revert-7536 branch September 2, 2024 07:01
@PerfectSlayer PerfectSlayer added this to the 1.39.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

comp: asm waf Application Security Management (WAF) tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.39.0

Development

Successfully merging this pull request may close these issues.

4 participants

@smola @manuel-alvarez-alvarez @PerfectSlayer