Skip to content

Update Gradle dependencies #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 11, 2024
Merged

Update Gradle dependencies #7739

merged 11 commits into from
Oct 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 6, 2024

This PR updates the Gradle dependencies. ⚠️ Don't forget to squash commits before merging. ⚠️

@github-actions github-actions bot added tag: no release notes Changes to exclude from release notes tag: dependencies Dependencies related changes labels Oct 6, 2024
@github-actions github-actions bot requested review from a team as code owners October 6, 2024 04:15
@pr-commenter
Copy link

pr-commenter bot commented Oct 6, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ci/update-gradle-dependencies-20241006
git_commit_date 1728603041 1728642400
git_commit_sha 457c92a db60a45
release_version 1.41.0-SNAPSHOT~457c92a63c 1.41.0-SNAPSHOT~db60a45ca2
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728644921 1728644921
ci_job_id 669594766 669594766
ci_pipeline_id 46374964 46374964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066482
Total [baseline] (10.428 s) : 0, 10428168
Agent [candidate] (1.067 s) : 0, 1067158
Total [candidate] (10.354 s) : 0, 10353659
section appsec
Agent [baseline] (1.206 s) : 0, 1205805
Total [baseline] (10.538 s) : 0, 10537877
Agent [candidate] (1.201 s) : 0, 1201484
Total [candidate] (10.587 s) : 0, 10587426
section iast
Agent [baseline] (1.203 s) : 0, 1202767
Total [baseline] (10.828 s) : 0, 10827823
Agent [candidate] (1.196 s) : 0, 1195794
Total [candidate] (10.829 s) : 0, 10829323
section profiling
Agent [baseline] (1.266 s) : 0, 1266344
Total [baseline] (10.631 s) : 0, 10631088
Agent [candidate] (1.266 s) : 0, 1266332
Total [candidate] (10.522 s) : 0, 10521789
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.206 s 139.323 ms (13.1%)
Agent iast 1.203 s 136.284 ms (12.8%)
Agent profiling 1.266 s 199.861 ms (18.7%)
Total tracing 10.428 s -
Total appsec 10.538 s 109.709 ms (1.1%)
Total iast 10.828 s 399.656 ms (3.8%)
Total profiling 10.631 s 202.921 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.201 s 134.327 ms (12.6%)
Agent iast 1.196 s 128.637 ms (12.1%)
Agent profiling 1.266 s 199.175 ms (18.7%)
Total tracing 10.354 s -
Total appsec 10.587 s 233.767 ms (2.3%)
Total iast 10.829 s 475.664 ms (4.6%)
Total profiling 10.522 s 168.13 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.869 ms) : 0, 680869
BytebuddyAgent [candidate] (681.384 ms) : 0, 681384
GlobalTracer [baseline] (309.881 ms) : 0, 309881
GlobalTracer [candidate] (310.17 ms) : 0, 310170
AppSec [baseline] (53.94 ms) : 0, 53940
AppSec [candidate] (53.722 ms) : 0, 53722
Remote Config [baseline] (655.369 µs) : 0, 655
Remote Config [candidate] (663.976 µs) : 0, 664
Telemetry [baseline] (7.522 ms) : 0, 7522
Telemetry [candidate] (7.595 ms) : 0, 7595
section appsec
BytebuddyAgent [baseline] (701.866 ms) : 0, 701866
BytebuddyAgent [candidate] (698.283 ms) : 0, 698283
GlobalTracer [baseline] (307.967 ms) : 0, 307967
GlobalTracer [candidate] (306.595 ms) : 0, 306595
AppSec [baseline] (163.022 ms) : 0, 163022
AppSec [candidate] (163.047 ms) : 0, 163047
Remote Config [baseline] (645.777 µs) : 0, 646
Remote Config [candidate] (644.752 µs) : 0, 645
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.181 ms) : 0, 8181
IAST [baseline] (20.151 ms) : 0, 20151
IAST [candidate] (22.233 ms) : 0, 22233
section iast
BytebuddyAgent [baseline] (801.791 ms) : 0, 801791
BytebuddyAgent [candidate] (797.036 ms) : 0, 797036
GlobalTracer [baseline] (300.501 ms) : 0, 300501
GlobalTracer [candidate] (298.937 ms) : 0, 298937
AppSec [baseline] (53.667 ms) : 0, 53667
AppSec [candidate] (54.866 ms) : 0, 54866
Remote Config [baseline] (608.337 µs) : 0, 608
Remote Config [candidate] (606.4 µs) : 0, 606
Telemetry [baseline] (7.078 ms) : 0, 7078
Telemetry [candidate] (7.036 ms) : 0, 7036
IAST [baseline] (25.374 ms) : 0, 25374
IAST [candidate] (23.686 ms) : 0, 23686
section profiling
ProfilingAgent [baseline] (96.711 ms) : 0, 96711
ProfilingAgent [candidate] (96.378 ms) : 0, 96378
BytebuddyAgent [baseline] (675.506 ms) : 0, 675506
BytebuddyAgent [candidate] (675.654 ms) : 0, 675654
GlobalTracer [baseline] (392.861 ms) : 0, 392861
GlobalTracer [candidate] (392.939 ms) : 0, 392939
AppSec [baseline] (54.653 ms) : 0, 54653
AppSec [candidate] (54.671 ms) : 0, 54671
Remote Config [baseline] (661.615 µs) : 0, 662
Remote Config [candidate] (651.361 µs) : 0, 651
Telemetry [baseline] (7.466 ms) : 0, 7466
Telemetry [candidate] (7.429 ms) : 0, 7429
Profiling [baseline] (96.734 ms) : 0, 96734
Profiling [candidate] (96.401 ms) : 0, 96401
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070001
Total [baseline] (8.541 s) : 0, 8541333
Agent [candidate] (1.064 s) : 0, 1063959
Total [candidate] (8.525 s) : 0, 8524678
section iast
Agent [baseline] (1.194 s) : 0, 1194295
Total [baseline] (9.081 s) : 0, 9080588
Agent [candidate] (1.201 s) : 0, 1201037
Total [candidate] (9.087 s) : 0, 9086617
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.201 s) : 0, 1200504
Total [baseline] (9.042 s) : 0, 9042362
Agent [candidate] (1.199 s) : 0, 1199150
Total [candidate] (9.101 s) : 0, 9100780
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1188442
Total [baseline] (9.07 s) : 0, 9069693
Agent [candidate] (1.188 s) : 0, 1188456
Total [candidate] (9.067 s) : 0, 9067232
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.07 s -
Agent iast 1.194 s 124.295 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 130.504 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.188 s 118.442 ms (11.1%)
Total tracing 8.541 s -
Total iast 9.081 s 539.255 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.042 s 501.029 ms (5.9%)
Total iast_TELEMETRY_OFF 9.07 s 528.359 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.201 s 137.078 ms (12.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 135.19 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.188 s 124.497 ms (11.7%)
Total tracing 8.525 s -
Total iast 9.087 s 561.939 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.101 s 576.103 ms (6.8%)
Total iast_TELEMETRY_OFF 9.067 s 542.555 ms (6.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.746 ms) : 0, 683746
BytebuddyAgent [candidate] (679.684 ms) : 0, 679684
GlobalTracer [baseline] (310.62 ms) : 0, 310620
GlobalTracer [candidate] (308.791 ms) : 0, 308791
AppSec [baseline] (53.673 ms) : 0, 53673
AppSec [candidate] (53.656 ms) : 0, 53656
Remote Config [baseline] (662.367 µs) : 0, 662
Remote Config [candidate] (660.437 µs) : 0, 660
Telemetry [baseline] (7.648 ms) : 0, 7648
Telemetry [candidate] (7.559 ms) : 0, 7559
section iast
BytebuddyAgent [baseline] (795.957 ms) : 0, 795957
BytebuddyAgent [candidate] (800.914 ms) : 0, 800914
GlobalTracer [baseline] (298.897 ms) : 0, 298897
GlobalTracer [candidate] (299.984 ms) : 0, 299984
AppSec [baseline] (53.961 ms) : 0, 53961
AppSec [candidate] (57.256 ms) : 0, 57256
IAST [baseline] (24.204 ms) : 0, 24204
IAST [candidate] (21.395 ms) : 0, 21395
Remote Config [baseline] (598.542 µs) : 0, 599
Remote Config [candidate] (606.387 µs) : 0, 606
Telemetry [baseline] (7.008 ms) : 0, 7008
Telemetry [candidate] (7.116 ms) : 0, 7116
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.946 ms) : 0, 800946
BytebuddyAgent [candidate] (800.97 ms) : 0, 800970
GlobalTracer [baseline] (300.041 ms) : 0, 300041
GlobalTracer [candidate] (298.685 ms) : 0, 298685
AppSec [baseline] (53.244 ms) : 0, 53244
AppSec [candidate] (54.618 ms) : 0, 54618
IAST [baseline] (25.012 ms) : 0, 25012
IAST [candidate] (22.651 ms) : 0, 22651
Remote Config [baseline] (590.904 µs) : 0, 591
Remote Config [candidate] (603.213 µs) : 0, 603
Telemetry [baseline] (6.945 ms) : 0, 6945
Telemetry [candidate] (7.818 ms) : 0, 7818
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.397 ms) : 0, 791397
BytebuddyAgent [candidate] (791.237 ms) : 0, 791237
GlobalTracer [baseline] (298.111 ms) : 0, 298111
GlobalTracer [candidate] (297.937 ms) : 0, 297937
AppSec [baseline] (56.835 ms) : 0, 56835
AppSec [candidate] (53.197 ms) : 0, 53197
IAST [baseline] (20.811 ms) : 0, 20811
IAST [candidate] (24.898 ms) : 0, 24898
Remote Config [baseline] (628.81 µs) : 0, 629
Remote Config [candidate] (607.132 µs) : 0, 607
Telemetry [baseline] (7.02 ms) : 0, 7020
Telemetry [candidate] (6.909 ms) : 0, 6909
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-11T10:39:14 2024-10-11T10:46:04
git_branch master ci/update-gradle-dependencies-20241006
git_commit_date 1728603041 1728642400
git_commit_sha 457c92a db60a45
release_version 1.41.0-SNAPSHOT~457c92a63c 1.41.0-SNAPSHOT~db60a45ca2
start_time 2024-10-11T10:39:00 2024-10-11T10:45:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1728643910 1728643910
ci_job_id 669594767 669594767
ci_pipeline_id 46374964 46374964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.715 ms) : 1692, 1739
.   : milestone, 1715,
appsec_no_iast (1.716 ms) : 1692, 1741
.   : milestone, 1716,
iast (1.49 ms) : 1468, 1513
.   : milestone, 1490,
profiling (1.5 ms) : 1476, 1524
.   : milestone, 1500,
tracing (1.464 ms) : 1439, 1489
.   : milestone, 1464,
section candidate
no_agent (1.342 ms) : 1323, 1362
.   : milestone, 1342,
appsec (1.71 ms) : 1686, 1733
.   : milestone, 1710,
appsec_no_iast (1.731 ms) : 1707, 1754
.   : milestone, 1731,
iast (1.461 ms) : 1439, 1484
.   : milestone, 1461,
profiling (1.471 ms) : 1446, 1495
.   : milestone, 1471,
tracing (1.489 ms) : 1465, 1512
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.715 ms [1.692 ms, 1.739 ms] 369.377 µs (27.4%)
appsec_no_iast 1.716 ms [1.692 ms, 1.741 ms] 370.427 µs (27.5%)
iast 1.49 ms [1.468 ms, 1.513 ms] 144.219 µs (10.7%)
profiling 1.5 ms [1.476 ms, 1.524 ms] 154.083 µs (11.4%)
tracing 1.464 ms [1.439 ms, 1.489 ms] 117.955 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.362 ms] -
appsec 1.71 ms [1.686 ms, 1.733 ms] 367.408 µs (27.4%)
appsec_no_iast 1.731 ms [1.707 ms, 1.754 ms] 388.394 µs (28.9%)
iast 1.461 ms [1.439 ms, 1.484 ms] 119.009 µs (8.9%)
profiling 1.471 ms [1.446 ms, 1.495 ms] 128.54 µs (9.6%)
tracing 1.489 ms [1.465 ms, 1.512 ms] 146.489 µs (10.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.277 µs) : 350, 391
.   : milestone, 370,
iast (486.736 µs) : 465, 508
.   : milestone, 487,
iast_FULL (555.075 µs) : 534, 576
.   : milestone, 555,
iast_GLOBAL (506.788 µs) : 485, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (479.494 µs) : 458, 501
.   : milestone, 479,
iast_INACTIVE (446.917 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (474.246 µs) : 453, 496
.   : milestone, 474,
tracing (449.451 µs) : 428, 471
.   : milestone, 449,
section candidate
no_agent (373.634 µs) : 354, 393
.   : milestone, 374,
iast (481.363 µs) : 460, 503
.   : milestone, 481,
iast_FULL (553.502 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (513.669 µs) : 491, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (486.521 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (445.585 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (474.091 µs) : 453, 496
.   : milestone, 474,
tracing (447.279 µs) : 427, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.277 µs [350.021 µs, 390.534 µs] -
iast 486.736 µs [465.306 µs, 508.165 µs] 116.458 µs (31.5%)
iast_FULL 555.075 µs [533.933 µs, 576.217 µs] 184.797 µs (49.9%)
iast_GLOBAL 506.788 µs [485.077 µs, 528.499 µs] 136.51 µs (36.9%)
iast_HARDCODED_SECRET_DISABLED 479.494 µs [458.409 µs, 500.58 µs] 109.217 µs (29.5%)
iast_INACTIVE 446.917 µs [425.938 µs, 467.897 µs] 76.64 µs (20.7%)
iast_TELEMETRY_OFF 474.246 µs [452.92 µs, 495.572 µs] 103.968 µs (28.1%)
tracing 449.451 µs [427.696 µs, 471.207 µs] 79.174 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.634 µs [354.033 µs, 393.235 µs] -
iast 481.363 µs [460.2 µs, 502.526 µs] 107.729 µs (28.8%)
iast_FULL 553.502 µs [532.311 µs, 574.693 µs] 179.868 µs (48.1%)
iast_GLOBAL 513.669 µs [490.985 µs, 536.353 µs] 140.035 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED 486.521 µs [464.997 µs, 508.045 µs] 112.887 µs (30.2%)
iast_INACTIVE 445.585 µs [424.896 µs, 466.274 µs] 71.951 µs (19.3%)
iast_TELEMETRY_OFF 474.091 µs [452.504 µs, 495.678 µs] 100.457 µs (26.9%)
tracing 447.279 µs [426.699 µs, 467.859 µs] 73.645 µs (19.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ci/update-gradle-dependencies-20241006
git_commit_date 1728603041 1728642400
git_commit_sha 457c92a db60a45
release_version 1.41.0-SNAPSHOT~457c92a63c 1.41.0-SNAPSHOT~db60a45ca2
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1728644336 1728644336
ci_job_id 669594768 669594768
ci_pipeline_id 46374964 46374964
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.102 s) : 15102000, 15102000
.   : milestone, 15102000,
appsec (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
iast (18.821 s) : 18821000, 18821000
.   : milestone, 18821000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
.   : milestone, 17988000,
profiling (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
tracing (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,
section candidate
no_agent (15.743 s) : 15743000, 15743000
.   : milestone, 15743000,
appsec (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
iast (18.984 s) : 18984000, 18984000
.   : milestone, 18984000,
iast_GLOBAL (18.041 s) : 18041000, 18041000
.   : milestone, 18041000,
profiling (15.907 s) : 15907000, 15907000
.   : milestone, 15907000,
tracing (15.269 s) : 15269000, 15269000
.   : milestone, 15269000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.102 s [15.102 s, 15.102 s] -
appsec 14.867 s [14.867 s, 14.867 s] -235.0 ms (-1.6%)
iast 18.821 s [18.821 s, 18.821 s] 3.719 s (24.6%)
iast_GLOBAL 17.988 s [17.988 s, 17.988 s] 2.886 s (19.1%)
profiling 15.082 s [15.082 s, 15.082 s] -20.0 ms (-0.1%)
tracing 15.259 s [15.259 s, 15.259 s] 157.0 ms (1.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.743 s [15.743 s, 15.743 s] -
appsec 15.136 s [15.136 s, 15.136 s] -607.0 ms (-3.9%)
iast 18.984 s [18.984 s, 18.984 s] 3.241 s (20.6%)
iast_GLOBAL 18.041 s [18.041 s, 18.041 s] 2.298 s (14.6%)
profiling 15.907 s [15.907 s, 15.907 s] 164.0 ms (1.0%)
tracing 15.269 s [15.269 s, 15.269 s] -474.0 ms (-3.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~db60a45ca2, baseline=1.41.0-SNAPSHOT~457c92a63c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.309 ms) : 2268, 2349
.   : milestone, 2309,
iast (2.049 ms) : 1999, 2100
.   : milestone, 2049,
iast_GLOBAL (2.1 ms) : 2049, 2152
.   : milestone, 2100,
profiling (1.934 ms) : 1891, 1976
.   : milestone, 1934,
tracing (1.906 ms) : 1867, 1945
.   : milestone, 1906,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.326 ms) : 2285, 2366
.   : milestone, 2326,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.103 ms) : 2051, 2155
.   : milestone, 2103,
profiling (2.371 ms) : 2136, 2606
.   : milestone, 2371,
tracing (1.905 ms) : 1866, 1943
.   : milestone, 1905,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.309 ms [2.268 ms, 2.349 ms] 844.266 µs (57.6%)
iast 2.049 ms [1.999 ms, 2.1 ms] 584.836 µs (39.9%)
iast_GLOBAL 2.1 ms [2.049 ms, 2.152 ms] 635.507 µs (43.4%)
profiling 1.934 ms [1.891 ms, 1.976 ms] 468.883 µs (32.0%)
tracing 1.906 ms [1.867 ms, 1.945 ms] 441.364 µs (30.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.326 ms [2.285 ms, 2.366 ms] 864.012 µs (59.1%)
iast 2.068 ms [2.016 ms, 2.12 ms] 606.413 µs (41.5%)
iast_GLOBAL 2.103 ms [2.051 ms, 2.155 ms] 641.351 µs (43.9%)
profiling 2.371 ms [2.136 ms, 2.606 ms] 909.318 µs (62.2%)
tracing 1.905 ms [1.866 ms, 1.943 ms] 443.095 µs (30.3%)

@PerfectSlayer PerfectSlayer mentioned this pull request Oct 7, 2024
Closed
@vandonr
Copy link
Contributor

vandonr commented Oct 9, 2024

I updated the mongo server version that we use to run the tests, because the latest client uses a new wire version to talk to it, so we need a server that can understand wire version 7.
I used the latest of the oldest currently supported versions:
https://www.mongodb.com/docs/manual/release-notes/5.0/#std-label-release-notes-5.0
v4.x and below are at end-of-life.

@vandonr
Copy link
Contributor

vandonr commented Oct 9, 2024

Release 5.2.0 of the java client includes this PR which adds an extra parameter to a method we instrumented, shifting the position of the argument we were relying on.

amarziali
amarziali previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amarziali amarziali dismissed their stale review October 9, 2024 18:37

Hit button by error

@vandonr
Copy link
Contributor

vandonr commented Oct 11, 2024 •
edited
Loading

using the server image v5 changes how the client spans look for the v4.3 of the client only I think 🤔 (tests on v4.10 pass and on v4.0.1 pass as well).
For now I used the version 4 of the server which seems to fit all, but in the future I don't know how we want to deal with that. Can we say that it's a known bug, and given the narrow version range, ask customers to upgrade their mongo client if it causes them trouble ?

@vandonr vandonr merged commit eadf0cc into master Oct 11, 2024
104 checks passed
@vandonr vandonr deleted the ci/update-gradle-dependencies-20241006 branch October 11, 2024 13:40
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 11, 2024
jordan-wong pushed a commit that referenced this pull request Oct 11, 2024
@github-actions @vandonr @jordan-wong
Update Gradle dependencies (#7739)
bf4a3b1 
* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* chore: Update Gradle dependencies

* update mongo container used to run tests against

* apply advice to method with new parameter ordering

* downgrade server image to v4 because v5 causes issues with tests on client 4.3

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raphaël Vandon <raphael.vandon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amarziali amarziali amarziali approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez was automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 was automatically assigned from DataDog/asm-java

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees

No one assigned

Labels

tag: dependencies Dependencies related changes tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.41.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vandonr @amarziali