-
Notifications
You must be signed in to change notification settings - Fork 324
Ignore timeouts on closing elasticmq for sqs tests #7765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069208
Total [baseline] (8.57 s) : 0, 8570109
Agent [candidate] (1.068 s) : 0, 1067559
Total [candidate] (8.57 s) : 0, 8570448
section iast
Agent [baseline] (1.194 s) : 0, 1194314
Total [baseline] (9.174 s) : 0, 9174496
Agent [candidate] (1.195 s) : 0, 1195264
Total [candidate] (9.101 s) : 0, 9101200
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1204937
Total [baseline] (9.111 s) : 0, 9111002
Agent [candidate] (1.195 s) : 0, 1194530
Total [candidate] (9.112 s) : 0, 9111746
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1200411
Total [baseline] (9.089 s) : 0, 9088683
Agent [candidate] (1.216 s) : 0, 1216393
Total [candidate] (9.146 s) : 0, 9146360
gantt
title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.685 ms) : 0, 682685
BytebuddyAgent [candidate] (680.175 ms) : 0, 680175
GlobalTracer [baseline] (311.062 ms) : 0, 311062
GlobalTracer [candidate] (311.613 ms) : 0, 311613
AppSec [baseline] (53.626 ms) : 0, 53626
AppSec [candidate] (53.908 ms) : 0, 53908
Remote Config [baseline] (671.919 µs) : 0, 672
Remote Config [candidate] (667.562 µs) : 0, 668
Telemetry [baseline] (7.546 ms) : 0, 7546
Telemetry [candidate] (7.553 ms) : 0, 7553
section iast
BytebuddyAgent [baseline] (795.699 ms) : 0, 795699
BytebuddyAgent [candidate] (796.452 ms) : 0, 796452
GlobalTracer [baseline] (299.245 ms) : 0, 299245
GlobalTracer [candidate] (299.144 ms) : 0, 299144
AppSec [baseline] (54.591 ms) : 0, 54591
AppSec [candidate] (54.038 ms) : 0, 54038
IAST [baseline] (23.486 ms) : 0, 23486
IAST [candidate] (24.291 ms) : 0, 24291
Remote Config [baseline] (607.71 µs) : 0, 608
Remote Config [candidate] (610.352 µs) : 0, 610
Telemetry [baseline] (7.05 ms) : 0, 7050
Telemetry [candidate] (7.036 ms) : 0, 7036
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.108 ms) : 0, 803108
BytebuddyAgent [candidate] (795.687 ms) : 0, 795687
GlobalTracer [baseline] (301.505 ms) : 0, 301505
GlobalTracer [candidate] (299.468 ms) : 0, 299468
AppSec [baseline] (57.346 ms) : 0, 57346
AppSec [candidate] (55.238 ms) : 0, 55238
IAST [baseline] (21.346 ms) : 0, 21346
IAST [candidate] (22.726 ms) : 0, 22726
Remote Config [baseline] (626.56 µs) : 0, 627
Remote Config [candidate] (611.07 µs) : 0, 611
Telemetry [baseline] (7.2 ms) : 0, 7200
Telemetry [candidate] (7.078 ms) : 0, 7078
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.198 ms) : 0, 799198
BytebuddyAgent [candidate] (809.965 ms) : 0, 809965
GlobalTracer [baseline] (301.47 ms) : 0, 301470
GlobalTracer [candidate] (305.39 ms) : 0, 305390
AppSec [baseline] (54.253 ms) : 0, 54253
AppSec [candidate] (55.077 ms) : 0, 55077
IAST [baseline] (24.168 ms) : 0, 24168
IAST [candidate] (24.346 ms) : 0, 24346
Remote Config [baseline] (612.374 µs) : 0, 612
Remote Config [candidate] (639.513 µs) : 0, 640
Telemetry [baseline] (6.925 ms) : 0, 6925
Telemetry [candidate] (6.998 ms) : 0, 6998
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068866
Total [baseline] (10.398 s) : 0, 10398024
Agent [candidate] (1.069 s) : 0, 1069140
Total [candidate] (10.467 s) : 0, 10467396
section appsec
Agent [baseline] (1.204 s) : 0, 1204217
Total [baseline] (10.6 s) : 0, 10600488
Agent [candidate] (1.206 s) : 0, 1205551
Total [candidate] (10.623 s) : 0, 10623251
section iast
Agent [baseline] (1.198 s) : 0, 1197783
Total [baseline] (10.874 s) : 0, 10873978
Agent [candidate] (1.207 s) : 0, 1207242
Total [candidate] (10.903 s) : 0, 10902694
section profiling
Agent [baseline] (1.275 s) : 0, 1274945
Total [baseline] (10.663 s) : 0, 10662666
Agent [candidate] (1.267 s) : 0, 1266903
Total [candidate] (10.688 s) : 0, 10688284
gantt
title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.735 ms) : 0, 681735
BytebuddyAgent [candidate] (682.117 ms) : 0, 682117
GlobalTracer [baseline] (311.288 ms) : 0, 311288
GlobalTracer [candidate] (311.123 ms) : 0, 311123
AppSec [baseline] (53.965 ms) : 0, 53965
AppSec [candidate] (54.012 ms) : 0, 54012
Remote Config [baseline] (682.443 µs) : 0, 682
Remote Config [candidate] (666.726 µs) : 0, 667
Telemetry [baseline] (7.577 ms) : 0, 7577
Telemetry [candidate] (7.567 ms) : 0, 7567
section appsec
BytebuddyAgent [baseline] (699.887 ms) : 0, 699887
BytebuddyAgent [candidate] (699.491 ms) : 0, 699491
GlobalTracer [baseline] (308.271 ms) : 0, 308271
GlobalTracer [candidate] (309.171 ms) : 0, 309171
AppSec [baseline] (162.997 ms) : 0, 162997
AppSec [candidate] (162.623 ms) : 0, 162623
Remote Config [baseline] (633.355 µs) : 0, 633
Remote Config [candidate] (641.273 µs) : 0, 641
Telemetry [baseline] (7.357 ms) : 0, 7357
Telemetry [candidate] (9.202 ms) : 0, 9202
IAST [baseline] (22.892 ms) : 0, 22892
IAST [candidate] (21.547 ms) : 0, 21547
section iast
BytebuddyAgent [baseline] (798.119 ms) : 0, 798119
BytebuddyAgent [candidate] (804.741 ms) : 0, 804741
GlobalTracer [baseline] (300.257 ms) : 0, 300257
GlobalTracer [candidate] (302.07 ms) : 0, 302070
AppSec [baseline] (56.792 ms) : 0, 56792
AppSec [candidate] (55.108 ms) : 0, 55108
Remote Config [baseline] (610.363 µs) : 0, 610
Remote Config [candidate] (622.701 µs) : 0, 623
Telemetry [baseline] (7.143 ms) : 0, 7143
Telemetry [candidate] (7.162 ms) : 0, 7162
IAST [baseline] (21.218 ms) : 0, 21218
IAST [candidate] (23.746 ms) : 0, 23746
section profiling
BytebuddyAgent [baseline] (680.344 ms) : 0, 680344
BytebuddyAgent [candidate] (674.655 ms) : 0, 674655
GlobalTracer [baseline] (396.225 ms) : 0, 396225
GlobalTracer [candidate] (394.556 ms) : 0, 394556
AppSec [baseline] (54.913 ms) : 0, 54913
AppSec [candidate] (54.261 ms) : 0, 54261
Remote Config [baseline] (664.308 µs) : 0, 664
Remote Config [candidate] (656.968 µs) : 0, 657
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.362 ms) : 0, 7362
ProfilingAgent [baseline] (96.493 ms) : 0, 96493
ProfilingAgent [candidate] (96.803 ms) : 0, 96803
Profiling [baseline] (96.517 ms) : 0, 96517
Profiling [candidate] (96.827 ms) : 0, 96827
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
. : milestone, 1345,
appsec (1.725 ms) : 1701, 1749
. : milestone, 1725,
appsec_no_iast (1.708 ms) : 1683, 1732
. : milestone, 1708,
iast (1.485 ms) : 1462, 1509
. : milestone, 1485,
profiling (1.494 ms) : 1469, 1519
. : milestone, 1494,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
section candidate
no_agent (1.343 ms) : 1324, 1362
. : milestone, 1343,
appsec (1.728 ms) : 1705, 1752
. : milestone, 1728,
appsec_no_iast (1.713 ms) : 1688, 1738
. : milestone, 1713,
iast (1.481 ms) : 1459, 1504
. : milestone, 1481,
profiling (1.471 ms) : 1447, 1496
. : milestone, 1471,
tracing (1.459 ms) : 1435, 1483
. : milestone, 1459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section baseline
no_agent (370.215 µs) : 350, 390
. : milestone, 370,
iast (480.102 µs) : 459, 501
. : milestone, 480,
iast_FULL (551.018 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (502.9 µs) : 482, 524
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (483.765 µs) : 462, 505
. : milestone, 484,
iast_INACTIVE (454.378 µs) : 433, 476
. : milestone, 454,
iast_TELEMETRY_OFF (469.95 µs) : 449, 491
. : milestone, 470,
tracing (442.275 µs) : 422, 463
. : milestone, 442,
section candidate
no_agent (372.67 µs) : 353, 393
. : milestone, 373,
iast (482.127 µs) : 461, 503
. : milestone, 482,
iast_FULL (550.222 µs) : 529, 572
. : milestone, 550,
iast_GLOBAL (504.535 µs) : 483, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.335 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (447.324 µs) : 427, 468
. : milestone, 447,
iast_TELEMETRY_OFF (468.187 µs) : 447, 489
. : milestone, 468,
tracing (447.304 µs) : 427, 468
. : milestone, 447,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1482
. : milestone, 1470,
appsec (2.321 ms) : 2281, 2362
. : milestone, 2321,
iast (2.063 ms) : 2011, 2115
. : milestone, 2063,
iast_GLOBAL (2.103 ms) : 2052, 2154
. : milestone, 2103,
profiling (1.929 ms) : 1888, 1971
. : milestone, 1929,
tracing (1.908 ms) : 1869, 1948
. : milestone, 1908,
section candidate
no_agent (1.463 ms) : 1452, 1474
. : milestone, 1463,
appsec (2.316 ms) : 2275, 2356
. : milestone, 2316,
iast (2.063 ms) : 2011, 2114
. : milestone, 2063,
iast_GLOBAL (2.105 ms) : 2054, 2156
. : milestone, 2105,
profiling (1.936 ms) : 1893, 1978
. : milestone, 1936,
tracing (1.917 ms) : 1877, 1956
. : milestone, 1917,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~8bc495a57b, baseline=1.41.0-SNAPSHOT~ee74fe9b64
dateFormat X
axisFormat %s
section baseline
no_agent (15.528 s) : 15528000, 15528000
. : milestone, 15528000,
appsec (15.203 s) : 15203000, 15203000
. : milestone, 15203000,
iast (18.914 s) : 18914000, 18914000
. : milestone, 18914000,
iast_GLOBAL (18.228 s) : 18228000, 18228000
. : milestone, 18228000,
profiling (15.845 s) : 15845000, 15845000
. : milestone, 15845000,
tracing (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
section candidate
no_agent (15.474 s) : 15474000, 15474000
. : milestone, 15474000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.66 s) : 18660000, 18660000
. : milestone, 18660000,
iast_GLOBAL (18.027 s) : 18027000, 18027000
. : milestone, 18027000,
profiling (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
tracing (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
|
vandonr
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Ignore exceptions on closing the elasticmq sqs server used in tests
That should happen when the test class shuts down
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]