-
Notifications
You must be signed in to change notification settings - Fork 322
🍒 Avoid race conditions on feature discovery during Writer creation #9177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PerfectSlayer
merged 3 commits into
release/v1.51.x
from
daniel.mohedano/backport-pr-9173
Jul 15, 2025
Merged
🍒 Avoid race conditions on feature discovery during Writer creation #9177
PerfectSlayer
merged 3 commits into
release/v1.51.x
from
daniel.mohedano/backport-pr-9173
Jul 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
approved these changes
Jul 15, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.704 ms) : 0, 996704
Total [baseline] (8.604 s) : 0, 8604354
Agent [candidate] (995.676 ms) : 0, 995676
Total [candidate] (8.546 s) : 0, 8546133
section iast
Agent [baseline] (1.127 s) : 0, 1126932
Total [baseline] (9.259 s) : 0, 9258771
Agent [candidate] (1.137 s) : 0, 1137224
Total [candidate] (9.277 s) : 0, 9276975
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.878 ms) : 0, 687878
BytebuddyAgent [candidate] (687.379 ms) : 0, 687379
GlobalTracer [baseline] (242.249 ms) : 0, 242249
GlobalTracer [candidate] (242.304 ms) : 0, 242304
AppSec [baseline] (30.812 ms) : 0, 30812
AppSec [candidate] (30.355 ms) : 0, 30355
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (5.95 ms) : 0, 5950
Remote Config [baseline] (677.28 µs) : 0, 677
Remote Config [candidate] (680.814 µs) : 0, 681
Telemetry [baseline] (8.28 ms) : 0, 8280
Telemetry [candidate] (8.237 ms) : 0, 8237
section iast
BytebuddyAgent [baseline] (802.553 ms) : 0, 802553
BytebuddyAgent [candidate] (811.675 ms) : 0, 811675
GlobalTracer [baseline] (231.671 ms) : 0, 231671
GlobalTracer [candidate] (232.409 ms) : 0, 232409
IAST [baseline] (26.359 ms) : 0, 26359
IAST [candidate] (27.221 ms) : 0, 27221
AppSec [baseline] (30.627 ms) : 0, 30627
AppSec [candidate] (30.827 ms) : 0, 30827
Debugger [baseline] (6.553 ms) : 0, 6553
Debugger [candidate] (5.753 ms) : 0, 5753
Remote Config [baseline] (601.825 µs) : 0, 602
Remote Config [candidate] (589.496 µs) : 0, 589
Telemetry [baseline] (7.869 ms) : 0, 7869
Telemetry [candidate] (7.955 ms) : 0, 7955
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (992.556 ms) : 0, 992556
Total [baseline] (10.586 s) : 0, 10585598
Agent [candidate] (994.343 ms) : 0, 994343
Total [candidate] (10.578 s) : 0, 10577854
section appsec
Agent [baseline] (1.171 s) : 0, 1170542
Total [baseline] (10.738 s) : 0, 10737899
Agent [candidate] (1.174 s) : 0, 1174095
Total [candidate] (10.727 s) : 0, 10727330
section iast
Agent [baseline] (1.142 s) : 0, 1142136
Total [baseline] (10.899 s) : 0, 10898674
Agent [candidate] (1.134 s) : 0, 1133688
Total [candidate] (10.808 s) : 0, 10807532
section profiling
Agent [baseline] (1.254 s) : 0, 1254332
Total [baseline] (11.025 s) : 0, 11024929
Agent [candidate] (1.259 s) : 0, 1259389
Total [candidate] (10.983 s) : 0, 10983257
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.125 ms) : 0, 685125
BytebuddyAgent [candidate] (686.39 ms) : 0, 686390
GlobalTracer [baseline] (241.343 ms) : 0, 241343
GlobalTracer [candidate] (241.943 ms) : 0, 241943
AppSec [baseline] (30.456 ms) : 0, 30456
AppSec [candidate] (30.361 ms) : 0, 30361
Debugger [baseline] (5.946 ms) : 0, 5946
Debugger [candidate] (5.977 ms) : 0, 5977
Remote Config [baseline] (684.024 µs) : 0, 684
Remote Config [candidate] (672.201 µs) : 0, 672
Telemetry [baseline] (8.21 ms) : 0, 8210
Telemetry [candidate] (8.225 ms) : 0, 8225
section appsec
BytebuddyAgent [baseline] (706.949 ms) : 0, 706949
BytebuddyAgent [candidate] (710.168 ms) : 0, 710168
GlobalTracer [baseline] (234.4 ms) : 0, 234400
GlobalTracer [candidate] (234.531 ms) : 0, 234531
IAST [baseline] (23.35 ms) : 0, 23350
IAST [candidate] (23.292 ms) : 0, 23292
AppSec [baseline] (170.761 ms) : 0, 170761
AppSec [candidate] (170.892 ms) : 0, 170892
Debugger [baseline] (5.677 ms) : 0, 5677
Debugger [candidate] (5.695 ms) : 0, 5695
Remote Config [baseline] (590.142 µs) : 0, 590
Remote Config [candidate] (596.603 µs) : 0, 597
Telemetry [baseline] (7.935 ms) : 0, 7935
Telemetry [candidate] (8.044 ms) : 0, 8044
section iast
BytebuddyAgent [baseline] (813.396 ms) : 0, 813396
BytebuddyAgent [candidate] (807.883 ms) : 0, 807883
GlobalTracer [baseline] (234.934 ms) : 0, 234934
GlobalTracer [candidate] (232.459 ms) : 0, 232459
IAST [baseline] (29.018 ms) : 0, 29018
IAST [candidate] (26.211 ms) : 0, 26211
AppSec [baseline] (29.552 ms) : 0, 29552
AppSec [candidate] (32.051 ms) : 0, 32051
Debugger [baseline] (5.761 ms) : 0, 5761
Debugger [candidate] (5.777 ms) : 0, 5777
Remote Config [baseline] (589.575 µs) : 0, 590
Remote Config [candidate] (579.524 µs) : 0, 580
Telemetry [baseline] (7.96 ms) : 0, 7960
Telemetry [candidate] (7.907 ms) : 0, 7907
section profiling
BytebuddyAgent [baseline] (685.032 ms) : 0, 685032
BytebuddyAgent [candidate] (687.65 ms) : 0, 687650
GlobalTracer [baseline] (363.048 ms) : 0, 363048
GlobalTracer [candidate] (363.723 ms) : 0, 363723
AppSec [baseline] (33.471 ms) : 0, 33471
AppSec [candidate] (34.3 ms) : 0, 34300
Debugger [baseline] (10.535 ms) : 0, 10535
Debugger [candidate] (9.742 ms) : 0, 9742
Remote Config [baseline] (660.298 µs) : 0, 660
Remote Config [candidate] (667.504 µs) : 0, 668
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (8.836 ms) : 0, 8836
ProfilingAgent [baseline] (103.683 ms) : 0, 103683
ProfilingAgent [candidate] (105.172 ms) : 0, 105172
Profiling [baseline] (103.707 ms) : 0, 103707
Profiling [candidate] (105.196 ms) : 0, 105196
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section baseline
no_agent (36.524 ms) : 36234, 36814
. : milestone, 36524,
appsec (45.116 ms) : 44710, 45522
. : milestone, 45116,
code_origins (44.566 ms) : 44170, 44961
. : milestone, 44566,
iast (45.784 ms) : 45380, 46188
. : milestone, 45784,
profiling (48.467 ms) : 48049, 48884
. : milestone, 48467,
tracing (42.773 ms) : 42420, 43125
. : milestone, 42773,
section candidate
no_agent (37.211 ms) : 36910, 37511
. : milestone, 37211,
appsec (47.501 ms) : 47085, 47918
. : milestone, 47501,
code_origins (44.645 ms) : 44276, 45013
. : milestone, 44645,
iast (44.407 ms) : 44013, 44800
. : milestone, 44407,
profiling (47.668 ms) : 47211, 48125
. : milestone, 47668,
tracing (42.057 ms) : 41706, 42409
. : milestone, 42057,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section baseline
no_agent (4.352 ms) : 4303, 4402
. : milestone, 4352,
iast (9.294 ms) : 9144, 9443
. : milestone, 9294,
iast_FULL (14.131 ms) : 13849, 14412
. : milestone, 14131,
iast_GLOBAL (9.908 ms) : 9738, 10078
. : milestone, 9908,
profiling (8.536 ms) : 8405, 8666
. : milestone, 8536,
tracing (7.304 ms) : 7196, 7412
. : milestone, 7304,
section candidate
no_agent (4.724 ms) : 4668, 4780
. : milestone, 4724,
iast (9.549 ms) : 9387, 9711
. : milestone, 9549,
iast_FULL (14.009 ms) : 13725, 14293
. : milestone, 14009,
iast_GLOBAL (10.373 ms) : 10189, 10558
. : milestone, 10373,
profiling (8.626 ms) : 8490, 8762
. : milestone, 8626,
tracing (7.354 ms) : 7253, 7455
. : milestone, 7354,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section baseline
no_agent (15.535 s) : 15535000, 15535000
. : milestone, 15535000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (18.403 s) : 18403000, 18403000
. : milestone, 18403000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
. : milestone, 17936000,
profiling (15.649 s) : 15649000, 15649000
. : milestone, 15649000,
tracing (14.667 s) : 14667000, 14667000
. : milestone, 14667000,
section candidate
no_agent (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
appsec (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
iast (18.66 s) : 18660000, 18660000
. : milestone, 18660000,
iast_GLOBAL (17.918 s) : 17918000, 17918000
. : milestone, 17918000,
profiling (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
tracing (14.675 s) : 14675000, 14675000
. : milestone, 14675000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~99c1f20afa, baseline=1.52.0-SNAPSHOT~b86f4f70d6
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.42 ms) : 2370, 2470
. : milestone, 2420,
iast (2.213 ms) : 2151, 2276
. : milestone, 2213,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.052 ms) : 2001, 2102
. : milestone, 2052,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
section candidate
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (2.423 ms) : 2373, 2473
. : milestone, 2423,
iast (2.205 ms) : 2142, 2267
. : milestone, 2205,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.044 ms) : 1993, 2094
. : milestone, 2044,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 16, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [app.cash.tempest:tempest-bom](https://github.com/cashapp/tempest) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2025.07.08.171526-e297588` -> `2025.07.15.155806-c1415e3` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `6.97.0` -> `6.97.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.51.0` -> `1.51.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.97.1`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6971-2025-07-15) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#​3992](googleapis/java-spanner#3992)) ([69ffd72](googleapis/java-spanner@69ffd72)) - Update googleapis/sdk-platform-java action to v2.60.1 ([#​3926](googleapis/java-spanner#3926)) ([7001b7f](googleapis/java-spanner@7001b7f)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.1): 1.51.1 ### Components #### Application Security Management (WAF) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9172](DataDog/dd-trace-java#9172) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Tracer core - 🐛 Avoid race conditions on feature discovery ([#​9175](DataDog/dd-trace-java#9175), [#​9177](DataDog/dd-trace-java#9177) - [@​daniel-mohedano](https://github.com/daniel-mohedano), [@​amarziali](https://github.com/amarziali) ) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.788`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112788-2025-07-11) [Compare Source](aws/aws-sdk-java@1.12.787...1.12.788) #### **AWS SDK for Java** - ### Features - Add account endpoint caching #### **Amazon DynamoDB** - ### Features - Cache account endpoint URIs </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 27a8b093249f74e7c13544759c5baf5d1acdc371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9173 to release/v1.51.x