Base HttpServerTest and updated Netty test #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbenson
force-pushed
the
tyler/http-server-testing
branch
from
9a961ae to
f77b4fa
Compare
tylerbenson
force-pushed
the
tyler/http-server-testing
branch
from
f77b4fa to
c1ec277
Compare
randomanderson
approved these changes
Jul 26, 2019
Contributor
randomanderson
left a comment
randomanderson
left a comment
There was a problem hiding this comment.
This pull request is 3 changes:
- Extracting the common gradle dependecies. 👍 . Over time, or in a separate pull request, we can update the other .gradle files
- Changing
fireChannelReadspan to be in scope. Not knowledgeable enough about netty to comment - The base server test. This is a great start. The methods that each server test needs to implement are minimal. One possible change might be to enforce the
ServerAdviceinstrumentation at compile time somehow. Not sure how possible it is, but I can definitely see myself forgetting to create theInstrumenter. The comment next to the failing test does help.
My biggest gripe is that so much code is duplicated between the two netty instrumentations. e.g. the two versions of HttpServerRequestTracingHandler are identical except they import a different version of AttributeKeys. Many changes here are the same exact +/- lines done twice. However, I would classify removing the duplication as "instrumentation cleanup" outside of the scope of this pull request.
Contributor
Author
|
Thanks for the summary. I didn't originally have #1 in here, but it was needed to have instrumentation in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes change to netty instrumentation so
fireChannelReadis also called "in scope".