-
Notifications
You must be signed in to change notification settings - Fork 323
Refactored assumeTrue to @IgnoreIf.
#9369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored assumeTrue to @IgnoreIf.
#9369
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: fc530fb | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056387
Total [baseline] (8.629 s) : 0, 8628872
Agent [candidate] (1.053 s) : 0, 1052520
Total [candidate] (8.645 s) : 0, 8644648
section iast
Agent [baseline] (1.187 s) : 0, 1187048
Total [baseline] (9.325 s) : 0, 9324679
Agent [candidate] (1.19 s) : 0, 1189674
Total [candidate] (9.375 s) : 0, 9374838
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (739.066 ms) : 0, 739066
BytebuddyAgent [candidate] (736.306 ms) : 0, 736306
GlobalTracer [baseline] (244.465 ms) : 0, 244465
GlobalTracer [candidate] (243.718 ms) : 0, 243718
AppSec [baseline] (30.381 ms) : 0, 30381
AppSec [candidate] (30.316 ms) : 0, 30316
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.056 ms) : 0, 6056
Remote Config [baseline] (676.07 µs) : 0, 676
Remote Config [candidate] (665.207 µs) : 0, 665
Telemetry [baseline] (13.091 ms) : 0, 13091
Telemetry [candidate] (12.927 ms) : 0, 12927
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (856.601 ms) : 0, 856601
BytebuddyAgent [candidate] (859.083 ms) : 0, 859083
GlobalTracer [baseline] (234.497 ms) : 0, 234497
GlobalTracer [candidate] (235.451 ms) : 0, 235451
IAST [baseline] (28.1 ms) : 0, 28100
IAST [candidate] (31.363 ms) : 0, 31363
AppSec [baseline] (28.526 ms) : 0, 28526
AppSec [candidate] (24.757 ms) : 0, 24757
Debugger [baseline] (7.627 ms) : 0, 7627
Debugger [candidate] (7.456 ms) : 0, 7456
Remote Config [baseline] (602.274 µs) : 0, 602
Remote Config [candidate] (618.264 µs) : 0, 618
Telemetry [baseline] (8.402 ms) : 0, 8402
Telemetry [candidate] (8.389 ms) : 0, 8389
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050789
Total [baseline] (10.843 s) : 0, 10843015
Agent [candidate] (1.059 s) : 0, 1059086
Total [candidate] (10.852 s) : 0, 10852042
section appsec
Agent [baseline] (1.232 s) : 0, 1231818
Total [baseline] (10.789 s) : 0, 10788613
Agent [candidate] (1.231 s) : 0, 1230990
Total [candidate] (10.788 s) : 0, 10788324
section iast
Agent [baseline] (1.191 s) : 0, 1191355
Total [baseline] (11.036 s) : 0, 11035556
Agent [candidate] (1.193 s) : 0, 1192911
Total [candidate] (10.884 s) : 0, 10884301
section profiling
Agent [baseline] (1.201 s) : 0, 1200971
Total [baseline] (10.91 s) : 0, 10910300
Agent [candidate] (1.205 s) : 0, 1205486
Total [candidate] (10.924 s) : 0, 10924103
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (734.374 ms) : 0, 734374
BytebuddyAgent [candidate] (740.773 ms) : 0, 740773
GlobalTracer [baseline] (243.691 ms) : 0, 243691
GlobalTracer [candidate] (245.832 ms) : 0, 245832
AppSec [baseline] (30.357 ms) : 0, 30357
AppSec [candidate] (30.558 ms) : 0, 30558
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.133 ms) : 0, 6133
Remote Config [baseline] (676.091 µs) : 0, 676
Remote Config [candidate] (679.319 µs) : 0, 679
Telemetry [baseline] (13.022 ms) : 0, 13022
Telemetry [candidate] (12.497 ms) : 0, 12497
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (761.218 ms) : 0, 761218
BytebuddyAgent [candidate] (760.97 ms) : 0, 760970
GlobalTracer [baseline] (236.838 ms) : 0, 236838
GlobalTracer [candidate] (236.848 ms) : 0, 236848
IAST [baseline] (23.808 ms) : 0, 23808
IAST [candidate] (23.748 ms) : 0, 23748
AppSec [baseline] (168.513 ms) : 0, 168513
AppSec [candidate] (170.329 ms) : 0, 170329
Debugger [baseline] (7.361 ms) : 0, 7361
Debugger [candidate] (5.763 ms) : 0, 5763
Remote Config [baseline] (645.717 µs) : 0, 646
Remote Config [candidate] (626.771 µs) : 0, 627
Telemetry [baseline] (10.678 ms) : 0, 10678
Telemetry [candidate] (9.999 ms) : 0, 9999
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (859.835 ms) : 0, 859835
BytebuddyAgent [candidate] (861.142 ms) : 0, 861142
GlobalTracer [baseline] (235.949 ms) : 0, 235949
GlobalTracer [candidate] (235.472 ms) : 0, 235472
IAST [baseline] (30.7 ms) : 0, 30700
IAST [candidate] (29.041 ms) : 0, 29041
AppSec [baseline] (26.395 ms) : 0, 26395
AppSec [candidate] (28.719 ms) : 0, 28719
Debugger [baseline] (6.717 ms) : 0, 6717
Debugger [candidate] (6.697 ms) : 0, 6697
Remote Config [baseline] (628.147 µs) : 0, 628
Remote Config [candidate] (616.444 µs) : 0, 616
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (8.497 ms) : 0, 8497
section profiling
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (765.333 ms) : 0, 765333
BytebuddyAgent [candidate] (768.364 ms) : 0, 768364
GlobalTracer [baseline] (222.946 ms) : 0, 222946
GlobalTracer [candidate] (223.561 ms) : 0, 223561
AppSec [baseline] (31.213 ms) : 0, 31213
AppSec [candidate] (31.082 ms) : 0, 31082
Debugger [baseline] (6.301 ms) : 0, 6301
Debugger [candidate] (6.317 ms) : 0, 6317
Remote Config [baseline] (699.094 µs) : 0, 699
Remote Config [candidate] (701.349 µs) : 0, 701
Telemetry [baseline] (14.915 ms) : 0, 14915
Telemetry [candidate] (15.647 ms) : 0, 15647
ProfilingAgent [baseline] (108.353 ms) : 0, 108353
ProfilingAgent [candidate] (108.332 ms) : 0, 108332
Profiling [baseline] (108.998 ms) : 0, 108998
Profiling [candidate] (109.011 ms) : 0, 109011
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section baseline
no_agent (4.454 ms) : 4397, 4512
. : milestone, 4454,
iast (9.238 ms) : 9086, 9391
. : milestone, 9238,
iast_FULL (13.948 ms) : 13671, 14224
. : milestone, 13948,
iast_GLOBAL (10.085 ms) : 9910, 10260
. : milestone, 10085,
profiling (8.535 ms) : 8402, 8668
. : milestone, 8535,
tracing (7.677 ms) : 7565, 7790
. : milestone, 7677,
section candidate
no_agent (4.46 ms) : 4409, 4512
. : milestone, 4460,
iast (9.324 ms) : 9173, 9476
. : milestone, 9324,
iast_FULL (14.025 ms) : 13745, 14306
. : milestone, 14025,
iast_GLOBAL (10.152 ms) : 9977, 10327
. : milestone, 10152,
profiling (8.483 ms) : 8346, 8620
. : milestone, 8483,
tracing (7.348 ms) : 7247, 7450
. : milestone, 7348,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section baseline
no_agent (38.045 ms) : 37738, 38352
. : milestone, 38045,
appsec (47.385 ms) : 46955, 47814
. : milestone, 47385,
code_origins (45.401 ms) : 45007, 45795
. : milestone, 45401,
iast (44.272 ms) : 43900, 44644
. : milestone, 44272,
profiling (49.724 ms) : 49234, 50214
. : milestone, 49724,
tracing (44.146 ms) : 43764, 44527
. : milestone, 44146,
section candidate
no_agent (36.96 ms) : 36654, 37266
. : milestone, 36960,
appsec (49.213 ms) : 48763, 49663
. : milestone, 49213,
code_origins (45.091 ms) : 44708, 45474
. : milestone, 45091,
iast (43.452 ms) : 43090, 43814
. : milestone, 43452,
profiling (47.932 ms) : 47457, 48408
. : milestone, 47932,
tracing (41.228 ms) : 40880, 41575
. : milestone, 41228,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section baseline
no_agent (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
appsec (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
iast (18.362 s) : 18362000, 18362000
. : milestone, 18362000,
iast_GLOBAL (18.243 s) : 18243000, 18243000
. : milestone, 18243000,
profiling (15.459 s) : 15459000, 15459000
. : milestone, 15459000,
tracing (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
section candidate
no_agent (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
appsec (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
iast (17.984 s) : 17984000, 17984000
. : milestone, 17984000,
iast_GLOBAL (18.239 s) : 18239000, 18239000
. : milestone, 18239000,
profiling (15.486 s) : 15486000, 15486000
. : milestone, 15486000,
tracing (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~fc530fb508, baseline=1.53.0-SNAPSHOT~c2e8852e57
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (3.695 ms) : 3475, 3914
. : milestone, 3695,
iast (2.22 ms) : 2157, 2284
. : milestone, 2220,
iast_GLOBAL (2.253 ms) : 2189, 2317
. : milestone, 2253,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
section candidate
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (3.714 ms) : 3495, 3933
. : milestone, 3714,
iast (2.215 ms) : 2152, 2278
. : milestone, 2215,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.08 ms) : 2027, 2132
. : milestone, 2080,
tracing (2.04 ms) : 1990, 2089
. : milestone, 2040,
|
What Does This Do
Refactored
assumeTrueto@IgnoreIf.Replaced
JUnit4.AssumewithJUnit5.Assumptionswhere applicable.Motivation
assumeTrue()method to simplify migration to JUnit5.