-
Notifications
You must be signed in to change notification settings - Fork 322
Remove leftover log entry #9407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d4d6893 | Docs | Was this helpful? Give us feedback! |
| @Override | ||
| public void afterResponse(final Request<?> request, final Response<?> response) { | ||
| final Context context = request.getHandlerContext(CONTEXT_CONTEXT_KEY); | ||
| log.warn("context {}", context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we had customers complying about? it's quite an annoying log this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it come from a recent refactoring. No release done since.
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045275
Total [baseline] (10.753 s) : 0, 10753459
Agent [candidate] (1.049 s) : 0, 1049225
Total [candidate] (10.747 s) : 0, 10746948
section appsec
Agent [baseline] (1.223 s) : 0, 1223411
Total [baseline] (10.765 s) : 0, 10765465
Agent [candidate] (1.224 s) : 0, 1223679
Total [candidate] (10.761 s) : 0, 10761076
section iast
Agent [baseline] (1.182 s) : 0, 1182237
Total [baseline] (10.962 s) : 0, 10962025
Agent [candidate] (1.191 s) : 0, 1191271
Total [candidate] (10.933 s) : 0, 10932652
section profiling
Agent [baseline] (1.204 s) : 0, 1204212
Total [baseline] (10.888 s) : 0, 10888047
Agent [candidate] (1.195 s) : 0, 1194999
Total [candidate] (10.847 s) : 0, 10846818
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (731.961 ms) : 0, 731961
BytebuddyAgent [candidate] (733.514 ms) : 0, 733514
GlobalTracer [baseline] (242.346 ms) : 0, 242346
GlobalTracer [candidate] (243.564 ms) : 0, 243564
AppSec [baseline] (30.188 ms) : 0, 30188
AppSec [candidate] (30.458 ms) : 0, 30458
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.111 ms) : 0, 6111
Remote Config [baseline] (682.566 µs) : 0, 683
Remote Config [candidate] (676.251 µs) : 0, 676
Telemetry [baseline] (11.52 ms) : 0, 11520
Telemetry [candidate] (12.267 ms) : 0, 12267
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (755.35 ms) : 0, 755350
BytebuddyAgent [candidate] (755.578 ms) : 0, 755578
GlobalTracer [baseline] (235.211 ms) : 0, 235211
GlobalTracer [candidate] (235.536 ms) : 0, 235536
AppSec [baseline] (170.919 ms) : 0, 170919
AppSec [candidate] (169.932 ms) : 0, 169932
Debugger [baseline] (6.67 ms) : 0, 6670
Debugger [candidate] (6.556 ms) : 0, 6556
Remote Config [baseline] (646.627 µs) : 0, 647
Remote Config [candidate] (635.406 µs) : 0, 635
Telemetry [baseline] (8.388 ms) : 0, 8388
Telemetry [candidate] (9.239 ms) : 0, 9239
IAST [baseline] (23.616 ms) : 0, 23616
IAST [candidate] (23.554 ms) : 0, 23554
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (852.378 ms) : 0, 852378
BytebuddyAgent [candidate] (861.148 ms) : 0, 861148
GlobalTracer [baseline] (233.87 ms) : 0, 233870
GlobalTracer [candidate] (234.348 ms) : 0, 234348
AppSec [baseline] (26.318 ms) : 0, 26318
AppSec [candidate] (28.692 ms) : 0, 28692
Debugger [baseline] (6.709 ms) : 0, 6709
Debugger [candidate] (5.8 ms) : 0, 5800
Remote Config [baseline] (601.403 µs) : 0, 601
Remote Config [candidate] (611.09 µs) : 0, 611
Telemetry [baseline] (8.329 ms) : 0, 8329
Telemetry [candidate] (8.351 ms) : 0, 8351
IAST [baseline] (31.476 ms) : 0, 31476
IAST [candidate] (29.627 ms) : 0, 29627
section profiling
ProfilingAgent [baseline] (108.657 ms) : 0, 108657
ProfilingAgent [candidate] (107.84 ms) : 0, 107840
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (767.461 ms) : 0, 767461
BytebuddyAgent [candidate] (760.993 ms) : 0, 760993
GlobalTracer [baseline] (223.026 ms) : 0, 223026
GlobalTracer [candidate] (221.958 ms) : 0, 221958
AppSec [baseline] (30.243 ms) : 0, 30243
AppSec [candidate] (30.069 ms) : 0, 30069
Debugger [baseline] (6.265 ms) : 0, 6265
Debugger [candidate] (6.278 ms) : 0, 6278
Remote Config [baseline] (703.272 µs) : 0, 703
Remote Config [candidate] (702.529 µs) : 0, 703
Telemetry [baseline] (16.322 ms) : 0, 16322
Telemetry [candidate] (16.153 ms) : 0, 16153
Profiling [baseline] (109.295 ms) : 0, 109295
Profiling [candidate] (108.489 ms) : 0, 108489
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049515
Total [baseline] (8.61 s) : 0, 8610099
Agent [candidate] (1.051 s) : 0, 1051025
Total [candidate] (8.618 s) : 0, 8618041
section iast
Agent [baseline] (1.181 s) : 0, 1181181
Total [baseline] (9.29 s) : 0, 9289786
Agent [candidate] (1.18 s) : 0, 1180409
Total [candidate] (9.327 s) : 0, 9327343
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (733.418 ms) : 0, 733418
BytebuddyAgent [candidate] (734.019 ms) : 0, 734019
GlobalTracer [baseline] (243.128 ms) : 0, 243128
GlobalTracer [candidate] (244.474 ms) : 0, 244474
AppSec [baseline] (30.198 ms) : 0, 30198
AppSec [candidate] (30.251 ms) : 0, 30251
Debugger [baseline] (6.051 ms) : 0, 6051
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (667.853 µs) : 0, 668
Remote Config [candidate] (670.369 µs) : 0, 670
Telemetry [baseline] (13.595 ms) : 0, 13595
Telemetry [candidate] (13.02 ms) : 0, 13020
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (852.318 ms) : 0, 852318
BytebuddyAgent [candidate] (851.969 ms) : 0, 851969
GlobalTracer [baseline] (233.628 ms) : 0, 233628
GlobalTracer [candidate] (233.147 ms) : 0, 233147
IAST [baseline] (28.727 ms) : 0, 28727
IAST [candidate] (32.313 ms) : 0, 32313
AppSec [baseline] (28.542 ms) : 0, 28542
AppSec [candidate] (24.372 ms) : 0, 24372
Debugger [baseline] (6.618 ms) : 0, 6618
Debugger [candidate] (7.433 ms) : 0, 7433
Remote Config [baseline] (612.146 µs) : 0, 612
Remote Config [candidate] (589.442 µs) : 0, 589
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.224 ms) : 0, 8224
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section baseline
no_agent (4.443 ms) : 4393, 4493
. : milestone, 4443,
iast (9.41 ms) : 9254, 9565
. : milestone, 9410,
iast_FULL (13.957 ms) : 13679, 14235
. : milestone, 13957,
iast_GLOBAL (10.299 ms) : 10103, 10495
. : milestone, 10299,
profiling (8.68 ms) : 8551, 8810
. : milestone, 8680,
tracing (7.513 ms) : 7407, 7619
. : milestone, 7513,
section candidate
no_agent (4.57 ms) : 4519, 4621
. : milestone, 4570,
iast (9.424 ms) : 9273, 9575
. : milestone, 9424,
iast_FULL (13.893 ms) : 13616, 14171
. : milestone, 13893,
iast_GLOBAL (10.468 ms) : 10283, 10654
. : milestone, 10468,
profiling (9.164 ms) : 9016, 9313
. : milestone, 9164,
tracing (7.628 ms) : 7509, 7746
. : milestone, 7628,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section baseline
no_agent (37.908 ms) : 37604, 38211
. : milestone, 37908,
appsec (48.9 ms) : 48460, 49340
. : milestone, 48900,
code_origins (45.232 ms) : 44839, 45626
. : milestone, 45232,
iast (44.043 ms) : 43673, 44414
. : milestone, 44043,
profiling (49.579 ms) : 49078, 50080
. : milestone, 49579,
tracing (45.596 ms) : 45192, 45999
. : milestone, 45596,
section candidate
no_agent (36.895 ms) : 36600, 37189
. : milestone, 36895,
appsec (48.375 ms) : 47953, 48797
. : milestone, 48375,
code_origins (45.992 ms) : 45595, 46388
. : milestone, 45992,
iast (45.976 ms) : 45586, 46366
. : milestone, 45976,
profiling (47.433 ms) : 47021, 47846
. : milestone, 47433,
tracing (43.757 ms) : 43397, 44117
. : milestone, 43757,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section baseline
no_agent (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
appsec (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
iast (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
iast_GLOBAL (17.803 s) : 17803000, 17803000
. : milestone, 17803000,
profiling (15.537 s) : 15537000, 15537000
. : milestone, 15537000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
section candidate
no_agent (14.652 s) : 14652000, 14652000
. : milestone, 14652000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.305 s) : 18305000, 18305000
. : milestone, 18305000,
iast_GLOBAL (18.198 s) : 18198000, 18198000
. : milestone, 18198000,
profiling (15.287 s) : 15287000, 15287000
. : milestone, 15287000,
tracing (15.088 s) : 15088000, 15088000
. : milestone, 15088000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4d689380a, baseline=1.53.0-SNAPSHOT~69196fa409
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.66 ms) : 3441, 3878
. : milestone, 3660,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.244 ms) : 2180, 2307
. : milestone, 2244,
profiling (2.065 ms) : 2012, 2117
. : milestone, 2065,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.472 ms) : 2419, 2526
. : milestone, 2472,
iast (2.192 ms) : 2129, 2255
. : milestone, 2192,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.04 ms) : 1990, 2091
. : milestone, 2040,
tracing (2.012 ms) : 1963, 2061
. : milestone, 2012,
|
What Does This Do
Clean up leftover log entry
Motivation
Remove refactoring debugging logs
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]