Skip to content

Increase flare reporter smoke test duration #9452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexeyKuznetsov-DD merged 4 commits into from
Sep 3, 2025
Merged

Increase flare reporter smoke test duration #9452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f837f1
Initial smoke tests for tracer flare functionality
Aug 29, 2025
2f8c79e
Replace naive wait with file watching
Sep 2, 2025
84e5026
Increase TracerFlare smoke test time
Sep 2, 2025
d8ad90c
Merge branch 'master' into mattalp/baseline-flarereporter-smoketesting
Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...atadog/profiling/agent/ProfilerFlare.java → ...rofiling/agent/ProfilerFlareReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
import java.util.Map;
import java.util.zip.ZipOutputStream;

public final class ProfilerFlare implements TracerFlare.Reporter {
private static final ProfilerFlare INSTANCE = new ProfilerFlare();
public final class ProfilerFlareReporter implements TracerFlare.Reporter {
private static final ProfilerFlareReporter INSTANCE = new ProfilerFlareReporter();
private static Exception profilerInitializationException;

public static void register() {
Expand Down
6 changes: 3 additions & 3 deletions dd-java-agent/agent-profiling/src/main/java/com/datadog/profiling/agent/ProfilingAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public static synchronized boolean run(final boolean earlyStart, Instrumentation

// Register the profiler flare before we start the profiling system, but early during the
// profiler lifecycle
ProfilerFlare.register();
ProfilerFlareReporter.register();

boolean startForceFirst =
Platform.isNativeImage()
Expand Down Expand Up @@ -176,11 +176,11 @@ public static synchronized boolean run(final boolean earlyStart, Instrumentation
// a detailed telemetry message has been sent from the attempts to enable the controllers
// -----------------------------------------------------------------------------------------
// but we do want to report this within the profiler flare
ProfilerFlare.reportInitializationException(e);
ProfilerFlareReporter.reportInitializationException(e);
} catch (final ConfigurationException e) {
log.warn("Failed to initialize profiling agent! {}", e.getMessage());
log.debug(SEND_TELEMETRY, "Failed to initialize profiling agent!", e);
ProfilerFlare.reportInitializationException(e);
ProfilerFlareReporter.reportInitializationException(e);
}
}
return false;
Expand Down
6 changes: 4 additions & 2 deletions dd-smoke-tests/tracer-flare/src/test/groovy/datadog/smoketest/TracerFlareSmokeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ import java.util.zip.ZipInputStream
*/
class TracerFlareSmokeTest extends AbstractSmokeTest {

// Time in seconds after which flare is triggered
private static final int FLARE_TRIGGER_SECONDS = 15

// Time in seconds after which flare is triggered.
// We delay the profiler start on Oracle JDK 8, so increase the wait time to at least 20s.
private static final int FLARE_TRIGGER_SECONDS = 20
// Number of processes to run in parallel for testing
private static final int NUMBER_OF_PROCESSES = 2

Expand Down
Loading