-
Notifications
You must be signed in to change notification settings - Fork 324
Wider exception check in AWS sdk v1 tests #9492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added the error that caused the flake as an acceptable error for the test also relaxed the check on the text of the SdkClientException on AI suggestion.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057792
Total [baseline] (8.642 s) : 0, 8641654
Agent [candidate] (1.051 s) : 0, 1050881
Total [candidate] (8.628 s) : 0, 8627801
section iast
Agent [baseline] (1.176 s) : 0, 1175870
Total [baseline] (9.374 s) : 0, 9373862
Agent [candidate] (1.176 s) : 0, 1175797
Total [candidate] (9.362 s) : 0, 9362286
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (740.931 ms) : 0, 740931
BytebuddyAgent [candidate] (736.592 ms) : 0, 736592
GlobalTracer [baseline] (243.258 ms) : 0, 243258
GlobalTracer [candidate] (243.363 ms) : 0, 243363
AppSec [baseline] (30.271 ms) : 0, 30271
AppSec [candidate] (30.118 ms) : 0, 30118
Debugger [baseline] (6.086 ms) : 0, 6086
Debugger [candidate] (6.073 ms) : 0, 6073
Remote Config [baseline] (704.758 µs) : 0, 705
Remote Config [candidate] (688.233 µs) : 0, 688
Telemetry [baseline] (13.887 ms) : 0, 13887
Telemetry [candidate] (11.469 ms) : 0, 11469
section iast
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (848.691 ms) : 0, 848691
BytebuddyAgent [candidate] (848.775 ms) : 0, 848775
GlobalTracer [baseline] (231.959 ms) : 0, 231959
GlobalTracer [candidate] (231.936 ms) : 0, 231936
AppSec [baseline] (25.367 ms) : 0, 25367
AppSec [candidate] (25.204 ms) : 0, 25204
Debugger [baseline] (6.725 ms) : 0, 6725
Debugger [candidate] (7.499 ms) : 0, 7499
Remote Config [baseline] (613.564 µs) : 0, 614
Remote Config [candidate] (604.719 µs) : 0, 605
Telemetry [baseline] (8.183 ms) : 0, 8183
Telemetry [candidate] (8.185 ms) : 0, 8185
IAST [baseline] (31.862 ms) : 0, 31862
IAST [candidate] (31.181 ms) : 0, 31181
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051071
Total [baseline] (10.709 s) : 0, 10708858
Agent [candidate] (1.055 s) : 0, 1055413
Total [candidate] (10.691 s) : 0, 10691218
section appsec
Agent [baseline] (1.222 s) : 0, 1221750
Total [baseline] (10.76 s) : 0, 10759910
Agent [candidate] (1.223 s) : 0, 1223482
Total [candidate] (10.842 s) : 0, 10841609
section iast
Agent [baseline] (1.195 s) : 0, 1194966
Total [baseline] (10.954 s) : 0, 10954158
Agent [candidate] (1.182 s) : 0, 1181853
Total [candidate] (10.977 s) : 0, 10977237
section profiling
Agent [baseline] (1.2 s) : 0, 1199999
Total [baseline] (10.86 s) : 0, 10859529
Agent [candidate] (1.197 s) : 0, 1197161
Total [candidate] (10.819 s) : 0, 10818921
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (735.483 ms) : 0, 735483
BytebuddyAgent [candidate] (738.932 ms) : 0, 738932
GlobalTracer [baseline] (241.722 ms) : 0, 241722
GlobalTracer [candidate] (244.136 ms) : 0, 244136
AppSec [baseline] (30.156 ms) : 0, 30156
AppSec [candidate] (30.358 ms) : 0, 30358
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.158 ms) : 0, 6158
Remote Config [baseline] (680.531 µs) : 0, 681
Remote Config [candidate] (723.338 µs) : 0, 723
Telemetry [baseline] (14.423 ms) : 0, 14423
Telemetry [candidate] (12.428 ms) : 0, 12428
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (754.403 ms) : 0, 754403
BytebuddyAgent [candidate] (755.681 ms) : 0, 755681
GlobalTracer [baseline] (235.13 ms) : 0, 235130
GlobalTracer [candidate] (235.567 ms) : 0, 235567
AppSec [baseline] (168.183 ms) : 0, 168183
AppSec [candidate] (168.907 ms) : 0, 168907
Debugger [baseline] (6.492 ms) : 0, 6492
Debugger [candidate] (8.096 ms) : 0, 8096
Remote Config [baseline] (620.319 µs) : 0, 620
Remote Config [candidate] (613.436 µs) : 0, 613
Telemetry [baseline] (10.865 ms) : 0, 10865
Telemetry [candidate] (8.483 ms) : 0, 8483
IAST [baseline] (23.566 ms) : 0, 23566
IAST [candidate] (23.656 ms) : 0, 23656
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (863.698 ms) : 0, 863698
BytebuddyAgent [candidate] (852.978 ms) : 0, 852978
GlobalTracer [baseline] (234.805 ms) : 0, 234805
GlobalTracer [candidate] (233.558 ms) : 0, 233558
AppSec [baseline] (27.307 ms) : 0, 27307
AppSec [candidate] (27.583 ms) : 0, 27583
Debugger [baseline] (7.458 ms) : 0, 7458
Debugger [candidate] (5.78 ms) : 0, 5780
Remote Config [baseline] (621.743 µs) : 0, 622
Remote Config [candidate] (601.293 µs) : 0, 601
Telemetry [baseline] (8.472 ms) : 0, 8472
Telemetry [candidate] (8.254 ms) : 0, 8254
IAST [baseline] (29.856 ms) : 0, 29856
IAST [candidate] (30.528 ms) : 0, 30528
section profiling
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (763.237 ms) : 0, 763237
BytebuddyAgent [candidate] (760.337 ms) : 0, 760337
GlobalTracer [baseline] (222.625 ms) : 0, 222625
GlobalTracer [candidate] (222.521 ms) : 0, 222521
AppSec [baseline] (30.623 ms) : 0, 30623
AppSec [candidate] (30.513 ms) : 0, 30513
Debugger [baseline] (6.284 ms) : 0, 6284
Debugger [candidate] (6.23 ms) : 0, 6230
Remote Config [baseline] (717.998 µs) : 0, 718
Remote Config [candidate] (704.315 µs) : 0, 704
Telemetry [baseline] (15.784 ms) : 0, 15784
Telemetry [candidate] (16.598 ms) : 0, 16598
ProfilingAgent [baseline] (108.726 ms) : 0, 108726
ProfilingAgent [candidate] (108.392 ms) : 0, 108392
Profiling [baseline] (109.392 ms) : 0, 109392
Profiling [candidate] (109.062 ms) : 0, 109062
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section baseline
no_agent (4.622 ms) : 4569, 4675
. : milestone, 4622,
iast (9.346 ms) : 9185, 9508
. : milestone, 9346,
iast_FULL (14.029 ms) : 13751, 14306
. : milestone, 14029,
iast_GLOBAL (10.604 ms) : 10402, 10806
. : milestone, 10604,
profiling (9.19 ms) : 9040, 9339
. : milestone, 9190,
tracing (7.444 ms) : 7334, 7555
. : milestone, 7444,
section candidate
no_agent (4.409 ms) : 4360, 4458
. : milestone, 4409,
iast (9.55 ms) : 9380, 9720
. : milestone, 9550,
iast_FULL (13.964 ms) : 13688, 14239
. : milestone, 13964,
iast_GLOBAL (10.53 ms) : 10339, 10721
. : milestone, 10530,
profiling (8.887 ms) : 8752, 9022
. : milestone, 8887,
tracing (8.118 ms) : 7999, 8236
. : milestone, 8118,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section baseline
no_agent (37.051 ms) : 36752, 37349
. : milestone, 37051,
appsec (47.752 ms) : 47331, 48172
. : milestone, 47752,
code_origins (44.664 ms) : 44284, 45044
. : milestone, 44664,
iast (44.595 ms) : 44208, 44982
. : milestone, 44595,
profiling (49.587 ms) : 49146, 50028
. : milestone, 49587,
tracing (45.991 ms) : 45589, 46393
. : milestone, 45991,
section candidate
no_agent (37.021 ms) : 36716, 37327
. : milestone, 37021,
appsec (46.999 ms) : 46588, 47409
. : milestone, 46999,
code_origins (46.075 ms) : 45672, 46479
. : milestone, 46075,
iast (44.658 ms) : 44264, 45053
. : milestone, 44658,
profiling (48.367 ms) : 47917, 48817
. : milestone, 48367,
tracing (44.163 ms) : 43786, 44541
. : milestone, 44163,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
iast (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
iast_GLOBAL (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
profiling (15.435 s) : 15435000, 15435000
. : milestone, 15435000,
tracing (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
section candidate
no_agent (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
appsec (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
iast (18.933 s) : 18933000, 18933000
. : milestone, 18933000,
iast_GLOBAL (18.235 s) : 18235000, 18235000
. : milestone, 18235000,
profiling (15.29 s) : 15290000, 15290000
. : milestone, 15290000,
tracing (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d332072632, baseline=1.54.0-SNAPSHOT~3ff796af33
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.665 ms) : 3449, 3880
. : milestone, 3665,
iast (2.199 ms) : 2136, 2262
. : milestone, 2199,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.051 ms) : 2000, 2103
. : milestone, 2051,
tracing (2.005 ms) : 1956, 2053
. : milestone, 2005,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.657 ms) : 3443, 3871
. : milestone, 3657,
iast (2.193 ms) : 2131, 2256
. : milestone, 2193,
iast_GLOBAL (2.235 ms) : 2172, 2297
. : milestone, 2235,
profiling (2.037 ms) : 1987, 2088
. : milestone, 2037,
tracing (2.013 ms) : 1965, 2061
. : milestone, 2013,
|
added the error that caused the flake as an acceptable error for the test
also relaxed the check on the text of the SdkClientException on AI suggestion.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]