-
Notifications
You must be signed in to change notification settings - Fork 324
Cleanup usages of JUnit4. #9500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 9a792fa | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048128
Total [baseline] (10.749 s) : 0, 10749396
Agent [candidate] (1.043 s) : 0, 1043495
Total [candidate] (10.691 s) : 0, 10690846
section appsec
Agent [baseline] (1.224 s) : 0, 1223557
Total [baseline] (10.801 s) : 0, 10801106
Agent [candidate] (1.225 s) : 0, 1225313
Total [candidate] (10.78 s) : 0, 10780100
section iast
Agent [baseline] (1.191 s) : 0, 1190624
Total [baseline] (10.94 s) : 0, 10939855
Agent [candidate] (1.181 s) : 0, 1181270
Total [candidate] (10.966 s) : 0, 10966345
section profiling
Agent [baseline] (1.201 s) : 0, 1200858
Total [baseline] (10.959 s) : 0, 10959063
Agent [candidate] (1.211 s) : 0, 1210523
Total [candidate] (10.927 s) : 0, 10926974
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (733.026 ms) : 0, 733026
BytebuddyAgent [candidate] (730.259 ms) : 0, 730259
GlobalTracer [baseline] (242.464 ms) : 0, 242464
GlobalTracer [candidate] (241.87 ms) : 0, 241870
AppSec [baseline] (30.536 ms) : 0, 30536
AppSec [candidate] (30.165 ms) : 0, 30165
Debugger [baseline] (6.508 ms) : 0, 6508
Debugger [candidate] (6.421 ms) : 0, 6421
Remote Config [baseline] (686.594 µs) : 0, 687
Remote Config [candidate] (676.825 µs) : 0, 677
Telemetry [baseline] (12.356 ms) : 0, 12356
Telemetry [candidate] (11.622 ms) : 0, 11622
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (755.471 ms) : 0, 755471
BytebuddyAgent [candidate] (756.915 ms) : 0, 756915
GlobalTracer [baseline] (235.055 ms) : 0, 235055
GlobalTracer [candidate] (236.263 ms) : 0, 236263
IAST [baseline] (23.567 ms) : 0, 23567
IAST [candidate] (23.657 ms) : 0, 23657
AppSec [baseline] (167.335 ms) : 0, 167335
AppSec [candidate] (170.221 ms) : 0, 170221
Debugger [baseline] (9.087 ms) : 0, 9087
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (660.178 µs) : 0, 660
Remote Config [candidate] (611.267 µs) : 0, 611
Telemetry [baseline] (9.93 ms) : 0, 9930
Telemetry [candidate] (9.22 ms) : 0, 9220
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (859.43 ms) : 0, 859430
BytebuddyAgent [candidate] (852.079 ms) : 0, 852079
GlobalTracer [baseline] (235.542 ms) : 0, 235542
GlobalTracer [candidate] (233.631 ms) : 0, 233631
IAST [baseline] (30.246 ms) : 0, 30246
IAST [candidate] (30.954 ms) : 0, 30954
AppSec [baseline] (26.679 ms) : 0, 26679
AppSec [candidate] (26.01 ms) : 0, 26010
Debugger [baseline] (7.051 ms) : 0, 7051
Debugger [candidate] (7.026 ms) : 0, 7026
Remote Config [baseline] (633.627 µs) : 0, 634
Remote Config [candidate] (633.803 µs) : 0, 634
Telemetry [baseline] (8.416 ms) : 0, 8416
Telemetry [candidate] (8.362 ms) : 0, 8362
section profiling
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (762.928 ms) : 0, 762928
BytebuddyAgent [candidate] (771.069 ms) : 0, 771069
GlobalTracer [baseline] (223.269 ms) : 0, 223269
GlobalTracer [candidate] (224.445 ms) : 0, 224445
AppSec [baseline] (30.804 ms) : 0, 30804
AppSec [candidate] (30.967 ms) : 0, 30967
Debugger [baseline] (6.745 ms) : 0, 6745
Debugger [candidate] (7.355 ms) : 0, 7355
Remote Config [baseline] (717.93 µs) : 0, 718
Remote Config [candidate] (698.643 µs) : 0, 699
Telemetry [baseline] (16.405 ms) : 0, 16405
Telemetry [candidate] (15.707 ms) : 0, 15707
ProfilingAgent [baseline] (107.923 ms) : 0, 107923
ProfilingAgent [candidate] (107.91 ms) : 0, 107910
Profiling [baseline] (108.651 ms) : 0, 108651
Profiling [candidate] (108.632 ms) : 0, 108632
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049377
Total [baseline] (8.63 s) : 0, 8630215
Agent [candidate] (1.047 s) : 0, 1047244
Total [candidate] (8.617 s) : 0, 8616511
section iast
Agent [baseline] (1.179 s) : 0, 1179271
Total [baseline] (9.346 s) : 0, 9345743
Agent [candidate] (1.181 s) : 0, 1180854
Total [candidate] (9.357 s) : 0, 9357129
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (733.731 ms) : 0, 733731
BytebuddyAgent [candidate] (731.283 ms) : 0, 731283
GlobalTracer [baseline] (242.457 ms) : 0, 242457
GlobalTracer [candidate] (241.912 ms) : 0, 241912
AppSec [baseline] (30.409 ms) : 0, 30409
AppSec [candidate] (30.067 ms) : 0, 30067
Debugger [baseline] (6.453 ms) : 0, 6453
Debugger [candidate] (6.407 ms) : 0, 6407
Remote Config [baseline] (689.375 µs) : 0, 689
Remote Config [candidate] (664.162 µs) : 0, 664
Telemetry [baseline] (13.164 ms) : 0, 13164
Telemetry [candidate] (14.418 ms) : 0, 14418
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (850.375 ms) : 0, 850375
BytebuddyAgent [candidate] (851.807 ms) : 0, 851807
GlobalTracer [baseline] (232.853 ms) : 0, 232853
GlobalTracer [candidate] (233.244 ms) : 0, 233244
IAST [baseline] (28.771 ms) : 0, 28771
IAST [candidate] (30.394 ms) : 0, 30394
AppSec [baseline] (28.938 ms) : 0, 28938
AppSec [candidate] (26.155 ms) : 0, 26155
Debugger [baseline] (6.959 ms) : 0, 6959
Debugger [candidate] (7.763 ms) : 0, 7763
Remote Config [baseline] (620.631 µs) : 0, 621
Remote Config [candidate] (617.426 µs) : 0, 617
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (8.391 ms) : 0, 8391
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (36.027 ms) : 35734, 36319
. : milestone, 36027,
appsec (49.645 ms) : 49208, 50081
. : milestone, 49645,
code_origins (45.328 ms) : 44936, 45721
. : milestone, 45328,
iast (44.397 ms) : 44021, 44772
. : milestone, 44397,
profiling (48.619 ms) : 48198, 49039
. : milestone, 48619,
tracing (43.031 ms) : 42665, 43397
. : milestone, 43031,
section candidate
no_agent (36.926 ms) : 36628, 37224
. : milestone, 36926,
appsec (48.774 ms) : 48336, 49212
. : milestone, 48774,
code_origins (46.139 ms) : 45730, 46548
. : milestone, 46139,
iast (45.735 ms) : 45322, 46148
. : milestone, 45735,
profiling (50.235 ms) : 49771, 50699
. : milestone, 50235,
tracing (44.382 ms) : 44010, 44754
. : milestone, 44382,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (4.381 ms) : 4331, 4430
. : milestone, 4381,
iast (9.306 ms) : 9153, 9459
. : milestone, 9306,
iast_FULL (13.848 ms) : 13575, 14122
. : milestone, 13848,
iast_GLOBAL (10.763 ms) : 10572, 10954
. : milestone, 10763,
profiling (8.856 ms) : 8718, 8993
. : milestone, 8856,
tracing (7.777 ms) : 7665, 7888
. : milestone, 7777,
section candidate
no_agent (4.227 ms) : 4176, 4277
. : milestone, 4227,
iast (9.651 ms) : 9492, 9810
. : milestone, 9651,
iast_FULL (14.088 ms) : 13812, 14363
. : milestone, 14088,
iast_GLOBAL (10.416 ms) : 10228, 10603
. : milestone, 10416,
profiling (9.128 ms) : 8976, 9280
. : milestone, 9128,
tracing (8.182 ms) : 8062, 8302
. : milestone, 8182,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.732 ms) : 3513, 3951
. : milestone, 3732,
iast (2.216 ms) : 2153, 2279
. : milestone, 2216,
iast_GLOBAL (2.253 ms) : 2189, 2317
. : milestone, 2253,
profiling (2.07 ms) : 2018, 2122
. : milestone, 2070,
tracing (2.039 ms) : 1989, 2089
. : milestone, 2039,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.482 ms) : 2428, 2536
. : milestone, 2482,
iast (2.215 ms) : 2152, 2279
. : milestone, 2215,
iast_GLOBAL (2.277 ms) : 2212, 2342
. : milestone, 2277,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~9a792fa6b5, baseline=1.54.0-SNAPSHOT~bca7d159dd
dateFormat X
axisFormat %s
section baseline
no_agent (15.504 s) : 15504000, 15504000
. : milestone, 15504000,
appsec (15.039 s) : 15039000, 15039000
. : milestone, 15039000,
iast (19.026 s) : 19026000, 19026000
. : milestone, 19026000,
iast_GLOBAL (18.253 s) : 18253000, 18253000
. : milestone, 18253000,
profiling (15.688 s) : 15688000, 15688000
. : milestone, 15688000,
tracing (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
section candidate
no_agent (15.667 s) : 15667000, 15667000
. : milestone, 15667000,
appsec (15.146 s) : 15146000, 15146000
. : milestone, 15146000,
iast (19.147 s) : 19147000, 19147000
. : milestone, 19147000,
iast_GLOBAL (18.396 s) : 18396000, 18396000
. : milestone, 18396000,
profiling (15.938 s) : 15938000, 15938000
. : milestone, 15938000,
tracing (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
|
jpbempel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for debugger
What Does This Do
Cleanup usages of JUnit4.
Motivation
Better to use JUnit5 as JUnit4 is outdated.
Additional Notes