Skip to content

Add support for DBM comment injection with MongoDB #9589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
na-ji merged 35 commits into from
Dec 19, 2025
Merged

Add support for DBM comment injection with MongoDB #9589

na-ji merged 35 commits into from
Dec 19, 2025

Conversation

@Yoone
Copy link
Member

@Yoone Yoone commented Sep 22, 2025 •
edited by na-ji
Loading

What Does This Do

Addind support for injecting trace info in mongo spans, which is used by DBM. This PR mirrors the logic that was added in dd-trace-py.

Motivation

  • Moving towards feature parity across tracer libraries
  • Enabling users to see their Database Monitoring information from within APM when using the Java tracing SDK

Additional Notes

  • SQLCommenter logic was mostly moved to SharedDBCommenter to share it with the new MongoCommentInjector, and now focuses on adding /* + */, which Mongo does not need
  • The modification of the MongoDB command required to instrument code in a place higher in the call stack than the mongo command listener used to add spans

To-do

  • Add smoke test(s) for Mongo comment injection
  • Move SharedDBCommenter from JDBC instrumentation to dd-trace-core (to fix pipeline, but also because Mongo logic should not depend on JDBC)

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@Yoone Yoone changed the title Added support for DBM comment injection with MongoDB Add support for DBM comment injection with MongoDB Sep 22, 2025
@pr-commenter
Copy link

pr-commenter bot commented Sep 22, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master yoann.bentz/mongodb-dbm-support
git_commit_date 1765967148 1765973629
git_commit_sha dda618e 5ffb54e
release_version 1.57.0-SNAPSHOT~dda618e90d 1.55.0-SNAPSHOT~5ffb54eb18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765975426 1765975426
ci_job_id 1302070784 1302070784
ci_pipeline_id 87262128 87262128
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lomis69h 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lomis69h 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079503
Total [baseline] (10.832 s) : 0, 10831685
Agent [candidate] (1.08 s) : 0, 1080213
Total [candidate] (10.783 s) : 0, 10783039
section appsec
Agent [baseline] (1.27 s) : 0, 1270417
Total [baseline] (11.072 s) : 0, 11071625
Agent [candidate] (1.266 s) : 0, 1265653
Total [candidate] (10.991 s) : 0, 10990784
section iast
Agent [baseline] (1.221 s) : 0, 1221070
Total [baseline] (11.167 s) : 0, 11167449
Agent [candidate] (1.225 s) : 0, 1225357
Total [candidate] (11.312 s) : 0, 11311585
section profiling
Agent [baseline] (1.211 s) : 0, 1211052
Total [baseline] (11.036 s) : 0, 11036056
Agent [candidate] (1.203 s) : 0, 1203009
Total [candidate] (10.966 s) : 0, 10966380
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.27 s 190.914 ms (17.7%)
Agent iast 1.221 s 141.568 ms (13.1%)
Agent profiling 1.211 s 131.55 ms (12.2%)
Total tracing 10.832 s -
Total appsec 11.072 s 239.94 ms (2.2%)
Total iast 11.167 s 335.763 ms (3.1%)
Total profiling 11.036 s 204.37 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.266 s 185.44 ms (17.2%)
Agent iast 1.225 s 145.144 ms (13.4%)
Agent profiling 1.203 s 122.796 ms (11.4%)
Total tracing 10.783 s -
Total appsec 10.991 s 207.745 ms (1.9%)
Total iast 11.312 s 528.546 ms (4.9%)
Total profiling 10.966 s 183.342 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (647.152 ms) : 0, 647152
BytebuddyAgent [candidate] (647.309 ms) : 0, 647309
GlobalTracer [baseline] (282.36 ms) : 0, 282360
GlobalTracer [candidate] (282.649 ms) : 0, 282649
AppSec [baseline] (32.147 ms) : 0, 32147
AppSec [candidate] (32.242 ms) : 0, 32242
Debugger [baseline] (67.795 ms) : 0, 67795
Debugger [candidate] (68.012 ms) : 0, 68012
Remote Config [baseline] (632.34 µs) : 0, 632
Remote Config [candidate] (634.671 µs) : 0, 635
Telemetry [baseline] (9.005 ms) : 0, 9005
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.762 ms) : 0, 3762
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (693.084 ms) : 0, 693084
BytebuddyAgent [candidate] (688.742 ms) : 0, 688742
GlobalTracer [baseline] (259.998 ms) : 0, 259998
GlobalTracer [candidate] (258.544 ms) : 0, 258544
AppSec [baseline] (174.374 ms) : 0, 174374
AppSec [candidate] (174.259 ms) : 0, 174259
Debugger [baseline] (67.749 ms) : 0, 67749
Debugger [candidate] (69.021 ms) : 0, 69021
Remote Config [baseline] (691.995 µs) : 0, 692
Remote Config [candidate] (728.786 µs) : 0, 729
Telemetry [baseline] (8.947 ms) : 0, 8947
Telemetry [candidate] (8.942 ms) : 0, 8942
Flare Poller [baseline] (3.863 ms) : 0, 3863
Flare Poller [candidate] (3.914 ms) : 0, 3914
IAST [baseline] (24.861 ms) : 0, 24861
IAST [candidate] (24.82 ms) : 0, 24820
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (788.976 ms) : 0, 788976
BytebuddyAgent [candidate] (790.749 ms) : 0, 790749
GlobalTracer [baseline] (255.143 ms) : 0, 255143
GlobalTracer [candidate] (256.962 ms) : 0, 256962
AppSec [baseline] (31.9 ms) : 0, 31900
AppSec [candidate] (33.636 ms) : 0, 33636
Debugger [baseline] (68.955 ms) : 0, 68955
Debugger [candidate] (67.596 ms) : 0, 67596
Remote Config [baseline] (576.394 µs) : 0, 576
Remote Config [candidate] (598.935 µs) : 0, 599
Telemetry [baseline] (8.44 ms) : 0, 8440
Telemetry [candidate] (8.585 ms) : 0, 8585
Flare Poller [baseline] (3.507 ms) : 0, 3507
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (26.956 ms) : 0, 26956
IAST [candidate] (27.139 ms) : 0, 27139
section profiling
ProfilingAgent [baseline] (98.992 ms) : 0, 98992
ProfilingAgent [candidate] (97.397 ms) : 0, 97397
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (703.001 ms) : 0, 703001
BytebuddyAgent [candidate] (700.669 ms) : 0, 700669
GlobalTracer [baseline] (222.965 ms) : 0, 222965
GlobalTracer [candidate] (220.861 ms) : 0, 220861
AppSec [baseline] (32.82 ms) : 0, 32820
AppSec [candidate] (31.877 ms) : 0, 31877
Debugger [baseline] (68.875 ms) : 0, 68875
Debugger [candidate] (68.014 ms) : 0, 68014
Remote Config [baseline] (651.876 µs) : 0, 652
Remote Config [candidate] (616.361 µs) : 0, 616
Telemetry [baseline] (8.996 ms) : 0, 8996
Telemetry [candidate] (9.024 ms) : 0, 9024
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (3.781 ms) : 0, 3781
Profiling [baseline] (99.588 ms) : 0, 99588
Profiling [candidate] (97.969 ms) : 0, 97969
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1085379
Total [baseline] (8.749 s) : 0, 8748777
Agent [candidate] (1.08 s) : 0, 1079740
Total [candidate] (8.742 s) : 0, 8742031
section iast
Agent [baseline] (1.219 s) : 0, 1219084
Total [baseline] (9.376 s) : 0, 9376250
Agent [candidate] (1.223 s) : 0, 1223263
Total [candidate] (9.425 s) : 0, 9425445
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.219 s 133.705 ms (12.3%)
Total tracing 8.749 s -
Total iast 9.376 s 627.472 ms (7.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.223 s 143.523 ms (13.3%)
Total tracing 8.742 s -
Total iast 9.425 s 683.415 ms (7.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (651.581 ms) : 0, 651581
BytebuddyAgent [candidate] (647.719 ms) : 0, 647719
GlobalTracer [baseline] (283.025 ms) : 0, 283025
GlobalTracer [candidate] (282.203 ms) : 0, 282203
AppSec [baseline] (32.613 ms) : 0, 32613
AppSec [candidate] (32.403 ms) : 0, 32403
Debugger [baseline] (67.843 ms) : 0, 67843
Debugger [candidate] (66.707 ms) : 0, 66707
Remote Config [baseline] (652.233 µs) : 0, 652
Remote Config [candidate] (614.688 µs) : 0, 615
Telemetry [baseline] (9.0 ms) : 0, 9000
Telemetry [candidate] (9.809 ms) : 0, 9809
Flare Poller [baseline] (3.797 ms) : 0, 3797
Flare Poller [candidate] (3.742 ms) : 0, 3742
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (787.749 ms) : 0, 787749
BytebuddyAgent [candidate] (790.448 ms) : 0, 790448
GlobalTracer [baseline] (255.486 ms) : 0, 255486
GlobalTracer [candidate] (256.382 ms) : 0, 256382
AppSec [baseline] (33.661 ms) : 0, 33661
AppSec [candidate] (31.111 ms) : 0, 31111
Debugger [baseline] (66.164 ms) : 0, 66164
Debugger [candidate] (69.07 ms) : 0, 69070
Remote Config [baseline] (595.108 µs) : 0, 595
Remote Config [candidate] (607.049 µs) : 0, 607
Telemetry [baseline] (8.41 ms) : 0, 8410
Telemetry [candidate] (8.468 ms) : 0, 8468
Flare Poller [baseline] (3.514 ms) : 0, 3514
Flare Poller [candidate] (3.48 ms) : 0, 3480
IAST [baseline] (26.935 ms) : 0, 26935
IAST [candidate] (27.025 ms) : 0, 27025
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master yoann.bentz/mongodb-dbm-support
git_commit_date 1765967148 1765973629
git_commit_sha dda618e 5ffb54e
release_version 1.57.0-SNAPSHOT~dda618e90d 1.55.0-SNAPSHOT~5ffb54eb18
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1765976007 1765976007
ci_job_id 1302070785 1302070785
ci_pipeline_id 87262128 87262128
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-2ef485h3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-2ef485h3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:no_agent:high_load worse
[+1.895ms; +3.235ms] or [+11.405%; +19.466%]		 unstable
[+1.999ms; +5.013ms] or [+7.127%; +17.871%]		 unstable
[-58.883op/s; -6.992op/s] or [-21.691%; -2.576%]		 19.184ms 31.554ms 238.531op/s 16.619ms 28.048ms 271.469op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.158 ms) : 1147, 1169
.   : milestone, 1158,
iast (3.23 ms) : 3186, 3274
.   : milestone, 3230,
iast_FULL (5.656 ms) : 5600, 5712
.   : milestone, 5656,
iast_GLOBAL (3.657 ms) : 3602, 3713
.   : milestone, 3657,
profiling (2.08 ms) : 2061, 2099
.   : milestone, 2080,
tracing (1.787 ms) : 1771, 1804
.   : milestone, 1787,
section candidate
no_agent (1.201 ms) : 1189, 1213
.   : milestone, 1201,
iast (3.117 ms) : 3080, 3155
.   : milestone, 3117,
iast_FULL (5.817 ms) : 5757, 5876
.   : milestone, 5817,
iast_GLOBAL (3.644 ms) : 3585, 3702
.   : milestone, 3644,
profiling (1.943 ms) : 1926, 1960
.   : milestone, 1943,
tracing (1.781 ms) : 1766, 1795
.   : milestone, 1781,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.158 ms [1.147 ms, 1.169 ms] -
iast 3.23 ms [3.186 ms, 3.274 ms] 2.072 ms (178.9%)
iast_FULL 5.656 ms [5.6 ms, 5.712 ms] 4.498 ms (388.4%)
iast_GLOBAL 3.657 ms [3.602 ms, 3.713 ms] 2.499 ms (215.8%)
profiling 2.08 ms [2.061 ms, 2.099 ms] 922.008 µs (79.6%)
tracing 1.787 ms [1.771 ms, 1.804 ms] 629.328 µs (54.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.201 ms [1.189 ms, 1.213 ms] -
iast 3.117 ms [3.08 ms, 3.155 ms] 1.916 ms (159.6%)
iast_FULL 5.817 ms [5.757 ms, 5.876 ms] 4.616 ms (384.3%)
iast_GLOBAL 3.644 ms [3.585 ms, 3.702 ms] 2.443 ms (203.4%)
profiling 1.943 ms [1.926 ms, 1.96 ms] 741.981 µs (61.8%)
tracing 1.781 ms [1.766 ms, 1.795 ms] 579.477 µs (48.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.191 ms) : 17023, 17359
.   : milestone, 17191,
appsec (18.861 ms) : 18671, 19051
.   : milestone, 18861,
code_origins (17.627 ms) : 17450, 17803
.   : milestone, 17627,
iast (17.684 ms) : 17511, 17858
.   : milestone, 17684,
profiling (18.714 ms) : 18528, 18900
.   : milestone, 18714,
tracing (17.59 ms) : 17415, 17765
.   : milestone, 17590,
section candidate
no_agent (19.567 ms) : 19364, 19770
.   : milestone, 19567,
appsec (18.431 ms) : 18244, 18619
.   : milestone, 18431,
code_origins (18.044 ms) : 17861, 18227
.   : milestone, 18044,
iast (18.027 ms) : 17843, 18210
.   : milestone, 18027,
profiling (18.479 ms) : 18296, 18662
.   : milestone, 18479,
tracing (17.995 ms) : 17816, 18174
.   : milestone, 17995,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.191 ms [17.023 ms, 17.359 ms] -
appsec 18.861 ms [18.671 ms, 19.051 ms] 1.67 ms (9.7%)
code_origins 17.627 ms [17.45 ms, 17.803 ms] 435.618 µs (2.5%)
iast 17.684 ms [17.511 ms, 17.858 ms] 493.363 µs (2.9%)
profiling 18.714 ms [18.528 ms, 18.9 ms] 1.523 ms (8.9%)
tracing 17.59 ms [17.415 ms, 17.765 ms] 399.254 µs (2.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.567 ms [19.364 ms, 19.77 ms] -
appsec 18.431 ms [18.244 ms, 18.619 ms] -1.135 ms (-5.8%)
code_origins 18.044 ms [17.861 ms, 18.227 ms] -1.523 ms (-7.8%)
iast 18.027 ms [17.843 ms, 18.21 ms] -1.54 ms (-7.9%)
profiling 18.479 ms [18.296 ms, 18.662 ms] -1.088 ms (-5.6%)
tracing 17.995 ms [17.816 ms, 18.174 ms] -1.572 ms (-8.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master yoann.bentz/mongodb-dbm-support
git_commit_date 1765967148 1765973629
git_commit_sha dda618e 5ffb54e
release_version 1.57.0-SNAPSHOT~dda618e90d 1.55.0-SNAPSHOT~5ffb54eb18
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1765975705 1765975705
ci_job_id 1302070787 1302070787
ci_pipeline_id 87262128 87262128
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-i6bvn8o8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-i6bvn8o8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.370ms; -1.032ms] or [-37.457%; -28.222%]		 2.456ms 3.657ms
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (3.657 ms) : 3441, 3873
.   : milestone, 3657,
iast (2.208 ms) : 2144, 2273
.   : milestone, 2208,
iast_GLOBAL (2.252 ms) : 2187, 2317
.   : milestone, 2252,
profiling (2.095 ms) : 2041, 2149
.   : milestone, 2095,
tracing (2.045 ms) : 1994, 2096
.   : milestone, 2045,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.456 ms) : 2404, 2507
.   : milestone, 2456,
iast (2.206 ms) : 2141, 2271
.   : milestone, 2206,
iast_GLOBAL (2.26 ms) : 2195, 2325
.   : milestone, 2260,
profiling (2.484 ms) : 2322, 2646
.   : milestone, 2484,
tracing (2.05 ms) : 1999, 2100
.   : milestone, 2050,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 3.657 ms [3.441 ms, 3.873 ms] 2.179 ms (147.5%)
iast 2.208 ms [2.144 ms, 2.273 ms] 730.987 µs (49.5%)
iast_GLOBAL 2.252 ms [2.187 ms, 2.317 ms] 774.831 µs (52.4%)
profiling 2.095 ms [2.041 ms, 2.149 ms] 617.498 µs (41.8%)
tracing 2.045 ms [1.994 ms, 2.096 ms] 567.417 µs (38.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.456 ms [2.404 ms, 2.507 ms] 976.701 µs (66.0%)
iast 2.206 ms [2.141 ms, 2.271 ms] 726.706 µs (49.1%)
iast_GLOBAL 2.26 ms [2.195 ms, 2.325 ms] 780.926 µs (52.8%)
profiling 2.484 ms [2.322 ms, 2.646 ms] 1.005 ms (67.9%)
tracing 2.05 ms [1.999 ms, 2.1 ms] 570.516 µs (38.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5ffb54eb18, baseline=1.57.0-SNAPSHOT~dda618e90d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.313 s) : 15313000, 15313000
.   : milestone, 15313000,
appsec (14.57 s) : 14570000, 14570000
.   : milestone, 14570000,
iast (18.451 s) : 18451000, 18451000
.   : milestone, 18451000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
.   : milestone, 17916000,
profiling (14.673 s) : 14673000, 14673000
.   : milestone, 14673000,
tracing (14.898 s) : 14898000, 14898000
.   : milestone, 14898000,
section candidate
no_agent (15.694 s) : 15694000, 15694000
.   : milestone, 15694000,
appsec (14.923 s) : 14923000, 14923000
.   : milestone, 14923000,
iast (18.153 s) : 18153000, 18153000
.   : milestone, 18153000,
iast_GLOBAL (18.104 s) : 18104000, 18104000
.   : milestone, 18104000,
profiling (14.704 s) : 14704000, 14704000
.   : milestone, 14704000,
tracing (14.748 s) : 14748000, 14748000
.   : milestone, 14748000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.313 s [15.313 s, 15.313 s] -
appsec 14.57 s [14.57 s, 14.57 s] -743.0 ms (-4.9%)
iast 18.451 s [18.451 s, 18.451 s] 3.138 s (20.5%)
iast_GLOBAL 17.916 s [17.916 s, 17.916 s] 2.603 s (17.0%)
profiling 14.673 s [14.673 s, 14.673 s] -640.0 ms (-4.2%)
tracing 14.898 s [14.898 s, 14.898 s] -415.0 ms (-2.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.694 s [15.694 s, 15.694 s] -
appsec 14.923 s [14.923 s, 14.923 s] -771.0 ms (-4.9%)
iast 18.153 s [18.153 s, 18.153 s] 2.459 s (15.7%)
iast_GLOBAL 18.104 s [18.104 s, 18.104 s] 2.41 s (15.4%)
profiling 14.704 s [14.704 s, 14.704 s] -990.0 ms (-6.3%)
tracing 14.748 s [14.748 s, 14.748 s] -946.0 ms (-6.0%)

@Yoone Yoone added type: enhancement Enhancements and improvements comp: database Database Monitoring inst: mongodb MongoDB instrumentation labels Sep 23, 2025
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD reviewed Sep 24, 2025
View reviewed changes
@Yoone Yoone force-pushed the yoann.bentz/mongodb-dbm-support branch from 22aab0a to 631958f Compare September 25, 2025 18:58
Yoone and others added 16 commits October 30, 2025 15:41
@Yoone @na-ji
Added support for DBM comment injection with MongoDB
18cab70
@Yoone @na-ji
Moved SharedDBCommenter from jdbc instrumentation to dd-trace-core
4c5095b
@Yoone @na-ji
Fixed SharedDBCommenterTest import
48c1358
@Yoone @na-ji
Replaced hardcoded length with constant
b3e777a
@Yoone @na-ji
Attempt at fixing existing tests
a26c412
@Yoone @na-ji
Updated INJECT_COMMENT logic
5df1948
@Yoone @na-ji
Fixed containsTraceComment for test cases
486e238
@Yoone @na-ji
Switched MongoDBMInjectionTest to MongoBaseTest
29aef39
@Yoone @na-ji
Revamped Mongo comment tests
7515a3f
@Yoone @na-ji
Attempt to fix SQL injection tests
2533add
@Yoone @na-ji
Revert changes to gradle.lockfile
dfa23a6
@Yoone @na-ji
PR comments: build traceparent incl. sampling flag, exception logging
ee8f5a0
@na-ji
Add missing helperClassNames for mongo drivers 3.1 and 3.4
7da62c3
@Yoone @na-ji
Using unit testing for trace parent changes
e8e0a3d
@Yoone @na-ji
Prevented cloning immutable Mongo objects
a0d854f
@Yoone @na-ji
Fixed smoke test (revert bug)
92a6054
@na-ji na-ji force-pushed the yoann.bentz/mongodb-dbm-support branch 3 times, most recently from 72e2fae to 18ebfd2 Compare November 5, 2025 14:14
@na-ji
fix server connection instrumentation advice not working on write que…
9da2307 
…ries

Write queries on the MongoDB driver >= 4.0 and <= 4.7 weren't correctly
instrumented. I didn't notice it before because the tests weren't
exhaustive, and my test app was using driver v5.6.
@na-ji na-ji force-pushed the yoann.bentz/mongodb-dbm-support branch from 80a07db to 9da2307 Compare December 11, 2025 10:47
@na-ji na-ji requested a review from vandonr December 15, 2025 13:19
vandonr
vandonr approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@vandonr vandonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a bit uneasy about adding stuff under the comment key if it already contains something (i.e. user data), but otherwise lgtm

@na-ji
move mongo < 4.0 to standalone package driver-3.6
5f3fdd5 
In the end, the instrumentation only works on driver > 3.6, so we
decided to make a standalone package for that. This version being 9
years old seems to be enough for DBM support
@na-ji
Move DefaultServerInstrumentation for mongo driver 4.0 to driver 3.8
047a79a 
We now have two instrumentations: one for 3.6 to 3.7, and another one
for 3.8 to 5.6
PerfectSlayer
PerfectSlayer approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the LP part. Sorry for the delay, I thought one approval was enough to get it unblock 🙇

@na-ji na-ji merged commit cce064e into master Dec 19, 2025
559 checks passed
@na-ji na-ji deleted the yoann.bentz/mongodb-dbm-support branch December 19, 2025 09:02
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 19, 2025
@na-ji na-ji mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@na-ji na-ji na-ji left review comments

@nenadnoveljic nenadnoveljic nenadnoveljic left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@vandonr vandonr vandonr approved these changes

@daniel-mohedano daniel-mohedano Awaiting requested review from daniel-mohedano daniel-mohedano was automatically assigned from DataDog/ci-app-libraries-java

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD Awaiting requested review from AlexeyKuznetsov-DD

@dougqh dougqh Awaiting requested review from dougqh

Assignees

No one assigned

Labels

comp: database Database Monitoring inst: mongodb MongoDB instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Yoone @na-ji @dougqh @PerfectSlayer @vandonr @nenadnoveljic @AlexeyKuznetsov-DD