refactor servlet modules #9621

amarziali · 2025-09-26T07:46:56Z

What Does This Do

Refactor instrumentation modules linked to the servlet api.

Notable changes:

division between javax-servlet and jakarta-servlet
servlet-common has been moved to javax-servlet/javax-servlet-iast since it contains only iast related stuff

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-official · 2025-09-26T08:32:23Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.89% (+0.04%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 8d6cb20 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-26T08:51:38Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/refactor4
git_commit_date	1759329350	1759332429
git_commit_sha	`836ba8d`	d6cb20a2ae
release_version	1.54.0-SNAPSHOT~836ba8d864	1.54.0-SNAPSHOT~8d6cb20a2ae

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759333699	1759333699
ci_job_id	1157689026	1157689026
ci_pipeline_id	78089969	78089969
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-12diutmq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-12diutmq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014122
Total [baseline] (10.706 s) : 0, 10706330
Agent [candidate] (1.014 s) : 0, 1014191
Total [candidate] (10.657 s) : 0, 10656809
section appsec
Agent [baseline] (1.199 s) : 0, 1198554
Total [baseline] (11.099 s) : 0, 11099265
Agent [candidate] (1.201 s) : 0, 1200516
Total [candidate] (11.169 s) : 0, 11168866
section iast
Agent [baseline] (1.145 s) : 0, 1145158
Total [baseline] (11.065 s) : 0, 11065441
Agent [candidate] (1.147 s) : 0, 1146547
Total [candidate] (11.069 s) : 0, 11069194
section profiling
Agent [baseline] (1.157 s) : 0, 1156890
Total [baseline] (11.062 s) : 0, 11061692
Agent [candidate] (1.17 s) : 0, 1169884
Total [candidate] (11.117 s) : 0, 11116620

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	appsec	1.199 s	184.432 ms (18.2%)
Agent	iast	1.145 s	131.036 ms (12.9%)
Agent	profiling	1.157 s	142.768 ms (14.1%)
Total	tracing	10.706 s	-
Total	appsec	11.099 s	392.936 ms (3.7%)
Total	iast	11.065 s	359.111 ms (3.4%)
Total	profiling	11.062 s	355.362 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	appsec	1.201 s	186.325 ms (18.4%)
Agent	iast	1.147 s	132.356 ms (13.1%)
Agent	profiling	1.17 s	155.694 ms (15.4%)
Total	tracing	10.657 s	-
Total	appsec	11.169 s	512.057 ms (4.8%)
Total	iast	11.069 s	412.385 ms (3.9%)
Total	profiling	11.117 s	459.811 ms (4.3%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (692.021 ms) : 0, 692021
BytebuddyAgent [candidate] (691.653 ms) : 0, 691653
GlobalTracer [baseline] (243.039 ms) : 0, 243039
GlobalTracer [candidate] (243.025 ms) : 0, 243025
AppSec [baseline] (31.065 ms) : 0, 31065
AppSec [candidate] (31.294 ms) : 0, 31294
Debugger [baseline] (6.342 ms) : 0, 6342
Debugger [candidate] (6.359 ms) : 0, 6359
Remote Config [baseline] (682.808 µs) : 0, 683
Remote Config [candidate] (671.669 µs) : 0, 672
Telemetry [baseline] (8.848 ms) : 0, 8848
Telemetry [candidate] (9.048 ms) : 0, 9048
Flare Poller [baseline] (9.411 ms) : 0, 9411
Flare Poller [candidate] (9.546 ms) : 0, 9546
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.478 ms) : 0, 1478
BytebuddyAgent [baseline] (721.07 ms) : 0, 721070
BytebuddyAgent [candidate] (722.33 ms) : 0, 722330
GlobalTracer [baseline] (236.624 ms) : 0, 236624
GlobalTracer [candidate] (236.965 ms) : 0, 236965
IAST [baseline] (25.284 ms) : 0, 25284
IAST [candidate] (25.148 ms) : 0, 25148
AppSec [baseline] (172.904 ms) : 0, 172904
AppSec [candidate] (174.334 ms) : 0, 174334
Debugger [baseline] (6.063 ms) : 0, 6063
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (644.705 µs) : 0, 645
Remote Config [candidate] (618.467 µs) : 0, 618
Telemetry [baseline] (9.266 ms) : 0, 9266
Telemetry [candidate] (8.355 ms) : 0, 8355
Flare Poller [baseline] (4.023 ms) : 0, 4023
Flare Poller [candidate] (4.041 ms) : 0, 4041
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (811.246 ms) : 0, 811246
BytebuddyAgent [candidate] (811.05 ms) : 0, 811050
GlobalTracer [baseline] (232.209 ms) : 0, 232209
GlobalTracer [candidate] (233.242 ms) : 0, 233242
IAST [baseline] (26.044 ms) : 0, 26044
IAST [candidate] (26.397 ms) : 0, 26397
AppSec [baseline] (33.987 ms) : 0, 33987
AppSec [candidate] (34.115 ms) : 0, 34115
Debugger [baseline] (5.934 ms) : 0, 5934
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (594.683 µs) : 0, 595
Remote Config [candidate] (584.559 µs) : 0, 585
Telemetry [baseline] (8.141 ms) : 0, 8141
Telemetry [candidate] (8.17 ms) : 0, 8170
Flare Poller [baseline] (4.171 ms) : 0, 4171
Flare Poller [candidate] (4.187 ms) : 0, 4187
section profiling
crashtracking [baseline] (1.419 ms) : 0, 1419
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (721.365 ms) : 0, 721365
BytebuddyAgent [candidate] (731.383 ms) : 0, 731383
GlobalTracer [baseline] (219.023 ms) : 0, 219023
GlobalTracer [candidate] (220.608 ms) : 0, 220608
AppSec [baseline] (31.375 ms) : 0, 31375
AppSec [candidate] (31.823 ms) : 0, 31823
Debugger [baseline] (6.606 ms) : 0, 6606
Debugger [candidate] (7.328 ms) : 0, 7328
Remote Config [baseline] (742.003 µs) : 0, 742
Remote Config [candidate] (782.378 µs) : 0, 782
Telemetry [baseline] (15.709 ms) : 0, 15709
Telemetry [candidate] (14.883 ms) : 0, 14883
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (5.061 ms) : 0, 5061
ProfilingAgent [baseline] (102.558 ms) : 0, 102558
ProfilingAgent [candidate] (102.712 ms) : 0, 102712
Profiling [baseline] (103.827 ms) : 0, 103827
Profiling [candidate] (103.95 ms) : 0, 103950

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015951
Total [baseline] (8.684 s) : 0, 8683867
Agent [candidate] (1.016 s) : 0, 1016364
Total [candidate] (8.651 s) : 0, 8650582
section iast
Agent [baseline] (1.157 s) : 0, 1157064
Total [baseline] (9.271 s) : 0, 9270567
Agent [candidate] (1.145 s) : 0, 1145354
Total [candidate] (9.268 s) : 0, 9267574

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.016 s	-
Agent	iast	1.157 s	141.113 ms (13.9%)
Total	tracing	8.684 s	-
Total	iast	9.271 s	586.699 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.016 s	-
Agent	iast	1.145 s	128.989 ms (12.7%)
Total	tracing	8.651 s	-
Total	iast	9.268 s	616.992 ms (7.1%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (692.286 ms) : 0, 692286
BytebuddyAgent [candidate] (692.678 ms) : 0, 692678
GlobalTracer [baseline] (242.856 ms) : 0, 242856
GlobalTracer [candidate] (243.164 ms) : 0, 243164
AppSec [baseline] (31.174 ms) : 0, 31174
AppSec [candidate] (31.448 ms) : 0, 31448
Debugger [baseline] (6.357 ms) : 0, 6357
Debugger [candidate] (6.347 ms) : 0, 6347
Remote Config [baseline] (684.862 µs) : 0, 685
Remote Config [candidate] (676.815 µs) : 0, 677
Telemetry [baseline] (8.867 ms) : 0, 8867
Telemetry [candidate] (9.066 ms) : 0, 9066
Flare Poller [baseline] (11.079 ms) : 0, 11079
Flare Poller [candidate] (10.369 ms) : 0, 10369
section iast
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (819.515 ms) : 0, 819515
BytebuddyAgent [candidate] (810.842 ms) : 0, 810842
GlobalTracer [baseline] (234.242 ms) : 0, 234242
GlobalTracer [candidate] (232.956 ms) : 0, 232956
AppSec [baseline] (34.295 ms) : 0, 34295
AppSec [candidate] (33.744 ms) : 0, 33744
Debugger [baseline] (6.053 ms) : 0, 6053
Debugger [candidate] (5.964 ms) : 0, 5964
Remote Config [baseline] (592.638 µs) : 0, 593
Remote Config [candidate] (580.281 µs) : 0, 580
Telemetry [baseline] (8.426 ms) : 0, 8426
Telemetry [candidate] (8.212 ms) : 0, 8212
Flare Poller [baseline] (4.228 ms) : 0, 4228
Flare Poller [candidate] (4.174 ms) : 0, 4174
IAST [baseline] (26.749 ms) : 0, 26749
IAST [candidate] (26.128 ms) : 0, 26128

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/refactor4
git_commit_date	1759329350	1759332336
git_commit_sha	`836ba8d`	d6cb20a2ae
release_version	1.54.0-SNAPSHOT~836ba8d864	1.54.0-SNAPSHOT~8d6cb20a2ae

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1759333274	1759333274
ci_job_id	1157689028	1157689028
ci_pipeline_id	78089969	78089969
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-484362t4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-484362t4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-744.861µs; -484.912µs] or [-8.818%; -5.741%]	unstable [-29.039op/s; +113.977op/s] or [-5.290%; +20.761%]	7.832ms	591.469op/s	8.447ms	549.000op/s
scenario:load:petclinic:no_agent:high_load	better [-2.859ms; -2.202ms] or [-7.388%; -5.689%]	unstable [+1.523op/s; +18.500op/s] or [+1.260%; +15.305%]	36.166ms	130.886op/s	38.697ms	120.875op/s
scenario:load:petclinic:profiling:high_load	better [-2.018ms; -1.022ms] or [-4.046%; -2.049%]	unstable [-2.840op/s; +11.164op/s] or [-3.027%; +11.899%]	48.358ms	97.987op/s	49.878ms	93.825op/s
scenario:load:petclinic:tracing:high_load	better [-2.196ms; -1.348ms] or [-4.834%; -2.968%]	unstable [-3.316op/s; +11.891op/s] or [-3.219%; +11.543%]	43.662ms	107.300op/s	45.434ms	103.013op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.302 ms) : 4253, 4351
.   : milestone, 4302,
iast (9.701 ms) : 9540, 9862
.   : milestone, 9701,
iast_FULL (14.193 ms) : 13916, 14470
.   : milestone, 14193,
iast_GLOBAL (10.104 ms) : 9924, 10284
.   : milestone, 10104,
profiling (9.0 ms) : 8849, 9151
.   : milestone, 9000,
tracing (8.447 ms) : 8323, 8571
.   : milestone, 8447,
section candidate
no_agent (4.313 ms) : 4265, 4361
.   : milestone, 4313,
iast (10.056 ms) : 9875, 10238
.   : milestone, 10056,
iast_FULL (13.856 ms) : 13580, 14132
.   : milestone, 13856,
iast_GLOBAL (10.447 ms) : 10265, 10629
.   : milestone, 10447,
profiling (8.882 ms) : 8742, 9021
.   : milestone, 8882,
tracing (7.832 ms) : 7715, 7950
.   : milestone, 7832,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.302 ms [4.253 ms, 4.351 ms]	-
iast	9.701 ms [9.54 ms, 9.862 ms]	5.399 ms (125.5%)
iast_FULL	14.193 ms [13.916 ms, 14.47 ms]	9.891 ms (229.9%)
iast_GLOBAL	10.104 ms [9.924 ms, 10.284 ms]	5.802 ms (134.9%)
profiling	9.0 ms [8.849 ms, 9.151 ms]	4.698 ms (109.2%)
tracing	8.447 ms [8.323 ms, 8.571 ms]	4.145 ms (96.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.313 ms [4.265 ms, 4.361 ms]	-
iast	10.056 ms [9.875 ms, 10.238 ms]	5.743 ms (133.2%)
iast_FULL	13.856 ms [13.58 ms, 14.132 ms]	9.543 ms (221.3%)
iast_GLOBAL	10.447 ms [10.265 ms, 10.629 ms]	6.134 ms (142.2%)
profiling	8.882 ms [8.742 ms, 9.021 ms]	4.569 ms (105.9%)
tracing	7.832 ms [7.715 ms, 7.95 ms]	3.519 ms (81.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.697 ms) : 38385, 39009
.   : milestone, 38697,
appsec (48.177 ms) : 47753, 48600
.   : milestone, 48177,
code_origins (44.169 ms) : 43799, 44539
.   : milestone, 44169,
iast (44.23 ms) : 43837, 44623
.   : milestone, 44230,
profiling (49.878 ms) : 49425, 50331
.   : milestone, 49878,
tracing (45.434 ms) : 45034, 45834
.   : milestone, 45434,
section candidate
no_agent (36.166 ms) : 35868, 36465
.   : milestone, 36166,
appsec (48.444 ms) : 48022, 48866
.   : milestone, 48444,
code_origins (44.573 ms) : 44198, 44948
.   : milestone, 44573,
iast (44.677 ms) : 44293, 45061
.   : milestone, 44677,
profiling (48.358 ms) : 47886, 48830
.   : milestone, 48358,
tracing (43.662 ms) : 43274, 44049
.   : milestone, 43662,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.697 ms [38.385 ms, 39.009 ms]	-
appsec	48.177 ms [47.753 ms, 48.6 ms]	9.48 ms (24.5%)
code_origins	44.169 ms [43.799 ms, 44.539 ms]	5.472 ms (14.1%)
iast	44.23 ms [43.837 ms, 44.623 ms]	5.534 ms (14.3%)
profiling	49.878 ms [49.425 ms, 50.331 ms]	11.182 ms (28.9%)
tracing	45.434 ms [45.034 ms, 45.834 ms]	6.737 ms (17.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.166 ms [35.868 ms, 36.465 ms]	-
appsec	48.444 ms [48.022 ms, 48.866 ms]	12.278 ms (33.9%)
code_origins	44.573 ms [44.198 ms, 44.948 ms]	8.407 ms (23.2%)
iast	44.677 ms [44.293 ms, 45.061 ms]	8.511 ms (23.5%)
profiling	48.358 ms [47.886 ms, 48.83 ms]	12.192 ms (33.7%)
tracing	43.662 ms [43.274 ms, 44.049 ms]	7.495 ms (20.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/refactor4
git_commit_date	1759329350	1759332341
git_commit_sha	`836ba8d`	d6cb20a2ae
release_version	1.54.0-SNAPSHOT~836ba8d864	1.54.0-SNAPSHOT~8d6cb20a2ae

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1759333847	1759333847
ci_job_id	1157689031	1157689031
ci_pipeline_id	78089969	78089969
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-vk2c0ul4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-vk2c0ul4 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.487 ms) : 1476, 1499
.   : milestone, 1487,
appsec (3.774 ms) : 3553, 3995
.   : milestone, 3774,
iast (2.233 ms) : 2169, 2297
.   : milestone, 2233,
iast_GLOBAL (2.281 ms) : 2216, 2345
.   : milestone, 2281,
profiling (2.102 ms) : 2049, 2155
.   : milestone, 2102,
tracing (2.039 ms) : 1990, 2089
.   : milestone, 2039,
section candidate
no_agent (1.489 ms) : 1477, 1501
.   : milestone, 1489,
appsec (3.739 ms) : 3520, 3958
.   : milestone, 3739,
iast (2.229 ms) : 2165, 2293
.   : milestone, 2229,
iast_GLOBAL (2.269 ms) : 2205, 2333
.   : milestone, 2269,
profiling (2.09 ms) : 2037, 2143
.   : milestone, 2090,
tracing (2.053 ms) : 2003, 2103
.   : milestone, 2053,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.487 ms [1.476 ms, 1.499 ms]	-
appsec	3.774 ms [3.553 ms, 3.995 ms]	2.286 ms (153.7%)
iast	2.233 ms [2.169 ms, 2.297 ms]	745.642 µs (50.1%)
iast_GLOBAL	2.281 ms [2.216 ms, 2.345 ms]	793.224 µs (53.3%)
profiling	2.102 ms [2.049 ms, 2.155 ms]	614.312 µs (41.3%)
tracing	2.039 ms [1.99 ms, 2.089 ms]	551.829 µs (37.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.489 ms [1.477 ms, 1.501 ms]	-
appsec	3.739 ms [3.52 ms, 3.958 ms]	2.25 ms (151.1%)
iast	2.229 ms [2.165 ms, 2.293 ms]	739.912 µs (49.7%)
iast_GLOBAL	2.269 ms [2.205 ms, 2.333 ms]	779.786 µs (52.4%)
profiling	2.09 ms [2.037 ms, 2.143 ms]	600.759 µs (40.3%)
tracing	2.053 ms [2.003 ms, 2.103 ms]	564.564 µs (37.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8d6cb20a2ae, baseline=1.54.0-SNAPSHOT~836ba8d864
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
appsec (14.948 s) : 14948000, 14948000
.   : milestone, 14948000,
iast (18.264 s) : 18264000, 18264000
.   : milestone, 18264000,
iast_GLOBAL (17.71 s) : 17710000, 17710000
.   : milestone, 17710000,
profiling (15.582 s) : 15582000, 15582000
.   : milestone, 15582000,
tracing (15.359 s) : 15359000, 15359000
.   : milestone, 15359000,
section candidate
no_agent (15.643 s) : 15643000, 15643000
.   : milestone, 15643000,
appsec (15.234 s) : 15234000, 15234000
.   : milestone, 15234000,
iast (18.484 s) : 18484000, 18484000
.   : milestone, 18484000,
iast_GLOBAL (17.844 s) : 17844000, 17844000
.   : milestone, 17844000,
profiling (15.257 s) : 15257000, 15257000
.   : milestone, 15257000,
tracing (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.106 s [15.106 s, 15.106 s]	-
appsec	14.948 s [14.948 s, 14.948 s]	-158.0 ms (-1.0%)
iast	18.264 s [18.264 s, 18.264 s]	3.158 s (20.9%)
iast_GLOBAL	17.71 s [17.71 s, 17.71 s]	2.604 s (17.2%)
profiling	15.582 s [15.582 s, 15.582 s]	476.0 ms (3.2%)
tracing	15.359 s [15.359 s, 15.359 s]	253.0 ms (1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.643 s [15.643 s, 15.643 s]	-
appsec	15.234 s [15.234 s, 15.234 s]	-409.0 ms (-2.6%)
iast	18.484 s [18.484 s, 18.484 s]	2.841 s (18.2%)
iast_GLOBAL	17.844 s [17.844 s, 17.844 s]	2.201 s (14.1%)
profiling	15.257 s [15.257 s, 15.257 s]	-386.0 ms (-2.5%)
tracing	15.0 s [15.0 s, 15.0 s]	-643.0 ms (-4.1%)

bric3

Looks good, but I would leave a comment on why order has to be set explicitly, maybe via a named constant rather than magic number.

...tadog/trace/instrumentation/servlet5/IastOptOutJakartaHttpServletRequestInstrumentation.java

...src/main/java/datadog/trace/instrumentation/servlet5/Servlet5RequestBodyInstrumentation.java

.../src/main/java/datadog/trace/instrumentation/servlet2/ServletRequestBodyInstrumentation.java

...ava/datadog/trace/instrumentation/servlet3/IastOptOutHttpServletRequest3Instrumentation.java

...et-3.0/src/main/java/datadog/trace/instrumentation/servlet3/IastServlet3Instrumentation.java

...rc/main/java/datadog/trace/instrumentation/servlet3/Servlet31RequestBodyInstrumentation.java

manuel-alvarez-alvarez

LGTM

amarziali requested review from a team as code owners September 26, 2025 07:46

amarziali added the type: enhancement Enhancements and improvements label Sep 26, 2025

amarziali requested a review from smola September 26, 2025 07:46

amarziali added the tag: no release notes Changes to exclude from release notes label Sep 26, 2025

amarziali requested a review from sezen-datadog September 26, 2025 07:46

amarziali added type: refactoring inst:servlet Servlet instrumentation labels Sep 26, 2025

amarziali force-pushed the andrea.marziali/refactor4 branch from 59e2158 to 34bc050 Compare September 26, 2025 08:11

PerfectSlayer approved these changes Sep 26, 2025

View reviewed changes

amarziali force-pushed the andrea.marziali/refactor4 branch 2 times, most recently from e23a8d2 to c6d02be Compare October 1, 2025 08:19

bric3 approved these changes Oct 1, 2025

View reviewed changes

manuel-alvarez-alvarez approved these changes Oct 1, 2025

View reviewed changes

amarziali added 3 commits October 1, 2025 17:15

refactor servlet modules

7b8e506

make iast things applying later

c3c4d93

add comments

8d6cb20

amarziali force-pushed the andrea.marziali/refactor4 branch from 03609d4 to 8d6cb20 Compare October 1, 2025 15:15

amarziali enabled auto-merge (squash) October 1, 2025 15:16

amarziali merged commit 5912cf3 into master Oct 1, 2025
531 of 534 checks passed

amarziali deleted the andrea.marziali/refactor4 branch October 1, 2025 16:05

github-actions bot added this to the 1.54.0 milestone Oct 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor servlet modules #9621

refactor servlet modules #9621

Uh oh!

amarziali commented Sep 26, 2025

Uh oh!

datadog-official bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

bric3 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

refactor servlet modules #9621

refactor servlet modules #9621

Uh oh!

Conversation

amarziali commented Sep 26, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

datadog-official bot commented Sep 26, 2025 •

edited

Loading

pr-commenter bot commented Sep 26, 2025 •

edited

Loading

bric3 left a comment •

edited

Loading