-
Notifications
You must be signed in to change notification settings - Fork 323
Simplify HelperInjector to make it easier to switch out the underlying approach
#9643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…HelperInjector This helps decouple internals and provides the same feedback with simpler code
…-loader in this class
|
🎯 Code Coverage 🔗 Commit SHA: 068d4aa | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1014637
Total [baseline] (8.674 s) : 0, 8674229
Agent [candidate] (1.017 s) : 0, 1016852
Total [candidate] (8.692 s) : 0, 8692382
section iast
Agent [baseline] (1.165 s) : 0, 1165256
Total [baseline] (9.283 s) : 0, 9283139
Agent [candidate] (1.147 s) : 0, 1146981
Total [candidate] (9.269 s) : 0, 9268841
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (691.77 ms) : 0, 691770
BytebuddyAgent [candidate] (691.768 ms) : 0, 691768
GlobalTracer [baseline] (243.54 ms) : 0, 243540
GlobalTracer [candidate] (243.678 ms) : 0, 243678
AppSec [baseline] (31.558 ms) : 0, 31558
AppSec [candidate] (31.099 ms) : 0, 31099
Debugger [baseline] (6.384 ms) : 0, 6384
Debugger [candidate] (6.307 ms) : 0, 6307
Remote Config [baseline] (684.909 µs) : 0, 685
Remote Config [candidate] (671.74 µs) : 0, 672
Telemetry [baseline] (9.189 ms) : 0, 9189
Telemetry [candidate] (8.968 ms) : 0, 8968
Flare Poller [baseline] (8.849 ms) : 0, 8849
Flare Poller [candidate] (11.794 ms) : 0, 11794
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (826.387 ms) : 0, 826387
BytebuddyAgent [candidate] (811.788 ms) : 0, 811788
GlobalTracer [baseline] (235.874 ms) : 0, 235874
GlobalTracer [candidate] (232.828 ms) : 0, 232828
AppSec [baseline] (34.001 ms) : 0, 34001
AppSec [candidate] (33.093 ms) : 0, 33093
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.089 ms) : 0, 6089
Remote Config [baseline] (590.836 µs) : 0, 591
Remote Config [candidate] (598.397 µs) : 0, 598
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.365 ms) : 0, 8365
Flare Poller [baseline] (4.287 ms) : 0, 4287
Flare Poller [candidate] (4.226 ms) : 0, 4226
IAST [baseline] (26.702 ms) : 0, 26702
IAST [candidate] (27.135 ms) : 0, 27135
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016224
Total [baseline] (10.724 s) : 0, 10723759
Agent [candidate] (1.016 s) : 0, 1015801
Total [candidate] (10.754 s) : 0, 10753640
section appsec
Agent [baseline] (1.192 s) : 0, 1191821
Total [baseline] (11.083 s) : 0, 11082571
Agent [candidate] (1.208 s) : 0, 1208254
Total [candidate] (11.151 s) : 0, 11151372
section iast
Agent [baseline] (1.153 s) : 0, 1152906
Total [baseline] (11.006 s) : 0, 11005606
Agent [candidate] (1.148 s) : 0, 1148120
Total [candidate] (10.938 s) : 0, 10938497
section profiling
Agent [baseline] (1.159 s) : 0, 1159030
Total [baseline] (11.146 s) : 0, 11145976
Agent [candidate] (1.154 s) : 0, 1153661
Total [candidate] (11.056 s) : 0, 11055885
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (692.222 ms) : 0, 692222
BytebuddyAgent [candidate] (691.111 ms) : 0, 691111
GlobalTracer [baseline] (243.674 ms) : 0, 243674
GlobalTracer [candidate] (243.165 ms) : 0, 243165
AppSec [baseline] (31.205 ms) : 0, 31205
AppSec [candidate] (31.159 ms) : 0, 31159
Debugger [baseline] (6.332 ms) : 0, 6332
Debugger [candidate] (6.329 ms) : 0, 6329
Remote Config [baseline] (683.744 µs) : 0, 684
Remote Config [candidate] (671.629 µs) : 0, 672
Telemetry [baseline] (9.04 ms) : 0, 9040
Telemetry [candidate] (8.955 ms) : 0, 8955
Flare Poller [baseline] (10.377 ms) : 0, 10377
Flare Poller [candidate] (11.749 ms) : 0, 11749
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (717.399 ms) : 0, 717399
BytebuddyAgent [candidate] (727.58 ms) : 0, 727580
GlobalTracer [baseline] (235.067 ms) : 0, 235067
GlobalTracer [candidate] (238.128 ms) : 0, 238128
IAST [baseline] (24.893 ms) : 0, 24893
IAST [candidate] (25.432 ms) : 0, 25432
AppSec [baseline] (172.876 ms) : 0, 172876
AppSec [candidate] (172.559 ms) : 0, 172559
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.159 ms) : 0, 6159
Remote Config [baseline] (627.417 µs) : 0, 627
Remote Config [candidate] (638.528 µs) : 0, 639
Telemetry [baseline] (8.32 ms) : 0, 8320
Telemetry [candidate] (9.931 ms) : 0, 9931
Flare Poller [baseline] (4.006 ms) : 0, 4006
Flare Poller [candidate] (4.879 ms) : 0, 4879
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (817.022 ms) : 0, 817022
BytebuddyAgent [candidate] (813.495 ms) : 0, 813495
GlobalTracer [baseline] (233.48 ms) : 0, 233480
GlobalTracer [candidate] (232.633 ms) : 0, 232633
IAST [baseline] (26.588 ms) : 0, 26588
IAST [candidate] (26.147 ms) : 0, 26147
AppSec [baseline] (33.8 ms) : 0, 33800
AppSec [candidate] (34.013 ms) : 0, 34013
Debugger [baseline] (6.035 ms) : 0, 6035
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (594.041 µs) : 0, 594
Remote Config [candidate] (573.51 µs) : 0, 574
Telemetry [baseline] (8.197 ms) : 0, 8197
Telemetry [candidate] (8.133 ms) : 0, 8133
Flare Poller [baseline] (4.217 ms) : 0, 4217
Flare Poller [candidate] (4.187 ms) : 0, 4187
section profiling
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (725.048 ms) : 0, 725048
BytebuddyAgent [candidate] (721.287 ms) : 0, 721287
GlobalTracer [baseline] (218.364 ms) : 0, 218364
GlobalTracer [candidate] (218.083 ms) : 0, 218083
AppSec [baseline] (31.479 ms) : 0, 31479
AppSec [candidate] (31.311 ms) : 0, 31311
Debugger [baseline] (6.527 ms) : 0, 6527
Debugger [candidate] (6.519 ms) : 0, 6519
Remote Config [baseline] (719.3 µs) : 0, 719
Remote Config [candidate] (727.64 µs) : 0, 728
Telemetry [baseline] (16.304 ms) : 0, 16304
Telemetry [candidate] (16.542 ms) : 0, 16542
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (4.224 ms) : 0, 4224
ProfilingAgent [baseline] (102.133 ms) : 0, 102133
ProfilingAgent [candidate] (101.005 ms) : 0, 101005
Profiling [baseline] (102.723 ms) : 0, 102723
Profiling [candidate] (101.569 ms) : 0, 101569
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section baseline
no_agent (4.386 ms) : 4336, 4437
. : milestone, 4386,
iast (9.79 ms) : 9627, 9952
. : milestone, 9790,
iast_FULL (14.304 ms) : 14016, 14592
. : milestone, 14304,
iast_GLOBAL (11.525 ms) : 11315, 11735
. : milestone, 11525,
profiling (8.587 ms) : 8446, 8728
. : milestone, 8587,
tracing (7.994 ms) : 7879, 8108
. : milestone, 7994,
section candidate
no_agent (4.231 ms) : 4183, 4279
. : milestone, 4231,
iast (9.849 ms) : 9686, 10012
. : milestone, 9849,
iast_FULL (14.751 ms) : 14451, 15050
. : milestone, 14751,
iast_GLOBAL (11.106 ms) : 10907, 11305
. : milestone, 11106,
profiling (9.097 ms) : 8945, 9250
. : milestone, 9097,
tracing (7.769 ms) : 7660, 7879
. : milestone, 7769,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section baseline
no_agent (38.014 ms) : 37706, 38321
. : milestone, 38014,
appsec (49.392 ms) : 48949, 49835
. : milestone, 49392,
code_origins (44.399 ms) : 44013, 44784
. : milestone, 44399,
iast (45.744 ms) : 45331, 46156
. : milestone, 45744,
profiling (48.973 ms) : 48537, 49408
. : milestone, 48973,
tracing (44.485 ms) : 44098, 44871
. : milestone, 44485,
section candidate
no_agent (37.406 ms) : 37096, 37717
. : milestone, 37406,
appsec (47.357 ms) : 46924, 47790
. : milestone, 47357,
code_origins (44.335 ms) : 43956, 44715
. : milestone, 44335,
iast (43.763 ms) : 43390, 44136
. : milestone, 43763,
profiling (49.508 ms) : 49002, 50014
. : milestone, 49508,
tracing (45.27 ms) : 44884, 45656
. : milestone, 45270,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.709 ms) : 3490, 3928
. : milestone, 3709,
iast (2.215 ms) : 2151, 2278
. : milestone, 2215,
iast_GLOBAL (2.249 ms) : 2185, 2312
. : milestone, 2249,
profiling (2.067 ms) : 2016, 2118
. : milestone, 2067,
tracing (2.025 ms) : 1976, 2074
. : milestone, 2025,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.469 ms) : 2418, 2520
. : milestone, 2469,
iast (2.214 ms) : 2151, 2278
. : milestone, 2214,
iast_GLOBAL (2.257 ms) : 2193, 2321
. : milestone, 2257,
profiling (2.077 ms) : 2025, 2130
. : milestone, 2077,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~068d4aae7d, baseline=1.54.0-SNAPSHOT~450f7b5139
dateFormat X
axisFormat %s
section baseline
no_agent (15.449 s) : 15449000, 15449000
. : milestone, 15449000,
appsec (15.147 s) : 15147000, 15147000
. : milestone, 15147000,
iast (18.56 s) : 18560000, 18560000
. : milestone, 18560000,
iast_GLOBAL (17.661 s) : 17661000, 17661000
. : milestone, 17661000,
profiling (15.715 s) : 15715000, 15715000
. : milestone, 15715000,
tracing (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
section candidate
no_agent (15.559 s) : 15559000, 15559000
. : milestone, 15559000,
appsec (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
iast (18.725 s) : 18725000, 18725000
. : milestone, 18725000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.494 s) : 15494000, 15494000
. : milestone, 15494000,
tracing (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
|
…ation is muzzled, its helpers won't be injected
What Does This Do
This helps decouple internals and provides the same feedback with simpler code
Motivation
Makes it easier to switch out the underlying approach.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]