Skip to content

Lower logging level for RepoIndex error #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-mohedano merged 2 commits into from
Oct 8, 2025
Merged

Lower logging level for RepoIndex error #9697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f65e52
fix: lower logging level for repo index error
daniel-mohedano Oct 8, 2025
ab29d63
fix: update test fixtures
daniel-mohedano Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../agent-ci-visibility/src/main/java/datadog/trace/civisibility/source/index/RepoIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private String getFallbackSourcePath(@Nonnull Class<?> c) throws SourceResolutio
try {
String fileName = Utils.getFileName(c);
if (fileName == null) {
log.error("Could not retrieve file name for class {}", c.getName());
log.debug("Could not retrieve file name for class {}", c.getName());
return null;
}

Expand Down
16 changes: 8 additions & 8 deletions dd-java-agent/instrumentation/junit/junit-4.10/src/test/groovy/JUnit4Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ class JUnit4Test extends CiVisibilityInstrumentationTest {

where:
testcaseName | success | tests | retriedTests
// "test-failed" | false | [TestFailed] | []
"test-failed" | false | [TestFailed] | []
"test-retry-failed" | false | [TestFailed] | [new TestFQN("org.example.TestFailed", "test_failed")]
// "test-failed-then-succeed" | true | [TestFailedThenSucceed] | [new TestFQN("org.example.TestFailedThenSucceed", "test_failed_then_succeed")]
// "test-assumption-is-not-retried" | true | [TestAssumption] | [new TestFQN("org.example.TestAssumption", "test_fail_assumption")]
// "test-skipped-is-not-retried" | true | [TestSkipped] | [new TestFQN("org.example.TestSkipped", "test_skipped")]
// "test-retry-parameterized" | false | [TestFailedParameterized] | [
// new TestFQN("org.example.TestFailedParameterized", "test_failed_parameterized") /* backend cannot provide parameters for flaky parameterized tests yet */
// ]
// "test-expected-exception-is-not-retried" | true | [TestSucceedExpectedException] | [new TestFQN("org.example.TestSucceedExpectedException", "test_succeed")]
"test-failed-then-succeed" | true | [TestFailedThenSucceed] | [new TestFQN("org.example.TestFailedThenSucceed", "test_failed_then_succeed")]
"test-assumption-is-not-retried" | true | [TestAssumption] | [new TestFQN("org.example.TestAssumption", "test_fail_assumption")]
"test-skipped-is-not-retried" | true | [TestSkipped] | [new TestFQN("org.example.TestSkipped", "test_skipped")]
"test-retry-parameterized" | false | [TestFailedParameterized] | [
new TestFQN("org.example.TestFailedParameterized", "test_failed_parameterized") /* backend cannot provide parameters for flaky parameterized tests yet */
]
"test-expected-exception-is-not-retried" | true | [TestSucceedExpectedException] | [new TestFQN("org.example.TestSucceedExpectedException", "test_succeed")]
Comment on lines +80 to +88
Copy link
Contributor Author

@daniel-mohedano daniel-mohedano Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed this in #9478 😭

Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!

}

def "test early flakiness detection #testcaseName"() {
Expand Down
9 changes: 6 additions & 3 deletions ...t/instrumentation/junit/junit-4.10/src/test/resources/test-failed-then-succeed/events.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"test.command" : "junit-4.10",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.status" : "fail",
"test.status" : "pass",
"test.type" : "test",
"test_session.name" : "session-name"
},
Expand Down Expand Up @@ -48,7 +48,7 @@
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.module" : "junit-4.10",
"test.status" : "fail",
"test.status" : "pass",
"test.type" : "test",
"test_session.name" : "session-name"
},
Expand Down Expand Up @@ -80,7 +80,7 @@
"test.framework_version" : ${content_meta_test_framework_version},
"test.module" : "junit-4.10",
"test.source.file" : "dummy_source_path",
"test.status" : "fail",
"test.status" : "pass",
"test.suite" : "org.example.TestFailedThenSucceed",
"test.type" : "test",
"test_session.name" : "session-name"
Expand Down Expand Up @@ -118,6 +118,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.module" : "junit-4.10",
Expand Down Expand Up @@ -168,6 +169,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.is_retry" : "true",
Expand Down Expand Up @@ -220,6 +222,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.is_retry" : "true",
Expand Down
4 changes: 4 additions & 0 deletions ...t/instrumentation/junit/junit-4.10/src/test/resources/test-retry-parameterized/events.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.module" : "junit-4.10",
Expand Down Expand Up @@ -169,6 +170,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.is_retry" : "true",
Expand Down Expand Up @@ -222,6 +224,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.is_retry" : "true",
Expand Down Expand Up @@ -275,6 +278,7 @@
"runtime-id" : ${content_meta_runtime_id},
"span.kind" : "test",
"test.codeowners" : "[\"owner1\",\"owner2\"]",
"test.failure_suppressed" : "true",
"test.framework" : "junit4",
"test.framework_version" : ${content_meta_test_framework_version},
"test.is_retry" : "true",
Expand Down