Skip to content

Commit

Permalink
share telemetry request metric symbol
Browse files Browse the repository at this point in the history
  • Loading branch information
IlyasShabi committed Feb 19, 2025
1 parent bc8bb99 commit 28ca64d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 8 deletions.
5 changes: 4 additions & 1 deletion packages/dd-trace/src/appsec/telemetry/common.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strinct'

const DD_TELEMETRY_REQUEST_METRICS = Symbol('_dd.appsec.telemetry.request.metrics')

const tags = {
BLOCK_FAILURE: 'block_failure',
EVENT_RULES_VERSION: 'event_rules_version',
Expand All @@ -20,5 +22,6 @@ function getVersionsTags (wafVersion, rulesVersion) {

module.exports = {
tags,
getVersionsTags
getVersionsTags,
DD_TELEMETRY_REQUEST_METRICS
}
3 changes: 1 addition & 2 deletions packages/dd-trace/src/appsec/telemetry/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict'

const { DD_TELEMETRY_REQUEST_METRICS } = require('./common')
const { addRaspRequestMetrics, trackRaspMetrics } = require('./rasp')
const { incrementMissingUserId, incrementMissingUserLogin } = require('./user')
const {
Expand All @@ -10,8 +11,6 @@ const {
incrementWafRequests
} = require('./waf')

const DD_TELEMETRY_REQUEST_METRICS = Symbol('_dd.appsec.telemetry.request.metrics')

const metricsStoreMap = new WeakMap()

let enabled = false
Expand Down
4 changes: 1 addition & 3 deletions packages/dd-trace/src/appsec/telemetry/rasp.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
'use strict'

const telemetryMetrics = require('../../telemetry/metrics')
const { getVersionsTags } = require('./common')
const { DD_TELEMETRY_REQUEST_METRICS, getVersionsTags } = require('./common')

const appsecMetrics = telemetryMetrics.manager.namespace('appsec')

const DD_TELEMETRY_REQUEST_METRICS = Symbol('_dd.appsec.telemetry.request.metrics')

function addRaspRequestMetrics (store, { duration, durationExt, wafTimeout, errorCode }) {
store[DD_TELEMETRY_REQUEST_METRICS].raspDuration += duration || 0
store[DD_TELEMETRY_REQUEST_METRICS].raspDurationExt += durationExt || 0
Expand Down
3 changes: 1 addition & 2 deletions packages/dd-trace/src/appsec/telemetry/waf.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
'use strict'

const telemetryMetrics = require('../../telemetry/metrics')
const { tags, getVersionsTags } = require('./common')
const { tags, getVersionsTags, DD_TELEMETRY_REQUEST_METRICS } = require('./common')

const appsecMetrics = telemetryMetrics.manager.namespace('appsec')

const DD_TELEMETRY_WAF_RESULT_TAGS = Symbol('_dd.appsec.telemetry.waf.result.tags')
const DD_TELEMETRY_REQUEST_METRICS = Symbol('_dd.appsec.telemetry.request.metrics')

const TRUNCATION_FLAGS = {
LONG_STRING: 1,
Expand Down

0 comments on commit 28ca64d

Please sign in to comment.