[test optimization] Fix logic to bypass jest's require cache (#4950)

integration-tests/ci-visibility/office-addin-mock/dependency.js

@@ -0,0 +1,7 @@
+require('office-addin-mock')
+
+function sum (a, b) {
+  return a + b
+}
+
+module.exports = sum

integration-tests/ci-visibility/office-addin-mock/test.js

@@ -0,0 +1,6 @@
+const sum = require('./dependency')
+const { expect } = require('chai')
+
+test('can sum', () => {
+  expect(sum(1, 2)).to.equal(3)
+})

integration-tests/jest/jest.spec.js

@@ -61,7 +61,13 @@ describe('jest CommonJS', () => {
   let testOutput = ''
 
   before(async function () {
-    sandbox = await createSandbox(['jest', 'chai@v4', 'jest-jasmine2', 'jest-environment-jsdom'], true)
+    sandbox = await createSandbox([
+      'jest',
+      'chai@v4',
+      'jest-jasmine2',
+      'jest-environment-jsdom',
+      'office-addin-mock'
+    ], true)
     cwd = sandbox.folder
     startupTestFile = path.join(cwd, testFile)
   })
@@ -2604,4 +2610,46 @@ describe('jest CommonJS', () => {
       })
     })
   })
+
+  // This happens when using office-addin-mock
+  context('a test imports a file whose name includes a library we should bypass jest require cache for', () => {
+    it('does not crash', (done) => {
+      receiver.setSettings({
+        itr_enabled: false,
+        code_coverage: false,
+        tests_skipping: false,
+        flaky_test_retries_enabled: false,
+        early_flake_detection: {
+          enabled: false
+        }
+      })
+
+      const eventsPromise = receiver
+        .gatherPayloadsMaxTimeout(({ url }) => url.endsWith('/api/v2/citestcycle'), (payloads) => {
+          const events = payloads.flatMap(({ payload }) => payload.events)
+
+          const tests = events.filter(event => event.type === 'test').map(event => event.content)
+
+          assert.equal(tests.length, 1)
+        })
+
+      childProcess = exec(runTestsWithCoverageCommand,
+        {
+          cwd,
+          env: {
+            ...getCiVisAgentlessConfig(receiver.port),
+            TESTS_TO_RUN: 'office-addin-mock/test'
+          },
+          stdio: 'inherit'
+        }
+      )
+
+      childProcess.on('exit', (code) => {
+        eventsPromise.then(() => {
+          assert.equal(code, 0)
+          done()
+        }).catch(done)
+      })
+    })
+  })
 })

packages/datadog-instrumentations/src/jest.js

@@ -861,12 +861,18 @@ addHook({
 
 const LIBRARIES_BYPASSING_JEST_REQUIRE_ENGINE = [
   'selenium-webdriver',
+  'selenium-webdriver/chrome',
+  'selenium-webdriver/edge',
+  'selenium-webdriver/safari',
+  'selenium-webdriver/firefox',
+  'selenium-webdriver/ie',
+  'selenium-webdriver/chromium',
   'winston'
 ]
 
 function shouldBypassJestRequireEngine (moduleName) {
   return (
-    LIBRARIES_BYPASSING_JEST_REQUIRE_ENGINE.some(library => moduleName.includes(library))
+    LIBRARIES_BYPASSING_JEST_REQUIRE_ENGINE.includes(moduleName)
   )
 }