Skip to content

Commit

Permalink
make it pass hopefully
Browse files Browse the repository at this point in the history
  • Loading branch information
bengl committed Aug 30, 2024
1 parent 51b3d3c commit 98d2f89
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/plugins.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,17 @@ jobs:
strategy:
matrix:
node-version: [16]
range: ['>=4.0.0 <5.2.0']
range: ['>=4.0.0 5.8.0']
aerospike-image: [ce-5.7.0.15]
include:
- node-version: 18
range: '5.2.0 - 5.7.0'
range: '>=5.2.0'
aerospike-image: ce-6.4.0.3
- node-version: 20
range: '>=5.8.0'
range: '>=5.5.0'
aerospike-image: ce-6.4.0.3
- node-version: latest
range: '>=5.8.0'
- node-version: 22
range: '>=5.12.1'
aerospike-image: ce-6.4.0.3
runs-on: ubuntu-latest
services:
Expand Down
11 changes: 5 additions & 6 deletions packages/datadog-instrumentations/src/aerospike.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,16 @@ function wrapProcess (process) {
}

const versions = (() => {

switch (NODE_MAJOR) {
case 16:
case 17:
return ['>=4 <5.2.0']
return ['>=4.0.0 <5.8.0']
case 18:
case 19:
return ['5.2.0 - 5.7.0']
return ['>=5.2.0']
case 20:
return ['>=5.5.0']
case 22:
return ['>=5.12.1']
default:
return ['>=5.8.0']
}
})()

Expand Down
4 changes: 3 additions & 1 deletion scripts/verify-ci-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ function getRangesFromYaml (job) {
}
nodeVersion = nodeVersion.map(v => Number(v))
if (nodeVersion.includes(nodeMajor)) {
return [possibility.range].flat()
if (possibility.range) {
return [possibility.range].flat()
}
}
}
} else if (job.strategy && job.strategy.matrix && job.strategy.matrix.range) {
Expand Down

0 comments on commit 98d2f89

Please sign in to comment.