Fix aws-sdk distributed tracing when using .promise() #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `.promise()` there is no callback for `dd-trace-js` to wrap. Before this change, that meant we never called tracer.extract on any incoming requests. This changes the functionality by creating a "fake" callback for us to wrap and then immediately calling it. Fixes DataDog#1680
|
@rochdev The code here is pretty messy still. More of a POC than anything else ATM. Happy to clean it up / add additional tests still |
rochdev
requested changes
Nov 9, 2021
There was a problem hiding this comment.
Thanks for the PR! However, this only works for a very specific usage of the library. Please see #1680 (comment) for more context and a potential alternative solution.
|
Is this a feature that you'd still be interested in working on? Looks like there are some conflicts and that Roch had some concerns. |
|
I'll close this PR for now but we can consider reopening it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using
.promise()there is no callback fordd-trace-jsto wrap.Before this change, that meant we never called tracer.extract on any
incoming requests.
This changes the functionality by creating a "fake" callback for us to
wrap and then immediately calling it.
Motivation
We use the
sqs-consumerlibrary that usessqs.receiveMessage({}).promise(). Meaning we currently don't get any distributed traces currently.Plugin Checklist
Additional Notes
Fixes #1680