[GraphQL] Include variables in metadata. #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
commented
Aug 16, 2018
| | Option | Default | Description | | ||
| |-----------------|--------------------------------------------------|------------------------------------------------------------------| | ||
| | service | *Service name of the app suffixed with -graphql* | The service name for this integration. | | ||
| | filterVariables | `variables => variables` | A callback that allows filtering of variables before submission. | |
There was a problem hiding this comment.
This default value isn’t actually defined like that (if none is specified it just gets skipped), but I used it to illustrate the signature of the callback.
alloy
force-pushed
the
graphql-include-variables
branch
2 times, most recently
from
2baae83 to
cac8288
Compare
|
Looks like the CI failure may just be a hiccup, but can’t re-run the job. |
This allows one to identify problematic queries when specific variables are applied. A filter callback is included so sensitive data can be redacted.
alloy
force-pushed
the
graphql-include-variables
branch
from
cac8288 to
02be1d2
Compare
This was referenced Aug 16, 2018
|
Seeing as you did review of this code in #245, I’m going to close this one in favour of that PR and do it all in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to identify problematic queries when specific variables are applied.
A filter callback is included so sensitive data can be redacted, which I assume is why this wasn’t included yet.