v0.6.0 #293
Merged
v0.6.0 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les in metadata (#245) * [GraphQL] Include variables in metadata. This allows one to identify problematic queries when specific variables are applied. A filter callback is included so sensitive data can be redacted. * [GraphQL] Instrument document parsing and validation.
* Respect and propagate X-Datadog-Sampling-Priority. Note that this does not provide a user API for setting user keep/discard, instead it merely respects any existing priority headers. Fixes #208. * Add test that samplingPriority is passed to child spans. * Remove extra newline. * Include the sampling priority metric key. This should tell the trace agent to include the priority sample-based sampler and to appropriately flag our spans for recording. * Fix ifs that should check undefined; keep sampled separate. Added/condensed tests for all four priority values, -1/0/1/2. * Test all priorities in span.spec.js as well. * Put sampled back before baggageItems. Just makes the diff nicer. * Cover all priorities in span_context.spec.js. * If priority header isn't available, still use sampling. Previously (even prior to this priority header PR AFAICT), the default behavior for extracted-from-carrier span contexts was to always be sampled. Since any child spans created by the application would see this carrier-extracted context, that meant we basically short-circuited any sampling that might have happened. This passes the tracer into the propagators so that, when making a top-level span context, they can decide whether it should be sampled. * update sampling priority with the full functionality * code cleanup * fix merge result + code cleanup * fix tests * code cleanup * move priority sampling out of the propagators * add a constant for sampling priority key * make priorities a set to avoid looping the array * code cleanup * code cleanup * code cleanup
palazzem
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.