-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote glob patterns in tests #2942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting prevents shell expansion.
Overall package sizeSelf size: 3.98 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
+ Coverage 79.20% 87.44% +8.23%
==========================================
Files 8 327 +319
Lines 428 11707 +11279
Branches 33 33
==========================================
+ Hits 339 10237 +9898
- Misses 89 1470 +1381 see 319 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rochdev
approved these changes
Mar 27, 2023
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting prevents shell expansion.
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting prevents shell expansion.
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting prevents shell expansion.
juan-fernandez
pushed a commit
that referenced
this pull request
Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting prevents shell expansion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quote all glob patterns in package.json
Motivation
**/*.js.spec
is interpreted as*/*.js.spec
by some shells, thus some tests are not run, quoting prevents shell expansion.