Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote glob patterns in tests #2942

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

nsavoire
Copy link
Collaborator

What does this PR do?

Quote all glob patterns in package.json

Motivation

**/*.js.spec is interpreted as */*.js.spec by some shells, thus some tests are not run, quoting prevents shell expansion.

`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting
prevents shell expansion.
@nsavoire nsavoire requested a review from a team as a code owner March 27, 2023 18:28
@github-actions
Copy link

Overall package size

Self size: 3.98 MB
Deduped: 59.49 MB
No deduping: 59.53 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.1.1 13.38 MB 13.39 MB
@datadog/pprof 2.1.0 12.31 MB 13.2 MB
@datadog/native-appsec 2.0.0 12.33 MB 12.34 MB
@datadog/native-metrics 1.5.0 7.1 MB 7.11 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
opentracing 0.14.7 194.81 kB 194.81 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
semver 5.7.1 61.58 kB 61.58 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.4 32.7 kB 37.17 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2942 (c443fdf) into master (32fac9e) will increase coverage by 8.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
+ Coverage   79.20%   87.44%   +8.23%     
==========================================
  Files           8      327     +319     
  Lines         428    11707   +11279     
  Branches       33       33              
==========================================
+ Hits          339    10237    +9898     
- Misses         89     1470    +1381     

see 319 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2023

Benchmarks

Comparing candidate commit c443fdf in PR branch nsavoire/fix_test_glob_patterns with baseline commit 32fac9e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 669 metrics, 39 unstable metrics.

@nsavoire nsavoire merged commit 913d77c into master Mar 27, 2023
@nsavoire nsavoire deleted the nsavoire/fix_test_glob_patterns branch March 27, 2023 19:08
juan-fernandez pushed a commit that referenced this pull request Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting
prevents shell expansion.
juan-fernandez pushed a commit that referenced this pull request Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting
prevents shell expansion.
juan-fernandez pushed a commit that referenced this pull request Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting
prevents shell expansion.
juan-fernandez pushed a commit that referenced this pull request Mar 28, 2023
`**/*.js.spec` is interpreted as `*/*.js.spec` by some shells, quoting
prevents shell expansion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants