Use sampling on timeline events #4861
Merged
+64
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 8.22 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
szegedi
force-pushed
the
szegedi/sample-timeline-events
branch
from
94ce9f6 to
6d5c5cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4861 +/- ##
===========================================
+ Coverage 74.33% 93.81% +19.48%
===========================================
Files 284 107 -177
Lines 13198 3365 -9833
===========================================
- Hits 9811 3157 -6654
+ Misses 3387 208 -3179 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-12-03 10:56:15 Comparing candidate commit 676742d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
…nt attributes when it would be discarded
szegedi
force-pushed
the
szegedi/sample-timeline-events
branch
2 times, most recently
from
33e40c4 to
aa2474f
Compare
szegedi
force-pushed
the
szegedi/sample-timeline-events
branch
from
aa2474f to
676742d
Compare
nsavoire
reviewed
Dec 3, 2024
| const eventHandler = event => this.eventSerializer.addEvent(event) | ||
| const eventFilter = options.timelineSamplingEnabled | ||
| // options.samplingInterval comes in microseconds, we need millis | ||
| ? createPossionProcessSamplingFilter((options.samplingInterval ?? 1e6 / 99) / 1000) |
There was a problem hiding this comment.
I was surprised to see that we never define options.samplingInterval in the config and therefore rely on the defaults set in WallProfiler / EventsProfiler
nsavoire
approved these changes
Dec 3, 2024
IlyasShabi
pushed a commit
that referenced
this pull request
Dec 16, 2024
rochdev
pushed a commit
that referenced
this pull request
Dec 17, 2024
Merged
rochdev
pushed a commit
that referenced
this pull request
Dec 17, 2024
Merged
rochdev
pushed a commit
that referenced
this pull request
Dec 18, 2024
rochdev
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of recording all events for the timeline, uses sampling to only select those events that occur during sampling instants. Sampling instants are produced by a Poisson point process with rate equal to the overall configured profiling sampling rate.
Motivation
We'll be introducing some new event types, increasing their cardinality. Introducing sampling will reduce the number of recorded events, with higher likelihood of discarding short events.
Additional Notes
JIRA issue PROF-10852