Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] [SDTEST-1332] Fetch di_enabled flag #5006

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Dec 12, 2024

What does this PR do?

Fetch the new di_enabled backend flag to determine whether Dynamic Instrumentation on retries is enabled.

Motivation

Allow customers to use the feature by controlling a toggle in our UI, rather than by an environment variable.

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented Dec 12, 2024

Overall package size

Self size: 8.31 MB
Deduped: 94.61 MB
No deduping: 95.12 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2024

Benchmarks

Benchmark execution time: 2024-12-17 15:38:10

Comparing candidate commit a164678 in PR branch juan-fernandez/fetch-di-enabled with baseline commit a17c93f in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 779 metrics, 18 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+86.113MB; +133.211MB] or [+15.926%; +24.637%]

@juan-fernandez juan-fernandez changed the title [test optimization] Fetch di_enabled flag [test optimization] [SDTEST-1332] Fetch di_enabled flag Dec 13, 2024
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fetch-di-enabled branch from b21d1b1 to 6782ab5 Compare December 17, 2024 14:17
@juan-fernandez juan-fernandez marked this pull request as ready for review December 17, 2024 15:31
@juan-fernandez juan-fernandez requested a review from a team as a code owner December 17, 2024 15:31
@juan-fernandez juan-fernandez merged commit 7d53c26 into master Dec 18, 2024
306 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fetch-di-enabled branch December 18, 2024 10:26
@rochdev rochdev mentioned this pull request Dec 18, 2024
@rochdev rochdev mentioned this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants