Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Associate probe results with active span #5035

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

watson
Copy link
Collaborator

@watson watson commented Dec 18, 2024

What does this PR do?

Adds trace and span id if available to the probe payload before sending it to the agent.

Motivation

This allows the user to correlate a given probe result with the active trace.

Plugin Checklist

Additional Notes

This is achived by executing a code-snippet on the top call frame of the paused thread when a breakpoint is hit. This code finds the current span context and fetches the trace- and span-id from it and returns it to the monitoring thread.

This comes with a significant performance overhead, but currently I haven't found a better solution.
As long as the probe isn't in a hot code-path, it's not a huge issue.
We can work on improving this algorithm later.

@watson watson requested review from a team as code owners December 18, 2024 12:22
@watson watson self-assigned this Dec 18, 2024
Copy link
Collaborator Author

watson commented Dec 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Overall package size

Self size: 8.31 MB
Deduped: 94.77 MB
No deduping: 95.29 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024

Benchmarks

Benchmark execution time: 2024-12-18 12:31:51

Comparing candidate commit 45e3764 in PR branch watson/DEBUG-2613/add-trace-and-span-id with baseline commit a17c93f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 779 metrics, 19 unstable metrics.

@watson watson merged commit 50619f7 into master Dec 18, 2024
308 checks passed
@watson watson deleted the watson/DEBUG-2613/add-trace-and-span-id branch December 18, 2024 12:45
@rochdev rochdev mentioned this pull request Dec 18, 2024
@rochdev rochdev mentioned this pull request Dec 18, 2024
@watson watson mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants