[asm] IAST security controls #5117
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| 'use strict' | ||
|
|
||
| import childProcess from 'node:child_process' | ||
| import express from 'express' | ||
| import { sanitize } from './sanitizer.mjs' | ||
| import sanitizeDefault from './sanitizer-default.mjs' | ||
| import { validate, validateNotConfigured } from './validator.mjs' | ||
|
|
||
| const app = express() | ||
| const port = process.env.APP_PORT || 3000 | ||
|
|
||
| app.get('/cmdi-s-secure', (req, res) => { | ||
| const command = sanitize(req.query.command) | ||
| try { | ||
| childProcess.execSync(command) | ||
| } catch (e) { | ||
| // ignore | ||
| } | ||
|
|
||
| res.end() | ||
| }) | ||
|
|
||
| app.get('/cmdi-s-secure-default', (req, res) => { | ||
| const command = sanitizeDefault(req.query.command) | ||
| try { | ||
| childProcess.execSync(command) | ||
| } catch (e) { | ||
| // ignore | ||
| } | ||
|
|
||
| res.end() | ||
| }) | ||
|
|
||
| app.get('/cmdi-iv-insecure', (req, res) => { | ||
| if (validateNotConfigured(req.query.command)) { | ||
| childProcess.execSync(req.query.command) | ||
| } | ||
|
|
||
| res.end() | ||
| }) | ||
|
|
||
| app.get('/cmdi-iv-secure', (req, res) => { | ||
| if (validate(req.query.command)) { | ||
| childProcess.execSync(req.query.command) | ||
| } | ||
|
|
||
| res.end() | ||
| }) | ||
|
|
||
| app.listen(port, () => { | ||
| process.send({ port }) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| 'use strict' | ||
|
|
||
| function sanitizeDefault (input) { | ||
| return input | ||
| } | ||
|
|
||
| export default sanitizeDefault |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict' | ||
|
|
||
| export function sanitize (input) { | ||
| return input | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| 'use strict' | ||
|
|
||
| export function validate (input) { | ||
| return true | ||
| } | ||
|
|
||
| export function validateNotConfigured (input) { | ||
| return true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| 'use strict' | ||
|
|
||
| const { createSandbox, spawnProc, FakeAgent } = require('../helpers') | ||
| const path = require('path') | ||
| const getPort = require('get-port') | ||
| const Axios = require('axios') | ||
| const { assert } = require('chai') | ||
|
|
||
| describe('ESM Security controls', () => { | ||
| let axios, sandbox, cwd, appPort, appFile, agent, proc | ||
|
|
||
| before(async function () { | ||
| this.timeout(process.platform === 'win32' ? 90000 : 30000) | ||
| sandbox = await createSandbox(['express']) | ||
| appPort = await getPort() | ||
| cwd = sandbox.folder | ||
| appFile = path.join(cwd, 'appsec', 'esm-security-controls', 'index.mjs') | ||
|
|
||
| axios = Axios.create({ | ||
| baseURL: `http://localhost:${appPort}` | ||
| }) | ||
| }) | ||
|
|
||
| after(async function () { | ||
| await sandbox.remove() | ||
| }) | ||
| const nodeOptions = '--import dd-trace/initialize.mjs' | ||
|
|
||
| describe('with --import', () => { | ||
| beforeEach(async () => { | ||
| agent = await new FakeAgent().start() | ||
|
|
||
| proc = await spawnProc(appFile, { | ||
| cwd, | ||
| env: { | ||
| DD_TRACE_AGENT_PORT: agent.port, | ||
| APP_PORT: appPort, | ||
| DD_IAST_ENABLED: 'true', | ||
| DD_IAST_REQUEST_SAMPLING: '100', | ||
| // eslint-disable-next-line no-multi-str | ||
| DD_IAST_SECURITY_CONTROLS_CONFIGURATION: '\ | ||
| SANITIZER:COMMAND_INJECTION:appsec/esm-security-controls/sanitizer.mjs:sanitize;\ | ||
| SANITIZER:COMMAND_INJECTION:appsec/esm-security-controls/sanitizer-default.mjs;\ | ||
| INPUT_VALIDATOR:*:appsec/esm-security-controls/validator.mjs:validate', | ||
| NODE_OPTIONS: nodeOptions | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| afterEach(async () => { | ||
| proc.kill() | ||
| await agent.stop() | ||
| }) | ||
|
|
||
| it('test endpoint with iv not configured have COMMAND_INJECTION vulnerability', async function () { | ||
|
|
||
| await axios.get('/cmdi-iv-insecure?command=ls -la') | ||
|
|
||
| await agent.assertMessageReceived(({ payload }) => { | ||
| const spans = payload.flatMap(p => p.filter(span => span.name === 'express.request')) | ||
| spans.forEach(span => { | ||
| assert.property(span.meta, '_dd.iast.json') | ||
| assert.include(span.meta['_dd.iast.json'], '"COMMAND_INJECTION"') | ||
| }) | ||
| }, null, 1, true) | ||
| }) | ||
|
|
||
| it('test endpoint sanitizer do not have COMMAND_INJECTION vulnerability', async () => { | ||
| await axios.get('/cmdi-s-secure?command=ls -la') | ||
|
|
||
| await agent.assertMessageReceived(({ payload }) => { | ||
| const spans = payload.flatMap(p => p.filter(span => span.name === 'express.request')) | ||
| spans.forEach(span => { | ||
| assert.notProperty(span.meta, '_dd.iast.json') | ||
| assert.property(span.metrics, '_dd.iast.telemetry.suppressed.vulnerabilities.command_injection') | ||
| }) | ||
| }, null, 1, true) | ||
| }) | ||
|
|
||
| it('test endpoint with default sanitizer do not have COMMAND_INJECTION vulnerability', async () => { | ||
|
There was a problem hiding this comment. I miss a test checking that the usage of the input of the sanitizer is considered vulnerable: const untrustedData = req.query.command
const safeData = sanitize(untrustedData)
exec(untrustedData) // this is vulnerable
exec(safeData) // this is not vulnerable |
||
| await axios.get('/cmdi-s-secure-default?command=ls -la') | ||
|
|
||
| await agent.assertMessageReceived(({ payload }) => { | ||
| const spans = payload.flatMap(p => p.filter(span => span.name === 'express.request')) | ||
| spans.forEach(span => { | ||
| assert.notProperty(span.meta, '_dd.iast.json') | ||
| assert.property(span.metrics, '_dd.iast.telemetry.suppressed.vulnerabilities.command_injection') | ||
| }) | ||
| }, null, 1, true) | ||
| }) | ||
|
|
||
| it('test endpoint with iv do not have COMMAND_INJECTION vulnerability', async () => { | ||
| await axios.get('/cmdi-iv-secure?command=ls -la') | ||
|
|
||
| await agent.assertMessageReceived(({ payload }) => { | ||
| const spans = payload.flatMap(p => p.filter(span => span.name === 'express.request')) | ||
| spans.forEach(span => { | ||
| assert.notProperty(span.meta, '_dd.iast.json') | ||
| assert.property(span.metrics, '_dd.iast.telemetry.suppressed.vulnerabilities.command_injection') | ||
| }) | ||
| }, null, 1, true) | ||
| }) | ||
| }) | ||
| }) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this
with --importrelevant?nodeOptionsis defined asconstout of thedescribe