Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tap to 18 #5168

Closed
wants to merge 2 commits into from
Closed

update tap to 18 #5168

wants to merge 2 commits into from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jan 29, 2025

What does this PR do?

Update tap to 18.

Motivation

So that we can use tap replay --reporter=junit to export JUnit reports in addition to the current report.

Additional Notes

We have to use tap 18.5.0 and mocha-globals 1.13.0 specifically because 18.6.0/1.14.0 dropped support for Node 18.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (c0550a0) to head (7a4bc23).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5168      +/-   ##
==========================================
+ Coverage   81.05%   82.30%   +1.25%     
==========================================
  Files         478      291     -187     
  Lines       21308    11412    -9896     
==========================================
- Hits        17271     9393    -7878     
+ Misses       4037     2019    -2018     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 29, 2025

Overall package size

Self size: 8.6 MB
Deduped: 95 MB
No deduping: 95.51 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.0 | 9.8 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025

Benchmarks

Benchmark execution time: 2025-01-29 14:49:16

Comparing candidate commit 7b0d4e7 in PR branch tap-18 with baseline commit c0550a0 in branch master.

Found 0 performance improvements and 24 performance regressions! Performance is the same for 889 metrics, 20 unstable metrics.

scenario:startup-control-everything-18

  • 🟥 cpu_user_time [+278.416ms; +298.133ms] or [+14.589%; +15.622%]
  • 🟥 execution_time [+302.501ms; +327.120ms] or [+13.828%; +14.954%]
  • 🟥 instructions [+1.1G instructions; +1.1G instructions] or [+24.184%; +24.745%]
  • 🟥 max_rss_usage [+18.533MB; +20.686MB] or [+9.849%; +10.993%]

scenario:startup-control-everything-20

  • 🟥 cpu_user_time [+269.452ms; +290.441ms] or [+15.728%; +16.953%]
  • 🟥 execution_time [+279.724ms; +303.639ms] or [+14.047%; +15.248%]
  • 🟥 instructions [+1.1G instructions; +1.1G instructions] or [+25.401%; +26.105%]
  • 🟥 max_rss_usage [+16.622MB; +17.524MB] or [+9.775%; +10.305%]

scenario:startup-control-everything-22

  • 🟥 cpu_user_time [+253.459ms; +282.914ms] or [+16.246%; +18.134%]
  • 🟥 execution_time [+285.493ms; +310.340ms] or [+15.441%; +16.784%]
  • 🟥 instructions [+1.1G instructions; +1.1G instructions] or [+25.375%; +26.000%]
  • 🟥 max_rss_usage [+18.601MB; +20.535MB] or [+10.385%; +11.465%]

scenario:startup-with-tracer-everything-18

  • 🟥 cpu_user_time [+295.034ms; +316.525ms] or [+12.265%; +13.158%]
  • 🟥 execution_time [+337.955ms; +363.651ms] or [+12.215%; +13.144%]
  • 🟥 instructions [+1.2G instructions; +1.2G instructions] or [+19.943%; +20.412%]
  • 🟥 max_rss_usage [+21.318MB; +21.869MB] or [+10.894%; +11.176%]

scenario:startup-with-tracer-everything-20

  • 🟥 cpu_user_time [+271.601ms; +293.768ms] or [+12.703%; +13.740%]
  • 🟥 execution_time [+305.056ms; +321.178ms] or [+12.224%; +12.870%]
  • 🟥 instructions [+1.1G instructions; +1.1G instructions] or [+20.827%; +21.238%]
  • 🟥 max_rss_usage [+20.759MB; +21.752MB] or [+11.925%; +12.495%]

scenario:startup-with-tracer-everything-22

  • 🟥 cpu_user_time [+283.318ms; +301.861ms] or [+13.983%; +14.898%]
  • 🟥 execution_time [+317.399ms; +335.583ms] or [+13.178%; +13.933%]
  • 🟥 instructions [+1.1G instructions; +1.2G instructions] or [+20.115%; +20.359%]
  • 🟥 max_rss_usage [+22.219MB; +24.137MB] or [+12.062%; +13.103%]

@rochdev
Copy link
Member Author

rochdev commented Jan 30, 2025

Closing since it turns out we would need a more recent version as the last version with Node 18 support is broken.

@rochdev rochdev closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant