Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.35.0 proposal #5189

Merged
merged 6 commits into from
Feb 3, 2025
Merged

v5.35.0 proposal #5189

merged 6 commits into from
Feb 3, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Feb 3, 2025

  • [ee6dbec9bc] - (SEMVER-PATCH) [DI] Handle different casing in probe file paths (Thomas Watson) #5188
  • [dbe0b74bf4] - (SEMVER-MINOR) Automatic userID tracking and blocking (simon-id) #4670
  • [bcdb068742] - (SEMVER-PATCH) [DI] Probe file path matching algo should prefer shorter paths (Thomas Watson) #5186
  • [729972edff] - (SEMVER-MINOR) Instrument dd-trace-api (Bryan English) #5145
  • [f01d38594b] - (SEMVER-MINOR) [MLOB-2098] feat(llmobs): record bedrock token counts (Sam Brenner) #5152

sabrenner and others added 6 commits February 3, 2025 10:01
* working version by patching deserializedr

* wip

* cleanup

* use tokens on response directly if available

* make it run on all command types if available

* make token extraction cleaner

* test output

* parseint headers

* remove comment

* rename channel

* cleanup

* simpler instance patching

* fmt

* Update packages/datadog-instrumentations/src/helpers/hooks.js

* check subscribers
* initial poc

* get the inject test working

* support object mapping for callback args

* start adding telemetry

* parity on sending and receiving sides

* initial dd-trace-api test

* rest of dd-trace-api testing

* quick test refactor

* support span context methods

* lint

* hoist counter tag

* add plugin test

* replace -> replaceAll
In case the file path provided by the user is a different casing than
the one actually deployed, the tracer should still be able to match it
and apply the probe.
Copy link

github-actions bot commented Feb 3, 2025

Overall package size

Self size: 8.59 MB
Deduped: 94.98 MB
No deduping: 95.5 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 90.78014% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@2f816e4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/datadog-plugin-dd-trace-api/src/index.js 86.66% 10 Missing ⚠️
packages/datadog-instrumentations/src/passport.js 89.47% 2 Missing ⚠️
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5189   +/-   ##
=======================================
  Coverage        ?   81.14%           
=======================================
  Files           ?      482           
  Lines           ?    21501           
  Branches        ?        0           
=======================================
  Hits            ?    17446           
  Misses          ?     4055           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: v5.35.0-proposal
Commit report: 5873da4
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 614 Passed, 0 Skipped, 14m 8.62s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-03 09:13:00

Comparing candidate commit 66486b7 in PR branch v5.35.0-proposal with baseline commit 2f816e4 in branch v5.x.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 904 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-84.653MB; -75.171MB] or [-9.033%; -8.022%]

scenario:startup-with-tracer-20

  • 🟥 cpu_user_time [+12.946ms; +20.599ms] or [+5.448%; +8.669%]
  • 🟥 execution_time [+17.985ms; +22.182ms] or [+6.415%; +7.912%]

@watson watson marked this pull request as ready for review February 3, 2025 09:15
@watson watson requested a review from a team as a code owner February 3, 2025 09:15
@watson watson merged commit 767e601 into v5.x Feb 3, 2025
352 checks passed
@watson watson deleted the v5.35.0-proposal branch February 3, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants