Skip to content

ci: unpin datadog actions#5199

Merged
simon-id merged 2 commits intomasterfrom
christoph.hamsen/upin-dd-actions
Feb 5, 2025
Merged

ci: unpin datadog actions#5199
simon-id merged 2 commits intomasterfrom
christoph.hamsen/upin-dd-actions

Conversation

@xopham
Copy link
Contributor

@xopham xopham commented Feb 4, 2025

What does this PR do?

Unpin GitHub Actions from DataDog org and revert to branch/tag pinning.

Motivation

As part of #5193, all actions are pinned by hash. It was noticed that datadog/system-tests is on purpose floating by main and not using tagged releases.

This reverts commit 5d6e698.
needs:
- build-artifacts
uses: DataDog/system-tests/.github/workflows/run-parametric.yml@994e6f9976f16c13c1cb15c02714d786e0eb8eb1 # main
uses: DataDog/system-tests/.github/workflows/run-parametric.yml@main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

View in Datadog  Leave us feedback  Documentation

get-scenarios:
name: Get parameters
uses: DataDog/system-tests/.github/workflows/compute-workflow-parameters.yml@994e6f9976f16c13c1cb15c02714d786e0eb8eb1 # main
uses: DataDog/system-tests/.github/workflows/compute-workflow-parameters.yml@main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

View in Datadog  Leave us feedback  Documentation

- name: Check code meets quality and security standards
id: datadog-static-analysis
uses: DataDog/datadog-static-analyzer-github-action@06d501a75f56e4075c67a7dbc61a74b6539a05c8 # v1.2.1
uses: DataDog/datadog-static-analyzer-github-action@v1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

View in Datadog  Leave us feedback  Documentation

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Overall package size

Self size: 8.62 MB
Deduped: 95.02 MB
No deduping: 95.53 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (eec4d28) to head (27ce5b5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5199   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         482      482           
  Lines       21522    21522           
=======================================
  Hits        17468    17468           
  Misses       4054     4054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xopham xopham marked this pull request as ready for review February 4, 2025 14:35
@xopham xopham requested review from a team as code owners February 4, 2025 14:35
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2025

Datadog Report

Branch report: christoph.hamsen/upin-dd-actions
Commit report: 25e8f34
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 614 Passed, 0 Skipped, 12m 58.92s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025

Benchmarks

Benchmark execution time: 2025-02-04 14:43:40

Comparing candidate commit 7e7c01c in PR branch christoph.hamsen/upin-dd-actions with baseline commit 15b9f39 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 905 metrics, 27 unstable metrics.

scenario:plugin-graphql-with-async-hooks-20

  • 🟩 max_rss_usage [-110.759MB; -108.641MB] or [-17.232%; -16.902%]

@simon-id simon-id merged commit 1b7c421 into master Feb 5, 2025
350 of 352 checks passed
@simon-id simon-id deleted the christoph.hamsen/upin-dd-actions branch February 5, 2025 11:35
rochdev pushed a commit that referenced this pull request Feb 7, 2025
This partially reverts commit 5d6e698.

Co-authored-by: simon-id <simon.id@datadoghq.com>
@rochdev rochdev mentioned this pull request Feb 7, 2025
rochdev pushed a commit that referenced this pull request Feb 10, 2025
This partially reverts commit 5d6e698.

Co-authored-by: simon-id <simon.id@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants