Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamodb payload tagging #5224

Merged
merged 9 commits into from
Feb 25, 2025
Merged

add dynamodb payload tagging #5224

merged 9 commits into from
Feb 25, 2025

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Feb 6, 2025

What does this PR do?

Enable payload tagging for dynamodb operations. (plugin: aws-sdk)

Motivation

https://datadoghq.atlassian.net/browse/APMS-14486

Testing done

Verified with a testing application:
Screenshot 2025-02-05 at 3 30 43 PM

Redaction functionality verified working.
Payload length limit is 5000 characters per value and is reasonable
Maximum depth’s default 10 is good enough for ddb cases

Plugin Checklist

Copy link

github-actions bot commented Feb 6, 2025

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (96bb84a) to head (9c843a3).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
- Coverage   80.94%   80.57%   -0.37%     
==========================================
  Files         488      484       -4     
  Lines       21844    21503     -341     
==========================================
- Hits        17681    17326     -355     
- Misses       4163     4177      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: joey/ddb-tagging
Commit report: cf12358
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 667 Passed, 0 Skipped, 13m 26.9s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-20 19:58:03

Comparing candidate commit 9c843a3 in PR branch joey/ddb-tagging with baseline commit 96bb84a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 917 metrics, 16 unstable metrics.

@joeyzhao2018 joeyzhao2018 marked this pull request as ready for review February 20, 2025 19:55
@joeyzhao2018 joeyzhao2018 requested review from a team as code owners February 20, 2025 19:55
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyzhao2018
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 14:05:17 UTC ℹ️ Start processing command /merge


2025-02-25 14:05:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-25 15:16:29 UTC ⚠️ MergeQueue: This merge request was unqueued

ruben.bridgewater@datadoghq.com unqueued this merge request

@BridgeAR
Copy link
Collaborator

/remove

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 15:16:20 UTC ℹ️ Start processing command /remove


2025-02-25 15:16:23 UTC ℹ️ Devflow: /remove

@BridgeAR BridgeAR merged commit ddcbcbb into master Feb 25, 2025
398 of 399 checks passed
@BridgeAR BridgeAR deleted the joey/ddb-tagging branch February 25, 2025 15:17
@BridgeAR
Copy link
Collaborator

@joeyzhao2018 great work!

watson pushed a commit that referenced this pull request Feb 27, 2025
* add dynamodb payload tagging

* add tests for ddb payload tagging

* lint and remove version dependent checks
@watson watson mentioned this pull request Feb 27, 2025
watson pushed a commit that referenced this pull request Feb 27, 2025
* add dynamodb payload tagging

* add tests for ddb payload tagging

* lint and remove version dependent checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants