Update eslint rules and activate multiple more #5800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assignment here could alter the id in a way that is conflicting with another iteration.
The comma-dongle rule is deprecated and will be removed soon. Instead, use the @stylistic/comma-dangle eslint rule. This also allows comma dongles instead of prohibiting them. That way diffs are potentially smaller in the future.
The rule often resulted in less readable code due to the added brackets. The order of and and or should be well known and this is therefore not needed.
These add JSDoc, improve readability, and simplify code.
Overall package sizeSelf size: 9.49 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 842.2 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5800 +/- ##
==========================================
+ Coverage 78.97% 79.00% +0.02%
==========================================
Files 517 517
Lines 23213 23221 +8
==========================================
+ Hits 18333 18345 +12
+ Misses 4880 4876 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BridgeAR
commented
May 31, 2025
| @@ -194,7 +194,6 @@ async function updateBreakpointInternal (breakpoint, probe) { | |||
| } catch (err) { | |||
| throw new Error(`Error setting breakpoint for probe ${probe.id}`, { cause: err }) | |||
| } | |||
| breakpoint.id = result.breakpointId | |||
There was a problem hiding this comment.
This likely fixes a race condition.
BenchmarksBenchmark execution time: 2025-05-31 18:37:28 Comparing candidate commit 396c82a in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 1269 metrics, 53 unstable metrics. scenario:plugin-bluebird-control-22
|
Datadog ReportBranch report: ✅ 0 Failed, 1155 Passed, 0 Skipped, 17m 32.56s Total Time |
BridgeAR
force-pushed
the
BridgeAR/2025-05-31-eslint-rules-4
branch
from
d12d8c2 to
a8f0697
Compare
This is a very small performance improvement by now having to recreate a method and by directly adding a tag. It should also make it easier to read the code overall. It also becomes a tad safer by now iterating over the object using in anymore.
BridgeAR
force-pushed
the
BridgeAR/2025-05-31-eslint-rules-4
branch
from
c5158a7 to
c161ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing it without whitespace changes. That limits the diff significantly.