-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: cannot build OFFLINE again #2825
Comments
Thanks for notifying us - I'll make sure to add some testing around that alongside the actual fixing. |
Fixes DataDog/dd-trace-php#2825. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Fixes DataDog/dd-trace-php#2825. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Woops, that was autoclosed. |
Hey @remicollet, we've generated a new artifact with that dependency fetched from crates.io. And added a check in our CI to prevent that from reoccurring. Would you mind testing/using https://output.circle-artifacts.com/output/job/11118184-517f-4f90-a55e-5b9dd0dc12b7/artifacts/0/pecl/datadog_trace-1.3.0.tgz this pecl .tar.gz? Nothing changed in there except the source of that dependency. Thanks! |
I confirm the fix is OK |
@remicollet Do you need a fresh tag, or can you just build based on that artifact? |
I don't need a new tag (RPM already built) |
Thanks a lot! |
Bug report
Despite using "cargo vendor" to avoid download during the build
Tracer or profiler version
1.2.0
Looks like a regression was OK for 1.1.0
The text was updated successfully, but these errors were encountered: