perf: use numbers instead of numeric strings in pprof labels #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backend now has support for this. Use WIP libdatadog endpoint update.
morrisonlevi
force-pushed
the
levi/numbers-in-pprof
branch
from
fd1bccc to
fd0bf6a
Compare
morrisonlevi
changed the title
morrisonlevi
force-pushed
the
levi/numbers-in-pprof
branch
from
7250aa8 to
7d08640
Compare
realFlowControl
approved these changes
Feb 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use numbers instead of numeric strings in pprof labels. This is more efficient, and may open the doors to having a global string table in the future, which could be used to create a global symbol table as well.
This pairs with DataDog/libdatadog#80.
This also simplifies some label strings from
Cow<str>to&static str. It shouldn't be a difficult thing to change some day if we need to, but for now all label keys and units are static.Readiness checklist
Tests added for this feature/bug.I haven't written a test, but I did manually confirm that Code Hotspots and Endpoint Profiling are working, and that the profiles didn't have any numeric strings. This was on the symfony/demo.Reviewer checklist